Commit Graph

1294 Commits

Author SHA1 Message Date
buster%netscape.com
f01655410d implemented basic attribute changed handling. most things currently work, those that don't will work better after Peter
lands some style context resolution changes.
1998-10-30 23:08:34 +00:00
buster%netscape.com
03cad6390d some extremely preliminary work for styleChanged incremental reflow 1998-10-30 07:57:44 +00:00
michaelp%netscape.com
fc225bf7c1 changes to support nsIRenderingContext that conforms to COM conventions. 1998-10-30 02:08:25 +00:00
buster%netscape.com
d029154680 minor fix in determining which layout algorithm to call based on available size 1998-10-29 19:42:43 +00:00
buster%netscape.com
21c24fad8c minor tweak to column handling 1998-10-27 08:38:56 +00:00
buster%netscape.com
7267908f46 fixed bug 1188. Colspans beyond the end of the table were adding entries
into the column cache, which is very, very bad.
1998-10-26 19:15:31 +00:00
buster%netscape.com
a56810053c fixed bug 1180 (mozilla.org) and all tables that have nonsense colspans 1998-10-26 18:42:22 +00:00
buster%netscape.com
4d2bc42fb1 *** empty log message *** 1998-10-23 20:52:23 +00:00
buster%netscape.com
c4b345b782 fixes Bug 1110, URL=http://www.webstandards.org
ables were not correctly applying the min width of the content of cells
that had col spans in some cases.  In this case, the nested table was specified
as being too narrow for the content.  There were 4 columns each with width=25%
in the first row, and in the next row a single cell with colspan=4 and whose
content min size was wider than the specified table width.
1998-10-23 19:56:11 +00:00
buster%netscape.com
5126910ee1 fixed bug 1112 - form submission within a table sometimes doesn't work
because the form doesn't get a reflow command.  Now it does.
1998-10-23 17:24:57 +00:00
buster%netscape.com
771cfdf226 minor bug fixes 1998-10-23 03:23:29 +00:00
buster%netscape.com
7ef1be09f4 just debug info 1998-10-22 21:59:13 +00:00
buster%netscape.com
5364335be2 fixed column caching 1998-10-22 06:04:37 +00:00
buster%netscape.com
9f3bd7bbbb fixed a bug where columns were not always created as needed during incremental appends
added some extra debugging and support methods
1998-10-22 05:27:11 +00:00
buster%netscape.com
5062d0261a fixed several incremental reflow bugs 1998-10-21 22:29:00 +00:00
buster%netscape.com
ad3ce75efb incremental reflow only does pass1 reflow on new frames when necessary
fixed some rotting bits in table frame classes having to do with breaking tables
1998-10-20 20:05:44 +00:00
buster%netscape.com
e220aee18d all containers now decend from nsHTMLContainerFrame
all "unknown frame" incremental reflow support methods now
replaced with nsHTMLContainerFrame::AddFrame and ::RemoveFrame
1998-10-20 17:45:07 +00:00
buster%netscape.com
d8e6fb4c34 incremental reflow now includes insert/append/delete cell 1998-10-20 15:59:56 +00:00
buster%netscape.com
a4725c5350 minor fix, moved a method call outside an assert macro 1998-10-20 14:35:41 +00:00
buster%netscape.com
5a92ea0733 fixed a bug introduced by a slight change in GetColumnCount() 1998-10-20 05:05:17 +00:00
buster%netscape.com
7cb1f39626 rows can now be incrementally inserted, appended, and deleted. 1998-10-19 23:43:06 +00:00
buster%netscape.com
0c1c724f56 incremental reflow: append/insert/delete row group, append/insert/delete col 1998-10-15 21:07:37 +00:00
buster%netscape.com
73b4846430 progress on table incremental reflow of row group insert/append/delete 1998-10-15 07:46:16 +00:00
buster%netscape.com
2a254f6de9 nsTableFrame can now incrementally insert, append, and delete colgroups 1998-10-14 22:51:50 +00:00
spider%netscape.com
0cf90ba175 Add EOL to get to compile on Solaris 1998-10-14 22:23:26 +00:00
spider%netscape.com
7649993273 Adding EOL in files so will compile on Solaris 1998-10-14 22:12:06 +00:00
buster%netscape.com
0d373afd21 lots of work for incremental reflow when the target frame is a table frame 1998-10-14 16:32:45 +00:00
peterl%netscape.com
9f87e56fe7 set border style 1998-10-13 19:17:57 +00:00
kipp%netscape.com
a77548baff Removed nsCSSLayout::GetStyleSize and converted callers to use state in the html reflow state 1998-10-12 17:00:32 +00:00
dcone%netscape.com
25b03013ae took off the class name infront of the routine. Mac does not like this 1998-10-12 15:57:41 +00:00
kipp%netscape.com
ea5a5735f5 Added an nsIPresContext& to html-reflow-state's ctors and used it to implement better percentage width/height handling 1998-10-12 14:48:02 +00:00
buster%netscape.com
56237b7411 WIP for inner table incremental reflow
lots of interface cleanup
1998-10-11 09:18:27 +00:00
buster%netscape.com
4a6afd6336 made allocation of mColumnWidths more flexible 1998-10-09 21:53:07 +00:00
buster%netscape.com
2aa95d75a8 support nsTableOuterFrame incremental reflow 1998-10-09 19:59:45 +00:00
troy%netscape.com
d25a9a35a2 Removed GetContentIndex() from nsIFrame 1998-10-08 20:35:16 +00:00
buster%netscape.com
c81a22ecf1 all frames properly setting ascent and descent values for reflow
WIP incremental reflow in nsTableOuterFrame
1998-10-08 15:34:48 +00:00
buster%netscape.com
05adbb04da fixed calculation for width of auto-width cells in constrained layout 1998-10-06 08:00:07 +00:00
kipp%netscape.com
186c55bec0 use new body factory method 1998-10-06 00:44:35 +00:00
troy%netscape.com
7e64653dab Changed ReflowChild() to send the WillReflow() notification as well 1998-10-06 00:27:22 +00:00
troy%netscape.com
3393397633 Removed calls to MoveTo() BEFORE reflowing a frame. We used to do this
sequence: MoveTo(), Reflow(), SetRect(). Now that we have the WillReflow()/
DidReflow() code sandwhiches we no longer need to do the MoveTo()
1998-10-05 00:58:32 +00:00
buster%netscape.com
2246094ae1 merge goof fixed, now works with new reflow API 1998-10-02 21:35:44 +00:00
buster%netscape.com
395bcf058e minor interface cleanup 1998-10-02 20:36:35 +00:00
buster%netscape.com
2545621ffb fixed coord-width colspan handling in some complex cases 1998-10-02 20:34:11 +00:00
troy%netscape.com
7aceb4270d Eliminated nsIRunaround interface, and folded space manager parameter into
nsHTMLReflowState structure
1998-10-02 04:10:00 +00:00
buster%netscape.com
d2b25dd7ee much better backwards compatibility for autowidth tables
now autowidth columns as assigned a width starting from their minimum.  The remaining
space is proportionately divided among them, never allowing a column to go over its max (for
autowidth tables only.)
1998-10-01 18:39:31 +00:00
troy%netscape.com
ba3c7125c2 Separated reflow process out of nsIFrame and into nsIFrameReflow. Also
added nsIHTMLReflow, which is an HTML specific reflow interface
1998-10-01 04:46:11 +00:00
troy%netscape.com
cce4e2129f Added XXX warning about retuning an unitialized variable... 1998-09-30 21:41:35 +00:00
buster%netscape.com
783bdbef96 just synching up some minor cleanup work 1998-09-30 18:11:48 +00:00
buster%netscape.com
85d7016988 fixed a minor bug in colspan layout
the layout strategy can now query the outer frame for the caption min width,
and use it to expand the table if necessary
did some related cleanup while I was in there.
1998-09-29 23:15:01 +00:00
kipp%netscape.com
2caa6d7cf3 Create table-cell's body as a top-level body so that it doesn't shrink wrap around it's children during pass2 table reflow 1998-09-29 22:36:30 +00:00
kipp%netscape.com
261b8bd181 Changed factory method to parameterize the shrink wrapping behavior 1998-09-29 03:44:25 +00:00
buster%netscape.com
15751816da fixed bug 915. Colgroup frames now get Init() calls properly with
synthesized COLs.
1998-09-28 20:38:10 +00:00
kipp%netscape.com
fff04dae01 Use modified css rendering API 1998-09-26 17:17:20 +00:00
kipp%netscape.com
a388e31cbd Fixed up includes to not depend on old content model classes 1998-09-24 21:37:45 +00:00
buster%netscape.com
0bec735087 removed lots of assumptions about frame ordering and containership.
table frames no longer assume they are n levels below the inner table frame
table frames no longer assume their child frames are always the expected type of
frame.  Now they check the display type and use that as sufficient proof that the frame
is of the right type.  This implies a heavy reliance on the frame construction code to do
the right thing and always stamp out the right kind of frame for a given display type.
1998-09-24 16:37:22 +00:00
troy%netscape.com
5dac3c72a9 Removed IsPseudoFrame() from nsContainerFrame 1998-09-24 04:57:30 +00:00
troy%netscape.com
f1e955440e Changed signature of PushChildren() member function 1998-09-24 04:18:58 +00:00
troy%netscape.com
1724bb5dad Removed IsLastChild() member function from nsContainerFrame 1998-09-24 04:12:01 +00:00
troy%netscape.com
fb0251ec2e Removed ChildIsPseudoFrame() and IsEmpty() from nsContainerFrame 1998-09-24 04:06:42 +00:00
troy%netscape.com
dd71642dd1 Removed PreReflowCheck() and PostReflowCheck() from nsContainerFrame 1998-09-24 03:59:30 +00:00
troy%netscape.com
b31a3f0a5f Removed mFirstContentOffset, LastContentOffset, and mLastContentIsComplete
from nsContainerFrame
1998-09-24 03:36:52 +00:00
buster%netscape.com
1fba5ac7dc all frame initialization and related logic has moved into the various table frames' Init() methods
from their respective InitalReflow() methods.
table-layout=fixed now completely skips pass1 reflow and doesn't require maxElementSize
information, saving a tremendous amount of time during initial reflow.
1998-09-23 21:48:26 +00:00
buster%netscape.com
5240b0ccd5 implementation of table-layout=fixed strategy 1998-09-23 02:32:15 +00:00
kipp%netscape.com
31dd9c5d3a Fixed the build 1998-09-23 01:47:17 +00:00
buster%netscape.com
6b5085a487 set all the groundwork for FAST table layout based on CSS-2 table-layout property 1998-09-22 23:36:06 +00:00
troy%netscape.com
0f842c0152 Removed all references to m<First,Last>ContentOffset,mChildCount,mLastContentIsComplete 1998-09-21 03:40:32 +00:00
buster%netscape.com
8c93860f3d captions now work properly with new frame layout strategy.
nsTableOuterFrame->mFirstChild==nsTableOuterFrame->mInnerTableFrame, always.
1998-09-20 04:50:08 +00:00
troy%netscape.com
62b1375f69 Removed farme enumeration member functions for indexed access, last child,
and child count
1998-09-19 03:24:26 +00:00
buster%netscape.com
9a953b8672 added ColIsSpannedInto, ColHasSpanningCells
moved *IsSpannedInto and *HasSpanningCells into cellmap, giving us the oppurtunity
to easily cache results if we want.  These methods are still accessed through nsTableFrame.
changed nsTableFrame::GetCellAt to nsTableFrame::GetCellFrameAt to make it more clear what
the method returns:  a frame, not content.
1998-09-18 22:37:14 +00:00
troy%netscape.com
29e5156e14 Removed nsIContentDelegate.h 1998-09-18 17:34:48 +00:00
troy%netscape.com
28c7cf540c Removed content delegates 1998-09-18 17:18:37 +00:00
troy%netscape.com
b2f7d8a3d8 Fixed a compiler warning 1998-09-18 03:13:47 +00:00
troy%netscape.com
c33300f711 Removed some old commented out code 1998-09-18 02:28:12 +00:00
troy%netscape.com
2c98bf3e01 Removed some code that's no longer needed now that we've switched to
new frame construction
1998-09-18 02:22:52 +00:00
troy%netscape.com
840d73eab9 Removed some commented out code that's not needed now that we're using the
new frame construction
1998-09-18 00:49:40 +00:00
troy%netscape.com
9adcf5d319 Cleaned up frame construction code 1998-09-17 04:07:58 +00:00
troy%netscape.com
434ecf7423 Fixed a problem with tables with COLGROUP and COL elements crashing
because there was a null cellmap
1998-09-16 23:24:39 +00:00
troy%netscape.com
e4acf0f90b Clean up work 1998-09-16 20:27:30 +00:00
troy%netscape.com
65269d3422 Frame construction changes for tables 1998-09-16 17:19:20 +00:00
buster%netscape.com
360b73b48c better handling of non-cell frames in rowFrames
support for the case where a nested table is in a cell that has colspan>1
1998-09-16 00:48:14 +00:00
pierre%netscape.com
19a8c40a7a fixing mac build (the class name was repeated in the method declaration) 1998-09-15 23:39:28 +00:00
buster%netscape.com
d610ebb563 nsTableRowGroupFrame no longer assumes all its children are rows, or that all row children are cells. 1998-09-15 20:36:42 +00:00
buster%netscape.com
953b2efb58 nsStyleConsts.h added some HTML 4 consts for tables
nsHTMLAtoms.cpp,h             added some HTML 4 strings for tables
nsHTMLParts.h                 added constructors for new table content classes
nsGenericHTMLElement.cpp,h    added table frame creation, common table attribute parsing
nsHTMLTable*Element.cpp       these are the new table content classes
nsHTMLContentSink.cpp         enabled the new content and removed the old
nsHTMLStyleSheet.cpp          fixed the table style optimizations to work with new content
nsTable*Frame.cpp             these work with the new content
1998-09-15 17:58:24 +00:00
buster%netscape.com
37869e9464 integrates with new frame creation methods 1998-09-09 21:34:10 +00:00
buster%netscape.com
2e72b5b556 many fixes that effect http://www.mozilla.org and related pages.
these fixes are for nested tables with percent widths, for tables including both rowspan and colspan,
and for tables with only a single column.
some rounding errors were eliminated.
more debugging output, and some new assertions.
1998-09-09 20:00:40 +00:00
buster%netscape.com
65191223c4 fixed 2 small errors in computing table widths.
1) sometimes we were adding 1 too many pixels in constrained tables
2) sometimes we were using the wrong value for the max width as an input to constrained tables
1998-09-08 19:11:14 +00:00
buster%netscape.com
5be0373ab2 fixed minColSpan to always be at least one. This helps support empty rows,
among other problems.
1998-09-03 06:15:18 +00:00
buster%netscape.com
70647d8bd6 fixed a space leak for tables with rowspans 1998-09-02 22:55:37 +00:00
buster%netscape.com
89e198237d expanded nsIFrame::List to include nsIListFilter *aFilter param, by default nsnull.
aFilter is useful for determining if a frame should output itself during
a List().  In any event, the children of the frame are always processed.
added nsIListFilter, an interface for any object that wants to act like a filter for frame dumps
added   static NS_LAYOUT nsIListFilter * GetFilter(nsString *aFilterName);
currently, only TableListFilter implements nsIListFilter.
in response to List(...TableListFilter), the frame model is dumped in a way that is useful
for table layout regression testing.  Currently this is controlled by command line switches on the viewer app.
1998-09-02 21:59:54 +00:00
buster%netscape.com
5b39e492d0 fixed a space leak caused by incorrect ~nsCellMap iteration through
the new data structures.
1998-09-02 21:51:01 +00:00
buster%netscape.com
1781327873 empty rows now handled properly 1998-09-01 17:49:05 +00:00
buster%netscape.com
49cf716e9d reimplemented cell map in terms of nsVoidArrays for incremental building.
the cellmap is now built incrementally, driven by nsTableRowFrame::InitialReflow
1998-08-31 21:23:28 +00:00
kipp%netscape.com
c6290fa577 XPCOM'ized nsIContent and nsIHTMLContent 1998-08-29 20:20:38 +00:00
michaelp%netscape.com
ca017f19d0 DeleteFrame() now takes a pres context. 1998-08-28 03:02:39 +00:00
peterl%netscape.com
8d66d72540 no longer force unique style contexts 1998-08-27 00:57:05 +00:00
peterl%netscape.com
12d7adf11e remove text attribute processing 1998-08-27 00:56:17 +00:00
buster%netscape.com
4ef0888af9 fixed a minor bug handling tables with COLS attribute 1998-08-26 17:53:47 +00:00
buster%netscape.com
7b6c525170 more content decoupling
support work for style optimizations
fixed a bug in table columns  -- the attribute repeat defaults to 1, not 0
1998-08-26 17:26:38 +00:00
joki%netscape.com
46137420c0 Modifying nsIContent's AppendChild -> AppendChildTo to stop conflict with
DOM interfaces.
1998-08-21 21:38:26 +00:00
buster%netscape.com
8bbbded0c7 verify that proportionate-width columns (1* format, or COLS attribute)
get sized to at least their minimum width
1998-08-20 17:31:20 +00:00
buster%netscape.com
ed605f9f6e fixes a layout bug where subsequent cells in a column when colspans are involved
could select the wrong starting width for the column, causing it to have the
wrong ending width.
1998-08-19 20:41:06 +00:00
buster%netscape.com
1e386bbc7c modified the resize reflow optimization so max element size is returned
if requested without triggering a reflow if the width hasn't changed.
1998-08-19 18:40:33 +00:00
buster%netscape.com
2515e08aee improved colspan handling.
cells with colspans and specified widths divide their width provisionally between the columns they span. This provisional division is ammended by any cell in any of the effected columns that:
1) has a colspan=1, and
2) has a width specified
the widths of all other columns must be adjusted for cells like these.  Further complicating matters is that it seems <faith> that if multiple colspanning cells intersect a column and each has a width
specified such that the column would have a different width depending on which is used, only the first such cell is used </faith>.  I can neither confirm nor deny this reading the mozilla code.

I also taught the cell map how to deal with this situation:

 colspan=1 | colspan=2 | colspan=1
 colspan=1 | colspan=2 | colspan=1

This table "really" has 4 columns, but the middle cells are treated as if they have no colspan.
Trust me, it matters.  The original colspan attributes can't simply be thrown away because Mr. DOM
could come along at any time and add/remove a cell that would make them important.
1998-08-19 15:43:51 +00:00
buster%netscape.com
a42be9cf57 fixed nested tables for the case where both parent and child table are %-width,
and the columns are any variety of width types
1998-08-17 23:37:04 +00:00
buster%netscape.com
49d858783e fixed a memory leak where a style context was not being released when
the table cell set the table column's style.
1998-08-17 19:03:36 +00:00
buster%netscape.com
c024161837 * migrated and improved some fixes from the branch to the tip
* fixes sample6, yahoo resizing
* added BasicTableLayoutStrategy::ColIsSpecifiedAsMinimumWidth helper function,
which tells us if the given column has a width attribute that means "make me as small as possible"
* nsTableFrame methods now no longer use mCellMap directly, they ask for it from
GetCellMap which gets the cell map from the first-in-flow.  Only the first-in-flow has a
cell map because the cellmap refers to the table as a single object, not to each table frame.
* Likewise, continuing table frames do not call BalanceColumnWidths or SetTableWidth
which are "global" operations.  Responsibility for these lies with the first-in-flow.
1998-08-14 16:16:43 +00:00
buster%netscape.com
fad1e52668 first cut at implementing %-width columns inside of auto-width tables.
This is about 50% done, which covers about 90% of the cases.
1998-08-11 18:42:10 +00:00
buster%netscape.com
0824132571 percent-width nested tables in fixed-width cells now use the computed
column width if available for computing their own width.
1998-08-10 02:16:18 +00:00
troy%netscape.com
acaa6d2f0e Change to object lifetime management. Views are no longer ref counted 1998-08-08 04:23:33 +00:00
buster%netscape.com
43c4537038 bug #312932. fixes nested tables with percent widths that also have
content with percent widths.
1998-08-07 21:53:27 +00:00
troy%netscape.com
a09b9a211e Removed MoveTo() and SizeTo() member functions that were for debug
purposes, and are no longer needed
1998-08-07 18:17:34 +00:00
buster%netscape.com
79c1b74a7a synch with branch
fixed the following bugs: 312653 312656 312655
the fixes were:

1. cells now inherit their bgcolor from the row, if available.  This is the
Nav4 way of drawing row bgcolor, rather than having the row paint its own bgcolor. (Troy, I intend to make this conditional
based on the compatibility mode)

2. colspans across cols that are all specified width no longer try to proportionately
divide the width of the span between the cols.  see http://www.city.net (now it's really fixed, without breaking nested tables in
constrained situations.)  A happy side effect is nested tables in general behave better when constrained.

3. min table sizes are fixed, so min width changes to content now effect the
table correctly during incremental reflow.  This fixes the table layout portion of the bugs on the http://www.aol.com/corp tree.
Rick will check in the other half of this fix soon.  Until then, don't expect to see much improvement.

4. fixed bug 312799.  Table cell now always reserve at least the maxElementSize
of its content, fixing problems when desiredSize<maxElementSize
1998-08-07 02:11:51 +00:00
buster%netscape.com
f8fb32ab12 removed an overly-aggressive assertion that prevents nested tables from laying out 1998-08-04 17:16:56 +00:00
buster%netscape.com
3aa831cc71 backed out a mistake from my last checkin. table min sizes are ok again 1998-08-04 00:56:57 +00:00
troy%netscape.com
51a8b8dc9a Added ASSERT for the case where we get passed a reflow reason of initial
when we've already been reflowed once
1998-08-03 23:29:35 +00:00
buster%netscape.com
5fb7fd0dc2 fixed this case: (an image tag with no width attribute) inside (a specified-width column) inside
(a nested table with specified width) inside (an auto-width column)
inside (a specified-width table).  Got that?
The problem was that we we not setting state correctly during incremental reflow
when the image returned its proper metrics after giving default metrics that
were for its ALT text.
1998-08-03 20:27:59 +00:00
buster%netscape.com
d1810c5bd8 made auto-width tables that have all-fixed-width columns act like
fixed-width tables.
1998-08-01 20:31:40 +00:00
buster%netscape.com
a45b2ebb58 *** empty log message *** 1998-08-01 02:36:31 +00:00
buster%netscape.com
1d94952b0c *** empty log message *** 1998-08-01 02:32:27 +00:00
buster%netscape.com
c0e2de3c56 fixed cases where we were not computing the table width correctly
fixed cases where we were inappropriately portioning out
a spanning cell's min width to the columns it spanned.
1998-08-01 02:31:55 +00:00
buster%netscape.com
705f18b571 fixed a memory leak on a style context 1998-08-01 02:30:35 +00:00
peterl%netscape.com
714146a525 rounding support 1998-07-31 23:34:45 +00:00
buster%netscape.com
ff35c20a64 we now paint backgrounds regardless of our content. Cell borders are
still conditionally painted based on whether the cell's content has
0=size or not.
1998-07-31 00:32:27 +00:00
buster%netscape.com
0e9212b3a8 fixed an error where min width of col spanners were getting proportionately distributed
only desired width gets distributed, not min size.
1998-07-31 00:31:09 +00:00
troy%netscape.com
961f75c4e0 Changed BuildCellMap() to iterate table cell frames using the sibling
list instead of ChildAt()
1998-07-30 04:50:38 +00:00
kipp%netscape.com
7ff5d0e7ce Remove most compiler warnings on IRIX 1998-07-29 20:19:08 +00:00
buster%netscape.com
906c36bf12 fix for distributing spanned width that is less than the column minimums it spans. 1998-07-28 00:23:01 +00:00
buster%netscape.com
ef37113511 more span fixes 1998-07-27 23:47:54 +00:00
buster%netscape.com
fb448713fb empty cells do not render border or background color 1998-07-27 07:37:57 +00:00
buster%netscape.com
01cb1091bc minor fixes for spans 1998-07-27 07:20:03 +00:00
buster%netscape.com
4aa30464e2 cleaner version of earlier code. still buggy on some pages for no apparent reason. 1998-07-27 05:32:50 +00:00
buster%netscape.com
5bc08af6bc *** empty log message *** 1998-07-27 03:02:32 +00:00
buster%netscape.com
b0820f4994 much better handling of tables who have fixed-width columns that make the table wider than it is allowed to be
added some sanity checking in BalanceColumnWidths be ensure that a column width
can never be less than the minimum element in that column.
1998-07-27 02:15:37 +00:00
buster%netscape.com
cb77901bc4 COLS attribute ignored if any column width info is specified (like <TD width=100>)
fixed lots of COLS related bugs.
handle min width spec (<TD width=0 or width=0% or width=0*>)
major fix to colspan handling
1998-07-26 04:23:01 +00:00
buster%netscape.com
c2cb496f85 NOWRAP turned off in fixed-width cells for backwards compatibility
we handle inconsistent width attributes better
1998-07-24 23:26:23 +00:00
buster%netscape.com
ccdd156af5 turn off debug 1998-07-24 17:15:12 +00:00
buster%netscape.com
cc50c03239 GetColCount now returns the effective column count of the table, adjusted
for nonsense COLSPANs at the edge of a table.  Fixed some bugs this uncovered
where the cell was being asked for its colspan attribute rather than the table
being asked for the cell's effective col span.
1998-07-24 16:51:16 +00:00
buster%netscape.com
8194f070cf fixed column balancing for case where minColWidth > specifiedFixedColumnWidth 1998-07-24 03:53:59 +00:00
buster%netscape.com
911380aeb5 any table with a nonsense rowspan lays out better 1998-07-24 00:43:09 +00:00
buster%netscape.com
4ad5fcf455 completed AdjustTableThatIsTooWide, now gets the table down to the right width. 1998-07-23 21:55:45 +00:00
peterl%netscape.com
2207f21400 factored backgound finding code to nsStyleUtil 1998-07-23 18:05:03 +00:00
buster%netscape.com
bf6286bcc1 fixed-width columns now respected when their content desired width exceeds
the specified width.
1998-07-22 20:06:31 +00:00
buster%netscape.com
250fdeafde BasicTableLayoutStrategy::Initialize now properly re-iinitializes instance variables 1998-07-22 18:22:12 +00:00
buster%netscape.com
35edf8df81 fixed table width problems when there are colspanning cells 1998-07-22 05:38:41 +00:00
troy%netscape.com
048270ffb0 Changed PaintBorder() to use the (x,y) that's passed in 1998-07-22 05:02:07 +00:00
buster%netscape.com
878f3fa809 * reworked the way colspan and rowspans are handled in table layout strategy. We do less work, and we look better.
* fixed more margin code.  we're inching towards correctness.
* the width contributed by a colspanning cell is now proportionately distributed to the columns based on the columns "effective width"
* added logic for handling illegal COLS attribute on a table (like COLS=4 in a 3-column table).  See nsTableFrame::GetEffectiveCOLSAttribute()
* added logic for handling illegal COLSPAN attribute on a cell (like COLSPAN=4 in a 3-column table).  See nsTableFrame::GetEffectiveColSpan().  This is wrong, and will get reworked soon.
* added the ability for cell width attributes to effect column width like Nav4.
1998-07-22 03:53:43 +00:00
troy%netscape.com
789a2dbe45 Changed nsCSSRendering::PaintBorder() so the entire rect is used
and not just the width and height
1998-07-22 02:46:00 +00:00
troy%netscape.com
4b6011fd11 Fixed it so tables that don't want a border don't get a border 1998-07-21 08:12:22 +00:00
troy%netscape.com
109b0e1a4d Commented out code that was forcing the border style to solid rather
than using whatever is in the default ua style sheet (inset)
1998-07-21 07:47:46 +00:00
troy%netscape.com
f657a18800 Changed Paint() to use the parent frame's color style struct. We can't use our
color style struct because we're a pseudo frame and so the style system forces
us to have a transparent background
1998-07-20 23:58:00 +00:00
troy%netscape.com
ebedcce239 Changed Paint() to render the background if there is one 1998-07-20 23:56:17 +00:00
buster%netscape.com
ef4c17cfab fixed a space leak/logic error handling colspans
added backwards compatibility for percent width tables inside of auto width tables (see http://webreview.com/wr/pub  warning:  you'll have to look at a local copy until
Troy/Vidur/somebody fixes an image problem.)
1998-07-17 21:02:28 +00:00
buster%netscape.com
516af96c36 fixed table maxElementSize 1998-07-17 17:51:55 +00:00
buster%netscape.com
43e2bfb777 we now allow empty rows 1998-07-17 17:51:43 +00:00
buster%netscape.com
51fe86ee79 fundemental overhaul of the BasicTableLayoutStrategy
We now cache lots of useful info in the colframes
we now properly account for margins just as uniform cellspacing
1998-07-16 23:23:31 +00:00
kipp%netscape.com
8a146ed86e Fix incremental reflow bug 1998-07-16 22:15:02 +00:00
troy
a629312753 Some more changes of nsIPresContext* to nsIPresContext& 1998-07-15 17:05:21 +00:00
troy
afdf23392e Added an XXX to remind me to talk with Cujo about how we determine
whether the column widths have changed...
1998-07-15 04:52:32 +00:00
troy
21525a97ca Turned off some code that was accidently turned on 1998-07-15 04:46:51 +00:00
troy
88ad0371f3 Some improvements to the incremental reflow logic to handle all the
cases handled by resize reflow
1998-07-15 04:45:58 +00:00
troy
d660868bc2 Changed API for CreateContinuingFrame and GetReflowMetrics to take
a reference to a nsIPresContext
1998-07-15 03:23:23 +00:00
troy
a90fe8e1de Changed Reflow() member function to take a reference to a nsIPresContext
instead of a pointer
1998-07-15 02:53:09 +00:00
troy
8fb033f617 Incremental reflow changes 1998-07-14 15:29:50 +00:00
buster
6670b21c59 turned debug noise off 1998-07-13 20:44:07 +00:00
buster
d00c767f83 for Nav compatibility, 0-width cells do not have insets 1998-07-13 20:41:38 +00:00
buster
2eb1eecd14 added Nav4 compatibility code for 0-width cells 1998-07-13 19:22:45 +00:00
buster
5be37245a3 fixed 2 minor space leaks having to do with temporary structs allocated
to handle colspans
1998-07-13 18:11:12 +00:00
kipp
a53b58f65f Reflow child when max-element-size is requested (this works around a purify detected crash) 1998-07-12 00:19:17 +00:00
troy
5d8fdf9dd8 Added back in some changes that got lost in the previous
check-in
1998-07-11 04:16:29 +00:00
buster
6e3192f275 fixed unix build, and one small uninitialized variable problem 1998-07-11 00:47:29 +00:00
buster
8ce4ae05e9 *** empty log message *** 1998-07-11 00:08:08 +00:00
buster
3e596fc26a major hackage to the table data structures. slimmer, simpler, faster
this work exposed a few bugs and slow spots, which have been fixed
for the aol page, I added some additional backwards compatibility code
to proportionately distribute width when a fixed-width cell has colspans
1998-07-11 00:00:31 +00:00
troy
786d36083e More code re-shuffling. I need to hurry and check-in before Cujo
whacks the tree
1998-07-10 22:56:13 +00:00
troy
97ae834b23 Deprecated the SetFirstContentOffset/SetLastContentOffset member
functions that take a nsIFrame*
1998-07-10 19:04:06 +00:00
troy
b147b465e4 Changed it so we assume that rows are always complete 1998-07-10 05:23:05 +00:00
troy
4e29404d47 Some incremental improvements 1998-07-10 04:00:38 +00:00
troy
360378b073 Changed it so the inner table is reflowed by using the Reflow()
member function rather than poking the individual pass 1, pass 2, ...
member functions
1998-07-09 14:30:34 +00:00
troy
ff91686953 Changes to the caption handling code 1998-07-08 20:21:17 +00:00
troy
3a510d5648 Tables not allow only one caption 1998-07-08 04:49:01 +00:00
troy
dbb8e4e65a Cleaned up ShrinkWrapChildren so pass 1 doesn't resize the rows 1998-07-07 03:48:21 +00:00
buster
72142b30f4 fixed 3 dumb bugs I introduced recently.
1. cellmap couldn't properly delete CellData because definition was unavailable
2. optimized table cells made taller wouldn't shrink when they should because we were not
remembering the previous desired height of the cell.
3. rows were placing cells on the left edge, and not adding in the left margin.
1998-07-07 01:06:51 +00:00
troy
6d54a65afb More incremental reflow changes 1998-07-07 00:49:07 +00:00
buster
f8cb71dab5 fix for empty tables. we now support tables that have no content. 1998-07-07 00:20:21 +00:00
buster
e90e663a7b fixed a few bugs with distributing excess/restricted space inappropriately.
we now pass around info about whether we're an auto width table.
1998-07-06 22:48:19 +00:00
troy
35c2e6b45c Incremental reflow work-in-progress 1998-07-06 21:39:23 +00:00
buster
5135afe659 added support for "effective column widths", the width of a column pretending that spanning cells have no effect.
this gets us some more Nav4 compatibility.
several minor fixes.
1998-07-06 21:00:11 +00:00
troy
44b7ebb358 More work-in-progress incremental reflow code 1998-07-02 23:19:31 +00:00
kipp
f0ed6d38a2 Fixed bug where tables weren't returning a proper set of metrics 1998-07-02 21:24:56 +00:00
troy
d138bc14e1 Moved code that resized the table row cells from the row group frame
to the row frame. It's now handled as part of the DidReflow() post-
processing code
1998-07-02 20:35:23 +00:00
buster
b54c4bdc95 added an optimization that skips pass2 cell reflows when the new available width is unchanged
from the prior available width.  Some real-world test cases sped up
1-2 orders of magnitude for resize reflow.  Initial reflow is unchanged because
we still need to get pass1 metrics on all content.
fixed nsCSSBlockFrame.cpp to take margins into account when computing parent's available width
fixed distribution of excess space to table cells when table is bigger than the content it holds.
not quite finished yet, but better.
1998-07-02 17:40:56 +00:00
troy
8df0e96786 Some work-in-progress for incremental reflow 1998-07-02 05:39:10 +00:00
atotic
9689fc070a Fixed the for (PRInt32 i=) problem 1998-07-01 22:40:00 +00:00
troy
183b82a765 Eliminated some usage of ChildAt() 1998-07-01 22:22:28 +00:00
troy
59d4da2785 Some work-in-progress for incremental reflow 1998-07-01 04:55:15 +00:00
troy
aa312a24e8 Removed some vertical margin collapsing stuff that wasn't needed 1998-07-01 03:03:32 +00:00
kipp
541fe9b490 Use new PropagateContentOffsets API 1998-06-30 20:22:44 +00:00
buster
70c232ebd4 fixed-width cells no longer improperly impact the available size
of subsequent cells in reflow pass 1

we correctly distribute extra space in a table proportionately.
We try to give the extra space to auto-width columns first,
and if there are none we distribute it to all columns.
The percentage is based on the cell content's desired size.
1998-06-30 20:12:45 +00:00
troy
add97af1d2 Moved shrink wrap code from table frame to table row group frame 1998-06-30 02:11:07 +00:00
buster
5a4c2d4364 columns that are fixed-width due to an attribute on the corresponding cell in the first row
now work correctly.
extra space is now properly apportioned in the "table fits" case when the table contains auto-width cells.
1998-06-30 00:37:03 +00:00
buster
1f0d9a91f1 cells no longer monkey with their available width based on attribute constraints.
The row does this work now. This makes table layout more properly top-down.
1998-06-29 20:38:22 +00:00
buster
705daa1418 minor tweaks for table layout 1998-06-29 03:09:14 +00:00
atotic
1437970bf6 That for (int i)... problem fix 1998-06-27 02:49:36 +00:00
atotic
12f2a33570 Another class reference inside class declaration problem class A { void A:method }; is bad 1998-06-27 02:48:39 +00:00
atotic
afb360e8c5 Fixed mac warnings 1998-06-27 02:47:44 +00:00
buster
471f5b46a8 support for Nav4 compatibility -- auto-width cells with 0-width content are 1 pixel wide 1998-06-26 23:31:33 +00:00
kipp
b00f7215a5 Eliminated IRIX compiler warnings (and a bug) 1998-06-26 15:07:09 +00:00
buster
d7cca42032 fixed some nested table bugs and made some minor adjustments to Kipp's new line layout code. 1998-06-26 00:48:44 +00:00
troy
04e9ce1a5f Added some asserts to the incremental reflow code 1998-06-24 22:05:59 +00:00
buster
ba02200c08 fixed some bugs related to rowspans. This gets us closer on pages like Mozilla.org that were getting wild table heights. 1998-06-24 19:13:19 +00:00
troy
48262a93f9 Changed to make sure we set the (x,y) for the frame before we reflow it 1998-06-24 18:09:47 +00:00
troy
d8ba6d4919 Changed to make sure we link the child frame into the list of frames before
we reflow it
1998-06-24 16:35:21 +00:00
troy
9419e27a89 Some incremental reflow changes 1998-06-24 04:38:52 +00:00
buster
9605fb0d2f now tables with precent width nested within tables with auto width work 1998-06-24 00:40:33 +00:00
buster
aca4c96fbe lots of nested tables look much better
misc. nav4 compatibility enhancements
added the ability to QueryInterface for some specific table frame types
1998-06-23 23:23:21 +00:00
troy
ea085cab4b Some work-in-progress for table incremental reflow 1998-06-23 05:43:27 +00:00
troy
7d13a4fd7f Eliminated mFirstPassValid and changed code to key off the reflow
reason
1998-06-22 21:59:43 +00:00
troy
14b98d4773 Started hooking up incremental reflow. So far we only handle changed
captions
1998-06-22 05:34:17 +00:00
troy
36e45e1fac Work in progress for incremental reflow 1998-06-19 05:21:45 +00:00
troy
3456471e4f Eliminated nsTableCaptionFrame and now we just use a nsBodyFrame instead 1998-06-19 00:34:12 +00:00
buster
3d98654938 minor updates and fixes 1998-06-17 19:51:51 +00:00
buster
288d645ae3 Separated table content from table layout. This paves the way for XML/CSS-2 tables.
Lots and lots of optimizations.
1998-06-17 16:38:24 +00:00
troy
0257810c1e Changed PaintChildren() to only paint those children that intersect
the dirty rect
1998-06-14 00:45:21 +00:00
troy
635160598d Changed ResizeReflowPass1() to default to the reflow reason that was
passed in and not resize
1998-06-12 04:28:07 +00:00
troy
0a13434a4d Fixed some places where the reflow reason wasn't getting correctly set for
the initial reflow
1998-06-12 04:11:41 +00:00
troy
6e3ac5fd90 Changed how cell layout data is accessed 1998-06-11 22:51:54 +00:00
troy
421b1e3377 Eliminated FindCellLayoutData() and changed code to use GetCellLayoutData()
instead
1998-06-11 18:50:17 +00:00
buster
f1483bd22e more separation between table content and frames 1998-06-11 17:50:51 +00:00
buster
9034e41c54 continuing work to separate content from frames 1998-06-11 15:46:37 +00:00
troy
63f9e5f77a Added some XXX performance reminders 1998-06-11 04:57:56 +00:00
buster
d3d2d16edd more cleanup and frame/content separation 1998-06-11 00:41:09 +00:00
buster
2d31c54583 some tentative steps towards content/frame separation in tables 1998-06-11 00:13:18 +00:00
troy
66b6882d23 Added nsIReflowCommand interface 1998-06-09 04:51:44 +00:00
rods
19bb8ad4ac moved inlined SetCellAt to body 1998-06-08 22:07:15 +00:00
buster
469b205bb3 most HTML 4 attributes supported (though some are still ignored)
lots of methods made inline
1998-06-08 19:57:04 +00:00
buster
0197ad9b72 more attributes: cell nowrap, caption align, some misc HTML 4 attributes too 1998-06-08 15:47:03 +00:00
buster
e5144b1a9c clean up, and still better cell width attribute layout 1998-06-05 22:50:03 +00:00
buster
f56ca7d23b column widths with cells that span columns now work in most cases, for pixels and percents
not yet implemented for the "constrained" case
1998-06-05 18:11:20 +00:00
peterl
91c5893512 sync up to new style data apis 1998-06-05 06:09:09 +00:00
buster
9b8b9a672d cells with colspans and width attributes now work correctly 1998-06-05 02:50:46 +00:00
buster
07076ff7cf cell width calculations are working (not for colspan cells yet)
some bug fixes and optimizations
some of the more elaborate test cases are closer to Nav4-compatible
1998-06-05 02:36:25 +00:00
buster
3780538b44 a variety of fixes and optimizations
together with a fix troy just checked in, this makes a lot of real-world tables look a whole lot better
1998-06-03 00:43:53 +00:00
buster
3fe1fe2844 made tables quiet again 1998-06-01 21:07:56 +00:00
buster
3086966c54 much better fixed and percentage width layout 1998-06-01 20:21:05 +00:00
kipp
9a2d1c3765 Updated a few table API's so that percentage width could be properly computed 1998-05-30 21:21:51 +00:00
buster
a58280cec0 some proportional column balancing now works
the <TABLE> COLS attribute is supported via proportional column balancing.
1998-05-29 22:08:19 +00:00
troy
7a485fcc40 Changed nsReflowState structs to be linked together 1998-05-29 20:36:05 +00:00
buster
aad54b07f6 set the groundwork for handling COLS attribute, and attributes on COLGROUP and COL tags. WIP.
set the groundwork for handling percentage-width tables.  Troy is adding a hook for me to get the correct width info from the parent.  WIP.
1998-05-28 21:39:22 +00:00
troy
27c2f0230b Added WillReflow() calls around reflowing of child frame 1998-05-28 18:37:56 +00:00
kostello
a080d1c9b5 Fix crasher loading mozilla.org page 1998-05-28 18:31:44 +00:00
buster
11d1544188 fixed case-sensitive include 1998-05-26 23:28:48 +00:00
peterl
613e577b7d added visibility style attribute 1998-05-26 23:17:29 +00:00
buster
2104457c96 table width computation using style system (more than it used to, at least) 1998-05-26 22:03:16 +00:00
kostello
e1dc943664 Updated Table Border code to render HTML3.2 compatible borders (no longer using the cool,
CSS borders).
Fixed Table but submitted by Isaac David Guedalia <daniel_sh@gezernet.co.il>.
1998-05-26 20:57:24 +00:00
troy
3ea1d2d8e3 Merged ResizeReflow() and IncrementalReflow() into one Reflow() member function 1998-05-25 17:31:49 +00:00
troy
6204c78831 Changed splittable enum to be bit flags 1998-05-22 04:54:11 +00:00
buster
aafa0d6ab4 made nsTableCaptionFrame a subclass of nsBodyFrame 1998-05-22 00:05:22 +00:00
kostello
193764594a * Added Support for cell spacing
* NOTE: due to changes in the style system -- things won't look correct right away.
1998-05-21 23:43:18 +00:00
peterl
7168f94691 Changed GetStyleData to use an enum instead of an nsID 1998-05-21 02:34:13 +00:00
thom
aa407491f5 fixed compile errors for mac 1998-05-19 23:11:28 +00:00
kipp
280ccad41e Fixed up code that wasn't using the nsReflowStatus constants defined in nsIFrame.h 1998-05-14 00:49:46 +00:00
michaelp
d55497643c added gamma correction methods to the device context. the windows rendering context now
gamma corrects colors. fixed tablecellframe to call the right nsStyleCoord constructor.
1998-05-13 18:15:06 +00:00
peterl
9bc80be166 sync to new spacing apis 1998-05-12 22:28:01 +00:00
troy
8f2db5dfa6 Changed enum to conform with coding standards 1998-05-12 04:38:23 +00:00
troy
5b69e1f043 Change to nsIFrame API 1998-05-12 04:17:56 +00:00
kipp
2358c691b7 Fixed irix bustage 1998-05-08 21:12:12 +00:00
kipp
519a6403a4 Ported to new CreateFrame/CreateContinuingFrame APIs 1998-05-07 00:08:20 +00:00
troy
d477d86672 Frames no longet store the content index-in-parent 1998-05-05 23:56:50 +00:00
troy
b6217c70a6 Changed body to create block pseudo-frame instead of a column pseudo frame,
and hooked up the reflow appended code
1998-05-03 03:51:48 +00:00
kostello
8f901ec3a2 Cleaned up getting attribute values 1998-05-01 21:55:36 +00:00
kostello
150ca7f331 Made SetStyleContext take the presentation context as a parameter
Made DidSetStyleContext virtual, since we need to override the behavior in subclasses
Moved attribute setting logic from nsTableCell to nsTableCellFrame
Table Borders are being drawn again : )
Table Padding is being displayed
1998-05-01 20:44:55 +00:00
peterl
4c198bdb45 updated to new value class api 1998-04-30 19:55:51 +00:00
buster
0c2432db59 fixed method names 1998-04-30 18:04:16 +00:00
buster
a972bb8d29 added nsITableLayoutStrategy as the interface for objects that manage
table column balancing.  Implemented in BasicTableLayoutStrategy (HTML4-spec).
nsTableFrame instantiates a strategy depending on the compatibility mode.
1998-04-30 17:57:09 +00:00
buster
91aae361d3 fixed a rounding error, and made tables quiet 1998-04-30 15:20:23 +00:00
buster
dcc6e9e245 lots of pre-conditions and asserts added
fixed a bug in layout having to do with sizing cells in columns that are spanned into
1998-04-30 00:27:59 +00:00
peterl
fc1f06f9c2 changed nsStyleText to use nsStyleCoord 1998-04-28 23:57:01 +00:00
kostello
3290c4a875 Call to RecalcLayoutData 1998-04-28 22:44:05 +00:00
kostello
629b7937fc Name changed from ResetColumnLayoutData to RecalcColumnLayoutData 1998-04-28 22:41:25 +00:00
kipp
1fb3e42519 Use PERCENT instead of PCT in style constants; udpated usage of vertical alignment information in nsStyleText 1998-04-27 21:26:48 +00:00
kipp
941c955ed8 Fix porting bugs - made it compile on IRIX 1998-04-26 02:59:29 +00:00
kipp
93fdfbe671 Port to removal of nsStyleMolecule 1998-04-25 18:48:48 +00:00
buster
58bd0f2550 even better pagination. Tables with small captions can split, and
simple tables with big cells can split the cell (and it's row)
1998-04-24 20:59:44 +00:00
buster
ca3ae5f05c fixed a nefarious little bug with multiple row spans in the same table
subsequent rows (the ones below the effected rows) were not placed correctly
when the height of the spanning cell became greater than the sum of the heights
of the rows it spanned.
1998-04-23 22:59:07 +00:00
buster
9481637fae table header and footer rowgroups placed properly, replicated across continuing tables
some pagination fixes, including a hack to make negative available heights = 1.
1998-04-23 17:29:07 +00:00
peterl
c6fc3d1e32 WIP moving margin, border & padding out of nsStyleMolecule
Switch to nsIPtr for style context ptrs to eliminate leaks
1998-04-22 06:37:57 +00:00
scullin
2edcb9609d Fix release mode bustage. 1998-04-21 18:25:52 +00:00
buster
073e82f152 table performance and minor bug fixes. 1998-04-20 22:49:15 +00:00
troy
e1e6d470ff Changed IsSplittable to have three return values 1998-04-17 23:08:20 +00:00
troy
3ce8e88882 Changed nsIFrame member functions to return a nsresult 1998-04-17 01:41:24 +00:00
buster
d825ba1dfe removed noisy debug 1998-04-16 22:25:09 +00:00
buster
d7f07f5ef7 simple tables now paginate nicely. Some more complex tables
also paginate ok, though resizing in paginated mode doesn't work yet.
Captions still don't work.
1998-04-16 22:21:32 +00:00
michaelp
150ac682db fixed bug where we would double paint any frame that had a view. 1998-04-14 21:49:29 +00:00
buster
d3269eec0c documentation changes 1998-04-14 21:45:28 +00:00
kipp
098bef52b4 moved to pub 1998-04-13 20:24:54 +00:00