Commit Graph

632300 Commits

Author SHA1 Message Date
Masayuki Nakano
96bd720118 Bug 1521396 - Make ClickHandlerChild prevent multiple action of middle click on link element for preventing middle click paste r=smaug
When user middle clicks a link, most users must not expect to expose clipboard
content to the web application.  Therefore, we should stop firing paste event
when user click a link with middle button.

This patch makes ClickHandlerChild.handleEvent() prevent multiple action
when it posts middle click event on a link.  Note that even if middle click
event is consumed, default event handler will dispatch paste event.
Unfortunately, this is compatible behavior with the other browsers.
Therefore, we cannot change this behavior with calling preventDefault() and
this is the reason why this patch adds Event.preventMultipleActions().

Out of scope of this bug though, if there is an element which looks like a
link but implemented with JS, web apps can steal clipboard content if user
enables middle click event and user just wants to open the link in new tab.
It might be better to stop dispatching paste event in any browsers and request
to change each web apps.

Differential Revision: https://phabricator.services.mozilla.com/D17209

--HG--
extra : moz-landing-system : lando
2019-01-22 07:28:55 +00:00
Nicolas Chevobbe
74a30370f2 Bug 1519104 - Create a preference for webconsole editor;r=Honza.
Differential Revision: https://phabricator.services.mozilla.com/D17094

--HG--
extra : moz-landing-system : lando
2019-01-22 06:45:50 +00:00
Daisuke Akatsuka
7a7e1778dc Bug 1521349: Skip the shortcut keys test on win ccov. r=jdescottes
Because browser_aboutdebugging_devtoolstoolbox_shortcuts.js test open/close the
devtools several times, it takes a long time comparing with other tests.
Also, since the win ccov is super slow, this test was timeouted.
Thus, skip the test on win ccov at this moment.

Differential Revision: https://phabricator.services.mozilla.com/D17173

--HG--
extra : moz-landing-system : lando
2019-01-22 06:23:19 +00:00
Emilio Cobos Álvarez
8addc7a883 Bug 1521137 - The pres context's base min font size is dead code. r=heycam
Nobody uses it from js, and we only thread the value around in layout. Let's
kill all this code.

Differential Revision: https://phabricator.services.mozilla.com/D16999

--HG--
extra : moz-landing-system : lando
2019-01-21 07:15:02 +00:00
Mike Hommey
2a53b3dd2b Bug 1521666 - Do not try to package layout debugger files when layout debugger is disabled. r=dmajor
Differential Revision: https://phabricator.services.mozilla.com/D17202

--HG--
extra : moz-landing-system : lando
2019-01-22 04:01:33 +00:00
Cosmin Sabou
a90615efc4 Merge mozilla-central to autoland. 2019-01-22 05:59:58 +02:00
Cosmin Sabou
951d31e64d Merge mozilla-inbound to mozilla-central. a=merge 2019-01-22 05:56:10 +02:00
Glenn Watson
aeeb0f3b78 Bug 1521420 - Skip some redundant work during picture caching updates. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D17085

--HG--
extra : moz-landing-system : lando
2019-01-22 02:10:01 +00:00
Cameron McCormack
6898c96479 Bug 1521652 - Run rustfmt on servo/ports/geckolib/. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D17177

--HG--
extra : moz-landing-system : lando
2019-01-22 01:59:21 +00:00
James Teh
ee1ef24296 Bug 1518054: Move a11y focus event firing from richlistitem.current to richlistbox.currentItem to fix the All Downloads view. r=paolo
The All Downloads view removes and re-adds its richlistbox for performance reasons.
However, after bug 1492326, this causes the richlistitem's .current property to be assigned before its binding is applied.
Since the .current property fires a11y focus events, this means this property is overridden and thus the events never get fired for that item.
To fix this, move a11y focus event firing into richlistbox.currentItem.

Differential Revision: https://phabricator.services.mozilla.com/D16932

--HG--
extra : moz-landing-system : lando
2019-01-22 02:08:26 +00:00
Robert Strong
322fd9defc Bug 1520693 - Add test for the About Dialog policyDisabled panel. r=Felipe 2019-01-21 15:50:17 -08:00
Hiroyuki Ikezoe
cfd37ea8ea Bug 1520455 - Don't use the minimum scale size on fullscreen state to avoid the layout viewport gets larger than the visual viewport. r=botond
This is a workaround. To properly fix the issue we need to fix both of bug
1516377 and bug 1508177.

Differential Revision: https://phabricator.services.mozilla.com/D17103

--HG--
extra : moz-landing-system : lando
2019-01-21 23:35:09 +00:00
Emilio Cobos Álvarez
a0eb07ee30 Bug 1505222 - Pass TransformStyle::Preserve3d to WebRender more often for perspective display items. r=mattwoodrow
See the comment.

Differential Revision: https://phabricator.services.mozilla.com/D16768
2019-01-22 00:58:52 +01:00
Miko Mynttinen
f534fe0743 Bug 1514653 - Use the reference frame of the first flattened effect when recycling the layer r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D17079

--HG--
extra : moz-landing-system : lando
2019-01-21 22:03:10 +00:00
Miko Mynttinen
7292107f24 Bug 1518069 - Do not use transform separators for nsDisplayWrapList containing just nsDisplayTransform r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D16841

--HG--
extra : moz-landing-system : lando
2019-01-21 21:50:11 +00:00
Tom Ritter
77cce78dd3 Bug 1520310 - Backout the patch from Bug 1498695 and cast to void*. r=bobowen
In Bug 1462100 we started casting to void* because mingw doesn't do
automatic conversions like MSVC does.  In Bug 1498695 I backed out that
change because I (mistakenly) thought it wasn't necessary for mingw-clang
when in actuality, I simply wasn't hitting the code path due to
SANDBOX_EXPORTS being defined.

Since we want to _not_ define SANDBOX_EXPORTS I need to put the original
patch back in place.

--HG--
extra : amend_source : a26eec746e7881fa88b963c8dd3c1fa900b6a8b6
2019-01-21 14:13:17 -06:00
Tim Huang
58f7b5b978 Bug 1508355 - Add a test case for assuring all "Save ... As" options honor the first party domain. r=baku,richard@torproject.org
This patch adds a test case which tests following "Save ... As" options:

* File menu:
  - Save Page As
* Context menu in content pages:
  - Save Page As
  - Save Image As
  - Save Video As
  - Save Link As
  - Save Frame As
* Page Info "Media" Panel:
  - Save As

It triggers the save process and checks if the OA of the saving channel
has the correct first party domain.
2019-01-21 21:54:39 +02:00
Noemi Erli
92a09b4912 Backed out changeset d8e4a86e306a (bug 1520310) for bustages in filesystem_dispatcher.cc 2019-01-21 21:47:43 +02:00
Gabriel Luong
3572d90a2b Bug 1521270 - Add classes to the rule when it is uneditable or unmatched. r=mtigley 2019-01-21 14:39:11 -05:00
Gabriel Luong
e473720094 Bug 1521407 - Avoid rendering the computed property list if it is not necessary. r=rcaliman
- Avoid rendering the computed property list is not expanded.
- Avoid rendering the shorthand overridden computed property list if there is
no overridden properties in the computed property list.
2019-01-21 14:38:00 -05:00
Sylvestre Ledru
c4a4488fb4 Bug 1519636 - Ride along: Add more commits to the git ignore list r=ehsan
Differential Revision: https://phabricator.services.mozilla.com/D17151

--HG--
extra : rebase_source : 2af9ab15f206340c85c3387de083efe87fba1ffd
2019-01-21 20:32:16 +01:00
Gabriel Luong
a6b6d7f526 Bug 1521243 - Show a warning for invalid declarations and filter icon for overridden declarations in the new rules view. r=mtigley 2019-01-21 14:34:49 -05:00
Tom Ritter
aaa41182a0 Bug 1520310 - Disable SANDBOX_EXPORTS for the mingw-clang build as well r=bobowen
--HG--
extra : amend_source : 3fd0fda02e8d7fabef0657fb3be520e37d59e97d
2019-01-21 11:42:03 -06:00
Razvan Maries
c941c393cb Merge mozilla-central to mozilla-inbound. a=merge on a CLOSED TREE 2019-01-21 20:01:06 +02:00
Andrew Osmond
bba2f124b6 Bug 1521478 - Update libwebp to v1.0.2. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D17110
2019-01-21 12:55:02 -05:00
Andrew Osmond
1b65a4f599 Bug 1520760 - Fix AVX2 detection to ensure we have all required CPU parameters. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D16994
2019-01-21 12:53:46 -05:00
Razvan Maries
299b5e79f7 Merge mozilla-inbound to mozilla-central a=merge 2019-01-21 19:50:56 +02:00
Razvan Maries
599c8191cc Merge autoland to mozilla-central a=merge 2019-01-21 19:48:03 +02:00
Mike Hommey
aa2783bf67 Bug 1521284 - Don't hardcode config.log path in old-configure. r=nalexander
Because old-configure is only refreshed when, essentially,
old-configure.in changes, hardcoded (absolute) paths don't necessarily
match the build environment of the current build.

So instead, use an environment variable that we pass from python
configure when invoking old-configure.

Also do dummy changes to old-configure.in so that old-configure is
refreshed at least once to get the environment-based value.

Differential Revision: https://phabricator.services.mozilla.com/D17077

--HG--
extra : moz-landing-system : lando
2019-01-21 17:32:11 +00:00
Cosmin Sabou
72b543cadb Bug 1520924 - Added missing comma. r=eslint-fix
--HG--
extra : rebase_source : 1869d6379410f4dfee4552b309c31e945f0733b8
2019-01-22 00:00:05 +02:00
Emilio Cobos Álvarez
835a776787 Bug 1489440 - Disable autocomplete in the XUL autocomplete bindings. r=dao
With the patch above we do find the input element, and try to autocomplete it
normally, which confuses some tests.

Differential Revision: https://phabricator.services.mozilla.com/D17143

--HG--
extra : moz-landing-system : lando
2019-01-21 21:54:26 +00:00
Olli Pettay
8fba17bea2 Bug 1521564 - Add GetDocument to nsContentSink, r=mccr8 2019-01-21 19:09:33 +02:00
Ehsan Akhgari
ea0beadb68 Bug 1516889 - Part 2: Make sure the storage access API prompt is denied when pressing Esc; r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D16737
2019-01-21 11:23:22 -05:00
Ehsan Akhgari
1ac089291a Bug 1516889 - Part 1: Make sure browser_storageAccessDoorHanger.js passes by packaging its depenencies correctly; r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D16736
2019-01-21 11:22:55 -05:00
Ciure Andrei
eb5345d4eb Backed out 2 changesets (bug 1516889) for failing browser_storageAccessDoorHanger.js CLOSED TREE
Backed out changeset fe40c77b54b4 (bug 1516889)
Backed out changeset 95fee3425c55 (bug 1516889)
2019-01-21 17:48:11 +02:00
Petru-Mugurel Lingurar
d587b36c42 Bug 1520520 - Part 2 - Refactor testTrackingProtection to listen for ContentBlockingEvent; r=esawin,ehsan
After the changes from bug 1514340 the app is now informed about tracking with
Content:ContentBlockingEvent instead of Content:SecurityChange
Also initialized mLastTracking with unknown as that is the default value
when no tracking event has been received (eg: no tracking elements on the page)

Depends on D16822

Differential Revision: https://phabricator.services.mozilla.com/D16823
2019-01-21 10:03:52 -05:00
Petru-Mugurel Lingurar
095fa60743 Bug 1520520 - Part 1 - Update UI with tracking events from ContentBlockingEvent; r=esawin,ehsan
onSecurityChange from browser.js will not send information about tracking
anymore to Java (because it doesn't know about that anymore).

onContentBlocking from browser.js will be responsible for this from now on.

    is called after onSecurityChange which will have created a SiteIdentity()

for that tab in Java

    is informed only about tracking status which it caches to only send updates

downstream to Java. Will not propagate identical events one after the other.

    will not fire for websites which do not contains any tracking elements

A Content:ContentBlockingEvent received in Java will update the tracking
property of SiteIdentity and finally update the UI with
ToolbarDisplayLayout#updateSiteIdentity().

Differential Revision: https://phabricator.services.mozilla.com/D16822
2019-01-21 10:02:16 -05:00
Ehsan Akhgari
4137a92662 Bug 1514340 - Part 2: Break out the content blocking related notifications into nsIWebProgressListener.onContentBlockingEvent(); r=baku,johannh
Differential Revision: https://phabricator.services.mozilla.com/D16052
2019-01-21 09:58:50 -05:00
Ehsan Akhgari
5d7e383969 Bug 1514340 - Part 1: Add the nsISecurityEventSink::OnContentBlockingEvent() helper method; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D16051
2019-01-21 09:58:50 -05:00
Ehsan Akhgari
46e587fc36 Bug 1516889 - Part 2: Make sure the storage access API prompt is denied when pressing Esc; r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D16737
2019-01-21 09:57:31 -05:00
Ehsan Akhgari
31ea61b3c2 Bug 1516889 - Part 1: Make sure browser_storageAccessDoorHanger.js passes by packaging its depenencies correctly; r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D16736
2019-01-21 09:57:31 -05:00
Sylvestre Ledru
755a1a7c2f Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D17063

--HG--
extra : moz-landing-system : lando
2019-01-21 14:49:22 +00:00
Emilio Cobos Álvarez
375a43132d Bug 1489440 - Fix nsFormFillController in presence of Shadow DOM. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D17121

--HG--
extra : moz-landing-system : lando
2019-01-21 14:29:16 +00:00
Tim Nguyen
d93a655764 Bug 1512663 - Show bookmark tags in UrlbarView rows. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D17078

--HG--
extra : moz-landing-system : lando
2019-01-21 21:57:22 +00:00
Ricky Rosario
bbd0796d2c Bug 1508364 - New UI for Private Browsing with Search r=andreio
MozReview-Commit-ID: 4WSGpL5Gvde

Differential Revision: https://phabricator.services.mozilla.com/D16854

--HG--
extra : moz-landing-system : lando
2019-01-21 20:14:26 +00:00
Botond Ballo
11b304b442 Bug 1521618 - Remove non-ASCII characters from comments in RetainedDisplayListBuilder.cpp (DONTBUILD for comment change). r=mattwoodrow.
Differential Revision: https://phabricator.services.mozilla.com/D17162

--HG--
extra : moz-landing-system : lando
2019-01-21 21:53:26 +00:00
cowlesni
994165ff86 Bug 1517529 - Migrate safeMode dialog to Fluent for localization, r=Gijs,flod
Differential Revision: https://phabricator.services.mozilla.com/D16987

--HG--
extra : moz-landing-system : lando
2019-01-21 21:51:10 +00:00
Tim Nguyen
a41077218e Bug 1520924 - Remove 'update' XBL binding and convert strings to Fluent. r=paolo,flod
Differential Revision: https://phabricator.services.mozilla.com/D16982

--HG--
extra : moz-landing-system : lando
2019-01-21 21:40:52 +00:00
Ed Lee
22c90af654 Bug 1521266 - Add 1/2-column lists, non-prerendered discovery and bug fixes to Activity Stream r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D17047

--HG--
extra : moz-landing-system : lando
2019-01-21 19:26:09 +00:00
Matt Woodrow
18b658e2e8 Bug 1477366 - Fuzz some tests for differences between WR and the fallback path. r=mstange
Differential Revision: https://phabricator.services.mozilla.com/D17090

--HG--
extra : moz-landing-system : lando
2019-01-21 20:01:22 +00:00