Commit Graph

653049 Commits

Author SHA1 Message Date
Jean-Yves Avenard
98f310048b Bug 1550422 - P10. Define StaticPrefs setter. r=njn
This is used by some gfx code and is required to convert gfxPrefs into StaticPrefs.

The setter only modifies the value of the StaticPref in the current process and doesn't propagate to others.

Differential Revision: https://phabricator.services.mozilla.com/D31254

--HG--
extra : moz-landing-system : lando
2019-05-23 04:13:08 +00:00
Jean-Yves Avenard
1ba7652612 Bug 1550422 - P9. Sync preferences in VR process when they change. r=daoshengmu
Differential Revision: https://phabricator.services.mozilla.com/D31017

--HG--
extra : moz-landing-system : lando
2019-05-23 04:13:07 +00:00
Jean-Yves Avenard
92e6d6a079 Bug 1550422 - P8. Add shared pref serializer/deserializer to VR process. r=kmag,daoshengmu
Differential Revision: https://phabricator.services.mozilla.com/D31016

--HG--
extra : moz-landing-system : lando
2019-05-23 04:13:07 +00:00
Jean-Yves Avenard
6b2b4eb23d Bug 1550422 - P7. Add VR process selector to prefs module. r=spohl
Will be needed to remove gfxPrefs in favor of StaticPrefs

Differential Revision: https://phabricator.services.mozilla.com/D31015

--HG--
extra : moz-landing-system : lando
2019-05-23 04:13:07 +00:00
Jean-Yves Avenard
0176b72a88 Bug 1550422 - P6. Release object early when error. r=mattwoodrow
No need to keep the object alive.

Differential Revision: https://phabricator.services.mozilla.com/D31014

--HG--
extra : moz-landing-system : lando
2019-05-23 04:13:06 +00:00
Jean-Yves Avenard
ae9b00180b Bug 1550422 - P5. Sync preferences with RDD process when then changed. r=mattwoodrow,mjf
Differential Revision: https://phabricator.services.mozilla.com/D30590

--HG--
extra : moz-landing-system : lando
2019-05-23 04:13:06 +00:00
Jean-Yves Avenard
74921b190e Bug 1550422 - P4. Sync preferences when they changed. r=mattwoodrow
This will allow to remove gfxPrefs later. On Windows in particular, the need to decide gfxPrefs vs StaticPrefs for the WMF decoders has caused several bugs in the past.
We will remove the confusion as a consequence.

Differential Revision: https://phabricator.services.mozilla.com/D30589

--HG--
extra : moz-landing-system : lando
2019-05-23 04:13:06 +00:00
Jean-Yves Avenard
6cdba9b76b Bug 1550422 - P3. Fix typo when filtering preferences to sync. r=njn
Differential Revision: https://phabricator.services.mozilla.com/D30588

--HG--
extra : moz-landing-system : lando
2019-05-23 04:13:05 +00:00
Jean-Yves Avenard
8f7ae177ac Bug 1550422 - P2. add shared pref serializer/deserializer to GPU process. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D30587

--HG--
extra : moz-landing-system : lando
2019-05-23 04:13:05 +00:00
Jean-Yves Avenard
63a416f158 Bug 1550422 - P1. Add GPU process selector to prefs module. r=spohl,mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D30586

--HG--
extra : moz-landing-system : lando
2019-05-23 04:13:05 +00:00
Jean-Yves Avenard
a7d76c8887 Bug 1550422 - P00. Fix Windows compilation. r=dmajor
Following the shift in unified build setup following the removal of gfxPrefs.{cpp,c} we hit this error.

Unified builds made this header get included with other files that use multiple inheritance, and clang-cl about the conflicting inheritance models. Local testing suggests clang-cl doesn't need the pragma anyway, so just take it out.

Differential Revision: https://phabricator.services.mozilla.com/D31465

--HG--
extra : moz-landing-system : lando
2019-05-23 04:13:13 +00:00
Jean-Yves Avenard
6fb0889b9a Bug 1550422 - P0. Use X11UndefineNone.h to avoid conflicts with the macro None from X11/X.h. r=karlt
Differential Revision: https://phabricator.services.mozilla.com/D31971

--HG--
extra : moz-landing-system : lando
2019-05-23 04:13:16 +00:00
Jorg K
d68e18d631 Bug 1553957 - Follow-up: Revert changeset 9a89e2b0fa9d and include WindowProxyHolder.h in JSWindowActorChild.cpp. r=bzbarsky
Reviewers: bzbarsky

Reviewed By: bzbarsky

Bug #: 1553957

Differential Revision: https://phabricator.services.mozilla.com/D32514

--HG--
extra : rebase_source : 32f18c40dbbfeb19da8fa5f25bd69ff4286d0a31
2019-05-25 02:53:49 +03:00
Barret Rennie
a71ef09a3f Bug 1547472 - Ref count the ProfilerScreenshots structure r=gerald,jesup
Differential Revision: https://phabricator.services.mozilla.com/D32524

--HG--
extra : moz-landing-system : lando
2019-05-24 23:53:28 +00:00
Narcis Beleuzu
b9bb66c9e0 Backed out changeset 204c7f42d427 (bug 1554178) for xpcshell failures on test_remote_settings.js . CLOSED TREE 2019-05-25 02:41:41 +03:00
Nika Layzell
1976124273 Bug 1535835 - Remove global weak ref to BrowsingContext within Unlink(), r=farre
Differential Revision: https://phabricator.services.mozilla.com/D30683

--HG--
extra : moz-landing-system : lando
2019-05-24 20:15:53 +00:00
Nika Layzell
77532c1fa6 Bug 1553270 - Part 2: Allow getting a protocol's name from its ProtocolID, r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D32043

--HG--
extra : moz-landing-system : lando
2019-05-24 22:36:49 +00:00
Nika Layzell
406f5cc2d8 Bug 1553270 - Part 1: Store the protocol ID on IProtocol directly, r=froydnj
This allows for the getter to be used in IProtocol's destructor, and generally
brings IProtocol more in line with IToplevelProtocol.

Differential Revision: https://phabricator.services.mozilla.com/D32042

--HG--
extra : moz-landing-system : lando
2019-05-24 20:21:35 +00:00
Brad Werth
0513d4f213 Bug 1496609 Part 1: Add a test of getViewportInfo clamping initial-scale to min-scale. r=botond
Differential Revision: https://phabricator.services.mozilla.com/D32366

--HG--
extra : moz-landing-system : lando
2019-05-24 22:58:45 +00:00
Dale Harvey
481bc67f05 Bug 1552193 - Restore engine shortName to pre webextensions value. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D31876

--HG--
extra : moz-landing-system : lando
2019-05-24 21:02:51 +00:00
Mathieu Leplatre
daebd4816c Bug 1554178 - Disable events sampling for uptake telemetry tests r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D32484

--HG--
extra : moz-landing-system : lando
2019-05-24 16:23:31 +00:00
Nika Layzell
899ad56a3d Bug 1550613 - Part 2: Add test for early-lifecycle in-process messages, r=jdai
Differential Revision: https://phabricator.services.mozilla.com/D30665

--HG--
extra : moz-landing-system : lando
2019-05-24 20:16:18 +00:00
Nika Layzell
dd50c7634c Bug 1550613 - Part 1: Get other side actor after posting to the event loop, r=jdai
This patch changes the timing of when the other side actor is created to
be after posting the message to the event loop, to avoid situations
early during actor creation when the parent side hasn't been created yet
triggering null pointer crashes.

Differential Revision: https://phabricator.services.mozilla.com/D30664

--HG--
extra : moz-landing-system : lando
2019-05-24 20:16:16 +00:00
Nika Layzell
e24cefae3f Bug 1553952 - Fire oop-browser-crashed when mBrowserParent construction fails, r=mconley
This is an attempt to reduce the negative impact of bug 1553644 by replacing a
remote browser which fails to create an `mBrowserParent` actor with a tab
crashed display rather than a failed `nsFrameLoader`. This is done by firing the
`oop-browser-crashed` event on the owner `<browser>` element when the attempt
fails, even if no `BrowserParent` was ever created.

This does not fix the root cause of bug 1553644, but may make the browser better
at recovering.

Differential Revision: https://phabricator.services.mozilla.com/D32381

--HG--
extra : moz-landing-system : lando
2019-05-24 22:14:44 +00:00
Sylvestre Ledru
d4a0ba5010 Bug 1554115 - mozlint rustfmt should fail if using the old rustfmt version r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D32439

--HG--
extra : moz-landing-system : lando
2019-05-24 21:53:58 +00:00
Alastor Wu
fb742c262d Bug 1550633 - part17 : enable loading for track elements in 'browser_cache.js ' and 'trackerFrame.html '. r=timhuang
As now we won't load disabled text track, we have to mark track as default in order to trigger loading which would be done by automatically text track selection, or to set its track mode explicitly.

Differential Revision: https://phabricator.services.mozilla.com/D32359

--HG--
extra : moz-landing-system : lando
2019-05-24 19:07:18 +00:00
alwu
2425d24591 Bug 1550633 - part16 : turn off the pref 'media.block-autoplay-until-in-foreground' in wpt. r=jgraham
Sometime wpt runs test even before the document becomes visible, which would delay `video.play()` and cause `play()` running in wrong order.

Differential Revision: https://phabricator.services.mozilla.com/D32079

--HG--
extra : moz-landing-system : lando
2019-05-24 00:40:55 +00:00
alwu
53b352f32f Bug 1550633 - part15 : return error when we failed to create channel. r=jya
The channel might not be created correctly if we pass invaild url (eg. "invalid://url"), we should handle this error.

Differential Revision: https://phabricator.services.mozilla.com/D32038

--HG--
extra : moz-landing-system : lando
2019-05-24 00:40:58 +00:00
alwu
abe2ed56ba Bug 1550633 - part14 : add a test for 'honor user preferences for automatic text track selection'. r=bzbarsky
This test is used to ensure that we queue 'honor user preferences for automatic text track selection' as a marco task, not a mirco task.

In this test, we would trigger a media event before queuing a text track selection task, and check the text track's mode to know whether the text track selection runs after the task for media event.

Differential Revision: https://phabricator.services.mozilla.com/D31921

--HG--
extra : moz-landing-system : lando
2019-05-24 00:41:00 +00:00
alwu
71e65af283 Bug 1550633 - part13.6 - refactor tests. r=jya
Refactor those tests' structure in order to make them more readable, and add the comment to show what the test purpose is for each test.

Differential Revision: https://phabricator.services.mozilla.com/D31914

--HG--
extra : moz-landing-system : lando
2019-05-24 00:41:02 +00:00
alwu
7e3d903ca9 Bug 1550633 - part13.5 - wait text track element's 'load' event. r=jya
This patch do two things in order to trigger loading for track element and wait for correct event to check track's and cues' status after loading finished.

(1) listen track element's load event
There are some tests listening video's loadedmetadata, but it's wrong. The loading process of media element and track element are completely non-related.
If you would like to check track element's status, you should wait for track element's load event.

(2) enable track explictly
If the text track which has default attribute is added to the media element before the media element starts running automatic track selection [1], then it would be enable by the media element.
Otherwise, you have to enable track explicitly by changing its track mode.

[1] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:text-track-7

Differential Revision: https://phabricator.services.mozilla.com/D31913

--HG--
extra : moz-landing-system : lando
2019-05-24 00:41:04 +00:00
alwu
b045a61b28 Bug 1550633 - part13.4 : don't use anonymous function. r=jya
Use named function for callback to reduce the indentation.

Differential Revision: https://phabricator.services.mozilla.com/D31912

--HG--
extra : moz-landing-system : lando
2019-05-24 00:41:06 +00:00
alwu
4b62a057ad Bug 1550633 - part13.3 - create elements in HTML, not in JS. r=jya
Create test elements in HTML beforehand, which can remove unnecessary JS code and make test cleaner.

Differential Revision: https://phabricator.services.mozilla.com/D31911

--HG--
extra : moz-landing-system : lando
2019-05-24 00:41:08 +00:00
alwu
75459f89eb Bug 1550633 - part13.2 - no need to set pref "media.webvtt.regions.enabled". r=jya
These tests didn't use region at all, so we have no need to set the pref.

Differential Revision: https://phabricator.services.mozilla.com/D31910

--HG--
extra : moz-landing-system : lando
2019-05-24 00:41:10 +00:00
alwu
35f5a82cdc Bug 1550633 - part13.1 - remove unnecessary elements. r=jya
These elemenets are useless and we can run tests without them.

Differential Revision: https://phabricator.services.mozilla.com/D31909

--HG--
extra : moz-landing-system : lando
2019-05-24 00:41:12 +00:00
alwu
087c97b591 Bug 1550633 - part12 : enable wpts. r=jya
Differential Revision: https://phabricator.services.mozilla.com/D31561

--HG--
extra : moz-landing-system : lando
2019-05-24 00:41:14 +00:00
alwu
0e6fb4ef3b Bug 1550633 - part11.1 - modify 'track-element-src-change-error.html'. r=jya
According to spec [1], if the track URL changes so that it is no longer equal to URL while fetching is ongoing, we need to change the text track readiness state to`failed to load` and dispatch `error`.

So we now only fire `error` if `src` is removed during loading, but if the track element has finished loading before removing `src`, we won't dispatch `error` for it.

[1] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:text-track-failed-to-load-3

Differential Revision: https://phabricator.services.mozilla.com/D31915

--HG--
extra : moz-landing-system : lando
2019-05-24 00:41:16 +00:00
alwu
0ecc59ad1d Bug 1550633 - part11 : modify wpt 'track-element-src-change.html' and 'track-element-src-change-error.html'. r=jya
According to the spec [1], the text track list of cues is initially empty. It is dynamically modified when the referenced file is parsed.

Therefore, after reset the track element's url, the number of cues of the text track should be zero, until we start parsing resource and add cue into the list.

[1]
https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:text-track-list-of-cues
https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:text-track-list-of-cues-3

Differential Revision: https://phabricator.services.mozilla.com/D31560

--HG--
extra : moz-landing-system : lando
2019-05-24 00:41:19 +00:00
alwu
fcc2ffd6d9 Bug 1550633 - part10 : automatically capture and print the address of track element in debug log and add new log. r=jya
To reduce non-neccesary input, we can always capture `this` and print the address in the log, and use same log level for all of them.

Differential Revision: https://phabricator.services.mozilla.com/D31559

--HG--
extra : moz-landing-system : lando
2019-05-24 00:41:21 +00:00
alwu
e233315d02 Bug 1550633 - part9 : capture 'this' in lambda. r=jya
There are too many `self` used in the lambda, we can just capture `this` to remove redudant `self`.

Differential Revision: https://phabricator.services.mozilla.com/D31558

--HG--
extra : moz-landing-system : lando
2019-05-24 00:41:25 +00:00
alwu
93f917aacf Bug 1550633 - part8 : no need to reload if the new url is the same. r=jya
Accoding to spec [1], after loading finished, the start the track processing model would stop at step12 and wait until the track URL changes to the URL which is not equal to the URL we have loaded before. That means, if we change track URL to the same URL we loaded before, we won't have to reload the resource.

[1] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:track-url-5

Differential Revision: https://phabricator.services.mozilla.com/D31557

--HG--
extra : moz-landing-system : lando
2019-05-24 00:41:23 +00:00
alwu
6a27441f17 Bug 1550633 - part7 : change ready state to 'FAILED_TO_LOAD' and dispatch 'error' event when we have no 'src' or have an empty url. r=jya
`Failed to load` [1] indicates that the text track was enabled, but when the user agent attempted to obtain it, this failed in some way.

According to the spec [2], if fetching fails for any reason (network error, the server returns an error code, CORS fails, etc), or if URL is the empty string, then queue a task to first change the text track readiness state to `failed to load` and then fire an event named `error` at the track element. And spec [3] also mention that, if the track URL changes so that it is no longer equal to URL while fetching is ongoing, we also need to change the text track readiness state to`failed to load` and dispatch `error`.

[1] https://html.spec.whatwg.org/multipage/media.html#text-track-readiness-state
[2] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:text-track-failed-to-load
[3] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:text-track-failed-to-load-3

Differential Revision: https://phabricator.services.mozilla.com/D31556

--HG--
extra : moz-landing-system : lando
2019-05-24 00:41:27 +00:00
alwu
973b2aec17 Bug 1550633 - part6 : clear track's cues list whenever track element's src attribute set, changed or removed. r=jya,baku
According to the spec [1], we should empty track's cue list whenever a track element has its src attribute set, changed, or removed.

[1] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:attr-track-src

Differential Revision: https://phabricator.services.mozilla.com/D31552

--HG--
extra : moz-landing-system : lando
2019-05-24 00:41:29 +00:00
alwu
339990cb09 Bug 1550633 - part5 : modify and enable test 'track-mode-not-changed-by-new-track.html'. r=jya
In `honor user preferences for automatic text track selection` [1], we would set `did-perform-automatic-track-selection` flag to true [2], and then we won't execute automatic track selection anymore [3].

It means that we would only do automatic track selection one time, and then user has to enable newly added track explicitly by changing its mode.

In this test, we have done the automatic track selection when we added the `metadata` track to media element's text track list, so we won't run it again, even if the newly added track has `default` attribute.

Therefore, we have to enable the `caption` track explicitly. In addition, add the missing `event` parameter for the function `trackAdded()`.


[1] https://html.spec.whatwg.org/multipage/media.html#honor-user-preferences-for-automatic-text-track-selection
[2] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:did-perform-automatic-track-selection-2
[3] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:did-perform-automatic-track-selection

Differential Revision: https://phabricator.services.mozilla.com/D31375

--HG--
extra : moz-landing-system : lando
2019-05-24 00:41:31 +00:00
alwu
ef9e1890ec Bug 1550633 - part4 : no need to run text track selection in stable state. r=bzbarsky
According to spec [1], it doesn't mention that we have to run text track selection in stable state, it just said "the user agent must queue a task to run the following steps".

[1] https://html.spec.whatwg.org/multipage/media.html#honor-user-preferences-for-automatic-text-track-selection

Differential Revision: https://phabricator.services.mozilla.com/D31374

--HG--
extra : moz-landing-system : lando
2019-05-24 00:41:33 +00:00
alwu
48d979dff3 Bug 1550633 - part3 : add debug log to show track's kind. r=jya
Showing track's kind in debug log is helpful.

Differential Revision: https://phabricator.services.mozilla.com/D31373

--HG--
extra : moz-landing-system : lando
2019-05-24 00:41:35 +00:00
alwu
ee122028fb Bug 1550633 - part2 : maybe start loading resource when the track's mode changes. r=jya
According to the spec [1], the user agent must start the track processing model when text track has its text track mode changed.

[1] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:start-the-track-processing-model

Differential Revision: https://phabricator.services.mozilla.com/D31372

--HG--
extra : moz-landing-system : lando
2019-05-24 00:41:38 +00:00
alwu
dbb90759a6 Bug 1550633 - part1 : HTMLTrackElement should not load resource when its text track is disable. r=jya
According to the spec step2 [1], we should not load resource for the track element which text track is disabled.

[1] https://html.spec.whatwg.org/multipage/media.html#start-the-track-processing-model

Differential Revision: https://phabricator.services.mozilla.com/D31371

--HG--
extra : moz-landing-system : lando
2019-05-24 00:41:40 +00:00
Timothy Nikkel
c2b7c26de8 Bug 1553061. Futher bump expected assert counts on toolkit/content/tests/chrome/test_bug437844.xul for beta. r=aosmond
Beta sees a couple more of these same asserts for some reason.

Explanation of logic for bumping these counts can be found in bug 1530190 where we bumped them already before.

Differential Revision: https://phabricator.services.mozilla.com/D32384

--HG--
extra : moz-landing-system : lando
2019-05-24 10:45:37 +00:00
David Walsh
1f92597fe6 Bug 1553278 - Fix download file functionality in debugger r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D32050

--HG--
extra : moz-landing-system : lando
2019-05-24 14:39:51 +00:00