Commit Graph

647650 Commits

Author SHA1 Message Date
Brian Grinstead
9bda39c108 Bug 1519502 - Convert menu bindings to a Custom Element r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D19593

--HG--
extra : moz-landing-system : lando
2019-04-18 16:41:46 +00:00
Brian Grinstead
7621a8bf3a Bug 1528268 - Make initializeAttributeInheritance and incremental attribute changes do less work r=aswan
This provides a flipped data structure based on the provided inheritedAttributes,
which looks like:

Object<selector, attrs_to_inherit_comma_separated>

To one that looks like:

Object<attr, Array<Array<selector, attr_to_inherit>>

This should improve performance because:

1) We only fetch element at connectedCallback that actually will have attributes inherited.
2) When an attribute changes we can quickly inherit only that one.

Differential Revision: https://phabricator.services.mozilla.com/D27801

--HG--
extra : moz-landing-system : lando
2019-04-18 16:41:39 +00:00
Razvan Maries
09aa6219f7 Bug 1543732 - disabled 785753-2 on all platforms r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D27705

--HG--
extra : moz-landing-system : lando
2019-04-18 03:42:33 +00:00
Brian Grinstead
9a35d3783f Bug 1543828 - Use <bdi> inside video controls content r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D27757

--HG--
extra : moz-landing-system : lando
2019-04-18 17:45:22 +00:00
Markus Stange
1278948ebb Bug 1543944 - Don't mark nsDisplayVideo as opaque for now because we were using a rectangle that's too big. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D27979

--HG--
extra : moz-landing-system : lando
2019-04-18 17:22:29 +00:00
Rob Wu
ccb2766ceb Bug 1301837 - Defer SwapDocShells event registration in MessageManagerProxy r=rpl
The "SwapDocShells" event should be deferred until "EndSwapDocShells".
Otherwise the event MessageManagerProxy may swap the event listeners
twice, and end up having the listeners on the incorrect message manager.

Differential Revision: https://phabricator.services.mozilla.com/D27295

--HG--
extra : moz-landing-system : lando
2019-04-18 17:07:46 +00:00
Andrew Halberstadt
e105223614 Bug 1539932 - [ci] Handle serviceworker/socketprocess test variants more generically, r=jmaher
We are starting to spin off more and more "variants" of test suites. These are
usually just duplicates of our pre-existing tasks, except with an additional
pref set.

Currently there are two variants (serviceworker-e10s and socketprocess-e10s),
but a third will be added soon (fission). This change ensures we handle these
types of requests in a consistent and well defined manner. It also splits tasks
in a loop, so we don't accidentally risk combinatorial explosion.

Variants should typically be reserved for very large changes that will impact
the entire codebase (think e10s).

Differential Revision: https://phabricator.services.mozilla.com/D28061

--HG--
extra : moz-landing-system : lando
2019-04-18 14:40:08 +00:00
Matt Howell
31bc6abec8 Bug 1046479 - Clean up the special ESR registry key during uninstall or paveover. r=agashlin
For bug 726781, the Windows installer was patched to begin creating a special
registry key when installing an ESR build, to provide a convenient indication
that the product that's installed is an ESR version of the product.
This key contains only the version number of the application being installed;
it is separate from the keys that are always created, for all types of
builds, and that contain the installation path, etc.

During an uninstall or a paveover install, the registry is cleaned by looking
for any keys which contain the path to the application being uninstalled and
removing those; the RegCleanMain function handles this, and for non-ESR builds
it works well. However, there is nothing that tries to remove or update the
special ESR key when an ESR build is being uninstalled or paved over with a
non-ESR build. This patch adds that code to RegCleanMain.

Differential Revision: https://phabricator.services.mozilla.com/D26625

--HG--
extra : moz-landing-system : lando
2019-04-18 16:47:42 +00:00
Chris H-C
1b6b21de96 Bug 1545207 - Mock the Search Service region test in Telemetry Client Tests r=raphael
We don't want spurious net connections, so we should mock the result.
In addition, we need to mock it to a specific non-North-American region to
ensure we don't cause an extra change to browser.search.region which may split
the subsession in the middle of our tests.

Differential Revision: https://phabricator.services.mozilla.com/D28059

--HG--
extra : moz-landing-system : lando
2019-04-18 16:38:16 +00:00
Thomas Wisniewski
8e80a6d3d8 Bug 1540933 - move the buttons on about:compat's mobile view to the left in rtl mode; r=miketaylr,denschub
move the buttons on about:compat's mobile view to the left in rtl mode

Differential Revision: https://phabricator.services.mozilla.com/D28000

--HG--
extra : moz-landing-system : lando
2019-04-18 15:50:03 +00:00
Andrew Halberstadt
af84858720 Bug 1532747 - Create try-only raptor tp6m-1 fenix task, r=rwood
Differential Revision: https://phabricator.services.mozilla.com/D27948

--HG--
extra : moz-landing-system : lando
2019-04-17 19:49:52 +00:00
Razvan Maries
74e5a11e50 Backed out changeset 24d0d307385d (bug 1545440) for perma failures on browser_parsable_css.js. CLOSED TREE 2019-04-19 02:06:41 +03:00
Haik Aftandilian
73b7f5c089 Bug 1543830 - Add Mac Hardened Runtime entitlement files to the tree r=spohl
Add entitlement files for Hardened Runtime configuration to be used by Release Engineering for official builds and try builds and developers for local builds. These entitlement files are input to the codesign command.

Hardened Runtime and codesigning is not yet enabled for local builds or try builds so for now these files will only be used by Release Engineering.

production.entitlements.xml is intended to be used for official channel builds that will be codesigned, notarized, and shipped to users.

developer.entitlements.xml is intended to be used for developer and try builds that will be codesigned, but not notarized or shipped to users. The developer file enables debugging which is not compatible with notarization, but is otherwise the same as the production file.

codesign.bash is a stop-gap script to allow developers who setup Apple Developer ID certificates to codesign Nightly themselves and enabled Hardened Runtime.

Differential Revision: https://phabricator.services.mozilla.com/D27396

--HG--
extra : moz-landing-system : lando
2019-04-18 15:56:00 +00:00
Andreea Pavel
b278ac4263 Merge mozilla-central to autoland on a CLOSED TREE 2019-04-19 01:19:13 +03:00
Andreea Pavel
9bcf2b8dd3 Backed out changeset 643f81697dae (bug 1444447) because it causes graphical corruption in menus, see bug 1444447 comment 25 a=backout 2019-04-19 01:15:25 +03:00
Ciure Andrei
7344cf1d0e Backed out changeset a7cbe0438433 (bug 1540733) for causing browser_ipcBlob_temporary.js and test_wasm_recompile.js to perma fail CLOSED TREE 2019-04-19 00:58:10 +03:00
Andreea Pavel
eb0b5758ea Merge mozilla-central to autoland. on a CLOSED TREE 2019-04-19 00:48:30 +03:00
Andreea Pavel
e5b695eefd Merge mozilla-inbound to mozilla-central. a=merge 2019-04-19 00:36:23 +03:00
Razvan Maries
0af3d45361 Backed out changeset a3dc461058c5 (bug 1544682) for perma failures on toolkit/components/extensions/test/browser/browser_ext_themes_separators.js. CLOSED TREE 2019-04-19 00:29:45 +03:00
Razvan Maries
1f6c35708a Backed out changeset 2f8f0e53a7db (bug 1460811) for leakcheck perma failures. CLOSED TREE 2019-04-19 00:16:32 +03:00
Rob Wu
d3467efbf0 Bug 1544981 - Stop tapping caskroom/versions in bootstrap for macOS r=nalexander
`caskroom/versions` was replaced with `homebrew/cask-versions` in 2018.
Tap `caskroom/versions` instead of the old one.

If you have two taps, remove the old one using:

    brew untap caskroom/versions

Differential Revision: https://phabricator.services.mozilla.com/D27839

--HG--
extra : moz-landing-system : lando
2019-04-18 18:39:31 +00:00
Mike Conley
6f2e110ae1 Bug 1544969 - Show the Picture-in-Picture flyout when hovering the toggle. r=jaws,flod
Differential Revision: https://phabricator.services.mozilla.com/D27835

--HG--
extra : moz-landing-system : lando
2019-04-18 17:29:39 +00:00
Brian Grinstead
36bfb3ba81 Bug 1544051 - Part 4 - Remove AddTask.js r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D27762

--HG--
extra : moz-landing-system : lando
2019-04-18 16:51:42 +00:00
Brian Grinstead
381332c51e Bug 1544051 - Part 3 - Scripted change to remove references to AddTask.js r=ahal
This was generated with the script at https://bug1544051.bmoattachments.org/attachment.cgi?id=9058672

Differential Revision: https://phabricator.services.mozilla.com/D27761

--HG--
extra : moz-landing-system : lando
2019-04-18 16:51:01 +00:00
Brian Grinstead
7ab932d712 Bug 1544051 - Part 2 - Remove some references to AddTask.js that aren't caught by the script in part 3 r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D27760

--HG--
extra : moz-landing-system : lando
2019-04-18 16:50:39 +00:00
Brian Grinstead
87bc6e7b7a Bug 1544051 - Part 1 - Move add_task into SimpleTest.js r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D27759

--HG--
extra : moz-landing-system : lando
2019-04-18 17:01:02 +00:00
Robert Strong
b8b5ed3ca4 Bug 1541989 - Remove ability to pause updates from the old update UI. r=bytesized
Pausing isn't implemented for BITS and this UI will be removed entirely in the future.

Differential Revision: https://phabricator.services.mozilla.com/D27847

--HG--
extra : moz-landing-system : lando
2019-04-18 16:28:37 +00:00
Aki Sasaki
2f5bc0820d Bug 1545256 - only append action TASK_ID to task deps if taskGroupId doesn't match r=dustin
We only want to append the action TASK_ID to the task dependencies when the taskGroupId doesn't match, otherwise we hit dup dependency errors.

Differential Revision: https://phabricator.services.mozilla.com/D27994

--HG--
extra : moz-landing-system : lando
2019-04-18 12:51:31 +00:00
Razvan Maries
98807b06a6 Backed out changeset 081a659775d3 (bug 1529879) for xpcshell perma failures. CLOSED TREE 2019-04-18 20:59:54 +03:00
Magnus Melin
3f542151f4 Bug 1530207 - fix crash [@ InvalidArrayIndex_CRASH | mozilla::a11y::Accessible::InsertChildAt] . r=surkov
For XULTreeAccessible, the ChildCount() is not only the mChildren, so check mChildren directly to make sure we stay within bounds

Differential Revision: https://phabricator.services.mozilla.com/D27553

--HG--
extra : moz-landing-system : lando
2019-04-18 09:39:59 +00:00
Julian Descottes
01f1b67f71 Bug 1544749 - Use toolbox.topWindow in devtools tests relying on toolbox.win.top/parent r=daisuke
Depends on D27677
 Update tests directly referencing toolbox.win.top/parent.

Differential Revision: https://phabricator.services.mozilla.com/D27680

--HG--
extra : moz-landing-system : lando
2019-04-18 09:06:23 +00:00
Julian Descottes
d2e81fef8f Bug 1544749 - Sidebar iframe onload callback should not rely on event.target r=daisuke
Depends on D27675
The target of the iframe load event is the content document when running in frame with type=chrome.
When running in frame with type=content, the target will be the iframe element itself.
Stop relying on event.target so that the Sidebar can work in both cases

Differential Revision: https://phabricator.services.mozilla.com/D27677

--HG--
extra : moz-landing-system : lando
2019-04-18 09:05:53 +00:00
Julian Descottes
83f2aa351a Bug 1544749 - Animation inspector scrubber should use getTopWindow r=daisuke
Depends on D27672

Differential Revision: https://phabricator.services.mozilla.com/D27675

--HG--
extra : moz-landing-system : lando
2019-04-18 09:05:35 +00:00
Julian Descottes
bbcab0f303 Bug 1544749 - Add shared helper to retrieve the top window r=bgrins
Some classes in DevTools will not have an easy way to get access to the toolbox.
However they might still want to use the topmost chrome window.
Extract the logic from toolbox.js to a shared helper.

Differential Revision: https://phabricator.services.mozilla.com/D27672

--HG--
extra : moz-landing-system : lando
2019-04-18 09:06:32 +00:00
Christian Holler
a15a27b2f0 Bug 1544400 - Update fuzzing builds to Clang 8 and use gold. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D27701

--HG--
extra : moz-landing-system : lando
2019-04-18 08:28:29 +00:00
Alex Chronopoulos
1af9f39b96 Bug 1543350 - don't shut-down taskqueue early. r=jya,mjf
Shutting down the taskqueue early prevents the decoder's tasks to be queued.

A TaskQueue no longer requires to be explicitly shutdown it will shutdown when ref counter drops to zero.

Differential Revision: https://phabricator.services.mozilla.com/D26929

--HG--
extra : moz-landing-system : lando
2019-04-18 08:23:59 +00:00
Ehsan Akhgari
5a1d95baaa Bug 1545251 - Remove the code added in bug 1462432 since it's all dead code; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D27972

--HG--
extra : moz-landing-system : lando
2019-04-18 06:01:55 +00:00
Nika Layzell
d4f1348c4b Bug 1540733 - Create a new IPCBlobInputStreamChild actor when migrating, r=baku
Differential Revision: https://phabricator.services.mozilla.com/D27970

--HG--
extra : moz-landing-system : lando
2019-04-18 15:23:54 +00:00
Lee Salzman
e12dc53ba3 Bug 1544188 - check cleartype level for WR DWrite fonts. r=jfkthame
Differential Revision: https://phabricator.services.mozilla.com/D27563

--HG--
extra : moz-landing-system : lando
2019-04-18 15:58:22 +00:00
Mats Palmgren
fcba4dfac7 Bug 1500708 - [cssom][css-grid] 'grid-auto-flow: row dense' should serialize to 'dense' since 'row' is implied. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D28058

--HG--
extra : rebase_source : dd8109fa0853bc73e8859198196aa52b5523786a
2019-04-18 01:16:03 +02:00
Emilio Cobos Álvarez
baf580cdfa Bug 1545107 - Remove nsIDocumentObserver::DocumentStatesChanged. r=smaug
It's a bit useless, only has one implementation. Call into the shell directly
instead.

Differential Revision: https://phabricator.services.mozilla.com/D27910

--HG--
extra : moz-landing-system : lando
2019-04-17 19:29:59 +00:00
Daosheng Mu
4eb28fa005 Bug 1545180 - Correct DualShock 4 mapping type. r=qdot
Differential Revision: https://phabricator.services.mozilla.com/D27945

--HG--
extra : moz-landing-system : lando
2019-04-18 06:44:09 +00:00
Brian Birtles
173788f3ba Bug 1541767 - Drop animations on an element before removing it from the document; r=hiro
See the previous patch in this series for a detailed explanation of why this is
necessary.

The test included in this patch is from some work I am doing to rewrite the CSS
transitions web-platform-tests. As a result, it includes more than is strictly
related to this issue addressed by this bug. Without the code changes in this
patch the fourth test onwards, "Transitions are canceled when an element is
removed from the document", will timeout waiting for the transitioncancel event.

Differential Revision: https://phabricator.services.mozilla.com/D28022

--HG--
extra : moz-landing-system : lando
2019-04-18 06:56:40 +00:00
Brian Birtles
7a10d13a65 Bug 1541767 - Don't post animation restyles when unbinding an element; r=hiro
Currently we avoid posting animation restyles when unbinding an element by
removing the element from the document before deleting its animation
collections. As a result, when canceled animations go to post a restyle, they
can't find a pres context and give up posting a restyle.

However, this is problematic for two reasons:

* It means we can't remove such canceled animations from the
  PendingAnimationTracker if they are present there (i.e. it regresses the fix
  from bug 1223445).

* It means we can't post cancel events for such animations/transitions since we
  can't lookup the appropriate AnimationEventDispatcher.

In the next patch in this series we will change that order to fix the above
problems but before we do that, we need to introduce another mechanism to make
sure that we don't post restyles when unbinding an element or else we will
regress bug 1396041.

This patch does that by introducing a flag which causes us to not post restyles
when we are doing DOM surgery. For all other cases we actually _do_ need to post
restyles in order to update the style correctly.

Without this patch, layout/style/crashtests/1396041.html would fail after
applying the next patch in this series.

Differential Revision: https://phabricator.services.mozilla.com/D28021

--HG--
extra : moz-landing-system : lando
2019-04-18 06:49:25 +00:00
Brian Birtles
62cd9bbaa9 Bug 1541767 - Make Animation::Cancel line up with the spec a little better; r=hiro
Animation::Cancel calls UpdateTiming() which in turns runs the procedure to
update the finished state. However, the spec[1] doesn't require that.
Furthermore, calling UpdateTiming here hides the fact that we end up triggering
a restyle.

It would be better to move the parts of UpdateTiming we require into Cancel
itself so that we align better with the spec and to make it a bit more clear
what side-effects of UpdateTiming we actually rely on.

[1] https://drafts.csswg.org/web-animations-1/#cancel-an-animation

Differential Revision: https://phabricator.services.mozilla.com/D28020

--HG--
extra : moz-landing-system : lando
2019-04-18 06:25:54 +00:00
Brian Birtles
d877551208 Bug 1541767 - Drop Animation::CancelNoUpdate; r=hiro
CancelNoUpdate actually can and does trigger restyles via its call to
KeyframeEffect::NotifyAnimationTimingUpdated so at very least its name is wrong.

Furthermore, we actually want canceling to trigger restyles in most cases since
when an animation is canceled we need to trigger a subsequent restyle to apply
the (no-longer-animated) result.

This wasn't necessary when CancelNoUpdate was first introduced but since then we
have introduced the Servo style engine where we use a separate traversal to
apply the result from creating/deleting/modifying animations.

This change will mean that we now trigger a "layer" restyle when canceling an
animation when we previously didn't. That, however, seems more correct if
anything.

This patch also makes CancelFromStyle no longer virtual since it doesn't seem
necessary anymore (perhaps because we now point to the concrete type:
CSSAnimation/CSSTransition from nsAnimationManager/nsTransitionManager whereas
previously we didn't).

Differential Revision: https://phabricator.services.mozilla.com/D28019

--HG--
extra : moz-landing-system : lando
2019-04-18 06:24:52 +00:00
Henrik Skupin
dafcfb1456 Bug 1544707 - [raptor] Use format strings instead of concatenating log messages. r=rwood
Depends on D27812

Differential Revision: https://phabricator.services.mozilla.com/D27813

--HG--
extra : moz-landing-system : lando
2019-04-18 06:42:00 +00:00
Henrik Skupin
647820f87f Bug 1544707 - [raptor] Move most of if/elif blocks for testType to switch statements. r=rwood
Differential Revision: https://phabricator.services.mozilla.com/D27812

--HG--
extra : moz-landing-system : lando
2019-04-18 06:41:42 +00:00
Ionut Goldan
b60a50e336 Bug 1544742 - Enable chrome CLI app argument r=rwood
Differential Revision: https://phabricator.services.mozilla.com/D27909

--HG--
extra : moz-landing-system : lando
2019-04-18 05:42:09 +00:00
Dan Glastonbury
ea351adb8a Bug 1526972 - P8: Reset InInvalidSubtree when processing unrelated frames. r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D26141

--HG--
extra : moz-landing-system : lando
2019-04-18 02:41:33 +00:00