These workarounds were due to an issue where the sidebar documents weren't having
the LightweightThemeChild instantiated for them on the `pageshow` event. This was
fixed by bug 1596852 about a year ago, so we can remove these workarounds now.
Differential Revision: https://phabricator.services.mozilla.com/D159622
This adds a Nimbus variable corresponding to `browser.urlbar.merino.providers`.
I noticed that when we added a Nimbus variable for client variants (bug
1743685), we didn't actually use it in the provider. Instead we use its fallback
pref. I fixed that too.
Differential Revision: https://phabricator.services.mozilla.com/D159557
imgDimension comes directly from the size of the frame, which has overflowed into the negatives. The code wants value to be positive but hasn't considered that imgDimension can be negative.
Differential Revision: https://phabricator.services.mozilla.com/D159138
While we're here, make the setup more consistent across host/target
c/c++, and remove the C compiler warning flags from the C linker flags,
where they are irrelevant.
Differential Revision: https://phabricator.services.mozilla.com/D159358
This fixes ESLint issues raised by mozilla/valid-services-properties.
This also changes follow-on issues to use Services.appinfo rather than getService.
Differential Revision: https://phabricator.services.mozilla.com/D159461
It looks like I got dropped in the import process or something,
so I added myself in. Emilio has also been added since this was
last updated.
I also fixed up some directories for the XPCOM and XPIDL modules,
deleting ones that no longer exist and adding new ones. A few
subdirectories like io/ still aren't covered but this at least
makes the situation better.
Differential Revision: https://phabricator.services.mozilla.com/D158804
It wanted to make this fix, so I figured I'd split it into a separate commit.
The new name nick is confusing, but I'm not sure how to override it.
Differential Revision: https://phabricator.services.mozilla.com/D158802
We now honor box-sizing (XUL layout never did), and this uses an HTML
element. We rely on it getting the exact height because we compensate it
with a negative margin, so this needs box-sizing: border-box.
Differential Revision: https://phabricator.services.mozilla.com/D159618
These are flex items and stretch anyways, so it should be useless.
I'm not convinced that the max-width is needed, could probably be
cleaned up.
Differential Revision: https://phabricator.services.mozilla.com/D159614
This improves the setup so that whenever there are only idle/deferred tasks, we can run low priority tasks immediately.
Manual testing shows that this way we get couple of more ticks every now and then.
Without this patch we'd rely on normal priority tasks, but since there might be multiple of those pending, ShouldGiveNonVsyncTasksMoreTime() would
return true.
So, low priority tasks are effectively "run when the queue is otherwise empty (but idle-type of tasks are still special)".
Differential Revision: https://phabricator.services.mozilla.com/D159583
There are (at least) two different cases leading to lower fps.
Motionmark seems to hit FinishedWaitingForTransaction() case rather often, but the testcase in the bug
hits the other case more often.
Differential Revision: https://phabricator.services.mozilla.com/D159260
I noticed that 'branch' is only used in Updatebot in the
Commit Alert task (we made it for Angle.) It doesn't do
anything anywhere else. So assert this in the validation checks
Differential Revision: https://phabricator.services.mozilla.com/D158047
If there is a vendoring section missing in the moz.yaml,
we will error out. Detect this right away and give a better error.
Perform some cleanup since we know we have a vendoring section.
Differential Revision: https://phabricator.services.mozilla.com/D158046
We'd like to provide NODE_CHILD_OF and NODE_PARENT_OF relations in the parent
process, relying on cached information, to avoid sync IPDL messages. This
revision implements most of the use cases for this relation for remote
accessibles, notably setting aside handling of MathML's <mroot> parent/child
relation. ARIA trees, treegrids, lists, and so on are handled in the remote
accessible largely identically to how they were handled in LocalAccessible.
Rather than define a new rule for walking the tree to find children, this
revision unifies the ItemIterator so it works on generic Accessibles, and uses
it in RemoteAccessibleBase the same way it's used in LocalAccessible. The
special case carve-out for MSAA clients now exists as a simpler IsTopLevel
check in DocAccessibleParent.
Differential Revision: https://phabricator.services.mozilla.com/D159452
