Upon a content process crash or hang crash annotations were incrementally
written into the .extra file starting with the exception handler callback and
then in a number of different places before the file was ready for submission.
This had a number of downsides: since the annotations were directly added to
the file it was impossible to tell which ones were already written at a
certain point in time, additionally some were written twice or even thrice.
The code doing the writing would also behave differently depending on the
contents of the file, the parameters passed to it and the contents of global
variables.
This change overhauls the whole process by keeping the annotations into a
temporary per-crash annotation table which is filled with all the required
annotations before being written out in a single pass when they are ready.
The annotations are gathered from the main process annotation table, the
per-process one (held by the CrashReporterHost) and exception-time specific
ones.
The resulting annotations are slightly different than before the patch: first
of all there are no more duplicate entries in the .extra file and secondly all
content/plugin process hangs annotations are properly filtered, before
annotations that were main process-only would leak into them.
Differential Revision: https://phabricator.services.mozilla.com/D31069
--HG--
extra : moz-landing-system : lando
This removes the XRE_TakeMinidumpForChild() which does not need to be
exposed anymore in the XUL API as well as
IToplevelProtocol::TakeMinidump() which was simply unused.
Differential Revision: https://phabricator.services.mozilla.com/D31062
--HG--
extra : moz-landing-system : lando
This patch sets the screen brightness on the reference Moto G5 and Pixel 2 phones to 50% before starting power tests and resets it to its original value once the test is complete.
Differential Revision: https://phabricator.services.mozilla.com/D31662
--HG--
extra : moz-landing-system : lando
- Put every color in a variable name.
- Add `label:hover` so that the radio input provides visual feedback upon hover.
- Implement "pressed" (`[type="radio"]:active`) and `:focus{border:0}`
to match Photon's design guidelines at
https://design.firefox.com/photon/components/radio-buttons.html
- Implement dark theme for radio inputs (using creative freedom as there
is no Photon guideline for this).
Differential Revision: https://phabricator.services.mozilla.com/D31510
--HG--
extra : moz-landing-system : lando
- Update info.svg to adjust color based on the fill color.
- Use button colors as defined by Photon (without this, the background
of the non-generic buttons are almost indistinguishable when dark
themes are enabled).
- Small refactor of message-bar.css to put all type-specific
declarations in one location.
Differential Revision: https://phabricator.services.mozilla.com/D31509
--HG--
extra : moz-landing-system : lando
Most colors have been replaced with a variable that has the same color
value.
The exception is the border color at the add-on details.
`--grey-90-a20` was replaced with `--in-content-box-border-color`,
whose value is `--grey-90-a30`. This is close enough.
Differential Revision: https://phabricator.services.mozilla.com/D31508
--HG--
extra : moz-landing-system : lando
we're looking to reduce costs on infra. as parallel gcp builds have served their purpose of demonstrating they are possible and valid, we'd now like to disable them until a later date.
Differential Revision: https://phabricator.services.mozilla.com/D31655
--HG--
extra : moz-landing-system : lando
The variable --theme-toolbar-icon-color is not defined in devtools. Let's use --theme-toolbar-color
Differential Revision: https://phabricator.services.mozilla.com/D31493
--HG--
extra : moz-landing-system : lando
A Proguard update in Bug 1550596 optimized away the WebAuthn methods, but
there's a convenient ReflectionTarget defined to say 'hey, don't do that.'
Differential Revision: https://phabricator.services.mozilla.com/D31693
--HG--
extra : moz-landing-system : lando
In bug 1527182 we made it so that APZ can directly drag-scroll scrollframes
that are inside SVG effects, because that's possible with WR on the compositor.
However the code changed in that bug was meant to be kept in sync with
a second piece of code. The second piece of code controls the generation
of ScrollInfo items for scrollframes inside SVG effects - since we can
APZ-scroll them with WR, we don't need the scrollinfo item anymore.
Producing the scrollinfo item was changing the structure of the APZ tree
in terms of where the transform ended up, and was causing badness with
untransforming the drag mouse events.
This patch adds a test that covers the scenario and also corrects the defect
by bringing the two bits of code back in sync.
Differential Revision: https://phabricator.services.mozilla.com/D31647
--HG--
extra : moz-landing-system : lando
Per https://bugzilla.mozilla.org/show_bug.cgi?id=1550625#c5 there is no
mechanism available for FIDO U2F JS API operations on Android. The exposed API
is FIDO2/WebAuthn-only. As such, Firefox cannot support FIDO U2F JS API
operations on Android, and we should disable the u2f preference so that
window.u2f is not set inappropriately.
Differential Revision: https://phabricator.services.mozilla.com/D31695
--HG--
extra : moz-landing-system : lando
To not collide with the built-in "filter" method, the local
filter module should be named as filters.
Differential Revision: https://phabricator.services.mozilla.com/D30532
--HG--
rename : testing/raptor/raptor/filter.py => testing/raptor/raptor/filters.py
extra : moz-landing-system : lando
`mach run` as it is doesn't really parallel `mach run` on Desktop;
this makes it a little closer more fully featured. The underlying
functionality is all there in layers of mozharness; let's make it
easier to get to.
Differential Revision: https://phabricator.services.mozilla.com/D18292
--HG--
extra : moz-landing-system : lando
This just separates out the Android definitions into
mobile/android/mach_commands.py. There was vestigial support for
running on Android with debuggers, but it was for wiring up JimDB,
which is no longer supported and in fact hasn't worked on actual
devices for a very long time. (The new flow for running on Android
under a debugger goes through the Android Studio hybrid debugger.)
Differential Revision: https://phabricator.services.mozilla.com/D18291
--HG--
extra : moz-landing-system : lando
We want `mach run` for Android to be wildly different than `mach run`
for Desktop. But right now, mach really doesn't support two different
implementations of the same underlying named command. The avenues
that might support different implementations, mostly run through
`conditions`.
`conditions` were added to mach commands in Bug 901972, and never
really anticipated this use case: commands are keyed by name condition
evaluation is delayed until dispatch-time. In order to have different
commands with the same name, and have full support for `--help`,
command matching, suggestions, etc, we really need conditions to
evaluate at parse-time. Indeed, since Bug 901972 landed, we've moved
context creation earlier in the dispatch flow and hacked in things
that look like parse-time conditions (see Bug 1291335 and Bug
1305695).
This approach is not the prettiest, but it handles this narrow
use-case -- making `mach run` and `mach install` different on Android
-- without much code churn.
Differential Revision: https://phabricator.services.mozilla.com/D18290
--HG--
extra : moz-landing-system : lando
Even if we do nothing, we need to know if the value actually changed to see if
we need to propagate it to descendants that explicitly inherit it.
Differential Revision: https://phabricator.services.mozilla.com//D31569
Depends on D31568
It was missing the cases where you changed values, but not count, and the image
was not visible, like:
mask-image: none;
mask-mode: match-source, match-source;
Then change mask-mode to `match-source, alpha`, for example.
Differential Revision: https://phabricator.services.mozilla.com//D31568
