Commit Graph

1914 Commits

Author SHA1 Message Date
Edward Lee
2b876799fc Bug 535670 - Poor UX on password change while connected
Detect if there was a login failure when opening the prefs and re-use the first-sign-in flow and feedback instead of using the change pwd/pph dialog.
2009-12-18 16:22:59 -08:00
Edward Lee
5e3b42f790 Bug 535722 - Reduce the amount of logging for default log levels
Include the URI on success/fail requests and only trace log the onStartRequest. Switch various debug messages to trace and remove importing Log4Moz in fx-weave-overlay and generic-change. Drop the rootLogger to Debug to not log trace messages from unpreffed loggers.
2009-12-17 18:51:55 -08:00
Edward Lee
6d5a688ec4 Bug 534459 - Can't reset password
Update the preference to point to the new password reset page on auth.smc, and for now, just open it per mconnor's suggestion.
2009-12-17 18:40:29 -08:00
Edward Lee
b1e4f67913 Bug 535479 - Be smarter in getting rid of the "remote tabs" notification
Add a tri-state pref that is unset, 0, or a number (modified time in seconds) and don't show the notification if it's in the "0" state. Unset pref means no modified time has been saved, and a non-0 state is the modified time of the last synced tab. So when tabs arrive with a different modified time, switch to the 0 state. Additionally, still remember if the user ever dismissed the notification and never show it again.
2009-12-17 12:20:07 -08:00
Mike Connor
167598baff bug 535562 - fix typo failure 2009-12-17 10:34:36 -05:00
Edward Lee
645d705058 Bug 535477 - Always sync tabs but inform Fennec users that recent tabs need syncing
Remove special casing of tabs prefs and remove tabs.backup to simplify the UI logic. Also remove dynamically enabling/disabling based on number of clients. For Fennec, show a notification about recent tabs need syncing.
2009-12-16 19:15:18 -08:00
Edward Lee
dcc74fa6ed Bug 535476 - Ping the server once a day to help count active daily clients
Fetch info/collections? with an extra "?" once a day on a normal sync so that it gets the same data but is easily differentiated in access logs.
2009-12-16 19:08:36 -08:00
Edward Lee
00057a427d Add pref for prefs logger and remove lightweight persisted prefs as those will be generated. 2009-12-15 14:51:16 -08:00
Edward Lee
1b845a7667 Bug 532175 - Send event when Weave is ready to register new engines
Notify with "weave:service:ready" so observers can lazily load and wait to add engines, Weave UI.
2009-12-15 14:21:13 -08:00
Edward Lee
1c4d7a2adc Bug 534923 - Only show Mobile Bookmarks if there are mobile bookmarks
Fix up existing users as well as only creating the place query under AllBookmarks if there are mobile bookmarks.
2009-12-15 14:21:13 -08:00
Edward Lee
30a5a5e095 Bug 534944 - Avoid loading/importing weave files until necessary to speed up fennec startup
Have importing service.js trigger startup instead of only starting up from Weave.js, which now is used as a backup kickstarter. Only call import(service.js) when necessary from various Fennec files.
2009-12-15 14:21:12 -08:00
Edward Lee
61a7c45b44 Bug 534687 - Weave's pref syncing can sync lightweight themes in a broken fashion
Trigger lightweight theme manager's currentTheme setter when changing the usedThemes pref.
2009-12-14 16:05:07 -08:00
Edward Lee
28cf762fdd Remove engines from failing load tests now that engines are gone. 2009-12-11 11:32:23 -08:00
Edward Lee
d23f46c4f3 Have wipeRemote wipe just the engines' data and make sure the clients process the command. 2009-12-10 18:39:51 -08:00
Edward Lee
45a9a59575 Bug 533475 - Improve language for Fennec tab sync page
Detect if tabs sync is pending or if tabs are all open or there's no tab data to show the appropriate message.
2009-12-10 18:37:30 -08:00
Edward Lee
e36bc83bfd Bug 532936 - Add root level node for bookmarks synced from Fennec
Create a mobile root in Firefox and link it to the Library UI as a query that fixes its own title if changed. Mark the mobile root on Firefox/Fennec as special so Weave uses "mobile" for the guid in the record, and items will appear in the appropriate folder.

--HG--
extra : rebase_source : fbd3afa2647204a370f7dacdf9d824e462ebb9b9
2009-12-10 16:12:14 -08:00
Mike Connor
120a548fe6 bug 533759 - delay real startup for 10 seconds on Fennec to get away from startup 2009-12-10 12:20:16 -08:00
Mike Connor
f0479802e6 bug 533573 - use aria attributes to make the radiobuttons accessible 2009-12-09 15:23:48 -08:00
Mike Connor
db2453cfd1 bug 526078 - add accesskeys throughout the prefpane and wizard 2009-12-08 17:51:00 -08:00
Mike Connor
8df647353a Bug 533580 - strip busted tbird support 2009-12-08 16:09:26 -08:00
Edward Lee
a27daaaec5 Bug 532770 - Allow tab sync's filtered urls to be set by pref
Expose engine.tabs.filteredUrls as a string to be used as regex and filter case insensitively.
2009-12-03 14:54:23 -08:00
Mike Connor
6302f7e50b bug 526078 - fix up some wording
--HG--
extra : rebase_source : dc6c4ee2acdbcff567dd185cb528636dbcc1702c
2009-12-03 17:24:41 -05:00
Mike Connor
06f700a2ff bug 530824 - close window and start syncing much sooner when setting up second machine
--HG--
extra : rebase_source : 10919d9957e323e0f12f5ca1b67e5fe9f8294288
2009-12-03 15:03:39 -05:00
Edward Lee
290955570d Bug 532722 - Use AddonOptionsLoad event to update Weave options
Make the weave add-on guid available as a constant and watch for AddonOptionsLoad with the matching addonID.
2009-12-03 12:14:56 -08:00
Mike Connor
52e6e79810 bug 530813 - better explanation of Sync and some iterations on bug 530824, just close the prefwindow on wizard finish
--HG--
extra : rebase_source : b9385c93b85f7707c839a4978102d243616ec27e
2009-12-03 01:52:17 -05:00
Edward Lee
a69a15740c Bug 488922 - Treat bookmarks restore specially
Add observers for bookmarks-restore-* and ignore changes during import and trigger a fresh start on success.
2009-12-02 19:20:44 -08:00
Edward Lee
1e7437ce9f Bug 532449 - Tabs don't sync until 4 syncs have happened
Always update the lastModified time to avoid tabs only sometimes getting updated.
2009-12-02 19:03:27 -08:00
Edward Lee
4eea405002 Bug 532570 - "keyring doesn't contain a key" when signing-in with a differently-cased username
Make sure username is always lowercase so that pubkey uri, storage uri, etc. are all the same no matter how the user logged in. Server needs to be wiped to make sure existing keys with other casing are removed.
2009-12-02 18:25:18 -08:00
Edward Lee
a938b1938a Bug 531005 - Sync is not working after update IWeaveCrypto.unwrapSymmetricKey NS_ERROR_FAILURE
Avoid concurrent key generation by updating meta/global immediately after resetting the client and have wipeServer not delete the meta collection. Also on detecting a syncid mismatch, sleep to allow remote keypair to be uploaded, and don't force a mismatch on upgrade.
2009-12-02 17:57:13 -08:00
Edward Lee
13dc29cda6 Bug 531005 - Sync is not working after update IWeaveCrypto.unwrapSymmetricKey NS_ERROR_FAILURE
Check that the cryptometa is unwrappable when syncing; if not purge the key and data and make a new crypto record.
2009-12-02 17:25:14 -08:00
Edward Lee
eab5c8f980 Bug 532173 - Don't sync tabs of some pages (weave firstrun, about:blank)
Ignore certain filtered urls when creating a list of tabs for remote machines.
2009-12-02 14:46:02 -08:00
Edward Lee
0a30c91bc0 Bug 530717 - sync after wipe local should always replace local values with remote
Always take the incoming item after a wipe and otherwise do the normal reconcile.
2009-12-02 14:44:52 -08:00
Edward Lee
34ad9876ab Bug 531239 - clear out duplicate/old machines from Clients record
Get rid of persistent storage for clients and tabs to always fetch fresh records.
2009-12-02 14:44:17 -08:00
Mike Connor
9c63572250 bug 530820 - add confirmation, error feedback, and attempt to provide some clarity that the user can't recover pp 2009-12-02 11:30:16 -05:00
Mike Connor
2cbefa0263 bug 531205 - show bookmarks/history/passwords for local and remote devices for remote when wiping 2009-12-01 15:39:43 -05:00
Igor Velkov
baa1783b76 Bug 526521 - Can't open preferences in SeaMonkey 2.0.1pre. r=Mardak
Reorganize fx-prefs to overlay itself so seamonkey can reference the same id and add Tabs sync.
2009-12-01 11:49:23 -08:00
Edward Lee
a30c30b7be Share tab-gathering code for both createRecord and locallyOpenTabMatches. 2009-12-01 11:36:56 -08:00
Edward Lee
9bd57f2170 Provide a fake service for platforms that don't have the service like Private Browsing (for Fennec/Seamonkey). 2009-11-30 14:36:03 -08:00
Edward Lee
4e72f0165b Bug 531943 - Sync scheduled by global threshold during private browsing
Use checkSyncStatus instead of directly calling syncOnIdle or scheduleNextSync so that we only schedule if we're okay to sync.
2009-11-30 14:03:59 -08:00
Edward Lee
6baeee3ae5 Bug 530863 - Global threshold update causes multiple syncs to fire
Make sure we only add one idle observer by keeping a flag.
2009-11-30 13:35:20 -08:00
Edward Lee
c27c49821c Bug 530823 - Engines need to be able to specify a prefName for sharing prefs (different history types)
Use prefName for checking if an engine is enabled and have forms share a prefName with history.
2009-11-30 12:15:18 -08:00
Edward Lee
c3f5e5f0a5 Remove unused SnapshotStore. (Bug 524916) 2009-11-25 17:59:26 -08:00
Edward Lee
54ac58d5e4 Remove unused prefs and imports. (Bug 524916)
--HG--
extra : rebase_source : 074e542f63ee840b61db7fe63a6c3540c13a31a5
2009-11-25 17:49:15 -08:00
Mike Connor
3244ad9b4b archive local bookmarks before wiping
--HG--
extra : rebase_source : dd54af2118cf60c9e4f4b3bf08b7a5c61e9e78b8
2009-11-25 17:09:32 -08:00
Mike Connor
c80471a7c9 bug 530832 - make Merge more prominent, and clearly the recommended choice, with crisper wording
--HG--
extra : rebase_source : 68fdf9035bf3354a99c93b5050eb4af58c54a072
2009-11-25 17:08:51 -08:00
Edward Lee
5b2d0e0fe2 Bug 530904 - tabs list style doesn't match fennec lists
Make headers larger, adjust text margins, add nokia sans font family.
2009-11-25 16:59:02 -08:00
Edward Lee
5c62d9223e Bug 530926 - remove "Weave /" from tab list page title 2009-11-25 15:25:55 -08:00
Edward Lee
12959d684f Bug 531177 - Tabs don't sync from firefox (when there's lots of tabs)
Simplify tab record to just use deferGetSet like the other records and sort tabs based on their last usage to pick out a subset.
2009-11-25 15:22:45 -08:00
Edward Lee
3e0ad22034 Bug 531171 - Tabs don't always update
Only expose that the tab engine knows about the current client's tabs, so always create/apply incoming and only create records tabs for local.
2009-11-25 15:17:39 -08:00
Edward Lee
84acd63006 Bug 531170 - Tabs don't sync from fennec
Add listeners for Fennec tab events the same way we do it for Firefox and share listener logic for various event types.

--HG--
extra : rebase_source : 685e45c16052db3d285c25c68db47680b7d15f72
2009-11-25 15:14:56 -08:00
Mike Connor
cb27e2d2e6 bug 530822 - make label more explicit, simplify branding
--HG--
extra : rebase_source : 9a6950423fa7999db0640562471cf41a60b3fd44
2009-11-24 18:55:59 -08:00
Mike Connor
726983dc3e bug 528483 - fix prefpane to use the backup pref when numClients = 1
--HG--
extra : rebase_source : ae74e04326f09cf8237dc7c82fe10ae7c4aa10ac
2009-11-24 17:54:06 -08:00
Mike Connor
22e557f25d bug 527517 - replace Connected As with Current User to remove ambiguity
--HG--
extra : rebase_source : 0c5f37c23490120048d8e7cc408667b00ab644a9
2009-11-24 16:02:56 -08:00
Mike Connor
4fdb8d9ec2 bug 527504 - overlay macBrowserOverlay so menu works on all windows that include
--HG--
extra : rebase_source : 1c95c891e89557f87539a66b678e3b54d659ce39
2009-11-24 15:50:51 -08:00
Edward Lee
57b5d69aee Bug 524916 - remove any/all code/images/strings that we aren't using anymore
Remove unused sync engines (cookies, extensions, input, microformats, plugins, themes).
2009-11-24 16:02:55 -08:00
Edward Lee
045f38742c Bug 515593 - audit set of prefs we're syncing
Add in prefs that are linked to the Firefox Preferences UI.
2009-11-24 14:53:59 -08:00
Edward Lee
c0765fefde Remove trailing whitespace from the codebase. 2009-11-20 14:34:20 -08:00
Edward Lee
691f609c50 Bug 527790 - Allow client names to be different from the default "Firefox"
Generate a client name based on the logged in username, appname, hostname, and profile name.
2009-11-19 23:31:04 -08:00
Edward Lee
b651389cb4 Bug 514545 - weave mangles bookmarks
For both folders and separators, use the parent name (not guid) in addition to the item's title/position to determine if it's a dupe. This modifies the bookmark format for folders and separators, so a storage version bump is needed.
2009-11-19 21:34:17 -08:00
Edward Lee
08ada66f52 Bug 528543 - Set default extensions.weave.client.name so it shows up in about:config
Just default to "Firefox" as both desktop and mobile are branded "Firefox".
2009-11-19 15:34:29 -08:00
Edward Lee
9a28b847cf Bug 527786 - Help users recover/remember the secret phrase
Show some help text if the passphrase is incorrect as well as showing the reset secret link on failure.
2009-11-19 13:59:11 -08:00
Edward Lee
edcdfdd645 Bug 516098 - Weave sync fails without any obvious reason, when I've upgraded one machine but not another
Detect if sync failed because it's out of date and show a warning notification with a button to open the add-on manager's extension view.
2009-11-18 16:59:34 -08:00
Edward Lee
3af727a5c5 Bug 528539 - Start over should warn about incorrect username/password before prompting for secret phrase
Show Connecting... when signin in on page 0 and Verifying... when checking the passphrase on page 1.
2009-11-18 14:42:13 -08:00
Edward Lee
3dd26a8fad Bug 507666 - Handle deleting places history
Use onBeforeDeleteURI to get the page's GUID and upload the delete record and process it by removing the page.
2009-11-18 11:47:25 -08:00
Edward Lee
cb8c34b644 Bug 529103 - Removing folders must use removeItem not removeFolder
Switch to Svc.Bookmark.removeItem from this._bms.removeFolder.
2009-11-18 10:24:09 -08:00
Edward Lee
316e01f125 Add missing fennec-tabs.dtd for bug 529104. 2009-11-18 10:21:20 -08:00
Edward Lee
1c3164596f Bug 525786 - Weave's log has a record of private browsing start/stop times
Switch some messages like private browsing, network change to trace and make the default service.main level Debug instead of Trace.
2009-11-16 17:11:10 -08:00
Mike Connor
19ec65c7e2 bug 528541 - enforce length and uniqueness, tweak description to be clearer/less wordy 2009-11-14 13:40:39 -05:00
Anant Narayanan
b0c0d87351 Sync Personas by defaul for Firefox 3.6 (bug #527729) 2009-11-13 18:00:42 +01:00
Edward Lee
4290447cc4 Comment out some trace logging in service.main for now (they always appear). 2009-11-12 19:25:43 -08:00
Edward Lee
3d4ed28c1b Bug 528356 - Bump storageAPI version to 1.0 2009-11-12 16:35:56 -08:00
Edward Lee
21aa4351a8 Bug 526942 - Try to sync tabs when viewing remote tabs
Try fetching tabs when loading the remote tabs view and if the sync got new tabs, reload the page.
2009-11-12 15:18:43 -08:00
Edward Lee
9a15bcc16b Bug 528343 - Tabs don't sync
Set the current client on any tab change for tracker.changedIDs and reset that when sync finishes.

--HG--
extra : rebase_source : 3100141bc1fdfaaa959b5f990a9538527761aace
2009-11-12 14:48:54 -08:00
Edward Lee
00cc35abdf Bug 527767 - Sync more history items on first sync
Syncing 1000 items should be good enough for anybody......
2009-11-12 13:51:28 -08:00
Edward Lee
ca8fe4c267 Bug 528090 - When logging out, stay disconnected until told to connect
Toggle the autoconnect pref on login/logout.
2009-11-12 13:49:41 -08:00
Mike Connor
f5e44f9c62 bug 527773 - warn noscript users when trying to use setup wizard 2009-11-12 16:16:19 -05:00
Mike Connor
cefffb249b Backed out changeset 23d90c46b89c 2009-11-12 15:44:33 -05:00
Edward Lee
3be71460fc Bug 528278 - Remove remote commands and wait for user on wipeRemote/changePassphrase
Store the reason for starting fresh (new syncId) in meta/global and fail remoteSetup on certain reasons to let the UI show a notification to the user for a response (pick merge or change passphrase). Code paths (sync, prep, etc.) related to remote commands are removed.
2009-11-12 11:54:21 -08:00
Mike Connor
9c4d31f028 Bug 528239 - hook up reset passphrase dialog 2009-11-12 13:42:56 -05:00
Mike Connor
7df553e494 bug 526569 - add explicit choice to setup flow for additional computers
--HG--
extra : rebase_source : 45e0af54dc4b059368e14fcf241fe4ab3250b151
2009-11-12 13:11:54 -05:00
Edward Lee
d2abea3b69 Remove unwanted info logging for bookmark indices. 2009-11-11 15:20:19 -08:00
Edward Lee
e11e6a2c55 Reset the score when calculating the global score. 2009-11-11 15:19:00 -08:00
Edward Lee
9e1ef1c8af Bug 527766 - Sync history pages with a single visit
Backout bug 518972 (6954c93b8903) so now we push all data instead of pages with more than 1 visit.
2009-11-10 15:52:40 -08:00
Edward Lee
48fddbe721 Bug 527775 - Allow customizable api version on the client
Add a new pref storageAPI (currently 0.5) that gets used for storage urls.

--HG--
extra : rebase_source : 74ca13de918d4211cbdcf708c30cc03d876fec7d
2009-11-10 15:24:31 -08:00
Mike Connor
8b18c0ef54 bug 518075 - fix copy/paste fail 2009-11-09 16:30:37 -05:00
Mike Connor
91e32684b5 bug 526940 - go back to SSL, now that it's not broken
--HG--
extra : rebase_source : e05b1dffadbb8d67d48488569d711a983609107c
2009-11-09 15:57:48 -05:00
Edward Lee
3f43f527e1 Bug 527379 - Passphrase gets synced back to previous value
Persist the new passphrase in the login manager to have it sync the modify (delete+add).

--HG--
extra : rebase_source : 940c8362aa3900615a06b73e34815acd6365e086
2009-11-09 12:56:14 -08:00
Mike Connor
be46d4fd98 bug 518075 - fix timer usage, reset engine score once added to globalScore 2009-11-09 14:33:53 -05:00
Mike Connor
516a5f8953 bug 518075 - tweak original patch and item values 2009-11-09 12:57:58 -05:00
Mike Connor
31cfd43156 bug 526765 - fix places we aren't localized properly 2009-11-07 18:27:31 -05:00
Guillermo López
ab0bdb2466 Bug 515809 - Use of three dots (...) instead of ellipsis (…) on Weave filess. r=Mardak 2009-11-04 17:45:22 -08:00
Edward Lee
43a1a96614 Bug 526661 - Use Firefox content to display the activity log
Just open the file as a tab to show the activity log. Remove related xul/js/strings. Saving can be done through normal Save Page As... No manual cleaning of the log, but the size is much smaller.
2009-11-04 17:01:49 -08:00
Edward Lee
509504e15f Missing let for declaring meta. 2009-11-04 16:27:35 -08:00
Edward Lee
b0552ee55b Bug 519139 - Weave freezes the browser for 5-10 secs when starting sync
Correctly remove the separator getter just like for folders to prevent triggering the lazy loader on every sync.
2009-11-04 16:07:05 -08:00
Edward Lee
4e4495a7a4 Bug 513438 - No easy way to enable / re-enable Weave
Assume Weave is always enabled (don't store it in a pref) and only disable if checks fail on startup.
2009-11-04 15:27:08 -08:00
Edward Lee
eb8a547f22 Avoid undefined property warnings by checking for null first instead of comparing. 2009-11-04 15:12:29 -08:00
Edward Lee
727e615361 Remove unused openStatus util call for status.xul. 2009-11-03 14:39:35 -08:00
Mike Connor
bb8fab54ae bug 526096 - add ToS link to wizard, fix some custom server and email validation stuff that popped up testing 2009-11-03 00:45:11 -05:00
Mike Connor
e57d84d4d6 bug 524916 - remove /xmpp from Sync, since we're not using it 2009-11-02 22:38:50 -05:00
Mike Connor
000df40447 bug 524916 - remove unused strings
--HG--
extra : rebase_source : 76779af95ada4c092bc8b68a6f744c59dcdedb3b
2009-11-02 21:36:04 -05:00
Edward Lee
e7b9bd8c7e Bug 524617 - give status updates during connection and sync
Show "Connecting…" after tapping connect and "in progress…" after tapping sync now.
2009-11-02 10:59:35 -08:00
Mike Connor
c803c9f499 bug 485108 - drop status dialog, show status including engines on statusbar, remove dead status bits 2009-10-28 03:42:35 -04:00
Mike Connor
ae0b04206e bug 522805 - better UI for private browsing mode, also fix 518035 by replacing Sign In/Out with Connect/Disconnect 2009-10-27 21:51:14 -04:00
Mike Connor
e757856e7c bug 524562 - add login feedback to prefpane 2009-10-27 20:36:43 -04:00
Mike Connor
261f7793c0 bug 520065 - partial sync fail should be an error, add better error string, and fix status object misuse so it actually works 2009-10-27 19:15:20 -04:00
Mike Connor
06a737b008 moar error checking, turn field validation back on in wizard, do better rewind/forward enabling
--HG--
extra : rebase_source : 473eccb2c879769b94011d6ae6b947a6e070fdaa
2009-10-23 03:05:41 -04:00
Edward Lee
ea2af3531c Bug 524052 - Remove about:weave
Remove files under content/about and content/ext (jQuery) and about:weave service.
2009-10-22 23:46:50 -07:00
Mike Connor
a74475172a merge backout 2009-10-23 01:11:07 -04:00
Mike Connor
d15a690d44 Backed out changeset 4e518b3ae5d2
overzealous pruning ftl ;)
2009-10-23 01:10:36 -04:00
Mike Connor
f681db6ada bug 521357 - handle login errors in the main prefpane better, still needs work after pre2
--HG--
extra : rebase_source : 442ea408d924e197982a0da4b2e87ea92f839ea0
2009-10-22 23:23:03 -04:00
Edward Lee
7de4d64b2c Remove onStartup call from fennec overlay now that we listen to final-ui-startup. 2009-10-22 17:03:51 -07:00
Edward Lee
c63aad855c Bug 483089 - Weave Preferences button in Add-ons manager should be enabled
Show the new pref pane (bug 521357) by having the options.xul file for Fennec (bug 523384) close iteself and open the real prefs window.
2009-10-22 16:15:34 -07:00
Edward Lee
d527ecbf58 Load a local firstrun page with instructions on what to do instead of about:weave. 2009-10-22 13:52:55 -07:00
Edward Lee
2fd35215ca Bug 523384 - Update Fennec UI for 0.8 release
Provide an optionsURL to show settings on Fennec and update the options on various events like sync, login, options loaded.
2009-10-22 13:51:50 -07:00
Mike Connor
0b7c499045 land new Firefox prefs/wizard 2009-10-22 15:31:45 -04:00
Edward Lee
169f0fabf9 Bug 520231 - strip identity from production track
Remove bits related to authenticator/auto-login and openid (munge and redirect).
2009-10-20 17:17:30 -07:00
Edward Lee
4f6c329f0a Remove unused TabsNotification for remote virtual tabs notification. 2009-10-19 17:06:50 -07:00
Edward Lee
57cd173e1d Remove unused change password/passphrase/generic dialog. 2009-10-19 16:37:25 -07:00
Edward Lee
998e703ef1 Remove unused pick-sync dialog (<==, <==>, ==>). 2009-10-19 16:24:32 -07:00
Edward Lee
2df003c9b1 Bug 517598 - Put useful interestingness/index values for bookmark
Use places to figure out the frecency of a bookmark and give items (not just bookmarks) a bonus if it's sitting in the toolbar.
2009-10-16 16:19:28 -07:00
Edward Lee
dbc6dadefc Bug 517598 - Put useful interestingness/index values for history
Additionally get the frecency for a history GUID/page when getting the url and title.
2009-10-16 16:18:53 -07:00
Edward Lee
cafcb53243 Ignore sortindex when comparing if records are different because it's only used for ordering of records. 2009-10-16 16:18:38 -07:00
Edward Lee
e84feadbdc Update predecessor test to additionally test unsorted bookmark predecessors. 2009-10-13 21:07:32 -07:00
Edward Lee
163c93866d Keep the unsorted bookmark folder unsorted and not worry about the ordering. 2009-10-13 16:27:10 -07:00
Edward Lee
83ba7d0855 Bug 522084 - Automatically sync much sooner if there's more data to fetch from the server
Have the syncInterval getter return with a lower interval for non-mobile clients while still enforcing backoff if it's bigger than the sync interval.
2009-10-13 11:56:46 -07:00
Edward Lee
7fcf4fdde6 Bug 522077 - Download a certain total number of items each sync instead of fixed "catch up"
Limit the initial the first fetch of new items by a total number of fetch and subtract the number of items processed. Use the difference to keep fetching more items from the backlog in chunks.
2009-10-13 11:20:28 -07:00
Edward Lee
3f44aa854b Split multiple id deletes into 100-id chunks instead of hitting max apache URI length. 2009-10-12 18:11:31 -07:00
Edward Lee
f56a03aa93 Bug 482906 - Gracefully handle wiping weave passwords if syncing doesn't restore them
After potentially wiping out all local passwords, save the Weave passwords to disk.
2009-10-12 16:45:40 -07:00
Edward Lee
53ada6a89f Bug 520215 - Only wipe if data is able to be restored from the server
For each engine, try decrypting a record from the server before wiping local data.
2009-10-12 16:22:54 -07:00
Edward Lee
39f90ad4f7 Simplify logic for Engines.getAll/Enabled and use Enabled for main sync loop. 2009-10-08 13:51:22 -07:00
Edward Lee
3485d4dcb1 Land external changes to Sync.js: setTimeout timer reference, checkAppReady comments/calls. 2009-10-08 11:45:51 -07:00
Edward Lee
8c92eee28a Bug 517492 - Sync will not complete, causing firefox not to quit successfully
Lazily listen for quit-application on the first sync-async call and bail out if the notification is sent while waiting for the callback.
2009-10-07 18:15:38 -07:00
Edward Lee
af5e61b913 Bug 519147 - "Sign In" is greyed out in Weave menu when Firefox starts, in Weave 0.7pre4
Switch back to STATUS_OK (from STATUS_DELAYED) when the delayed startup is actually called.
2009-10-07 10:47:55 -07:00
Edward Lee
3b609cc8bc Move the status record into a separate Status object exported with the Weave object. 2009-10-07 10:47:43 -07:00
Edward Lee
1578c6c3d2 Remove eval() workaround now that jit.chrome doesn't crash on latest 1.9.2 fennec (bug 517247). 2009-10-02 13:46:38 -07:00
Edward Lee
a2514cee67 Don't try logging out when already logged out -- about:weave calls logout which tries to _log, but Fennec weave hasn't loaded Weave yet. 2009-09-30 15:16:56 -07:00
Edward Lee
fbb222d35d Bug 518226 - Service should bubble up partial sync information
Set a flag on the status object to indicate partial sync after syncing an engine. For now, just show some text under the sync arrows to let the user know nothing needs to be done.
2009-09-30 14:46:59 -07:00
Mike Connor
9344db61c8 fix merge fail 2009-09-29 18:40:18 -07:00
Mike Connor
061821547d bug 518273 - need to handle not having an active node assigned, r=edilee
--HG--
extra : rebase_source : f86c6cc164241cee263345de5e13dd5ae0a3758b
2009-09-29 18:33:41 -07:00
Edward Lee
1468737a00 Remove unused threshold code that will be replaced soon with bug 518075. 2009-09-29 13:02:08 -07:00
Edward Lee
21a3b5a172 Don't wrap changePassword with _catch and persist the password on success. 2009-09-28 16:28:38 -07:00
Edward Lee
6416822a50 Don't unnecessarily throw from verifyLogin and remove its _catch wrapper.
--HG--
extra : rebase_source : ca74b47b96f4d1fbc1b8454d5b505a57b558e729
2009-09-28 16:13:42 -07:00
Mike Connor
56d0995726 bug 515593 - remove a bunch of stuff we shouldn't sync, will revisit potential additions for 0.8 2009-09-28 15:54:45 -07:00
Edward Lee
6bdcdd5e20 Bug 519262 - Forgot password doesn't work -> throbber keeps spinning
Just get the pref without slashifying with getURLPref.
2009-09-28 13:34:56 -07:00
Edward Lee
08eb7e1a48 Call eval() in Sync-async loop to work around crashes on 1.9.2 Fennec. 2009-09-25 20:53:46 -07:00
Edward Lee
86667667bd Default to mobile sync interval (5 min) for account creation and upgrade. 2009-09-25 20:47:38 -07:00
Edward Lee
9c2378f997 Don't unconditionally forceGC on processIncoming especially when there's nothing to process. 2009-09-25 18:39:24 -07:00
Edward Lee
e55480bf35 Sort the sync timing report to show certain functions first. 2009-09-25 18:38:47 -07:00
Edward Lee
14fe8aed33 Add some account creation error handling, but it's still pretty clunky with username detection and alerts for other stuff. 2009-09-25 18:19:30 -07:00
Edward Lee
bb2e492d25 Use the default or backoff intervals only after checking a previously scheduled sync and pick the bigger of the two. 2009-09-25 17:32:35 -07:00
Edward Lee
589b85a361 Run sync on idle on a separate event so that login can return and release the lock before trying to sync. 2009-09-25 17:28:48 -07:00
Edward Lee
0d568192bf Bug 518972 - Only upload history records that have more than one visit
Allow each engine to provide a custom Collection object and have History provide a collection that filters out certain data. This is inefficient because we have to first create then encrypt the record before we can filter it out.
2009-09-25 16:52:12 -07:00
Edward Lee
f8ce20a6b7 Bug 518958 - Only sync tabs if there has been tab activity
Check the score, which gets bumped up on tab open/close/select, to decide if tabs should be marked as changed.
2009-09-25 16:14:26 -07:00
Edward Lee
2b1018a27e Persist sync intervals because we only update it when changing the number of clients. 2009-09-25 15:41:27 -07:00
Edward Lee
450c304c35 Bug 514601 - Don't send DELETE for old history/form data on every sync
Don't send any deletes as the server will do the delete with bug 518945.
2009-09-25 15:30:26 -07:00
Edward Lee
45daba81ae Bug 517597 - waste fewer resources while a user only has one client active
Adjust how often Weave syncs based on the number of clients and only sync tabs if there are multiple clients.
2009-09-25 15:05:09 -07:00
Edward Lee
a1553a0ff7 Bug 518864 - Persist "next sync time" across events that disable sync
Save a nextSync value in a pref and use it to trigger a sync-on-idle if the "next sync time" already passed when logging in. Make sure to default to backoff time first, then next sync, then use the default.
2009-09-25 11:46:29 -07:00
Edward Lee
1f712aaa28 Wire up "custom" inputs to set/read and show/hide server url box. 2009-09-25 09:11:19 -07:00
Edward Lee
61ff7efb89 Bug 512809 - signup form uses colors for input validation feedback. r=Mardak
Add initial error reporting and "available" tagging. Also add "start over" functionality and change some custom settings display.
2009-09-25 09:09:05 -07:00
Edward Lee
0087e7aedb Bug 513944 - Weave should not load / do anything until it absolutely needs to
Weave already triggers on a late notification and puts itself on the event loop, so just additionally delay startup based on the number of open tabs (which will all be busy at startup).
2009-09-25 08:13:12 -07:00
Mike Connor
d6af22e0ca Land some initial statusbar UI bits of bug 513944 and remove unused/debug code. 2009-09-24 23:16:27 -07:00
Edward Lee
964e049c2e Add a simpler-to-use nsITimer wrapper, Utils.delay, that can use a named property of an object to additionally delay or clear the timer. Get rid of Utils.EventListener and simplify/fix up users. 2009-09-24 22:51:38 -07:00
Edward Lee
fc8b595236 Correctly cancel any sync triggers after starting a sync with a shared function that removes timers and idle observers. 2009-09-24 19:04:06 -07:00
Edward Lee
13ec4c4921 Bug 518146 - Generate shorter GUIDs than nsIUUIDGenerator
Randomly generate 10 characters from a pool of 70 possible characters for an equivalent 61.29-bit GUID which should have around 1% chance of collision (within a collection) after ~100 million records.
2009-09-24 15:54:47 -07:00
Edward Lee
442f5ac9d3 Bug 506268 - Session restore fails halfway through, leaves tabs unloaded
Load Weave off of the event that triggered sessionstore so that it and its callers can finish loading before autoconnect does network activity.
2009-09-24 14:31:05 -07:00
Edward Lee
6fa67802b5 Bug 518077 - Add custom settings for "sign in" to set things like server url
Provide an initial implementation to read and set preferences: autoconnect, serverURL. For now show them in a "Custom settings" expando tab like the one for create account, but the styling isn't great.

--HG--
extra : rebase_source : 3fc1e8bad7786cf06e2da8c95e7bca5f50fb6ec3
2009-09-22 01:00:43 -07:00
Dan Mills
68d9050e1c Bug 518069: forgot password UI / bug 518067: directional sync dialog during setup 2009-09-21 23:52:00 -07:00
Edward Lee
774b54a2a3 Don't update the cluster on each login unless verify login failed or there was no cluster set. 2009-09-21 18:03:56 -07:00
Edward Lee
3d76548184 Bug 518022 - Logging in with invalid username results in "Couldn't sign in: Network error"
Report 404 info/collections responses as "login rejected" if we're on the right cluster.
2009-09-21 17:34:19 -07:00
Edward Lee
736efc571f Bug 518018 - Default to serverURL instead of userAPI on 404 cluster check
Rework server/user/misc prefs to allow relative paths and full urls for generating API paths. Cache string properties of generated URLs under the storageAPI instead of using dynamic getters.
2009-09-21 17:13:41 -07:00
Dan Mills
af7b9b3aa9 implement forgot password/passphrase dialogs 2009-09-20 19:26:01 -07:00
Edward Lee
6be4412a84 Keep track of previously opened windows of pages that should only have one instance open and close the old one if it's still open. 2009-09-18 00:15:37 -07:00
Edward Lee
fcb7e6d648 Land about-weave on weave. Bug 516350 - about:weave round 3 followup fixes. r=thunder 2009-09-17 14:51:00 -07:00
Edward Lee
b21c9b6300 Use trace logging for reporting GUIDs. 2009-09-17 14:41:24 -07:00
Edward Lee
56b977bd62 Merge weave to about-weave. 2009-09-16 19:16:48 -07:00
Edward Lee
dea85e923c Remove meta serialization now that resource takes objects. 2009-09-16 19:15:55 -07:00
Edward Lee
1e9df514ed Remove trailing period for passphrase error code. 2009-09-16 19:15:46 -07:00
Edward Lee
4d0bbd635e Use the lazyStrings object for error strings to avoid using the wrong file (locales vs locale). 2009-09-16 16:52:43 -07:00
Edward Lee
b9bbbc007b Resolve conflicts by taking the already-fixed about.js and locally-fixed constants.js.in. 2009-09-16 13:56:37 -07:00
Edward Lee
dddc3943ed Merge mconnor's about-weave branch to weave-about-weave with conflicts. 2009-09-16 13:53:15 -07:00
Edward Lee
252df77258 Resolve constants.js.in conflicts by switching to the new format. 2009-09-16 13:45:08 -07:00
Edward Lee
5a62191729 Merge weave to weave-about-weave with conflicts. 2009-09-16 13:39:51 -07:00
Dan Mills
145df5ff00 Bug 516350 - about:weave round 3 initial landing 2009-09-16 13:36:11 -07:00
Edward Lee
ff2da1acb5 Get rid of the ugly EXPORTED_SYMBOLS array of strings for constants and generate it from a constants hash that sets the value and provides the exported name. Remove some unused constants and line-up the values at 40th column. 2009-09-15 19:07:23 -07:00
Mike Connor
2c44bfad8d fix minor merge kvetch 2009-09-15 21:57:06 -04:00
Dan Mills
2625b8a1fb initial patch
--HG--
extra : rebase_source : 250c8f0d85483300147a6f0d691e0214db6d837b
2009-09-15 21:54:05 -04:00
Mike Connor
cc109400c6 bug 511549 - make detailedStatus much smarter about errors and backoff, r=edilee
--HG--
extra : rebase_source : 42e3eb9c89d2567d18c02e7583202e284dd69b0e
2009-09-15 21:38:52 -04:00
Mike Connor
2aea4ab80a missing file fail from bug 512393 2009-09-15 17:18:00 -04:00
Edward Lee
0677c647e1 Bug 516096 - Nothing loads; about:weave has empty boxes/buttons; can't log in or sync
Work around bug 514803 by not calling toLocaleString() and generate a date string manually.
2009-09-11 17:14:45 -07:00
Edward Lee
3dfa70a1a9 Merge weave-partial-view to weave. Bug 507429 - Partial sync download support. r=thunder 2009-09-11 16:48:58 -07:00
Edward Lee
a8046d8b8e Address review comments nits. r=thunder 2009-09-11 16:44:26 -07:00
Edward Lee
345151e76f Chop off the end of long URIs for debug output onStartRequest. 2009-09-11 14:52:27 -07:00
Edward Lee
3729a2df9c Be less chatty when showing GUIDs and ignore cases. 2009-09-11 14:39:48 -07:00
Edward Lee
8973822877 Fix exception name. 2009-09-11 13:10:19 -07:00
Edward Lee
a1a35caae8 Add some comments to partial download code and remove other comments. 2009-09-11 08:24:42 -07:00
Edward Lee
1a4b100a73 Merge weave to weave-partial-view. 2009-09-10 23:18:33 -07:00
Edward Lee
439d963fbf Bug 507429 - Partial sync download support
Only fetch a limited number of items on first/update syncs and if we get the same number, ask the server for the ids to fetch later. Also on every download, process some of the backlog and save the list of GUIDs to disk as json for cross-session support.
2009-09-10 23:11:33 -07:00
Edward Lee
da76f65a99 Remove some unnecessary logs that follow right after the notify/event now that we only show verbose. Only log non-success response body for Trace. 2009-09-10 22:57:36 -07:00
Edward Lee
1f9d82f9b7 Use a short-circuiting check to determine if a history visit already exists. 2009-09-10 21:27:47 -07:00
Edward Lee
122062e186 Don't create a GUID when looking for dupes and set the GUID when adding a url. 2009-09-10 20:04:34 -07:00
Edward Lee
fb89ee1b60 Add limit as a param to Collection. Make requesting guids the default. 2009-09-10 14:18:31 -07:00
Edward Lee
a364a3c310 Merge weave to weave-partial-view. 2009-09-10 12:42:29 -07:00
Edward Lee
695967c675 Update lastSync to the lastModified time from info/collections instead of updating times on each record. This is to prepare for fetching a list of GUIDs and processing a list of GUIDs. 2009-09-10 12:41:38 -07:00
Edward Lee
554e7266d1 Bug 515676 - Allow giving objects to PUT/POST without Filters to avoid stringify([parse(stringify(stringify(obj)))])
Get rid of Filters and automatically JSON.stringify PUT/POST data that aren't strings, so plain Records can be passed in to PUT and POST. This leverages toJSON of Records to provide an object that can be serialized. Fix up client record serialize/deserialize to still escape/unescape non-ASCII.
2009-09-10 11:05:13 -07:00
Edward Lee
4d5295d9ac Bug 515678 - Provide a smart getter to get the object representation of a JSON Resource response
Always allow getting an object representation of potentially JSON response for any Resource instead of explicitly on filterDownload. Update existing Resource GETs that manually parse the response. This prevents the String response from accidentally toString()ing a filteredDownload that converted to a different type.
2009-09-10 11:04:36 -07:00
Edward Lee
890c3d342c Merge weave to weave-partial-view. 2009-09-08 23:35:21 -07:00
Edward Lee
e343e595ee Detect dupe separators by identifying them by their position and generate the lookup lazily with the folder/title mapping for now. 2009-09-08 23:33:58 -07:00
Edward Lee
57b041bbe1 Expose a _handleDupe on engines and provide a custom one for bookmarks that tracks GUID changes so that it can keep an alias mapping to fix incoming item properties (id, parent, predecessor). Move out _reparentOrphans so that it is triggered on update and not just create because folders can change ids to the right parent. 2009-09-08 23:33:15 -07:00
Edward Lee
039de62d6f Remove the brief log now that we only show verbose. 2009-09-07 18:24:21 -07:00
Edward Lee
54ad191966 Bug 514323 - Use info/collections to check if there's new data. r=thunder
Fetch info/collections before syncing engines and set the lastModified property on the engine so that they can check if they need to process incoming.
2009-09-03 21:30:40 -07:00
Edward Lee
461f6105f9 Bug 513191 - cloud -> client sync wipes auth cache, including weave credentials. r=thunder
Bug 506790 - Utils.setPassword unnecessarily removes logins and add them when the realm/user/pass are the same
Bug 506792 - Utils.setPassword gets called multiple times for both password and passphrase on login
Bug 514499 - Passphrase not verified with auto-login
Don't aggressively persist the password with smart (dumb?) setters that clear out the temp password; and provide a separate function to persist the login. This effectively makes setting password/passphrase always temporary until persisted, which will check if the value is different from the one already stored on disk. A number of verify/cluster functions are privitized to not need to take user/pass/passph as arguments so that the default authenticator will work, and verifyPassphrase will use the stored passphrase to correctly handle auto-login.
2009-09-03 21:11:32 -07:00
Edward Lee
15ce110350 Bug 514600 - Track how long various parts of sync take
Instrument all functions that are part of the sync engine (except some constructors, etc.) and generate statistics (min/max/sum/num/avg) for processing. For now with the default appender, implement toString to report just the total time.
2009-09-03 20:11:36 -07:00
Edward Lee
079a8a520a Remove unimplemented engines so they do not initialize. 2009-09-03 19:57:02 -07:00
Edward Lee
4aacb93fbb Bug 512600 - Split rel/dev-track users on to separate servers. r=thunder
Insert the server_url for the default preference at package time. For now, have both rel and dev use auth.smc.
2009-09-03 01:03:05 -07:00
Edward Lee
e95c1122bc Switch to 0.5 server API for deleting multiple ids from a collection. 2009-08-31 18:30:44 -07:00
Edward Lee
18a57b6d35 Resolve bookmarks.js merge conflicts switching to batchSync (with trailing comma). 2009-08-31 18:04:40 -07:00
Edward Lee
5f8f947cfd Merge weave to weave-partial-view w/ conflicts. 2009-08-31 18:03:35 -07:00
Edward Lee
a2c283b591 Detect dupe folders by title for now. Might need to update the hash during sync if titles are added. 2009-08-31 17:54:21 -07:00
Edward Lee
b0e2b6f92e Pick a canonical guid to keep in a way that all machines can agree without having all data -- "smaller" guid. 2009-08-31 17:51:26 -07:00
Edward Lee
60f942b3ea Implement multiple ids deletion for use with 0.3 APIs. 2009-08-31 17:50:23 -07:00
Edward Lee
d09d8a37e6 Switch end-of-sync deletes to something SyncEngine is aware of and runs at _syncFinish. 2009-08-31 17:30:34 -07:00
Edward Lee
8df3731ca9 Use places utils to find an existing bookmark dupe for an incoming record. 2009-08-31 17:29:47 -07:00
Edward Lee
6fc3d9dd75 Convert uses of recordLike/findLikeId to findDupe except Bookmarks is unimplemented. 2009-08-31 17:27:30 -07:00
Edward Lee
e1afea8a88 Remove mostly unused FaultTolerance service and fix up remaining references. 2009-08-31 17:17:20 -07:00
Edward Lee
d439ae6ca8 Bug 512457 - Report errors before they get eaten up by runInBatchMode
Save the exception from inside runBatched and not have runInBatchMode return failure, so we can then expose the exception.
2009-08-31 16:28:00 -07:00
Edward Lee
935e1f21d3 Remove unused fennec preference overlays, scripts, strings, styles. 2009-08-28 12:21:26 -07:00
Mike Connor
1c4fde8583 bug 503703 - add make target for building a single-OS XPI, r=edilee. actually allows specifying multiple package targets 2009-08-27 01:40:43 -04:00
Dan Mills
5c1a1bedc6 remove 'GPrefs' from Svc, Preferences will do fine; don't make the username in the center status a link, since the whole area is a click target; open 'generic dialogs' for change password & passphrase 2009-08-26 21:20:08 -07:00
Edward Lee
ffd2b8bb07 Add erase server data button to the cloud bubble.
--HG--
extra : rebase_source : fef9abc20e34ebe40fc0d0a2b660e3869c5f6965
2009-08-26 20:22:59 -07:00
Edward Lee
3d8f8a2198 Remove Firefox Weave pref pane and point Preferences... to about:weave.
--HG--
extra : rebase_source : c8e47a770d342dc52aa49d8912be66cd2fa1bfa2
2009-08-26 19:50:39 -07:00
Dan Mills
3777541de2 about:weave polish: add localized help drawer & other small fixes
--HG--
extra : rebase_source : e82da40950dd20d6f418c90cb9b02ba896cd5693
2009-08-26 18:48:22 -07:00
Edward Lee
f03e1375ea Bug 512637 - Use newlines instead of JSON collection for incremental parsing. r=thunder
Switch to newline mode when using a collection record handler, and look for newlines! Easy! Update test to provide newline-separated strings instead of JSON.
2009-08-26 18:09:41 -07:00
Edward Lee
e12767d926 Land weave-0.5-api on weave. r=thunder. 2009-08-26 18:03:52 -07:00
Edward Lee
2437e43bbc New User API returns server code 2 instead of http 417. 2009-08-26 17:59:50 -07:00
Edward Lee
f1ce6f3fb7 Remove old modified arg for collections. 2009-08-26 17:52:46 -07:00
Edward Lee
e082c52844 Save an exception/catch when failing to import a record. 2009-08-26 17:49:23 -07:00
Edward Lee
30e824480c Server expects catcha-challenge not captcha_challenge for new users. 2009-08-26 16:45:24 -07:00
Dan Mills
8aa7a591f1 Parse new 0.5 error codes. 2009-08-26 16:44:30 -07:00
Edward Lee
7c9ca97a64 Resolve lastChannel removal and 0.5 api changes. r=thunder 2009-08-26 16:09:48 -07:00
Edward Lee
9be9fdd6c3 Merge weave to weave-0.5-api w/ conflicts. 2009-08-26 15:42:05 -07:00
Edward Lee
771c9805e7 Bug 511746 - Resource.foo shouldn't throw except in exceptional cases. r=thunder
Get rid of lastChannel and return a String object from _request with additional properties of status, succeeded, headers -- even if the response was handled by cache. Update engines to check for non-success and throw the failure. Update tests to use these additional properties instead of lastChannel, etc.
2009-08-26 15:32:46 -07:00
Dan Mills
5e5d1b1243 Adds another pref for the "misc" api, makes base/misc url prefs default to auth.smc/{user,misc}/, fixes about:weave captcha path. r=Mardak 2009-08-26 15:01:28 -07:00
Edward Lee
1996dc0246 Bug 506297 - Livemarks with null site/feed uris cause sync to fail
It's possible for livemarks to not have a siteURI, so don't assume it to be there.

--HG--
extra : rebase_source : 870bb41c980834ef3e5f302739d20adfed6f7f8d
2009-08-26 14:22:11 -07:00
Mike Connor
2ee5449f03 remove files that were supposed to be culled already, stupid Hg 2009-08-26 13:07:23 -04:00
Mike Connor
6b21954fbd add missing pick-sync.dtd
--HG--
extra : rebase_source : 082544cd2a595206bd550cee94d35f635444e5ed
2009-08-26 13:03:33 -04:00
Edward Lee
852bb71758 Backed out changeset 129ca9a54aed due to burning
test_auth_manager:      FAIL
test_resource:  FAIL
2009-08-26 01:50:36 -07:00
Anant Narayanan
adf361843a Change Resource.get() semantics and support X-Weave-Alert (bug #478330)
--HG--
extra : rebase_source : e0eb1e34f85ddd041005d780590640005dc0b434
2009-08-26 00:05:57 -07:00
Edward Lee
6dce762690 Read out the timestamp of the POST response header because the modified time is not part of the response data. 2009-08-25 18:04:46 -07:00
Edward Lee
c3049133e5 Fix wipeServer to use the new 0.5 API: get list at info/collections, a hash; delete storage/<engine>. 2009-08-25 17:43:40 -07:00
Edward Lee
3fe9021f27 Just strip out " from cluster response because Spidermonkey JSON.parse does not allow literals. 2009-08-25 17:42:25 -07:00