Commit Graph

745149 Commits

Author SHA1 Message Date
Emilio Cobos Álvarez
a228cdaaa6 Bug 1691428 - Stop claiming we support the Menuitem widgets in nsNativeBasicTheme.cpp. r=mstange
We don't.

Depends on D104874

Differential Revision: https://phabricator.services.mozilla.com/D104875
2021-02-16 10:36:18 +00:00
Dorel Luca
847a939bb4 Backed out changeset 56ce2feb53e7 (bug 1688813) for Browser-chrome failures in browser_panelUINotifications_multiWindow.js. CLOSED TREE 2021-02-16 12:36:20 +02:00
Emilio Cobos Álvarez
ca89009775 Bug 1692721 - nsNativeBasicTheme should handle outline-offset like non-auto outline does. r=mstange
I thought we didn't support outline-offset on auto-style outline.

The rect we get is already inflated, so we just got to compute the
radius using that.

Differential Revision: https://phabricator.services.mozilla.com/D105125
2021-02-16 10:25:32 +00:00
Sebastian Hengst
d9fd906046 Bug 1692950 - update expectations for structured-clone.any.worker.html?101-last. DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D105281
2021-02-16 10:10:36 +00:00
Jonathan Kew
4a675c2c2f Bug 1692498 - Let the emoji font pref override Unicode presentation style only if it's explicitly user-set. r=emk
Differential Revision: https://phabricator.services.mozilla.com/D105102
2021-02-16 10:06:10 +00:00
Kagami Sascha Rosylight
104874c6e2 Bug 1691755 - Move view-source context menu items to nsContextMenu r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D104956
2021-02-16 09:49:32 +00:00
Timothy Nikkel
d6c5347d8b Bug 1691878. Modify gfx/layers/apz/test/mochitest/helper_scrollframe_activation_on_load.html to test the activate all scroll frames code better. r=botond
Differential Revision: https://phabricator.services.mozilla.com/D104657
2021-02-16 09:32:21 +00:00
Robert Mader
daafa866da Bug 1668805: Enable opaque region if new GDK API is availabe, r=stransky
From GTK 3.24.25 on we have a new API that allows us to savely apply
opaque regions to our own surfaces without risking to freeze GDK.

Differential Revision: https://phabricator.services.mozilla.com/D102835
2021-02-16 09:04:47 +00:00
Sebastian Hengst
da690f85ed Bug 1692969 - set 2d.imageData.get.source.outside.html as also passing on Android WebRender opt. DONTBUILD
Expectation to timeout got set in latest synchronization with upstream
repository of web-platform-tests (bug 1692513).

Depends on D105275

Differential Revision: https://phabricator.services.mozilla.com/D105276
2021-02-16 09:02:12 +00:00
Sebastian Hengst
a87785f4a8 Bug 1692968 - set document-has-system-focus.html as passing on Linux WebRender shippable. DONTBUILD
Expectation as timeout got set in latest synchronization with upstream
web-platform-tests repository (bug 1692513).

Depends on D105274

Differential Revision: https://phabricator.services.mozilla.com/D105275
2021-02-16 09:02:12 +00:00
Sebastian Hengst
14b96921d9 Bug 1692966 - set double-content-security.https.html as passing on Linux WebRender shippable. DONTBUILD
Expectation to time out got set with latest synchronization of
web-platform-tests with upstream in bug 1692513.

Differential Revision: https://phabricator.services.mozilla.com/D105274
2021-02-16 09:02:11 +00:00
Simon Giesecke
767b2bb664 Bug 1689680 - Add StorageDBUpdater::CreateCurrentSchema and call that if we know we have a fresh database file. r=dom-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D104716
2021-02-16 08:55:15 +00:00
Simon Giesecke
338908171d Bug 1692846 - Remove redundant nullptr checks of return value of infallible new in accessible/. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D105174
2021-02-16 08:43:57 +00:00
Sebastian Hengst
ae517d5b6d Bug 1692513 - set iframe-inheritance-about-blank.html as intermittent on Android. DONTBUILD
Expectations got modified in latest web-platform-test synchronization.

Differential Revision: https://phabricator.services.mozilla.com/D105273
2021-02-16 08:40:11 +00:00
André Bargull
a52e5fbe2f Bug 1692876 - Part 7: Use fixed- instead of reserved-slot accessors for SharedArrayObject. r=jandem
Use `{g,s}etFixedSlot()` instead of `{g,s}etReservedSlot()` for consistency with
non-shared array buffers and because it's slightly faster.

Depends on D105207

Differential Revision: https://phabricator.services.mozilla.com/D105208
2021-02-16 08:31:15 +00:00
André Bargull
29c9e9526b Bug 1692876 - Part 6: Replace the remaining (shared) array buffer helpers with standard is/as() methods. r=jandem
Use the standard `is/as()` methods to test/convert (shared) array buffers.

Depends on D105206

Differential Revision: https://phabricator.services.mozilla.com/D105207
2021-02-16 08:31:14 +00:00
André Bargull
d4aac7b373 Bug 1692876 - Part 5: Remove unused (shared) array buffer functions. r=jandem
Remove functions which are entirely unused.

Depends on D105205

Differential Revision: https://phabricator.services.mozilla.com/D105206
2021-02-16 08:31:14 +00:00
André Bargull
eaebe094bc Bug 1692876 - Part 4: Remove unused declarations in array buffer code. r=jandem
- Remove ArrayBufferObject::OwnsState enum.
- Remove method declarations without definitions.

Depends on D105204

Differential Revision: https://phabricator.services.mozilla.com/D105205
2021-02-16 08:31:13 +00:00
André Bargull
0567e08a1c Bug 1692876 - Part 3: Remove AsAnyArrayBuffer function. r=jandem
`AsAnyArrayBuffer()` was only called in a single place in "asm.js". Replace
that call by directly rejecting shared array buffers at the top of `CheckBuffer`.

Depends on D105203

Differential Revision: https://phabricator.services.mozilla.com/D105204
2021-02-16 08:31:13 +00:00
André Bargull
ccb9ac10bc Bug 1692876 - Part 2: Fix isPreparedForAsmJS for shared buffers. r=jandem
`SharedArrayBufferObject` doesn't define an `isPreparedForAsmJS()` method, so
this method was actually calling itself again.

Depends on D105202

Differential Revision: https://phabricator.services.mozilla.com/D105203
2021-02-16 08:31:13 +00:00
André Bargull
86541427a7 Bug 1692876 - Part 1: Remove indirections for ArrayBufferObjectMaybeShared methods. r=jandem
Inline the various `AnyArrayBufferXYZ()` functions into the corresponding
`ArrayBufferObjectMaybeShared` methods.

Drive-by change:
Remove the `buf` variable in `ArrayBufferObjectMaybeShared::dataPointerEither()`
for consistency with the other `ArrayBufferObjectMaybeShared` methods.

Differential Revision: https://phabricator.services.mozilla.com/D105202
2021-02-16 08:31:12 +00:00
stransky
cb776b928b Bug 1635757 [Wayland] Set MOZ_GTK_DRAG_RESULT_NO_TARGET in invisibleSourceDragFailed, r=jhorak
Depends on https://phabricator.services.mozilla.com/D104802

Differential Revision: https://phabricator.services.mozilla.com/D105198
2021-02-16 08:24:01 +00:00
stransky
2a3383c928 Bug 1635757 [Linux] Remove nsDragService logging module and log D&D with WidgetDrag log module, r=jhorak
Differential Revision: https://phabricator.services.mozilla.com/D104802
2021-02-16 07:52:36 +00:00
Jan de Mooij
d3800ae5c6 Bug 1688913 part 10 - Improve ranges of MNonNegativeIntPtrToInt32 and similar instructions. r=anba,nbp
Differential Revision: https://phabricator.services.mozilla.com/D104662
2021-02-16 07:47:27 +00:00
Matt Woodrow
cd814ab6a8 Bug 1688813 - Draw position:fixed elements relative to the top-left of the document when using drawSnapshot. r=emilio,mstange
Differential Revision: https://phabricator.services.mozilla.com/D104935
2021-02-16 07:38:51 +00:00
Gabriele Svelto
5d9d0b4383 Bug 1692531 - Reinstate the out-of-tree Breakpad patch fixing bug 1371390 r=KrisWright
Differential Revision: https://phabricator.services.mozilla.com/D105098
2021-02-16 06:41:00 +00:00
Cosmin Sabou
5120ec6857 Backed out changeset 6f247372f7ab (bug 1691516) for causing a spike in failure rate for Bug 1276456 and Bug 1630974. 2021-02-16 07:04:50 +02:00
Gerald Squelart
2416d881e2 Bug 1691589 - Reduce reliance on GeckoProfiler.h when only labels (and maybe markers) are needed - r=necko-reviewers,geckoview-reviewers,sg,agi,florian
There are no code changes, only #include changes.
It was a fairly mechanical process: Search for all "AUTO_PROFILER_LABEL", and in each file, if only labels are used, convert "GeckoProfiler.h" into "ProfilerLabels.h" (or just add that last one where needed).
In some files, there were also some marker calls but no other profiler-related calls, in these cases "GeckoProfiler.h" was replaced with both "ProfilerLabels.h" and "ProfilerMarkers.h", which still helps in reducing the use of the all-encompassing "GeckoProfiler.h".

Differential Revision: https://phabricator.services.mozilla.com/D104588
2021-02-16 04:44:19 +00:00
Gerald Squelart
811250c823 Bug 1691589 - Extract profiler label APIs into separate headers - r=florian
New headers BaseProfilerLabels.h and ProfilerLabels.h now contain all label-related APIs.

These files were hg-copied from the main headers, to preserve history, and then non-label content was removed from the main headers.
The "RAII" macros were moved to these *ProfilerLabels.h headers, because that's the most-common header in which they're needed. Meta-bug 1681416 will probably move these again as needed.

Differential Revision: https://phabricator.services.mozilla.com/D104587
2021-02-16 04:44:19 +00:00
Gerald Squelart
9cc158ebf3 Bug 1691589 - Don't include main profiler headers from markers headers - r=florian
{Base,}ProfilerMarkers.h can now rely on {Base,}ProfilerState.h (and just one function forward declaration), so they don't need to include {Base,Gecko}Profiler.h anymore.
Thanks to that, {Base,Gecko}Profiler.h can now include {Base,}ProfilerMarkers.h at the top.

Also, BaseProfilingStack.h should not include BaseProfiler.h (include loop, can cause failures) not algorithm (not used).

***
roll up into 2nd patch

Differential Revision: https://phabricator.services.mozilla.com/D104969
2021-02-16 04:44:18 +00:00
Gerald Squelart
1e76096bd5 Bug 1691589 - Extract profiler state APIs into separate headers - r=florian
New headers BaseProfilerState.h and ProfilerState.h now contain most state-reading APIs.

These files were hg-copied from the main headers, to preserve history, and then chosen declarations were kept only in the relevant header.
This is needed in a following patch, where new headers *ProfilerLabels.h use `profiler_is_active()`.

Differential Revision: https://phabricator.services.mozilla.com/D104968
2021-02-16 04:44:17 +00:00
Emilio Cobos Álvarez
bacf8a0988 Bug 1692893 - Minimal patch: Workaround atk extern "C" issue. r=Jamie
They include system headers inside extern "C", which seems wrong and
causes the issue. This is the minimal patch.

Differential Revision: https://phabricator.services.mozilla.com/D105217
2021-02-16 00:40:33 +00:00
Gijs Kruitbosch
0d46f3f35f Bug 1692847 - fix domWindowOpenedAndLoaded to take a check function, r=darktrojan
Differential Revision: https://phabricator.services.mozilla.com/D105192
2021-02-15 22:54:09 +00:00
Julian Descottes
35cb97f06b Bug 1690698 - [devtools] Add a test for the watcher TargetConfiguration actor r=bomsy,ochameau
Depends on D104394

Differential Revision: https://phabricator.services.mozilla.com/D104429
2021-02-15 22:42:00 +00:00
Julian Descottes
6b61f87e90 Bug 1690698 - [devtools] Introduce a watcher TargetConfiguration actor r=ochameau,bomsy,devtools-backward-compat-reviewers
Depends on D104891

Note: some comments are still not finalized, but I want to flag for review now to start collecting feedback.
See inline comments for areas which should be carefully reviewed.

Differential Revision: https://phabricator.services.mozilla.com/D104394
2021-02-15 22:41:59 +00:00
Julian Descottes
c2ea869048 Bug 1690698 - [devtools] Remove performReload option and call reload from the frontend r=ochameau,bomsy,devtools-backward-compat-reviewers
Depends on D104424

performReload is not a regular configuration option as it is not persisted.
It is rather a flag for a single call to Target::reconfigure.
As we move configuration options outside of the target, it will be easier to drive the reload from the frontend.
The call sites using performReload are quite rare and only found in the netmonitor so it doesn't feel like this
requires a framework solution for now. We add explicit calls to TargetFront::reload() in spots where the netmonitor
used to pass performReload = true.

Differential Revision: https://phabricator.services.mozilla.com/D104891
2021-02-15 22:41:59 +00:00
Julian Descottes
853a765c1f Bug 1690698 - [devtools] Move calls to reconfigure behind TargetList::updateConfiguration r=ochameau,bomsy
Depends on D104423

Same as for isJavascriptEnabled in the previous patch.
With the upcoming Configuration actor, updating the configuration should not be on target-scoped API.
Moving the `reconfigure` API to TargetList reduces the required refactors for the next patch.

Differential Revision: https://phabricator.services.mozilla.com/D104424
2021-02-15 22:41:58 +00:00
Julian Descottes
01d766b469 Bug 1690698 - [devtools] Expose isJavascriptEnabled API on TargetList r=ochameau,bomsy
Depends on D104392

With the Configuration actor the javascript enabled information should no longer be held by the target front.
This abstraction layer in target-list will make the transition easier.

Differential Revision: https://phabricator.services.mozilla.com/D104423
2021-02-15 22:41:58 +00:00
Julian Descottes
5628ea638e Bug 1690698 - [devtools] Add isTopLevelTarget flag on target actors r=ochameau
Depends on D104391

This flag will be needed for server side target switching as well.
Introducing it here will allow to update the configuration only on top level targets

Differential Revision: https://phabricator.services.mozilla.com/D104392
2021-02-15 22:41:58 +00:00
Julian Descottes
bf7d7502cd Bug 1690698 - [devtools] Remove unused reconfigure trait r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D104391
2021-02-15 22:41:57 +00:00
Bogdan Tara
f1451cbda6 Backed out 2 changesets (bug 1680104) for browser_newTabDrop.js mochitest failures CLOSED TREE
Backed out changeset 45f6157a879e (bug 1680104)
Backed out changeset f430e91157eb (bug 1680104)
2021-02-16 00:28:40 +02:00
Bogdan Tara
2a3a8792b0 Backed out changeset 95d35d57d5d6 (bug 1692498) for assertion failure at StaticPrefList_gfx.h CLOSED TREE 2021-02-15 23:23:33 +02:00
Mark Striemer
2e3562988a Bug 1692232 - Part 2: Remove tab-modal UI experiment r=preferences-reviewers,jaws,fluent-reviewers,flod
Depends on D104844

Differential Revision: https://phabricator.services.mozilla.com/D104864
2021-02-15 20:34:19 +00:00
Mark Striemer
080813ab45 Bug 1692232 - Enable tab-modal print UI on all channels r=sfoster,preferences-reviewers,jaws
Differential Revision: https://phabricator.services.mozilla.com/D104844
2021-02-15 20:34:18 +00:00
Julien Wajsberg
b8852c646d Bug 1688669 - Add a new test for network markers for requests going through a service worker r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D103805
2021-02-15 20:32:02 +00:00
Julien Wajsberg
1c8338dc6e Bug 1688669 - Add a new test for network markers r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D102940
2021-02-15 20:32:01 +00:00
Julien Wajsberg
fb405c1684 Bug 1688669 - Add a helper to assert property values in objects r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D102939
2021-02-15 20:32:01 +00:00
Julien Wajsberg
761a4721d8 Bug 1688669 - Clearly write which support files are needed for which profiler browser tests r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D102938
2021-02-15 20:32:01 +00:00
Julien Wajsberg
c352a1f51a Bug 1688669 - Do not sample stacks in marker tests r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D102937
2021-02-15 20:32:00 +00:00
Jonathan Kew
1260865663 Bug 1692498 - Let the emoji font pref override Unicode presentation style only if it's explicitly user-set. r=emk
Differential Revision: https://phabricator.services.mozilla.com/D105102
2021-02-15 20:11:17 +00:00