This removes some redundant files entirely, and drops a slew of
conditions made redundant by the test being complete disabled. In the
remaining cases, the clauses filtering on Windows 10.0.15063 are dropped
since we aren't running on that Windows version any more.
Differential Revision: https://phabricator.services.mozilla.com/D19410
--HG--
extra : moz-landing-system : lando
We used to hard-code the raster spatial node of plane splits to the root.
Now we are using the actual root during batching.
Differential Revision: https://phabricator.services.mozilla.com/D19384
--HG--
extra : moz-landing-system : lando
Depends on D17917
As discussed on slack. Let me know if you'd prefer another comment and/or moving this to the message CSS file?
Differential Revision: https://phabricator.services.mozilla.com/D17918
--HG--
extra : moz-landing-system : lando
Had to modify localization to accomodate for the test so I would like an additional review from l10n peers here.
@stas feel free to forward if somebody else should have a look.
Below is a summary of the problem I faced here for localization, without any of the specifics related to aboutdebugging:
```
Localized(
{
id: "my-component-localization-id",
attrs: {
title: true,
value: true,
}
}
SomeSharedComponent{
title: "fallback-title",
value: "fallback-value"
}
);
```
with the ftl:
```
my-component-localization-id =
.title = Localized title
.value = Localized value
```
The `value` prop can take any node, and later on in the development, I need a more complex wrapper (here for tests). It shouldn't impact the localization, but now I can't directly use my localized value:
```
Localized(
{
id: "my-component-localization-id",
attrs: {
title: true,
}
},
SomeSharedComponent{
title: "fallback-title",
value: Localized(
{
id: my-component-localization-value
},
dom.span(
{
className: "some-class-needed-for-tests",
},
"fallback-value"
)
)
}
);
```
with the ftl:
```
my-component-localization-id =
.title = Localized title
my-component-localization-value = Localized value
```
It feels wrong to change the localization here, but the only other solution would be to introduce another Component, just to maintain the same API from the standpoint of the FTL:
```
Localized(
{
id: "my-component-localization-id",
attrs: {
title: true,
value: true,
},
},
SomeNewComponentForFluent{
title: "fallback-title",
value: "fallback-value",
}
);
```
with an additional component
```
class SomeNewComponentForFluent extends PureComponent {
render() {
return SomeSharedComponent{
title: this.props.title,
value: dom.span(
{
className: "some-class-needed-for-tests",
},
this.props.value,
),
};
}
}
```
Did you already face similar situations? Is there a recommendation/pattern we should follow here?
Differential Revision: https://phabricator.services.mozilla.com/D17917
--HG--
extra : moz-landing-system : lando
Reworked the continue file code so the test doesn't fail if the continue file isn't removed. Instead tests will then check if the UI has advanced to the next check and the continue file is removed at the end of the test.
Increases timeouts since some of the tests need longer for verify / TV runs.
Removes skip-if for tests that now pass verify / TV on Linux
Adds an .eslintrc to the test data directory
Modified the sjs files so they pass eslint
Differential Revision: https://phabricator.services.mozilla.com/D19335
--HG--
extra : moz-landing-system : lando
Intermittent leaks with js_arena_realloc and CompileUtf8 have started
showing up to leaks involving a bunch of JS stuff, so add them to the
top-level LSan WPT white list.
Differential Revision: https://phabricator.services.mozilla.com/D19393
--HG--
extra : moz-landing-system : lando
Adds a common registerCleanupFunction for all tests
Moves several common test setup calls to the add_task used for common test setup
Also clean up several of the comments and formatting
Differential Revision: https://phabricator.services.mozilla.com/D19327
--HG--
extra : moz-landing-system : lando
This appears to be unused, and the [image] attribute on the host is inherited onto
.menu-iconic-icon[src] as an alternative.
Differential Revision: https://phabricator.services.mozilla.com/D19315
--HG--
extra : moz-landing-system : lando
Changed simple.mar from a complete mar to a partial mar to prevent it from accidentally removing application files via an application precomplete file.
Changed the name of the precomplete to update_precomplete in simple.mar so it won't accidentally replace an application's precomplete file.
Differential Revision: https://phabricator.services.mozilla.com/D19267
--HG--
extra : moz-landing-system : lando
This moves the allocation of the ScriptSource object into
ScriptSource::XDR instead of being done in the caller. A
MutableHandle<ScriptSourceHolder> is used to manage both
ScriptSource::refCount as well as tracing Atoms from BinAST.
Differential Revision: https://phabricator.services.mozilla.com/D19164
--HG--
extra : moz-landing-system : lando
Make the method static so that in a follow-up the allocation of the
object can be absorbed in the method.
Differential Revision: https://phabricator.services.mozilla.com/D19163
--HG--
extra : moz-landing-system : lando
Also change JSTryNote::kind to uint32_t to absorb alignment padding of
structure.
Differential Revision: https://phabricator.services.mozilla.com/D19007
--HG--
extra : moz-landing-system : lando
There is no existing bug, but passing correct values to constructor is
more predictable for future.
Differential Revision: https://phabricator.services.mozilla.com/D18875
--HG--
extra : moz-landing-system : lando
This ensures the script source is properly ininitialized before calling
JSScript::Create. This fixes issues with LCov when the script comes from
an XDR-based cache.
Differential Revision: https://phabricator.services.mozilla.com/D18874
--HG--
extra : moz-landing-system : lando
Sanity check was reading out-of-range value. This caused more XDR decode
failures than expected, but non-cache load would recover anyways. With
fix, a few more cases will support XDR caching.
Differential Revision: https://phabricator.services.mozilla.com/D18873
--HG--
extra : moz-landing-system : lando
There are two changes being made here:
* In call sites where we know both origin arguments are equal,
we will call a specialized version of the function which
avoids the origin equality check.
* We avoid calling into the generic printf structure and build
the result string manually.
Differential Revision: https://phabricator.services.mozilla.com/D19245
--HG--
extra : moz-landing-system : lando
Using an old default profile that is empty (like from bug 1518591) causes us to
also show the user a welcome page when that isn't necessary.
Instead leave old empty profiles alone (older versions will use them as the
default), create a new profile but don't set the flag to say that the old
default was skipped.
Differential Revision: https://phabricator.services.mozilla.com/D19243
--HG--
extra : moz-landing-system : lando
