When display style is changed from 'none' to other in animation-only restyle
we need to resolve descendant elements' style that were in the display:none
subtree.
Three possible ways to resolve the descendant elements' style;
1) Traversing unstyled elements in animation-only restyle
We can't simply traverse unstyled elements in the animation-only restyle
since when we decided to traverse the unstyled elements we don't know yet
the elements will be initially styled or are in display:none subtree. It
will result that the new elements are styled in animation-only restyle,
it's undesirable.
2) Creating a SequentialTask and resolve the descendants' style with
ServoStyleSet::StyleNewSubtree()
We can't resolve the descendants' styles with ServoStyleSet::StyleNewSubtree()
in SequentialTask since at the moment we are still in servo traversal (i.e.
sInServoTraversal is true). That means AutoSetInServoTraversal fails
in PrepareAndTraverseSubtree().
3) Creating a SequentialTask and set restyle subtree hint and defer descendants'
restyle in a subsequent normal traversal
Note that, when we process throttled animations flush, we don't process
normal traversal so the descendants will not be traversed until normal
restyle happens but it will not be a big problem since it's really rare
that user clicks display animation element just at the right moment when
display property changes from none to other. Also, if it will be really
a problem, we should process *only* transform animations on the compositor,
it's ideally right thing to do. Display property never runs on the
compositor.
This patch takes the third approach.
MozReview-Commit-ID: Krxa3kkdIq4
--HG--
extra : rebase_source : 33e9db953f21168c76716329568191625bd15896
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1385089
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
Source-Repo: https://github.com/servo/servo
Source-Revision: e07beacd4db4805beb6fd063bf5ccc806f90bf15
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 6faa293c2f45ea761850fcfd43689aca92d1c678
When a container layer's transform has an animated scale, we clamp it
to a near power of two so that descendent layers' resolutions do not
keep changing and we minimize repainting. The current behaviour only
clamps the scale when it has not changed with respect to the previous
transaction. In animations where the scale usually changes, but
happens to remain constant between two consecutive transactions, this
is bad.
Rather than only checking against the previous scale value, use
ActiveLayerTracker::IsScaleSubjectToAnimation() to determine whether
to clamp, as it takes into account a longer period.
--HG--
extra : rebase_source : 6bc773e387c5750746722d4a0cc5864ebf7757e2
This adds several tests to make sure we can expand Sets and Maps entries, and that we manage
those properties in the store as expected.
We also add a stub for a Set object and take this as an opportunity to fix the stub name.
MozReview-Commit-ID: ChhIHKMPINF
--HG--
extra : rebase_source : 89e5216605f77fb3812b3297bb95b6d3fc10de49
Add getObjectEntries and loadObjectEntries as props for the ObjectInspector so
we can display entries on Maps and Sets.
MozReview-Commit-ID: Cy6SjxwclHI
--HG--
extra : rebase_source : 02b4eb11f45f25eab9af7e640939177ab1c0f0fc
When the MOZ_HEADLESS output variable is set in the environment,
--headless will be implied when using the Marionette harness. This will
cause test rules and ignores to be picked up with MOZ_HEADLESS as they
are with --headless.
MozReview-Commit-ID: 8L7J4asQXyF
--HG--
extra : rebase_source : 0d4a41d028752c806fab94a5d0d0bb2802134b81
<!-- Please describe your changes on the following line: -->
Update angle dependency (Fixes a crash when compiling shaders on Android)
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: 7651cebcd05376c034df38f480701f541fd38da1
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : c58c34cbbcca3213012eb56a8f88002394b3f3f3
This commit
- Fixes the focus count failure. The bug 1375793 turned on the onboarding on all channels but this test still checks `AppConstants.NIGHTLY_BUILD`. Hence although the onboarding is enabled on Beta, this test thought it is disabled and missed counting the onboarding elements. The solution is to remove `AppConstants.NIGHTLY_BUILD` condition.
- Updates the `promiseTourNotificationOpened` function the same as the bug 1383070 btw
MozReview-Commit-ID: 2TVyqDxMGS6
--HG--
extra : rebase_source : f6d0488f06d9fda42ba01e78e70ea64d389b0294
The page load timeout of Marionette is 300s long. By using the same value
for the firefox ui harness invocation from mozharness it can cause a race
condition. Lets increase the value to what the Marionette jobs use to be
in sync.
MozReview-Commit-ID: FUevLmRIMSF
--HG--
extra : rebase_source : 43ee8b9009ba4ea89c8e8642d44eecf643b05ecc
The test was failing on 56 beta because the new console frontend isn't enabled there and thus
the ObjectInspector that were tested not in the old frontend.
This patch adds a branch in the test so we can wait for the correct element (VariableView or ObjectInspector)
depending on whether the new console frontend is enabled or not.
MozReview-Commit-ID: HGGgr7CWMpe
--HG--
extra : rebase_source : ef8e21d1f0a1b074fd798ed2b05fb18a9a9335cc
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
Source-Repo: https://github.com/servo/servo
Source-Revision: 3ef182ca36f0067c0e431addc8ee7f1343b575c4
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 713870d033ff517a18131822f871fff4a85031b5
If a devtools entry point isn't hit in a test (toolbox open, keyboard shortcut,
opening the web dev menu, etc), then things like the menu items aren't installed.
This is for performance reasons (Bug 1359855), but it means that some tests
may fail when run alone. Prevent that from happening by forcing devtools to start
up in shared-head.js.
This causes certain tests to fail when run alone if they don't open the tools
MozReview-Commit-ID: ANuUhYXIbSF
--HG--
extra : rebase_source : f8a20a7eabfdbbfe51ecaf2ea8c59a4fcf41e695
This used to be necessary when larger/smaller did a table lookup.
However as of bug 1361550 these are simple ratios and should be treated
the same as em units.
MozReview-Commit-ID: 2zM7O0awynG
* Filmstrip style svg animation for start download notification, vertically centered to allow for variable-height toolbar buttons
* Simultaneous identifer "dip" animation on the icon for download start
* Identifier icon bounce animation for download finish (no notification animation in the #downloads-animation-container)
* Always measure the anchor element as toolbarheight may change in a session (e.g. switching to compact mode)
* Conditionally include the start/finish pngs for non-Photon builds
* Have #downloads-notification-anchor hidden by default, and show it before measuring for placement. This avoids the interference with scrolling/APZ when the notifier element is tall enough to overlap the tabbrowser element
MozReview-Commit-ID: LJF6iV9HiJi
--HG--
extra : rebase_source : 80238cf0240c32943667ee4c141c756813b2728e
