Commit Graph

2430 Commits

Author SHA1 Message Date
Jim Chen
8e0ad67a7a Bug 1291375 - 5. Use Fennec bindings where needed; r=snorp
Switch include statements from GeckoView bindings to Fennec bindings
where needed.
2016-09-16 15:13:48 -04:00
Michael Layzell
e583117bfa Bug 1018486 - Part 5: Changes in docshell/ and uriloader/, r=bz
MozReview-Commit-ID: GiyHWL3aaOv
2016-09-07 10:50:41 -04:00
Nicholas Nethercote
34dcc7b852 Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm.
This change avoids lots of false positives for Coverity's CHECKED_RETURN
warning, caused by NS_WARN_IF's current use in both statement-style and
expression-style.

In the case where the code within the NS_WARN_IF has side-effects, I made the
following change.

> NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
> -->
> Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));

In the case where the code within the NS_WARN_IF lacks side-effects, I made the
following change.

> NS_WARN_IF(!condWithoutSideEffects);
> -->
> NS_WARNING_ASSERTION(condWithoutSideEffects, "msg");

This has two improvements.
- The condition is not evaluated in non-debug builds.
- The sense of the condition is inverted to the familiar "this condition should
  be true" sense used in assertions.

A common variation on the side-effect-free case is the following.

> nsresult rv = Fn();
> NS_WARN_IF_(NS_FAILED(rv));
> -->
> DebugOnly<nsresult rv> = Fn();
> NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed");

--HG--
extra : rebase_source : 58788245021096efa8372a9dc1d597a611d45611
2016-09-02 17:12:24 +10:00
Nicholas Nethercote
742fc7eb48 Bug 1297961 (part 1) - Introduce nsURI::GetSpecOrDefault(). r=hurley.
This function is an infallible alternative to nsIURI::GetSpec(). It's useful
when it's appropriate to handle a GetSpec() failure with a failure string, e.g.
for log/warning/error messages. It allows code like this:

  nsAutoCString spec;
  uri->GetSpec(spec);
  printf("uri: %s", spec.get());

to be changed to this:

  printf("uri: %s", uri->GetSpecOrDefault().get());

This introduces a slight behavioural change. Previously, if GetSpec() failed,
an empty string would be used here. Now, "[nsIURI::GetSpec failed]" will be
produced instead. In most cases this failure string will make for a clearer
log/warning/error message than the empty string.
* * *
Bug 1297961 (part 1b) - More GetSpecOrDefault() additions. r=hurley.

I will fold this into part 1 before landing.

--HG--
extra : rebase_source : ddc19a5624354ac098be019ca13cc24b99b80ddc
2016-08-26 16:02:31 +10:00
Wei-Cheng Pan
9a0fc7767f Bug 1293212 - Add MOZ_MUST_USE to prevent potential bugs. r=smaug
MozReview-Commit-ID: EuyeBkDlk2G

--HG--
extra : rebase_source : de8d5a95f74b757b7441cdc1e0f2dadb3a77ac6e
2016-08-08 18:16:15 +08:00
Ryan VanderMeulen
69113163cf Merge m-c to inbound. a=merge 2016-08-24 09:09:05 -04:00
Xidorn Quan
bef532f153 Bug 306471 part 2 - Do not query handler service for content-type of file extension. r=bz
MozReview-Commit-ID: FP1J6Qk3fsM

--HG--
extra : rebase_source : b223c630266294dc157e88d1a6090a1c99dd8746
2016-08-12 20:58:31 +10:00
Xidorn Quan
f95f57c3c2 Bug 306471 part 1 - Some code style cleanup for nsExternalHelperAppService::GetTypeFromExtension. r=bz
MozReview-Commit-ID: 3N37Kd2fNjS

--HG--
extra : rebase_source : 825308563f4d1ebdb3e672d088975df30bf89392
2016-08-12 20:56:23 +10:00
Kan-Ru Chen
b6d880aca1 Bug 1297276 - Rename mfbt/unused.h to mfbt/Unused.h for consistency. r=froydnj
The patch is generated from following command:

  rgrep -l unused.h|xargs sed -i -e s,mozilla/unused.h,mozilla/Unused.h,

MozReview-Commit-ID: AtLcWApZfES


--HG--
rename : mfbt/unused.h => mfbt/Unused.h
2016-08-24 14:47:04 +08:00
Samael Wang
a4bc3b938a Bug 1268962 - Add load / error event to prefetch link. r=bz
--HG--
extra : rebase_source : e62d8f12b0a4b4e047869ff005161df15cb6ab42
2016-08-12 15:09:05 +08:00
Nicholas Nethercote
3b0485fcdb Bug 1294645 - Don't use NS_CALLBACK for callbacks in nsI{Input,Output,UnicharInput},Stream.idl. r=froydnj.
Slightly less than half (93 / 210) of the NS_METHOD instances in the codebase
are because of the use of NS_CALLBACK in
nsI{Input,Output,UnicharInput},Stream.idl. The use of __stdcall on Win32 isn't
important for these callbacks because they are only used as arguments to
[noscript] methods.

This patch converts them to vanilla |nsresult| functions. It increases the size
of xul.dll by about ~600 bytes, which is about 0.001%.

--HG--
extra : rebase_source : c15d85298e0975fd030cd8f8f8e54501f453959b
2016-08-12 17:36:22 +10:00
Wes Kocher
b92ae9a263 Backed out changeset 626f8cc8b7bc (bug 1268962) for causing bug 1268962 a=backout 2016-08-11 13:49:25 -07:00
Honza Bambas
237faab5b3 Bug 1285476 - Let appcache double-cache resources that are cross origin, r=michal 2016-07-27 13:08:00 +02:00
Marcos Caceres
4b42312a6f Bug 1160200 - APNG can't be used with type switching. r=mcaceres, r=jrmuizel, r=johns 2016-08-09 22:15:00 +02:00
Samael Wang
319c7870ef Bug 1268962 - Add load / error event to prefetch link. r=bz 2016-08-09 14:28:17 +08:00
Xidorn Quan
5dd417a0d9 Bug 373621 - Make mime-type of PDF not overridable. r=bz
MozReview-Commit-ID: 8k2XorDX0z9

--HG--
extra : transplant_source : %86J%CA%F9%E6%B3%85jk%CB%E7%0AX%8C%F1y%D9%B4%95%D9
2016-07-28 20:20:42 +10:00
Ben Kelly
886f5ab205 Bug 1288915 P1 Make nsExternalAppHandler respect existing channel ApplyConversion flag. r=jdm 2016-07-28 15:51:49 -04:00
Makoto Kato
38dcdb48a4 Bug 1288650 - Export mac/nsOSHelperAppService.h instaed of win/nsOSHelperAppService.h on OSX builder. r=mshal
MozReview-Commit-ID: LvM3XY0wujz

--HG--
extra : rebase_source : 1b988cf26c103157b37b88a4aec53bc736a63ad8
2016-07-28 13:12:39 +09:00
Carsten "Tomcat" Book
336105a0de merge mozilla-inbound to mozilla-central a=merge 2016-07-22 11:58:02 +02:00
Jim Chen
ce45a595ab Bug 1287946 - Update existing code to use mozilla::java; r=me 2016-07-21 13:49:04 -04:00
Tom Tromey
5538d692d3 Bug 1286877 - do not set c-basic-offset for python-mode; r=gps
This removes the unnecessary setting of c-basic-offset from all
python-mode files.

This was automatically generated using

    perl -pi -e 's/; *c-basic-offset: *[0-9]+//'

... on the affected files.

The bulk of these files are moz.build files but there a few others as
well.

MozReview-Commit-ID: 2pPf3DEiZqx

--HG--
extra : rebase_source : 0a7dcac80b924174a2c429b093791148ea6ac204
2016-07-14 10:16:42 -06:00
Chris Peterson
b175c9fdd5 Bug 1277106 - Part 2: Expand MOZ_UTF16() strings to u"" string literals. r=Waldo 2016-07-20 22:03:25 -07:00
Carsten "Tomcat" Book
e8bc59a87a Backed out changeset 684888aeee81 (bug 1287946) 2016-07-21 08:07:12 +02:00
Jim Chen
78f67d1f6f Bug 1287946 - Update existing code to use mozilla::java; r=me 2016-07-21 00:42:26 -04:00
Nicholas Nethercote
a913f99107 Bug 1285554 - Remove remnants of widget/qt. r=dougt,mshal.
Because bug 1282866 removed Qt support but missed a bunch of things.
* * *
Bug 1285554 - more

--HG--
extra : rebase_source : c48d2485f1fdf1c961e08d91651bbca41e3a1a53
2016-07-12 09:16:45 +10:00
Honza Bambas
2342cffea3 Bug 1277028 - Make external protocol handlers work with e10s redirects, r=jduell 2016-07-01 05:16:00 +02:00
Olli Pettay
437d8cd427 bug 1282985, don't try to notify about page load of already stopped page, r=khuey
--HG--
extra : rebase_source : aa3369235aa3eb3e4f315ddb85f12791d10c021a
2016-06-30 13:04:01 +03:00
Gian-Carlo Pascutto
0706b698f4 Bug 579388 - nsIMIMEService should run in chrome. r=jaas+18821
MozReview-Commit-ID: Hu2sdcOWuZX

--HG--
extra : rebase_source : a6950d5971343c63e60d0acddd77e130fc2f45cb
2016-06-15 12:29:30 +01:00
Thomas Nguyen
545e22fb16 Bug 1264165 - Implement link referrerPolicy attribute. r=josh, r=khuey
MozReview-Commit-ID: GxMtNB23eD8
2016-06-24 10:38:47 +08:00
Ralph Giles
10281b30c2 Bug 1275744 - Reference MOZ_LOG in uriloader comments. r=erahm
NSPR_LOG_MODULES is deprecated.

MozReview-Commit-ID: HjVIwcxH4My

--HG--
extra : rebase_source : 813d00ff83e2d3741f89c3c5fec6b01fffb3ebb2
2016-05-26 11:48:27 -07:00
Nicholas Hurley
9e6ef0d3a6 Bug 1276052 - Fix NS_ConvertUTF16toUTF8 usage. r=smaug
MozReview-Commit-ID: BLvxeSWpF6h
2016-06-09 12:54:14 -07:00
dimi
8d44df2c72 Bug 1258033 - Part 1: Add IsTrackingProtectionOn for nsILoadContext. r=smaug
MozReview-Commit-ID: 2eQzO6KDLyX

--HG--
extra : rebase_source : 1f5c1c7b250336ff4ecf1e5b3949a532b7bb9144
2016-06-02 10:12:39 +08:00
Chris Peterson
8a9e2d2bd4 Bug 1272513 - Part 2: Remove redundant -Wshadow CXXFLAGS from moz.build files. r=glandium 2016-05-14 00:54:55 -07:00
Chris Peterson
353ee65255 Bug 1272513 - Part 1: Suppress -Wshadow warnings-as-errors in some directories. r=glandium 2016-05-11 00:00:01 -07:00
Christoph Kerschbaumer
36b4675908 Bug 1246736 - Remove SEC_NORMAL from uriloader/ (r=sicking) 2016-02-08 12:41:40 -08:00
Kyle Huey
941ab1f522 Bug 1268313: Part 7 - Move NS_NewRunnableMethod and friends to mozilla::NewRunnableMethod. r=froydnj 2016-05-05 01:45:00 -07:00
Thomas Zimmermann
bad0d78379 Bug 1267214: Close private DBus connection in |nsDBusHandlerApp::LaunchWithURI|, r=bz
|nsDBusHandlerApp::LaunchWithURI| uses a private DBus connection, which
is supposed to be closed by the caller. Using |UniquePtr| does this auto-
matically.

MozReview-Commit-ID: C2j05Rpzkav
2016-05-04 11:41:07 +02:00
Carsten "Tomcat" Book
ba3fe0975c Backed out changeset 85ce8cb0639a (bug 1268313)
--HG--
extra : rebase_source : 56d1cf41a2dc4959b67f834e07192a5c772176a8
2016-04-29 14:21:16 +02:00
Kyle Huey
48a594a09e Bug 1268313: Part 7 - Move NS_NewRunnableMethod and friends to mozilla::NewRunnableMethod. r=froydnj 2016-04-28 14:08:25 -07:00
Sebastian Hengst
b4020b78c0 Backed out changeset e786ecce31b2 (bug 1266875) for pgo build bustage in xpcshell/xpcom/tests/unit/nsIFileEnumerator. r=backout on a CLOSED TREE 2016-04-27 18:35:41 +02:00
Mike Shal
a204083dd1 Bug 1266875 - Remove custom install rules; r=chmanchester
MozReview-Commit-ID: CoWdHidlDrV
2016-04-18 10:36:07 -04:00
Sebastian Hengst
c108701a85 Backed out changeset 68442febc36c (bug 1160200) for almost permafailing added test apng-mime/test.html Android 4.3 API15+ opt. r=backout 2016-04-23 22:33:26 +02:00
David Newton
f44103a43f Bug 1160200 - APNG can't be used with type switching. r=mcaceres,r=jrmuizel 2016-04-20 23:57:00 +02:00
Thomas Zimmermann
d812f7602e Bug 1266033: |nsDBusHandlerApp|: Use private connection to DBus session bus, r=bz
Sharing DBus connections can interfere with other modules (e.g., watching
connections on multiple threads concurrently might introduce race conditions).

This patch changes |nsDBusHandlerApp| to use it's private connection to
the session bus to avoid interference.
2016-04-21 11:24:23 +02:00
Thomas Zimmermann
b8fa61ee49 Bug 1266033: |nsDBusHandlerApp|: Hold reference to |DBusMessage| in |RefPtr|, r=bz 2016-04-21 11:24:23 +02:00
Thomas Zimmermann
809e2dc71c Bug 1266033: |nsDBusHandlerApp|: Hold reference to |DBusConnection| in |RefPtr|, r=bz
|nsDBusHandlerApp| currently leaks its DBus connection. This patch
fixes the leak with automated reference-counting by using |RefPtr|.
2016-04-21 11:24:23 +02:00
Thomas Zimmermann
ec0b5f67ca Bug 1266033: Fix white-space errors in |nsDBusHandlerApp|, r=bz 2016-04-21 11:24:23 +02:00
Chris H-C
3edb79bbd9 Bug 1260483 - Use AssocQueryString to get friendly protocol handler names. r=jimm
In Win8+, AssocQueryString supports ASSOCF_IS_PROTOCOL which simplifies fetching
the friendly application name for a given protocol/scheme. For "Universal" apps,
this simplified mechanism is required to get something other than TWINUI.

MozReview-Commit-ID: pTruoBeTgK

--HG--
extra : transplant_source : %F4%F4%96%5D%D5%8A%BA%91%D7%E9-%1C%C8%E2%DF%DFy%87%C5%F3
extra : histedit_source : 7d8685f181638c2a74b02ebe86f09bf8f22b9d27
2016-04-04 12:54:41 -04:00
Ms2ger
bba6a76c33 Bug 1259018 - Part c: Pass arguments to the nsExtProtocolChannel constructor; r=jst 2016-03-25 09:17:43 +01:00
Ms2ger
794d9e6353 Bug 1259018 - Part b: Use early returns and stop accepting null in nsExternalProtocolHandler::HaveExternalProtocolHandler; r=jst 2016-03-25 09:17:37 +01:00