updateLayer expects some objects to be non-null which are only initialized when the pref is set.
But in builds that were compiled with the 10.14 SDK, all NSViews are layer-backed by default, so
wantspdateLayer gets called, and returning YES from that unconditionally will cause updateLayer
to be called.
Differential Revision: https://phabricator.services.mozilla.com/D42333
--HG--
extra : amend_source : a7a1f7ecba9418e3bf5464bca90ba655002bc637
Automatic update from web-platform-tests
Handle null effect when interrupting a transition
If the effect of a CSS Transition is removed (via the getAnimations API)
and then the transition is interrupted by removing the 'to' style, we
previously assumed that the effect would always exist. This CL adds a
null-check for that case.
Bug: 992668
Change-Id: I399be7fd859bac0ca6e7ee1e29dbcbbae2e89403
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753671
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686932}
--
wpt-commits: 8194a35b1626cb99346d3b2d008f83998194c2af
wpt-pr: 18428
Automatic update from web-platform-tests
Use observer for sync bases
Previously sync bases would not be updated if the base element was
swapped out. This has been changed to allow for this. Making events
and sync bases work more uniformly.
This is the first step in changing sync base repeats into actual
sync bases.
Bug: 993702
Change-Id: I1a1b381d094100296a420de8877bb1e57cd9709e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753004
Commit-Queue: Edvard Thörnros <edvardt@opera.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Auto-Submit: Edvard Thörnros <edvardt@opera.com>
Cr-Commit-Position: refs/heads/master@{#686838}
--
wpt-commits: 5777568726d1e9d7e3e0cfa6b65497dcca2de229
wpt-pr: 18419
Automatic update from web-platform-tests
Revert "Changed test_designMode to check for empty string instead of br tag (#17809)" (#18421)
This reverts commit 0ca74f4e7b40069719c77d8ffab0e56e5ef2b095.
--
wpt-commits: 464774c28a35d48ff5f8cd8eb1c8e089277bb77f
wpt-pr: 18421
Automatic update from web-platform-tests
Make status neutral return code 0 so that jobs stop failing
GitHub seems to have broken the feature where an action returning
status 78 is deemed neutral, so to stop it looking like everything
failed, use a success status instead (i.e. return code 0); this
can be reverted when GitHub fix their bug.
--
wpt-commits: 70682eca754225b5513dab1ba6148368de59f82c
wpt-pr: 18417
Automatic update from web-platform-tests
[LargestContentfulPaint] Re-enable untrusted scroll test
The test was disabled because it landed too close to the change which changed
the startTime to not be 0. After addressing that change, the test now passes.
Bug: 987915
Change-Id: Id19623083aa141f7c3b541ad490db6395add6f8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753082
Auto-Submit: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686787}
--
wpt-commits: 6c01d2da08c37e2e7b75e8ab7b983a8b2afb6f3a
wpt-pr: 18411
Automatic update from web-platform-tests
Fix DCHECK when compositing additive CSS transform animations
Previously CSSTransformNonInterpolableValue assumed that anything that was
composited on-top of would be single. However that is not true; in the simple
case where there is a replace animation before it, the replace effect will be a
pair:
target.animate({ transform: [ 'scale(1)', 'scale(2)' ] }, 1000);
target.animate({ transform: [ 'rotate(0)', 'rotate(90deg)' ] },
{ duration: 1000, composite: 'add' });
In the example above, the scale animation would not yet have been reduced to a
single interpolated value, so the DCHECK for is_single_ would fail. This CL
fixes the logic to perform an interpolation in that case.
Bug: 979952
Change-Id: I36a3221c55aa3d98281a21a4ac93d95d61c5a1ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750200
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686789}
--
wpt-commits: eba08b270c0e767b21cc725355c840a71c1d4e11
wpt-pr: 18403
Automatic update from web-platform-tests
CSS: Shortest serialization for gap shorthand
gap is <'row-gap'> <'column-gap'>?
https://drafts.csswg.org/css-align-3/#propdef-gap
If row-gap and column-gap are the same, we serialize
only a single value, consistent with Firefox and
the shortest representation principle.
https://drafts.csswg.org/cssom/#serializing-css-values
Change-Id: I8a2380d963cdbb7f33676b435d9cfb909abf9e77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750521
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686773}
--
wpt-commits: a06709fbf13b28f4b1b3d24f5bbc2e5274fe87af
wpt-pr: 18407
Automatic update from web-platform-tests
[WebNFC] Distinguish between NFC not available and not enabled
Following spec change at https://github.com/w3c/web-nfc/issues/237, this
CL allows web developers to distinguish when NFC is not available and
when it's disabled by user preference.
Bug: 520391
Change-Id: I3927d855edef1b1cf9b2036a0b4991745b962e04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751948
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Cr-Commit-Position: refs/heads/master@{#686762}
--
wpt-commits: 33a1ccaeb68cb1c02498a320b94cf7fd20708869
wpt-pr: 18416
Automatic update from web-platform-tests
Changed test_designMode to check for empty string instead of br tag (#17809)
--
wpt-commits: 0ca74f4e7b40069719c77d8ffab0e56e5ef2b095
wpt-pr: 17809
Automatic update from web-platform-tests
[Import Maps] Update resolving tests from upstream
This CL imports more tests from upstream:
- Test files from
https://github.com/WICG/import-maps/tree/master/reference-implementation/__tests__
are imported to import-maps/imported/resources/.
- Generated test HTMLs are placed in import-maps/imported/.
- To support more tests, the glue code in resolving.tentative.html
is moved into `jest-test-helper.js` and extended to support new tests.
The current test failures are added as -expected.txt, and will be
fixed in the future when import map functionalities are implemented or fixed.
Bug: 990561
Change-Id: I087df82355513584a0cf1891da648dd2155f53c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734024
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686701}
--
wpt-commits: a29f9a0f1982c43d4cb7c5d0b2f6769db3131ba1
wpt-pr: 18264
Automatic update from web-platform-tests
[css-text-decor] Parsing of text-shadow (#18373)
text-shadow is none or a list, each item an optional color
and two or three lengths.
https://drafts.csswg.org/css-text-decor-3/#text-shadow-property
--
wpt-commits: 15f1ab49523aae62e7570dc2d4a4dcb1bec6fce8
wpt-pr: 18373
This adds a "remote(pup)" TaskCluster job for running the Google
Puppeteer tests against the new Firefox remote agent.
Earlier in this patchset we added a "./mach puppeteer-test" command
that wraps npm, and this being a source-test with access to the
full checkout, invokes this command directly instead of going
through mozharness.
Differential Revision: https://phabricator.services.mozilla.com/D37015
--HG--
extra : moz-landing-system : lando
This makes it possible to for mach to determine which test types
are likely to be relevant.
Differential Revision: https://phabricator.services.mozilla.com/D37014
--HG--
extra : moz-landing-system : lando
Makes it possible for mach to resolve test paths for Puppeteer,
so that individual tests can be run from the command line using
"./mach test", as such:
% ./mach test remote/test/puppeteer/test/screenshot.spec.js
As the Puppeteer test suite is imported from upstream and we cannot
change this directory at will (i.e. to add test manifest files),
we take the same approach as for WPT and populate the manifest by
recursively walking the remote/test/puppeteer/test/**/*.spec.js file tree.
Differential Revision: https://phabricator.services.mozilla.com/D37013
--HG--
extra : moz-landing-system : lando
The Puppeteer test flavour are functional tests for the CDP-based
Puppeteer library from Google, that we want to run against our
implementation of CDP for Firefox.
They are distinct from the Firefox Puppeteer tests based on Marionette.
Differential Revision: https://phabricator.services.mozilla.com/D37012
--HG--
extra : moz-landing-system : lando
We vendor the Puppeteer library, but not its dependencies.
When "npm install" is called in remote/test/puppeteer/, it puts
its dependencies under remote/test/puppeteer/node_modules/ and
generates a remote/test/puppeteer/package-lock.json file. We do
not want these to be checked in.
DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D37010
--HG--
extra : moz-landing-system : lando
Introduces "./mach puppeteer-test" command for running the Puppeteer
tests against the remote agent. This has to be a top-level command
because the automatic test detection system in mach does not allow
us to delegate to a subcommand such as "./mach remote puppeteer-test".
The tests run against a fork of Puppeteer with hotfixes needed for
it to work with the CDP implementation in Firefox. This fork is
located at https://github.com/andreastt/puppeteer/tree/firefox, and
vendored under remote/test/puppeteer/ in a previous commit in this series.
Differential Revision: https://phabricator.services.mozilla.com/D37009
--HG--
extra : moz-landing-system : lando
Puppeteer is licensed under the Apache-2.0 license.
No code from Puppeteer gets included in Firefox.
Differential Revision: https://phabricator.services.mozilla.com/D37008
--HG--
extra : moz-landing-system : lando
Introduces "./mach remote vendor-puppeteer" for vendoring the
Puppeteer client without dependencies into remote/test/puppeteer/.
The particular checkout of Puppeteer is
https://github.com/andreastt/puppeteer/tree/firefox, which contains a
couple of hotfixes we need for the client to work with the Firefox
implementation of CDP.
The remote agent targets a specific version of Puppeteer, so it is
not suitable for this to be vendored under third_party/. We also
wouldn't want other code in central to accidentally use a patched fork.
The vendoring process is not part of "./mach vendor" because it does
not yet have Node.js support, and implementing that for mach is outside
the scope of getting the Puppeteer tests running with the remote agent.
Differential Revision: https://phabricator.services.mozilla.com/D37007
--HG--
extra : moz-landing-system : lando
This removes the call to SetThreeDPointParameter which is no longer necessary
now that we're using AudioParams for position and orientation. Doing the
conversion can cause an assertion failure when the AudioParams have a scheduled
future value.
Differential Revision: https://phabricator.services.mozilla.com/D42023
--HG--
extra : moz-landing-system : lando
