Commit Graph

15437 Commits

Author SHA1 Message Date
Matt Woodrow
a925a86ada Bug 1574372 - Add API to test stream converters to find out their output type. r=bzbarsky
We don't want to run stream conversion in the parent (since a lot of them require access to the document), so this instead adds a way to find out what their output type will be.

Differential Revision: https://phabricator.services.mozilla.com/D56134

--HG--
extra : moz-landing-system : lando
2019-12-17 03:02:02 +00:00
Oana Pop Rus
5545e5a016 Backed out 9 changesets (bug 1574372) for bustage and wpt failures. on a CLOSED TREE
Backed out changeset b0183a606fec (bug 1574372)
Backed out changeset b7c96254826e (bug 1574372)
Backed out changeset 196d61adc272 (bug 1574372)
Backed out changeset 419b94b1210e (bug 1574372)
Backed out changeset c192e499eb47 (bug 1574372)
Backed out changeset 4e57038c3518 (bug 1574372)
Backed out changeset 6ec2aa542b59 (bug 1574372)
Backed out changeset d71b4c0aac1a (bug 1574372)
Backed out changeset a05c3b113ac1 (bug 1574372)
2019-12-17 03:26:38 +02:00
Matt Woodrow
d1851fa263 Bug 1574372 - Add API to test stream converters to find out their output type. r=bzbarsky
We don't want to run stream conversion in the parent (since a lot of them require access to the document), so this instead adds a way to find out what their output type will be.

Differential Revision: https://phabricator.services.mozilla.com/D56134

--HG--
extra : moz-landing-system : lando
2019-12-16 21:40:06 +00:00
Alexandre Poirot
fd7704e4fb Bug 1602791 - Make the storage panel use the TargetList and support target switching. r=miker
Differential Revision: https://phabricator.services.mozilla.com/D56552

--HG--
extra : moz-landing-system : lando
2019-12-16 16:22:15 +00:00
Alexandre Poirot
a17b5ecf2c Bug 1602791 - Move storage front retrieval from Panel to UI. r=miker
Differential Revision: https://phabricator.services.mozilla.com/D56551

--HG--
extra : moz-landing-system : lando
2019-12-16 17:40:33 +00:00
Nicolas Chevobbe
a02d35ea91 Bug 1566850 - Remove target.activeConsole usage in Toolbox. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D56692

--HG--
extra : moz-landing-system : lando
2019-12-13 14:21:20 +00:00
Nicolas Chevobbe
adb3042270 Bug 1566850 - Remove target.activeConsole usage in WebConsole. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D56691

--HG--
extra : moz-landing-system : lando
2019-12-13 14:04:46 +00:00
Nicolas Chevobbe
b4cd01d457 Bug 1566850 - Remove target.activeConsole usage in Debugger. r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D56690

--HG--
extra : moz-landing-system : lando
2019-12-13 14:02:55 +00:00
Nicolas Chevobbe
5737a86acf Bug 1566850 - Remove target.activeConsole usage in Netmonitor. r=Honza.
Differential Revision: https://phabricator.services.mozilla.com/D56689

--HG--
extra : moz-landing-system : lando
2019-12-13 14:01:18 +00:00
Nicolas Chevobbe
38fc79b020 Bug 1566850 - Remove target.activeConsole usage in tests. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D56688

--HG--
extra : moz-landing-system : lando
2019-12-13 13:58:54 +00:00
Nicolas Chevobbe
753e89f48e Bug 1566850 - Remove target.activeConsole usage in DOM panel. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D56686

--HG--
extra : moz-landing-system : lando
2019-12-13 13:55:46 +00:00
Boris Zbarsky
6639140a09 Bug 1603806. Add a blocking reason when loads with the SEC_REQUIRE_SAME_ORIGIN_* security flags are blocked due to not being same-origin. r=ckerschb,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D57147

--HG--
extra : moz-landing-system : lando
2019-12-16 09:36:45 +00:00
Csoregi Natalia
dc9d562004 Backed out changeset d09d8fa3332f (bug 1438979) for failures on browser_webconsole_network_messages_expand_before_updates.js. CLOSED TREE 2019-12-16 15:43:57 +02:00
Thiago Arrais
72fef7b640 Bug 765651 - Fix console protocol for ws connections. r=Honza,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D56965

--HG--
extra : moz-landing-system : lando
2019-12-16 11:42:01 +00:00
Daisuke Akatsuka
039838c924 Bug 1578753: Add a test for top-level target switing. r=jdescottes,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D56705

--HG--
extra : moz-landing-system : lando
2019-12-16 10:18:07 +00:00
Daisuke Akatsuka
daf33e67cf Bug 1578753: Reflect the switching of the top-level target. r=jdescottes,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D56704

--HG--
extra : moz-landing-system : lando
2019-12-16 10:16:05 +00:00
Daisuke Akatsuka
5bcf346ce2 Bug 1578753: Use the current target of TargetList. r=jdescottes,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D56703

--HG--
extra : moz-landing-system : lando
2019-12-16 10:15:58 +00:00
Nicolas Chevobbe
37f504d78f Bug 1438979 - Re-enable browser_webconsole_network_messages_expand.js. r=Honza.
The test is split in two to make it easier to read.

Differential Revision: https://phabricator.services.mozilla.com/D56884

--HG--
extra : moz-landing-system : lando
2019-12-16 10:13:39 +00:00
Csoregi Natalia
efccf499c7 Backed out changeset e1ef71575321 (bug 1438979) for failures on browser_webconsole_stubs_network_event.js. CLOSED TREE 2019-12-16 11:51:18 +02:00
Oriol Brufau
78ab5f5552 Bug 1603962 - Add comment explaining why addJsonViewTab races two load promises. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D57204

--HG--
extra : moz-landing-system : lando
2019-12-16 09:03:36 +00:00
Nicolas Chevobbe
4daf948695 Bug 1438979 - Re-enable browser_webconsole_network_messages_expand.js. r=Honza.
The test is split in two to make it easier to read.

Differential Revision: https://phabricator.services.mozilla.com/D56884

--HG--
extra : moz-landing-system : lando
2019-12-16 07:57:40 +00:00
Julian Descottes
021cb66c83 Bug 1602727 - Fix DevTools destroyer patterns r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D56527

--HG--
extra : moz-landing-system : lando
2019-12-15 21:07:59 +00:00
Brad Werth
f75b1c5a9a Bug 1595092 Part 2: Update an existing RDM content size test to test against the new RDM UI. r=mtigley
Depends on D56979

Differential Revision: https://phabricator.services.mozilla.com/D57144

--HG--
extra : moz-landing-system : lando
2019-12-13 19:25:43 +00:00
Brad Werth
34532dab1e Bug 1595092 Part 1: Make new RDM UI size the content pane with content-box. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D56979

--HG--
extra : moz-landing-system : lando
2019-12-13 19:22:02 +00:00
Kris Maglione
39d7eb39ed Bug 1596918: Part 4g - Misc cleanup/fixes. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D53748

--HG--
extra : moz-landing-system : lando
2019-12-13 20:36:48 +00:00
Kris Maglione
295e55e227 Bug 1596918: Part 4d - Fix callers which try to return non-clonable values. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D53745

--HG--
extra : moz-landing-system : lando
2019-12-13 20:36:37 +00:00
Kris Maglione
0b1a146519 Bug 1596918: Part 4c - Fix callers which depend on document lifecycle changes. r=mccr8
ContentTask tasks have a different lifetime than SpecialPowers tasks, with the
former being tied to the lifetime of a message manager and the latter tied to
the lifetime of a window global. That means that existing ContentTask callers
which expect to be able to register load listeners before the creation of a
window global, or which expect to persist after a page has navigated, won't
work as SpecialPowers tasks.

Since those sorts of tasks are not really resilient in the face of Fission,
they should really be written to work differently, but this patch mostly just
reverts them to using ContentTask for the time being.

Differential Revision: https://phabricator.services.mozilla.com/D53744

--HG--
extra : moz-landing-system : lando
2019-12-13 20:36:36 +00:00
Kris Maglione
90bbf045db Bug 1596918: Part 4a - Re-add eslint-disable comments removed by rewrite. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D53742

--HG--
extra : moz-landing-system : lando
2019-12-13 20:36:25 +00:00
Kris Maglione
9853440599 Bug 1596918: Part 3b - Run code formatters on files changed by previous patch. r=mccr8,remote-protocol-reviewers,ato
Differential Revision: https://phabricator.services.mozilla.com/D53741

--HG--
extra : moz-landing-system : lando
2019-12-13 20:36:24 +00:00
Kris Maglione
94e3b0bd8d Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740

--HG--
extra : moz-landing-system : lando
2019-12-13 20:36:16 +00:00
Boris Zbarsky
ee1cc488f2 Bug 1602483 part 2. Add a window id argument to CheckLoadURIWithPrincipal. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D56428

--HG--
rename : devtools/client/webconsole/test/browser/browser_webconsole_same_origin_errors.js => devtools/client/webconsole/test/browser/browser_webconsole_checkloaduri_errors.js
rename : devtools/client/webconsole/test/browser/test-same-origin-required-load.html => devtools/client/webconsole/test/browser/test-checkloaduri-failure.html
extra : moz-landing-system : lando
2019-12-12 16:41:19 +00:00
Boris Zbarsky
cbc90e1aca Bug 1602090 part 2. Create separate CheckMayLoad and CheckMayLoadWithReporting APIs. r=ckerschb
CheckMayLoadAndReport takes a window ID.  This allows us to report
errors from it to the web console as needed.  Most consumers know statically
whether they want reporting or not, so there's no reason to force the ones that
don't to provide window ids.

Differential Revision: https://phabricator.services.mozilla.com/D56388

--HG--
extra : moz-landing-system : lando
2019-12-13 06:24:12 +00:00
Brad Werth
a226876281 Bug 1579178 Part 4: Update test functions and an existing zoom test to work with new RDM UI. r=mtigley
This patch does several related things:
1) Updates the test helper functions in ui.js to make them sensible
for both the old and new RDM UI.
2) Updates the test helper function addRDMTask to return the correct
"browser" values for both RDM UIs. Old RDM UI tests that want to
spawn a content task should now use ui.getViewportBrowser() for that,
and only use the browser value for getting/setting of zoom and any
other methods that take browsers as arguments.
3) Updates the test helper function promiseRDM to make it wait on
the correct event.
4) Updates a non-zoom test that uses addRDMTask to use the new
browser value correctly.
5) Updates a zoom test to use the addRDMTask function, and therefore
run the test using the new RDM UI. This test exercises the issue
that is the focus of this bug.

Differential Revision: https://phabricator.services.mozilla.com/D56510

--HG--
extra : moz-landing-system : lando
2019-12-13 19:13:00 +00:00
Brad Werth
21a5598360 Bug 1579178 Part 3: Remove the old RDM UI method for save-and-restore of resolution for full zoom changes. r=mtigley
The firing of the "ZoomComplete" event is no longer necessary, now
that ZoomParent fires a "PostFullZoomChange" event, which serves a
similar purpose. The next part of the patch listens for that event.

Differential Revision: https://phabricator.services.mozilla.com/D56509

--HG--
extra : moz-landing-system : lando
2019-12-13 19:12:55 +00:00
Brad Werth
d4e3fa3cf8 Bug 1579178 Part 1: Make RDM new browser ui change viewport size in response to zoom. r=mtigley
Because the new RDM UI does not retain the width and height of the
device, this patch extracts those values from the prefs which are
updated in the viewports reducer. There probably should be a more
resilient way to maintain those values.

Differential Revision: https://phabricator.services.mozilla.com/D54379

--HG--
extra : moz-landing-system : lando
2019-12-13 19:11:15 +00:00
Micah Tigley
2d2c2562ac Bug 1598893 - Add check for elements absolutely positioned within a grid container. r=pbro,miker,Oriol
This revision introduces a check for whether or not grid-item properties have an affect on an “absolutely-positioned” grid element. It’s important to note this grid element is not necessarily a grid item, it just needs to be contained within a grid container that generates its containing block. The general algorithm for this is to first check whether or not the element is either `position: fixed` or `position: absolute` then find an ancestor grid element that generates its containing block.

To help DevTools identify such an element,  InspectorUtils provides an API called `containingBlockOf` that returns the absolutely-positioned element’s containing block. If the element’s containing block is the viewport, then this method returns null. For now, `containingBlockOf` is designed for absolute/fixed positioned elements. So it’s important to be aware that trying to use it for other purposes might return unexpected results.

This revision also adds/updates tests that check whether or not grid-item properties are active on a grid element.

Differential Revision: https://phabricator.services.mozilla.com/D55400

--HG--
extra : moz-landing-system : lando
2019-12-13 17:47:02 +00:00
Jason Laster
7079ed7803 Bug 1603698 - Omniscient Browser Toolbox error "this._stopThreadFrontListeners is not a function". r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D57135

--HG--
extra : moz-landing-system : lando
2019-12-13 16:55:19 +00:00
Julian Descottes
1676f649b6 Bug 1603366 - Rename the Main process target in about:debugging when Multiprocess toolbox is enabled r=ladybenko,fluent-reviewers,flod
Depends on D56877

Differential Revision: https://phabricator.services.mozilla.com/D56914

--HG--
extra : moz-landing-system : lando
2019-12-13 12:02:31 +00:00
Julian Descottes
55cb60a6e3 Bug 1603366 - Rename Omniscient browser toolbox to Multiprocess Browser Toolbox and support localization r=pbro,flod
Differential Revision: https://phabricator.services.mozilla.com/D56877

--HG--
extra : moz-landing-system : lando
2019-12-12 15:00:20 +00:00
Belén Albeza
cbb88fbdce Bug 1603087 - Disable test when parent_intercept is false r=jdescottes
Since `parent_intercept` requires to be set from the beginning, either we disable the test when it's not the case, or we force the pref to be flipped for this test… I chose the former, but happy to do the latter if it's preferable.

Differential Revision: https://phabricator.services.mozilla.com/D56762

--HG--
extra : moz-landing-system : lando
2019-12-12 12:56:01 +00:00
shindli
1cfffc2672 Backed out 8 changesets (bug 1566850, bug 1603035) for causing perma bc failures in browser/components/extensions/test/browser/browser_ext_devtools_inspectedWindow.js CLOSED TREE
Backed out changeset da1672f831d1 (bug 1566850)
Backed out changeset b3aea303d3ed (bug 1566850)
Backed out changeset 3c8ef35fde92 (bug 1566850)
Backed out changeset 4deadf97378f (bug 1566850)
Backed out changeset 55ac64d74725 (bug 1566850)
Backed out changeset 33c4706a4255 (bug 1566850)
Backed out changeset 1796a39b020b (bug 1566850)
Backed out changeset ae02ae71f846 (bug 1603035)
2019-12-13 12:50:45 +02:00
Julian Descottes
625d25aee8 Bug 1602371 - Rename LocalTabTargetFront tab getter to localTab r=ochameau
Depends on D56330

Renaming the "tab" getter to "localTab" will make it easier to refactor later.

Differential Revision: https://phabricator.services.mozilla.com/D56331

--HG--
extra : moz-landing-system : lando
2019-12-13 10:38:07 +00:00
Julian Descottes
eebe135d8e Bug 1602371 - Remove csp and contentPrincipal getters in LocalTabTargetFront r=ochameau
Depends on D56327. Not reason to make target-mixin more complex for this workaround which already has access to the tab object.

Differential Revision: https://phabricator.services.mozilla.com/D56330

--HG--
extra : moz-landing-system : lando
2019-12-13 10:00:25 +00:00
Nicolas Chevobbe
74eeee21f6 Bug 1566850 - Remove target.activeConsole usage in Toolbox. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D56692

--HG--
extra : moz-landing-system : lando
2019-12-13 09:15:17 +00:00
Nicolas Chevobbe
2fa7a9ac6b Bug 1566850 - Remove target.activeConsole usage in WebConsole. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D56691

--HG--
extra : moz-landing-system : lando
2019-12-13 09:13:58 +00:00
Nicolas Chevobbe
6865c4f4be Bug 1566850 - Remove target.activeConsole usage in Debugger. r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D56690

--HG--
extra : moz-landing-system : lando
2019-12-13 09:13:02 +00:00
Nicolas Chevobbe
684b113226 Bug 1566850 - Remove target.activeConsole usage in Netmonitor. r=Honza.
Differential Revision: https://phabricator.services.mozilla.com/D56689

--HG--
extra : moz-landing-system : lando
2019-12-13 09:11:44 +00:00
Nicolas Chevobbe
018643b9e6 Bug 1566850 - Remove target.activeConsole usage in tests. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D56688

--HG--
extra : moz-landing-system : lando
2019-12-13 09:10:33 +00:00
Nicolas Chevobbe
1df3816fb1 Bug 1566850 - Remove target.activeConsole usage in DOM panel. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D56686

--HG--
extra : moz-landing-system : lando
2019-12-13 09:09:01 +00:00
Nicolas Chevobbe
948806d70b Bug 1602974 - Catch errors while setting console history to prevent test failures. r=Honza.
Some tests are failing on Linux ccov when adding
item to the webconsole history. I suspect it could
be because some expression have emojis, but I'm
not sure.
Catching the rejection will at least not make the
test fail.

Differential Revision: https://phabricator.services.mozilla.com/D56744

--HG--
extra : moz-landing-system : lando
2019-12-13 07:54:08 +00:00