This patch uses the favicons as actually served by the sites. I tried to get 32x32 versions where possible, but a few are smaller and larger. There's also a mix of .ico and .png. I think the inconsistency is acceptable, and even desirable, seeing as these are the actual icons that would appear in the UrlbarView should they appear in the user's frecency results.
Differential Revision: https://phabricator.services.mozilla.com/D60421
--HG--
extra : moz-landing-system : lando
Automatic update from web-platform-tests
Replace some assert_throws('Something', stuff) calls with assert_throws_dom. (#21392)
This diff was generated by running:
find . -type f -print0 | xargs -0 perl -pi -e "BEGIN { \$/ = undef; } s/assert_throws\(([ \n]*'[A-Za-z_]*') *(, *.)/assert_throws_dom(\1\2/gs"
in bash (doesn't work in tcsh, due to the $ inside "").
This does affect indentation poorly in cases when the first arg was on the same
line as the assert_throws, there was a newline after the ',' after the first
arg, and the following args were lined up with the first arg. Fixing that,
especially when there are multiple lines after the first arg, is not trivial
with a regexp.
Co-authored-by: Boris Zbarsky <bzbarsky@mit.edu>
--
wpt-commits: d5103044974ae41deb6e099649d7520c374aa36b
wpt-pr: 21392
Automatic update from web-platform-tests
Replace some more "assert_throws(new FooError(), stuff)" calls with assert_throws_js or assert_throws_dom. (#21380)
This diff was generated by running:
find . -type f -print0 | xargs -0 perl -pi -e 'BEGIN { $/ = undef; } s/assert_throws\(([ \n]*)new ([A-Za-z]*Error) *\(\) *(, *.)/assert_throws_js(\1\2\3/gs'
on the relevant files and then:
1) Manually fixing up "assert_throws_js(SyntaxError, ...)" to be 'assert_throws_dom("SyntaxError", ...).
2) Changing kv-storage/interface.https.html to get TypeError from the same global as the object it's testing.
Note: these are the files which had changes to them reverted as part
of landing <https://github.com/web-platform-tests/wpt/pull/21354>.
The two manual fixups there address the issues that led to the revert.
--
wpt-commits: 9940584f86638e9e558928d0a5fc7266f1848cec
wpt-pr: 21380
Automatic update from web-platform-tests
Replace some assert_throws("Something", stuff) calls with assert_throws_dom. (#21377)
This diff was generated by running:
find . -type f -print0 | xargs -0 perl -pi -e 'BEGIN { $/ = undef; } s/assert_throws\(([ \n]*"[A-Za-z_]*") *(, *.)/assert_throws_dom(\1\2/gs'
followed by a fix to
xhr/resources/send-after-setting-document-domain-window-helper.js to make
xhr/send-after-setting-document-domain.htm pass.
This does affect indentation poorly in cases when the first arg was on the same
line as the assert_throws, there was a newline after the ',' after the first
arg, and the following args were lined up with the first arg. Fixing that,
especially when there are multiple lines after the first arg, is not trivial
with a regexp.
Co-authored-by: Boris Zbarsky <bzbarsky@mit.edu>
--
wpt-commits: 3696f2233a37437896505b7187968aa605be9255
wpt-pr: 21377
Automatic update from web-platform-tests
Replace some "assert_throws({'name': 'domerror'}, stuff)" with assert_throws_dom. (#21390)
This diff was generated by running:
find . -type f -print0 | xargs -0 perl -pi -e "BEGIN { \$/ = undef; } s/assert_throws\(([ \n]*)\{ *[\"']?name[\"']? *: *(['\"](?:InvalidStateError|SyntaxError|NotSupportedError|DataError|SecurityError)[\"']) *\} *(, *.)/assert_throws_dom(\1\2\3/gs"
in bash (doesn't work in tcsh, due to the $ inside "").
Co-authored-by: Boris Zbarsky <bzbarsky@mit.edu>
--
wpt-commits: a20f9f34f30dea66683c656b9a6561a8d4b474a0
wpt-pr: 21390
Automatic update from web-platform-tests
Add nsatragno to webauthn reviewers list
--
wpt-commits: bf9b18d3a7de81ce0308af1c74c47d811083ca29
wpt-pr: 20619
Automatic update from web-platform-tests
Remove assert_throws use in html tests. (#21385)
--
wpt-commits: 93ee31309acd4081e5da8f4f020664f9cecb90f3
wpt-pr: 21385
Automatic update from web-platform-tests
Remove assert_throws use in custom elements tests (#21382)
--
wpt-commits: a2175cc3a07e1de1e9d09df99a09ab60e954d9dc
wpt-pr: 21382
Automatic update from web-platform-tests
Replace some "assert_throws(FooError(), stuff)" calls with assert_throws_js. (#21378)
This diff was generated by running:
find . -type f -print0 | xargs -0 perl -pi -e 'BEGIN { $/ = undef; } s/assert_throws\(([ \n]*)([A-Za-z]*Error) *\(\) *(, *.)/assert_throws_js(\1\2\3/gs'
and then:
1) Manually editing dom/nodes/Element-matches.js to get the TypeError
constructor from the element's global.
2) Manually editing dom/nodes/ParentNode-querySelector-All.js to get the
TypeError constructor from root's global, whether "root" is a Document or some
other kind of node.
Co-authored-by: Boris Zbarsky <bzbarsky@mit.edu>
--
wpt-commits: f06523527a0735d23879f4e687d6efc095f780b7
wpt-pr: 21378
Automatic update from web-platform-tests
Use assert_precondition in ElementTiming/LargestContentfulPaint
This CL replaces assert_unreached for assert_precondition for the API
existence checks in the ElementTiming and LargestContentfulPaint WPTs.
Change-Id: Icd2ff3e045835cf4c46a370a384455143a717308
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013863
Reviewed-by: Tom McKee <tommckee@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734494}
--
wpt-commits: bd2c0495a860571b7467989e89dd51ebad4f9562
wpt-pr: 21326
Automatic update from web-platform-tests
Add tests of the recalculation of 'ch' in pseudo elements
Length unit 'ch' should be recalculated after loading a web font. This
patch is a followup of crrev.com/c/1972815 to ensure that it's also
recalculated in pseudo elements.
Bug: 441925
Change-Id: Ie62dba854aa9d1beb6b9a734f31760abf1acd040
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016198
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734495}
--
wpt-commits: 025c749a21b0fd0c9bd758cc33c7ff3e122073de
wpt-pr: 21362
Automatic update from web-platform-tests
Replace some "assert_throws({'name': 'jserror'}, stuff)" with assert_throws_js. (#21379)
This diff was generated by running:
find . -type f -print0 | xargs -0 perl -pi -e "BEGIN { \$/ = undef; } s/assert_throws\(([ \n]*)\{ *[\"']?name[\"']? *: *['\"](TypeError|Error)[\"'] *\} *(, *.)/assert_throws_js(\1\2\3/gs"
in bash (doesn't work in tcsh, due to the $ inside "") and then manually
changing service-workers/service-worker/ServiceWorkerGlobalScope/resources/extendable-message-event-constructor-worker.js
to use assert_throws_exactly in a few places where we want to verify that
specific exception values are propagated out.
Co-authored-by: Boris Zbarsky <bzbarsky@mit.edu>
--
wpt-commits: b0daaa6b86c3dc2f9c16aa362136655c0db7308b
wpt-pr: 21379
Automatic update from web-platform-tests
SharedWorker: Add meta.url WPT for SharedWorker with type 'module' (#21333)
This CL adds a web platform test for checking the behavior of
|import.meta.url| in SharedWorker when the script type is set to module.
Bug: 824646
Change-Id: Ifaa34e238fe0a432137c5e8213e81610249b7e79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014355
Commit-Queue: Eriko Kurimoto <elkurin@google.com>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734387}
--
wpt-commits: 380eb46722a1945770c4df9bd00ea0ea77868d0b
wpt-pr: 21333
Automatic update from web-platform-tests
Replace some "assert_throws(new FooError(), stuff)" calls with assert_throws_js. (#21354)
This diff was generated by running:
find . -type f -print0 | xargs -0 perl -pi -e 'BEGIN { $/ = undef; } s/assert_throws\(([ \n]*)new ([A-Za-z]*Error) *\(\) *(, *.)/assert_throws_js(\1\2\3/gs'
and then:
1) Manually adjusting fullscreen/rendering/fullscreen-pseudo-class-support.html
to test for the right sort of exceptions ("SyntaxError" DOMException, not a JS
SyntaxError).
2) Manually adjusting performance-timeline/po-observe-type.any.js to test for
the right sort of exceptions ("SyntaxError" DOMException, not a JS
SyntaxError).
3) Manually adjusting performance-timeline/po-observe.any.js to test for
the right sort of exceptions ("SyntaxError" DOMException, not a JS
SyntaxError).
4) Manually adjusting user-timing/mark_exceptions.html to test for the right
sort of exceptions ("SyntaxError" DOMException, not a JS SyntaxError).
5) Manually adjusting user-timing/measure_syntax_err.any.js to test for the right
sort of exceptions ("SyntaxError" DOMException, not a JS SyntaxError).
6) Manually adjusting domxpath/lexical-structure.html to test for a
"SyntaxError" DOMException, since that's what all browsers throw and there is no
clear spec for this.
7) Manually adjusting workers/constructors/Worker/Worker-constructor.html to
test for the right sort of exceptions ("SyntaxError" DOMException, not a JS
SyntaxError).
8) Backing out the changes to resources/idlharness.js because some tests pass
objects from a different window to it, and we end up with the wrong TypeError
constructor in those cases.
This does affect indentation poorly in cases when the first arg was on the same
line as the assert_throws, there was a newline after the ',' after the first
arg, and the following args were lined up with the first arg. Fixing that,
especially when there are multiple lines after the first arg, is not trivial
with a regexp.
Co-authored-by: Boris Zbarsky <bzbarsky@mit.edu>
Co-authored-by: Stephen McGruer <smcgruer@chromium.org>
--
wpt-commits: 2c5c3c4c27d27a419c1fdba3e9879c2d22037074
wpt-pr: 21354
Automatic update from web-platform-tests
Change COEP tests relying on onload events for network errors to use a timeout instead (#21344)
--
wpt-commits: 2f39e90ef46a0aeaf2ac7e769f0478bb5882dfed
wpt-pr: 21344
Automatic update from web-platform-tests
[FlexNG] Use previous constraint space for layout roots.
Devtools had an issue where elements were sized at 0px height.
This was caused by the relayout boundary logic not working correctly.
In Devtools these elements had layout and size containment triggering
ObjectIsRelayoutBoundary() to return true.
The call to NGConstraintSpace::CreateFromLayoutObject for this flex-item
was incorrect as it wasn't using the stretched size (as we don't
set HasOverrideLogicalWidth(), etc).
This refactors the various callers of
NGConstraintSpace::CreateFromLayoutObject and create a new method
UpdateInFlowBlockLayout which contains the previously (duplicated)
logic.
This new method will try and use the previous constraint space (if
it is a layout root), instead of creating it.
Bug: 845235
Change-Id: I52ddb9d58ae010305b980657bb434a30d5b7fbbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010983
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734420}
--
wpt-commits: fb09ccb613400a3a0327967063cb1117cea96468
wpt-pr: 21308
Automatic update from web-platform-tests
Add more reviewers to tools/META.yml (#21346)
--
wpt-commits: 3eef88a45f57eac659b9f4ea8c1b56031cae8842
wpt-pr: 21346
Automatic update from web-platform-tests
SharedWorker: Fix the wrong WPT undefined-arguments.html (#21365)
The worker's name must be |''| in this test.
According to the spec, the default value of WorkerOptions (which is the
second argument of SharedWorker) is set as follows:
dictionary WorkerOptions {
WorkerType type = "classic";
RequestCredentials credentials = "same-origin";
DOMString name = "";
};
spec:https://html.spec.whatwg.org/multipage/workers.html#workeroptions
Here, name property is set to an empty string.
Therefore, the worker's name must be an empty string when the second
argument is |undefined|.
Bug:907749
Change-Id: I5bc9c5afcf76beae1e3924661b2ea65fad5efe1d
--
wpt-commits: 49cf4238f4f963392a17d5b9a81e347a1bfd3aa9
wpt-pr: 21365
Automatic update from web-platform-tests
Python3: replace the usage of ConfigParser with six.moves.configparser (#21373)
--
wpt-commits: c6c0f5b802ad7f3fa5ca9f749984dfa6c0ded2d8
wpt-pr: 21373
Automatic update from web-platform-tests
Add --py3 parameter to run wpt commands using python3 (#21372)
--
wpt-commits: 73a4d68c2639d6d8eed846510f0777200d4e95e5
wpt-pr: 21372
Automatic update from web-platform-tests
[IntersectionObserver] Allow Document argument to constructor
This implements a behavioral change as described in:
https://github.com/w3c/IntersectionObserver/issues/372
If the 'root' argument to the IntersectionObserver constructor is a
Document, then the observer will clip to the Document's root
scroller. For the top Document, this is the same behavior as the
implicit root. For an iframe Document, this is new behavior which is
unobtainable by other means.
BUG=1015183
Change-Id: I234bfce28ab954bb15b8d157bc22ee2d2469d5e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003750
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734268}
--
wpt-commits: aebf5e72a429c448637c388512bcadd4d4e3fa65
wpt-pr: 21222
Automatic update from web-platform-tests
CookieStore: Fix Flaky WPT Test for getSubscriptions
This test fails because the cleanup to "unsubscribe" cookies would
occur after the registration has already been unregistered for
non-workers. This change removes the cleanup to "unsubscribe" and
just relies on "unregister" for cleanup.
The flaky failures can be reproduced locally using the following gn args
and commandline. (Googlers: http://screen/E7px76cVS2E)
gn args:
dcheck_always_on = true
ffmpeg_branding = "Chrome"
is_component_build = false
is_debug = false
mac_deterministic_build = true
proprietary_codecs = true
symbol_level = 1
use_goma = true
command: python third_party/blink/tools/run_web_tests.py -t LinuxTest third_party/blink/web_tests/external/wpt/cookie-store/cookieStoreManager_getSubscriptions_multiple.tentative.https.any.js --gtest_repeat=20
Bug: 1029713
Change-Id: Ifa766b974bddfcc6ee43e60be0766c1cb80cb742
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014100
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734193}
--
wpt-commits: b3e087acabf346e7013a5a8182a5a4bf8b94b453
wpt-pr: 21351
Automatic update from web-platform-tests
[WPT/common/security-features] Support sub projects and split referrer-policy 4K tests (#21217)
This CL implements the support for sub projects in common/security-features infra,
to support similar but slightly different generated tests.
See README.md changes for how it works.
Particularly, this CL implements logics to read and merge multiple `spec.src.json`s,
and include multiple `test-case.sub.js` in generated tests.
By using sub projects, this CL split referrer-policy tests for
4KB referrer policy length limitations into separate generated files under
e.g. `referrer-policy/4K/gen/`.
Previously, the 4KB limit tests are done within the same files as
the main referrer-policy tests. They required multiple forward and back
navigations via `history.replaceState` and `history.back`
within a single generated test,
and this hit race conditions and interoperability issues,
especially around `history.back` navigations + `<iframe>` navigations.
After this CL, only one forward navigation occurs per one test file.
This CL doesn't affect existing generated files, because they
don't use sub projects.
The newly generated files under `referrer-policy/4K*` will be added by
https://chromium-review.googlesource.com/c/chromium/src/+/1993003/.
Bug: 906850
Change-Id: Ic2d3de0492b097adf293f55ebcbe4690065e4ba8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991066
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733185}
Co-authored-by: hiroshige-g <hiroshige@google.com>
--
wpt-commits: 114f1774a546adc8d69b24c716902dcc203a1240
wpt-pr: 21217
Automatic update from web-platform-tests
Fix and refactor some "handleEvent" tests
* Make sure "handleEvent" property is looked up
* Extract `uncaught_error_test` helper
WebKit issue: https://bugs.webkit.org/show_bug.cgi?id=203288
Follow-up of #15105 and #20401.
--
wpt-commits: 3d6cd8f7c405fb732d05822763b0331f109821d4
wpt-pr: 21186
Automatic update from web-platform-tests
Fire "load" event at <style> when textContent changes
Prior to this CL, the load event was not being fired when the
textContent of a <style> element was changed, contrary to the
spec ([1]). Now, the load event is fired in this case.
Note that when textContent is changed, per spec [2], the children
changed steps are run. This first removes the existing <style>
contents, which once complete, fires a "load" event. Then the new
<style> contents are parsed, after which another "load" event is
fired. So in the example of 674518, two load events will now be
fired when the style is changed.
[1] https://html.spec.whatwg.org/multipage/semantics.html#update-a-style-block
[2] https://dom.spec.whatwg.org/#concept-node-children-changed-ext
Fixed: 674518
Change-Id: Idb0ddb9f0ca2478a8a35d06817928503e74fa3fb
Bug: 674518
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011133
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734147}
--
wpt-commits: ef6f3f030261b545af4734d9cdb6b64b3fb18e39
wpt-pr: 21327