The [persist] attribute requires the element has an id, so it was failing to remember
screenX and screenY for the dialog before this change.
Depends on D63233
Differential Revision: https://phabricator.services.mozilla.com/D63236
--HG--
extra : moz-landing-system : lando
This error has been present since the initial landing in Bug 1523696.
This is unrelated to the fix in the next patch, just something I noticed when debugging it.
Differential Revision: https://phabricator.services.mozilla.com/D63233
--HG--
extra : moz-landing-system : lando
Replace ElementOrCSSPseudoElement with Element and add PseudoElement (which is
a DOMString) into KeyframeAnimationOptions and KeyframeEffect.
Differential Revision: https://phabricator.services.mozilla.com/D62667
--HG--
extra : moz-landing-system : lando
In order to store the different combinations of (Element, PsuedoStyleType)
pairs, including (nullptr, ::before/::after), we drop Maybe<> and use
OwningAnimationTarget directly.
Differential Revision: https://phabricator.services.mozilla.com/D62666
--HG--
extra : moz-landing-system : lando
Test is also re-run when sanity-test.webrender.force-disabled pref is updated.
Gfx sanity test does hardware decoded video rendering check and Advanced Layers check. hardware video decoding has already controlled by blacklist. And when WebRender is used, Advanced Layers could be disabled as fallback candidate. Then when WebRender is used, gfx sanity test could be skipped.
Differential Revision: https://phabricator.services.mozilla.com/D63125
--HG--
extra : moz-landing-system : lando
This data was recorded for releases 52-57 when the remote decoding process
mechanism was developed. Enable it again to monitor the data and see if
stagefright still crashes in recent Android versions. If it's no longer the
case, we might deprecate out-of-process decoder and save some IPC overhead.
Differential Revision: https://phabricator.services.mozilla.com/D63257
--HG--
extra : moz-landing-system : lando
Now that shippable macOS builds have PGO+LTO enabled, it is not
necessary to build the normal macOS builds with LTO enabled.
Differential Revision: https://phabricator.services.mozilla.com/D62873
--HG--
extra : moz-landing-system : lando
LTO was enabled on Android back when the normal Android builds were the
ones we shipped. But now we have separate builds for what is shipped,
*and* they do PGO+LTO.
Differential Revision: https://phabricator.services.mozilla.com/D62872
--HG--
extra : moz-landing-system : lando
2020-02-18 Kevin Jacobs <kjacobs@mozilla.com>
* gtests/ssl_gtest/ssl_extension_unittest.cc,
gtests/ssl_gtest/ssl_version_unittest.cc, lib/ssl/dtlscon.c,
lib/ssl/tls13con.c, lib/ssl/tls13con.h, lib/ssl/tls13exthandle.c:
Bug 1615208 - Send DTLS version numbers in DTLS 1.3
supported_versions extension r=mt
This patch modifies `supported_versions` encodings to reflect DTLS
versions when DTLS1.3 is use. Previously, a DTLS1.3 CH would include
`[0x7f1e, 0x303, 0x302]` instead of the expected `[0x7f1e, 0xfefd,
0xfeff]`, causing compatibility issues.
[9e0d34a6cf91] [tip]
2020-02-12 Mikael Urankar <mikael.urankar@gmail.com>
* lib/freebl/Makefile, lib/freebl/freebl.gyp:
Bug 1612177 - Set -march=armv7 when compiling gcm-arm32-neon, in
order to enable NEON code generation.
[4413841bd26d]
2020-02-14 Dmitry Baryshkov <dbaryshkov@gmail.com>
* gtests/freebl_gtest/blake2b_unittest.cc, lib/freebl/blake2b.c:
Bug 1431940 - remove dereference before NULL check in BLAKE2B code.
r=kjacobs
[5e661906698f]
2020-02-12 Kevin Jacobs <kjacobs@mozilla.com>
* gtests/ssl_gtest/ssl_resumption_unittest.cc, lib/ssl/sslnonce.c:
Bug 1614870 - Free sid->peerID before reallocating in
ssl_DecodeResumptionToken. r=mt
This patch adds a missing `PORT_Free()` when reallocating
`sid->PeerID`, and adds a test for a non-empty PeerID.
[1eb4e00b016e]
Differential Revision: https://phabricator.services.mozilla.com/D63220
--HG--
extra : moz-landing-system : lando
The other widget backends do not call resize during nsWindow creation and
there's not really a need to do it. The bounds can just be adjusted at the
beginning.
Differential Revision: https://phabricator.services.mozilla.com/D62613
--HG--
extra : moz-landing-system : lando
This allows `performAction` to immediately return false if a boundary is
reached and allow TalkBack to navigate past the web view.
Change viewport cache listener to reorder since it should catch all tree
mutations in the document.
Differential Revision: https://phabricator.services.mozilla.com/D63117
--HG--
extra : moz-landing-system : lando
Converting a shared buffer source to buffer souce type should
always throw if the type isn't annotated with [AllowShared].
Differential Revision: https://phabricator.services.mozilla.com/D63047
--HG--
extra : moz-landing-system : lando
GENERATED_FILES now defaults to python3 unless py2=True is specified as
an argument. All existing GENERATED_FILES scripts and GeneratedFile
templates have the py2=True attribute added, so this patch should
effectively be a no-op.
Going forward, individual scripts can be converted to python3 and their
corresponding py2=True attribute can be deleted. In effect, this patch
will be backed out in pieces until all scripts run in python3, at which
point the py2 attribute itself can be removed.
Differential Revision: https://phabricator.services.mozilla.com/D60919
--HG--
extra : moz-landing-system : lando
The default method implementations cause problems when trying to
override them with different types in a direct call class.
For the `Recv__delete__` case there's a simple solution: omit it if
there are any arguments, because it doesn't make much sense to specify
arguments and then completely ignore them, and the no-arg case isn't a
problem for overriding.
Differential Revision: https://phabricator.services.mozilla.com/D62977
--HG--
extra : moz-landing-system : lando
Automatic update from web-platform-tests
[css-pseudo] Fix text selection and drag-and-drop for pseudo-elements
Before this patch, if you had a tree like
<div><div::before>abc</div::before>def</div>
and you tried to select "bc", Chromium would end up selecting "ef" in
some cases. Similarly, trying to drag a text and drop it between "bc",
would end up inserting the text between "ef".
This patch fixes the problem, now trying to select "bc" won't select
anything. And dropping some text between "bc" will insert it between
the "cd".
BUG=1051685
TEST=external/wpt/css/css-pseudo/text-selection.html
TEST=fast/css-generated-content/drag-and-drop.html
The 2nd test is internal because I didn't manage to properly simulate
drag and drop using testdriver.js
Change-Id: Iedd594b46022ed434bdb1462232c717ec08f5304
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047287
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#741909}
--
wpt-commits: 410f5ece454de3f304f4ac885be244ed9755ac18
wpt-pr: 21808
Automatic update from web-platform-tests
Fix resources path in lazy load tests
When moving lazy load tests to html/semantics/embedded-content/the-img-element
the internal resources paths were not adjusted, so do it in this change.
--
wpt-commits: 0ffd3515e2a53c04c5465687153d77bc50328c86
wpt-pr: 21821
Automatic update from web-platform-tests
Use six.iteritems to iterate over dictionary's items in tools
This corresponds to dictionary.iteritems() on Python 2 and
dictionary.items() on Python 3.
--
wpt-commits: 70efafb7da25cb0c44beb95dfbb4198e80a557b9
wpt-pr: 21835
Automatic update from web-platform-tests
[WPT/mixed-content] Remove websocket + redirect tests
Redirects are forbidden (see Step 12 and the warning at the bottom:
https://fetch.spec.whatwg.org/#concept-websocket-establish ).
Previously, websocket + redirect tests were generated, but
their behavior was the same as websocket + no-redirect,
because the websocket subresource endpoint ignores
redirect-related parameters.
This CL removes such redundant tests.
Bug: 906850
Change-Id: I86be33d1812b4d16ba463f14320fb23369321cc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058707
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741851}
--
wpt-commits: 2d1c196b4bb245aa80b4fafe5824384fee386a82
wpt-pr: 21832
Automatic update from web-platform-tests
[WPT/common/security-features] Transition `spec.src.json` to JSON5
To allow inline comments in `spec.src.json` to make it more
descriptive, this CL parses `spec.src.json`s as JSON5,
using `json5` non-standard library.
After parsing, we still use `json` module for outputting
JSON objects.
Subsequent CLs e.g. [1] will actually add inline comments
to `spec.src.json`s.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/2049953
This CL doesn't change the generated results.
Bug: 906850, https://github.com/web-platform-tests/wpt/issues/21824
Change-Id: I8c6472b41ae55a051889fc29cf57d392ef60b69f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058706
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741850}
--
wpt-commits: 8205a7e07caf3606abed03306d5b51c0d688252a
wpt-pr: 21826
Automatic update from web-platform-tests
SharedWorker: Fire an error event when type or credentials mismatch
This CL adds the step to check if type and credentials values are same
with these of matched SharedWorkerGlobalScope before connecting to it.
This is just added to the spec.
Spec issue: https://github.com/whatwg/html/issues/5235
Pull request: https://github.com/whatwg/html/pull/5258
WPT: https://github.com/web-platform-tests/wpt/pull/21651
This changes the behavior, and WPT is already added from the public pull
requests to WPT GitHub:
wpt/workers/shared-worker-options-mismatch.html
In this CL, http/tests/workers/shared-worker-shared.html is modified.
Since the way to catch worker's error had changed, this test was no
longer catching the error properly. This test was attempting to create
SharedWorker with non-existing script url so ErrorEvent had been fired.
However, this test couldn't successfully catch ErrorEvent and this is
found out since the console error log added in this CL is printed as
"text diff". Fixing this test is out-of-scope, so this CL avoid this
console error by using an existing script url.
Bug: 1050438
Change-Id: I03232ff19db89560d99d3ddc6a25cdd8f1898222
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041386
Commit-Queue: Eriko Kurimoto <elkurin@google.com>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741848}
--
wpt-commits: 497675f53a9542bdb77c0640cd683e5990659a94
wpt-pr: 21795
Automatic update from web-platform-tests
Iterating over dictionary's items with six library for PY2 & PY3 compatibility.
--
wpt-commits: ef72cc2212e324334032148aea9169edf2562ef5
wpt-pr: 21822
Automatic update from web-platform-tests
[WPT/mixed-content] Flatten subresource types
To unify `spec.src.json`, this CL flattens subresource types
in `mixed-content/spec.src.json`, to match the structure with
other `spec.src.json`s.
A subsequent CL
https://chromium-review.googlesource.com/c/chromium/src/+/2049953
will actually merge some parts of `spec.src.json`s.
This CL doesn't change the generated results.
Bug: 906850
Change-Id: I38963dbc847b09fb314907e8d068232c15e7cffc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058705
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741847}
--
wpt-commits: b2331fccbc54f5b0a57d66190d30d40341cbc957
wpt-pr: 21823
Automatic update from web-platform-tests
Add new comprehensive test for image-set rendering (#21539)
* Add new comprehensive test for image-set rendering
* Use dpr 1 for now for test - no sufficient infra for DPR setting
--
wpt-commits: 1b7dcb06ea477226e90ca0fbc0b86262a410f7ad
wpt-pr: 21539
