Commit Graph

763736 Commits

Author SHA1 Message Date
Emanuel Krivoy
ac2a6dc542 Bug 1719906 [wpt PR 29625] - FSA: Add AccessHandleHost, a=testonly
Automatic update from web-platform-tests
FSA: Add AccessHandleHost

This CL adds the basic scaffolding for AccessHandleHost.
AccessHandleHost allows the renderer to notify the browser when an
access handle closes. Future CLs will use this functionality to create
exclusive write locks that prevent the creation of other access handles
or writables. AccessHandleHost will also eventually own the browser
side of the file delegate when in incognito mode.

For more context on this surface and the general objective of the merger
between Storage Foundation and OPFS, check out:
https://docs.google.com/document/d/1g7ZCqZ5NdiU7oqyCpsc2iZ7rRAY1ZXO-9VoG4LfP7fM

Bug: 1218431
Change-Id: I0f804bb08da96bd978e5899b68f55cf7501935b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3015198
Reviewed-by: Richard Stotz <rstz@chromium.org>
Reviewed-by: Austin Sullivan <asully@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Emanuel Krivoy <krivoy@google.com>
Cr-Commit-Position: refs/heads/master@{#902978}

--

wpt-commits: a8a36544812a1e9fa655820ae3361931c47559b7
wpt-pr: 29625
2021-07-20 19:18:52 +00:00
Chris Lord
93360e0b3d Bug 1721150 [wpt PR 29704] - Add Chris Lord as a suggested reviewer for OffscreenCanvas tests, a=testonly
Automatic update from web-platform-tests
Add Chris Lord as a suggested reviewer for OffscreenCanvas tests (#29704)

--

wpt-commits: d8899c277366e6960b0c564f76815f14dfd92cab
wpt-pr: 29704
2021-07-20 19:18:52 +00:00
moz-wptsync-bot
9fcf641093 Bug 1719853 [wpt PR 29618] - Update wpt metadata, a=testonly
wpt-pr: 29618
wpt-type: metadata
2021-07-20 19:18:51 +00:00
Ms2ger
e59ec95f7c Bug 1719853 [wpt PR 29618] - Improve tests for extra arguments to getContext()., a=testonly
Automatic update from web-platform-tests
Improve tests for extra arguments to getContext(). (#29618)

--

wpt-commits: 7f5aaca5709faad3f7cb40f79000028ddded078a
wpt-pr: 29618
2021-07-20 19:18:51 +00:00
Manuel Rego Casasnovas
99c890a510 Bug 1721116 [wpt PR 29699] - [css-ui] Added "checked" to accent-color test, a=testonly
Automatic update from web-platform-tests
[css-ui] Added "checked" to accent-color test

This test was comparing an unchecked checkbox
but you usually don't see the accent-color in that case.
This patch just marks it as "checked" so if accent-color applies
we'll see some difference.

--

wpt-commits: f9d5959e214985a0895943d8559ca62806e38ebf
wpt-pr: 29699
2021-07-20 19:18:50 +00:00
David Grogan
4785f59302 Bug 1721040 [wpt PR 29697] - [css-text] Make text-indent apply to anonymous flex and grid items, a=testonly
Automatic update from web-platform-tests
[css-text] Make text-indent apply to anonymous flex and grid items

There was a check that only allowed text-indent to apply to
anonymous blocks if they were the first child of the parent block.
That's exactly right for anonymous blocks that take part in a BFC and
surround inline content, but is overrestrictive for anonymous blocks
that take part in a flex or grid formatting context.

Fixed: 1159311
Change-Id: Id2d6909a30da9e8fe3de3b3058ffe630f180ff8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3036862
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#902884}

--

wpt-commits: 9c174dc5f5044609669af7bc28e35924ac02fbb4
wpt-pr: 29697
2021-07-20 19:18:50 +00:00
moz-wptsync-bot
80443ae8d1 Bug 1720805 [wpt PR 29682] - Update wpt metadata, a=testonly
wpt-pr: 29682
wpt-type: metadata
2021-07-20 19:18:49 +00:00
Mason Freed
3aa5e0fe72 Bug 1720805 [wpt PR 29682] - Fix a few bugs in declarative Shadow DOM cloning, a=testonly
Automatic update from web-platform-tests
Fix a few bugs in declarative Shadow DOM cloning

Previously, the cloning operation would fail if the declarative shadow
root was sufficiently nested (e.g. inside another <div> or inside a
nexted <template>). This CL fixes this bug, by passing through the
CloneChildrenFlag to all the places it's needed.

Two new test conditions are added for the two broken cases.

Fixed: 1229311
Change-Id: I3e1fe7e6075e1aa74ff753c66ee209bd08a8a29c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3033299
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#902843}

--

wpt-commits: eafef7e9e90735e4cc2e55d704e3cf6c3d0f8a2c
wpt-pr: 29682
2021-07-20 19:18:49 +00:00
Jamie Nicol
ebb76fd7e3 Bug 1719437 - Do not initialize shaders when creating SingletonGL for software webrender. r=aosmond
It leads to OpenGL errors, as we must initialize a webrender Device in
order to initialize the shaders, and this Device attempts to use
OpenGL commands not supported by the GL context. For example the GL
context may only support GLES 2, hence why we are using SWGL in the
first place.

Differential Revision: https://phabricator.services.mozilla.com/D120356
2021-07-20 19:10:58 +00:00
Ryan Hunt
b40ac20343 Bug 1720514 - wasm: Add framework for intrinsics with basic i8vecmul. r=jseward
This commit implements a framework for creating 'intrinsics' which are
natively implemented functions that are exposable as wasm functions
that can be called or linked against. A simple 8-bit vector product for
flexible vectors is implemented as a proof of concept.

The basic API is:
```
let module = wasmIntrinsicI8VecMul(); // WebAssembly.Module
let memory = new WebAssembly.Module({ initial: pageSize });
let instance = new WebAssembly.Instance(module,
  { "": { memory } });
instance.exports.i8vecmul(dest, src1, src2, len);
```

The implementation is mainly done through `CompileIntrisicModule` which
manually builds a ModuleEnvironment with an imported memory, and a single
exported function which is of the bytecode form:
```
(func (params ...)
  local.get 0
  ...
  local.get n
  private_intrinsic_opcode
)
```
The private_intrinsic_opcode is implemented as an instance call. An
additional heap base parameter is added which allows quick bounds
checking, similar to Instance::memory32Copy.

A followup will implement the intrinsic for the firefox
translations project.

Differential Revision: https://phabricator.services.mozilla.com/D119919
2021-07-20 19:05:59 +00:00
Stefan Zabka
9468e1cce4 Bug 1715499 - Display special dialogue for single base domain r=pbz,fluent-reviewers,preferences-reviewers,flod,Gijs,jaws
Differential Revision: https://phabricator.services.mozilla.com/D118729
2021-07-20 18:52:03 +00:00
stransky
699174544b Bug 1721023 [Wayland] Close display registry right after use, r=rmader
Don't keep reference to wl_registry object as we don't need that so release it right after use.

Differential Revision: https://phabricator.services.mozilla.com/D120129
2021-07-20 18:29:49 +00:00
stransky
dafa12b4b3 Bug 1718507 [Wayland] Implement nsWindow::GetWidgetScreen() by ScreenGetter on Wayland, r=jhorak
- Move screen getter initialization to ScreenGetterGtk::Init() to initialize it after a global object is created.
- Store screen list internally at ScreenGetterWayland to allow searching in it.
- Implement ScreenGetterWayland::GetMonitorForWindow() to get monitor/wl_output for nsWindow.
- Implement ScreenGetterWayland::GetScreenForWindow() to get screen where the window is placed.
- Implement ScreenGetterWayland::GetScreenRectForWindow() to get window screen rect.
- Do some more logging on ScreenHelperGTK.cpp

Differential Revision: https://phabricator.services.mozilla.com/D120056
2021-07-20 18:18:31 +00:00
stransky
ec88a58c27 Bug 1718507 [Wayland] Implement ScreenGetterWayland to get screen config on Wayland, r=jhorak
- Implement new ScreenGetterWayland() object and get screen/monitor configuration directly from Wayland.
- Use it at ScreenHelperGTK when runnin on Wayland
- Use LOG_SCREEN() macro for screen logging

Differential Revision: https://phabricator.services.mozilla.com/D118959
2021-07-20 18:18:30 +00:00
Bernard Igiri
75326296ea Bug 1710629 - Adjust bookmarks menu button panel padding r=mak
Modified bookmarks menu button panel padding in Windows and Linux to match the appearance of that panel in MacOS.

Differential Revision: https://phabricator.services.mozilla.com/D119643
2021-07-20 18:11:07 +00:00
Sean Feng
2aa145db40 Bug 1705141 - Implement imperative slotting API r=smaug,emilio
Differential Revision: https://phabricator.services.mozilla.com/D119444
2021-07-20 18:06:25 +00:00
Sean Feng
6b3d341c93 Bug 1705141 - Move the usage of SlotAssignedNodeChanged into (Insert|Append|Remove)AssignedNode functions r=smaug
According to our current usage, I don't see a case where we need to call
SlotAssignedNodeChanged without acutally moving the node. So this patch
just simpifies that behaviour.

Differential Revision: https://phabricator.services.mozilla.com/D119443
2021-07-20 18:06:25 +00:00
Sean Feng
b0a59f832a Bug 1705141 - Update tests ini settings for HTMLSlotElement::Assign r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D119441
2021-07-20 18:06:24 +00:00
Sean Feng
f00ee1f211 Bug 1705141 - Update imperative slotting API tests r=smaug
- Added a new test to ensure the assign slottables step is done in tree order
- Added a new assertion to a test

Differential Revision: https://phabricator.services.mozilla.com/D119442
2021-07-20 18:06:24 +00:00
Sean Feng
3f8d79934d Bug 1705141 - Fix an imperative slotting API test r=smaug
When the manual assigned node is moved to its original root, it should
be assigned again.

Differential Revision: https://phabricator.services.mozilla.com/D119645
2021-07-20 18:06:24 +00:00
Neil Deakin
30080e9d9a Bug 1721047, fix tooltip not appearing on bookmarks sidebar, r=mak
Differential Revision: https://phabricator.services.mozilla.com/D120271
2021-07-20 17:54:45 +00:00
Jonathan Kew
e4f80082a0 Bug 1717685 - Silently handle NOTHING_TO_DO as SUCCESS when replaying a recording, rather than asserting on it. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D119398
2021-07-20 17:43:31 +00:00
Jonathan Kew
90ced4b1e3 Bug 1721424 - Fix _cairo_strtod to accept a leading sign, avoiding infinite loop in parse_array. r=jrmuizel
This has been submitted upstream at https://gitlab.freedesktop.org/cairo/cairo/-/merge_requests/203.

Differential Revision: https://phabricator.services.mozilla.com/D120365
2021-07-20 17:42:20 +00:00
Emily McMinn
119339eff7 Bug 1709720 - Refactor multistage about_welcome tests and remove unused code r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D120097
2021-07-20 17:17:41 +00:00
Luca Greco
bb54b70d04 Bug 1721214 - ServiceWorkerManager RegisterForTest and RegisterForAddonPrincipal should return a rejected promise on invalid call parameters. r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D120254
2021-07-20 17:06:24 +00:00
Sandor Molnar
bc49b607ec Backed out changeset da1412413022 (bug 490136) for causing bc failures in sessionstore/test/browser_625016. CLOSED TREE 2021-07-20 20:04:22 +03:00
Alexandru Michis
ea1c530b9f Backed out changeset 04cfc5a3587f (bug 1721215) for causing eslint failures in screenshots.js
CLOSED TREE
2021-07-20 19:37:27 +03:00
Sebastian Hengst
5e64e39ac3 Bug 1718274 - don't run GTest on Windows Shippable. r=jmaher DONTBUILD
The rules to not run GTest for Windows Shippable didn't get updated when the
platform name got the '-qr' suffix in bug 1715515 and the gtest test bundle was
missing. The generation of the GTest bundle takes too long with Windows pgo
(see bug 1200311), hence it's kept disabled on these platforms.

Differential Revision: https://phabricator.services.mozilla.com/D120343
2021-07-20 16:30:35 +00:00
Andrew Osmond
be05f05157 Bug 1721407 - Explicitly block Mali 4xx for WR so that they get SW-WR by default. r=jnicol
Differential Revision: https://phabricator.services.mozilla.com/D120359
2021-07-20 16:22:20 +00:00
Emma Malysz
6025f76adc Bug 1721215, lazily load screenshots subscript r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D120255
2021-07-20 15:53:32 +00:00
Paul Zuehlcke
5041b199e3 Bug 1720612 - Renew external protocol dialog telemetry and add additional protocols. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D120238
2021-07-20 15:50:45 +00:00
Brindusan Cristian
38925a4041 Backed out changeset b12a0c04a68b (bug 1719492) for causing bc failures in browser_all_files_referenced.js.
CLOSED TREE
2021-07-20 19:16:56 +03:00
Brindusan Cristian
262e09aeea Backed out changeset 919c542f5b8b (bug 1720951) for causing build bustages and py3 failures in test_jarmaker.py.
CLOSED TREE
2021-07-20 19:02:16 +03:00
Nicolas Chevobbe
f928f3a26d Bug 1691575 - [devtools] Don't rely on webconsole fronts to fetch longStrings fullText. r=bomsy.
The Netmonitor used to call the WebConsoleFront `getString` method to get the full
text of a long string. This could make some test to fail with Fission and target
switching.
Since the webconsole actor is not even involved in the webconsole method, there's
no reason to keep using it. A similar function is added into a util file; the only
difference is that it doesn't cache the front it creates, which does not matter
as the netmonitor only calls this once and then put the full text in its redux
store.
This allows us to re-enable `browser_ext_devtools_network.js` with Fission.

Differential Revision: https://phabricator.services.mozilla.com/D120333
2021-07-20 15:20:11 +00:00
Nicolas Chevobbe
f0ad2e5ccb Bug 1691575 - [devtools] Don't explicitly destroy target front in head_devtools.js closeToolboxForTab. r=ochameau,rpl.
The helper is already calling `gDevTools.closeToolboxForTab`, which does take care
of destroying its associated descriptor.
This makes some extension test to pass with server side target switching enabled.

Differential Revision: https://phabricator.services.mozilla.com/D120332
2021-07-20 15:20:11 +00:00
surajeet310
2f5fc1d2b8 Bug 1720951 - Removed instances of 'ensure_bytes()' from python/mozbuild/mozbuild r=mhentges
Inlined the usage of 'ensure_bytes()' and removed dependency of 'ensure_bytes()' from util.py .

Differential Revision: https://phabricator.services.mozilla.com/D120325
2021-07-20 15:15:18 +00:00
Jan de Mooij
c46c4e9c6d Bug 1721333 part 11 - Use a reserved slot instead of private slot for testResolveRecursion. r=jonco
Depends on D120316

Differential Revision: https://phabricator.services.mozilla.com/D120317
2021-07-20 15:05:18 +00:00
Jan de Mooij
783f42b739 Bug 1721333 part 10 - Use a reserved slot instead of private slot for ForOfPICObject. r=jonco
Depends on D120315

Differential Revision: https://phabricator.services.mozilla.com/D120316
2021-07-20 15:05:18 +00:00
Jan de Mooij
879c3f154f Bug 1721333 part 9 - Use a reserved slot instead of private slot for RegExpStaticsObject. r=jonco
Depends on D120314

Differential Revision: https://phabricator.services.mozilla.com/D120315
2021-07-20 15:05:17 +00:00
Jan de Mooij
16469dff6e Bug 1721333 part 8 - Use a reserved slot instead of private slot for PropertyIteratorObject. r=jonco
Differential Revision: https://phabricator.services.mozilla.com/D120314
2021-07-20 15:05:17 +00:00
Jan de Mooij
ff4127fa5f Bug 1721333 part 7 - Use a reserved slot instead of private slot for WeakMapObject and WeakSetObject. r=jonco
Depends on D120312

Differential Revision: https://phabricator.services.mozilla.com/D120313
2021-07-20 15:05:17 +00:00
Jan de Mooij
a85a460c67 Bug 1721333 part 6 - Use a reserved slot instead of private slot for MapObject and SetObject. r=jonco
Depends on D120311

Differential Revision: https://phabricator.services.mozilla.com/D120312
2021-07-20 15:05:16 +00:00
Jan de Mooij
35bbd0896d Bug 1721333 part 5 - Use a reserved slot instead of private slot for DebuggerInstanceObject. r=jonco
Depends on D120310

Differential Revision: https://phabricator.services.mozilla.com/D120311
2021-07-20 15:05:16 +00:00
Jan de Mooij
0cb0639db2 Bug 1721333 part 4 - Remove unused private slot from WeakMap jsapi-test. r=jonco
Depends on D120309

Differential Revision: https://phabricator.services.mozilla.com/D120310
2021-07-20 15:05:15 +00:00
Jan de Mooij
ebf855d007 Bug 1721333 part 3 - Remove WasmRuntimeExceptionObject's unused private slot. r=jonco
Depends on D120308

Differential Revision: https://phabricator.services.mozilla.com/D120309
2021-07-20 15:05:15 +00:00
Jan de Mooij
cde5c967e7 Bug 1721333 part 2 - Remove SavedFrame's unused private slot. r=jonco
Depends on D120307

Differential Revision: https://phabricator.services.mozilla.com/D120308
2021-07-20 15:05:15 +00:00
Jan de Mooij
5e24e93fb0 Bug 1721333 part 1 - Remove DebuggerMemory's unused private slot. r=jonco
Differential Revision: https://phabricator.services.mozilla.com/D120307
2021-07-20 15:05:14 +00:00
surajeet310
443fa17b92 Bug 1717651 - Removed instances of 'ensure_subprocess_env' from testing/xpcshell r=mhentges
Since Python 2 is no longer used in testing/xpcshell, therefore 'ensure_subprocess_env' is obsolete.

Differential Revision: https://phabricator.services.mozilla.com/D120267
2021-07-20 14:58:35 +00:00
Kajal Sah
e450fdda18 Bug 1719492 - Migrates screenshot icons into the browser/component/screenshots directory. r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D119540
2021-07-20 14:49:00 +00:00
Nicolas Chevobbe
4cfda87a78 Bug 1689351 - [devtools] Fix browser_console_chrome_context_message.js intermittent. r=bomsy.
Focus the browser console before evaluating the expression.

Differential Revision: https://phabricator.services.mozilla.com/D120213
2021-07-20 14:35:33 +00:00