Commit Graph

726524 Commits

Author SHA1 Message Date
Eitan Isaacson
aff0fbb702 Bug 1620324 - Build breakage followup. r=dluca. CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D90474
2020-09-16 21:15:55 +00:00
Emma Malysz
ba5624012d Bug 1662939, disable form if user prints or opens system dialog when preview is rendering. r=mstriemer
We wait for initialization to finish before we print or open the system dialog.

Differential Revision: https://phabricator.services.mozilla.com/D89539
2020-09-16 19:59:27 +00:00
Toshihito Kikuchi
b45fd9fde1 Bug 1588245 - Collect the assembly pattern of a target function on detour failure. r=mhowell
Many instances of the launcher failure ping indicate hooking NtMapViewOfSection
or LdrLoadDll failed.  This is most likely caused by a third-party application
applying a hook onto the same target earlier than we do.

This patch is to add a new field "detour_orig_bytes" in the laucnher failure ping
to collect the first sixteen bytes of a detour target function.  With this,
we can know whether those detour failures were caused by a third-party hook or not,
and if yes, what was the actual binary pattern.

Differential Revision: https://phabricator.services.mozilla.com/D89836
2020-09-16 20:12:08 +00:00
Scott
355702c4f3 Bug 1658787 - On save rec telemetry. r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D90199
2020-09-16 20:09:10 +00:00
Eitan Isaacson
e90b4197f4 Bug 1665162 - Add text leaf parameterized attributes. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D90304
2020-09-16 20:24:17 +00:00
Drew Willcoxon
08b6f031d0 Bug 1665292 - Clear the view's selected result and UrlbarInput._resultForCurrentValue when the view is cleared. r=harry
First, `UrlbarView.clear` needs to null the selected element. Second, setting
the selected element to null needs to also null
`UrlbarInput._resultForCurrentValue`. `UrlbarView._selectElement` does call
`input.setValueFromResult`, which sets `_resultForCurrentValue` -- but not if
the `updateInput` arg is false. So I added a new
`UrlbarInput.setResultForCurrentValue` method so `_selectElement` can set it. At
first I tried unconditionally calling `input.setValueFromResult`, but a bunch of
tests failed. I looked into it, but it's complicated, so I gave up and added
this new method.

This also makes some other changes that I'll comment on inline.

Differential Revision: https://phabricator.services.mozilla.com/D90360
2020-09-16 20:26:03 +00:00
Eitan Isaacson
09969de13b Bug 1665200 - Add test for root group and AXAnyTypeSearchKey. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D90319
2020-09-16 20:23:12 +00:00
Eitan Isaacson
b9f75d2671 Bug 1620324 - Part 2: Make rotor API work with generated root group. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D90175
2020-09-16 20:20:10 +00:00
Eitan Isaacson
e039e76c8f Bug 1620324 - Part 1: Add mac accessible intermediate root group when needed. r=morgan
When a doc does not have top-level DOM group, or consists of a single leaf,
we need to insert a generated root group. The rotor API expects this and uses
it for boundary detection.

Differential Revision: https://phabricator.services.mozilla.com/D90174
2020-09-16 20:20:00 +00:00
Julian Descottes
f738b0b163 Bug 1662455 - [marionette] Add unit test for getText in chrome context r=marionette-reviewers,maja_zf,whimboo
Depends on D90298

Differential Revision: https://phabricator.services.mozilla.com/D90363
2020-09-16 20:17:50 +00:00
Julian Descottes
ad32141928 Bug 1662455 - [marionette] Port WebDriver:GetElementText to JSWindowActor r=marionette-reviewers,maja_zf
Depends on D90297

Differential Revision: https://phabricator.services.mozilla.com/D90298
2020-09-16 20:17:45 +00:00
Julian Descottes
0cff29f7e0 Bug 1662455 - [marionette] Port WebDriver:GetElementTagName to JSWindowActor r=marionette-reviewers,maja_zf
Depends on D90296

Differential Revision: https://phabricator.services.mozilla.com/D90297
2020-09-16 20:17:37 +00:00
Julian Descottes
81f63d94c5 Bug 1662455 - [marionette] Port WebDriver:GetElementCSSValue to JSWindowActor r=marionette-reviewers,maja_zf
Differential Revision: https://phabricator.services.mozilla.com/D90296
2020-09-16 20:17:35 +00:00
Glenn Watson
43baeb56f2 Bug 1663865 - Fix incorrect assertion check. r=nical
The debug assertion check here is trying to validate that we don't
enter an unexpected path for non-tiled images if the image template
has tiling enabled.

However, it was not correctly handling the case where an image key
has been sent but the image was removed. This case is handled by
the `resolve_image` code below, so it's a valid state to encounter
in this code path.

Differential Revision: https://phabricator.services.mozilla.com/D90343
2020-09-16 10:55:42 +00:00
Agi Sferro
f9bb44fe18 Bug 1664522 - Move ext_tabs_captureTab test to toolkit. r=robwu,snorp
Differential Revision: https://phabricator.services.mozilla.com/D90167
2020-09-16 20:11:35 +00:00
Agi Sferro
8647758548 Bug 1664522 - Fix tabs.captureVisibleTab for mobile. r=robwu,zombie,snorp
There are two things wrong with captureVisibleTab on mobile:

    * ownerGlobal is not available on nativeTab, this patch uses
      this.browser.ownerGlobal instead.
    * ZoomManager is not available on mobile, this patch moves that code to
      browser/../ext-tabs.

Differential Revision: https://phabricator.services.mozilla.com/D90009
2020-09-16 20:12:00 +00:00
Agi Sferro
5e3d005f59 Bug 1664522 - Implement tabs.captureTab on mobile. r=snorp
Differential Revision: https://phabricator.services.mozilla.com/D90165
2020-09-16 20:12:28 +00:00
Dorel Luca
8c2d120be5 Backed out 4 changesets (bug 1662455) for Eslint failures in gecko/testing/marionette/driver.js. CLOSED TREE
Backed out changeset 272a44797a77 (bug 1662455)
Backed out changeset 19ff0827dc06 (bug 1662455)
Backed out changeset a476aa0a9bfa (bug 1662455)
Backed out changeset dd580e17ab5b (bug 1662455)
2020-09-16 23:13:05 +03:00
Dorel Luca
1a57280c05 Backed out changeset bdca8dc601a4 (bug 1589781) for Build bustages in netwerk/base/NetworkConnectivityService.cpp. CLOSED TREE 2020-09-16 23:11:52 +03:00
Kris Maglione
890adab104 Bug 1658791: Make SpecialPowers.pushPermissions Fission-compatible. r=mccr8
Some tests rely on SpecialPowers.pushPermissions/popPermissions/flushPermissions
operating on the same permissions stack no matter the SpecialPowers instance
they're called on. This works when all of those SpeicalPowers instances are in
the same process, but with out-of-process Fision frames, that isn't always the
case.

This patch updates the permission stack code to operate the same way as the
preference stack code, which was already updated to deal with this issue.

Differential Revision: https://phabricator.services.mozilla.com/D90320
2020-09-16 19:32:46 +00:00
Tim Huang
b4f0a1e48b Bug 1665375 - Set pref 'privacy.window.name.update.enabled' for wpt test 'unset_context_name-1.html'. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D90457
2020-09-16 19:53:28 +00:00
Joel Maher
0b80f4878e Bug 1664884 - migrate windows10 mochitest plain, gpu from aws to datacenter. r=bc
migrate windows10 mochitest plain and gpu fro maws to datacenter.

Differential Revision: https://phabricator.services.mozilla.com/D90451
2020-09-16 19:45:24 +00:00
Julian Descottes
e86d80eb40 Bug 1662455 - [marionette] Add unit test for getText in chrome context r=marionette-reviewers,maja_zf,whimboo
Depends on D90298

Differential Revision: https://phabricator.services.mozilla.com/D90363
2020-09-16 19:44:29 +00:00
Julian Descottes
05348a4188 Bug 1662455 - [marionette] Port WebDriver:GetElementText to JSWindowActor r=marionette-reviewers,maja_zf
Depends on D90297

Differential Revision: https://phabricator.services.mozilla.com/D90298
2020-09-16 19:16:57 +00:00
Julian Descottes
c31f784147 Bug 1662455 - [marionette] Port WebDriver:GetElementTagName to JSWindowActor r=marionette-reviewers,maja_zf
Depends on D90296

Differential Revision: https://phabricator.services.mozilla.com/D90297
2020-09-16 18:11:54 +00:00
Julian Descottes
90cd514c04 Bug 1662455 - [marionette] Port WebDriver:GetElementCSSValue to JSWindowActor r=marionette-reviewers,maja_zf
Differential Revision: https://phabricator.services.mozilla.com/D90296
2020-09-16 18:10:45 +00:00
Mark Banner
1114c50941 Bug 1665301 - Disable separate private default search engine in Nightly. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D90439
2020-09-16 15:41:13 +00:00
Ted Campbell
1ccf17b7b7 Bug 1664312 - Optimize tiny atoms in ParserAtomsTable r=djvj
This add a similar optimization as js::StaticStrings for tiny strings to the
ParserAtoms mechanism. This includes (some) length 1 and length 2 atoms for
fast lookup. This is effective for large minified JS files and can speed up
syntax-parsing by up to 20% in some cases. We extend the atomIndex_ Variant
to have new `StaticParserString{1,2}` types which we use to in toJSAtom to
quickly translate to the corresponding StaticStrings.

Depends on D90152

Differential Revision: https://phabricator.services.mozilla.com/D90153
2020-09-16 19:18:44 +00:00
Ted Campbell
189e97c7b8 Bug 1664312 - Use mozilla::Variant in js::frontend::ParserAtomEntry r=djvj
Later patches will add more types of known-atoms and MaybeOneOf has a limit
on the number of types.

Differential Revision: https://phabricator.services.mozilla.com/D90152
2020-09-16 18:30:05 +00:00
Ted Campbell
26ab22283e Bug 1664312 - Inline ParserAtomsTable::lookupOrInternChar16Seq into callers r=djvj
This lets us specialize how and when well-known lookups are done.

Differential Revision: https://phabricator.services.mozilla.com/D90151
2020-09-16 18:30:07 +00:00
Ted Campbell
9cdd991446 Bug 1664312 - Reorder ParserAtomsTable methods r=djvj
Depends on D90149

Differential Revision: https://phabricator.services.mozilla.com/D90150
2020-09-16 18:30:09 +00:00
Ted Campbell
b7835d946a Bug 1664312 - Rename ParserAtomsTable::internUtf8 length arg to nbyte r=djvj
In this code we often use 'length' to refer to number of char16_t and this
can be a little confusing with UTF-8 so instead use 'nbytes' as the argument
until we establish what length of the inflated sequence is.

Depends on D90148

Differential Revision: https://phabricator.services.mozilla.com/D90149
2020-09-16 18:30:14 +00:00
Ted Campbell
040164e3f2 Bug 1664826 - Update StaticStrings small-chars to include '$', '_' r=djvj
The `$` and `_` characters are legal JS identifiers and can show up a fair
bit in large minified code-bases. This changes the {to,from}SmallChar which
is used during `StaticStrings::init`. We already use a table-based lookup
while atomizing so there isn't additional perf cost during atomization.

Differential Revision: https://phabricator.services.mozilla.com/D90148
2020-09-16 18:30:12 +00:00
mcccs
b51ce503d3 Bug 1589781 - NAT64 synthesis for TRR. r=valentin,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D86343
2020-09-16 17:52:38 +00:00
Henrik Skupin
ad78cbbf56 Bug 1394354 - [marionette] Add trace log output when using non spec-compatible element click. r=marionette-reviewers,maja_zf
Differential Revision: https://phabricator.services.mozilla.com/D90362
2020-09-16 17:59:11 +00:00
Nihanth Subramanya
e2c3fd4f60 Bug 1411618 - Remove trailing periods for error: tab crash choices. r=jaws,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D90448
2020-09-16 17:44:38 +00:00
Gavin Lazar Suntop
cf1c5fdac0 Bug 1655123 - save to pocket ui refresh r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D90295
2020-09-16 18:56:12 +00:00
Jonathan Watt
c6449897c3 Bug 1663733. Add telemetry for the time from print initiation to FrameLoader.printPreview() call and completion. r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D90370
2020-09-16 18:53:41 +00:00
unknown
7f28f17f33 Bug 1665280 - For RawBuffer reads, return a view into the shmem. r=lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D90354
2020-09-16 07:16:48 +00:00
Kartikaya Gupta
c95f299299 Bug 1661117 - Follow-up to update standalone WR CI for osmesa-src bump. r=kvark
This extracts an install-meson.sh helper script to install meson in both
the wrench-deps task for Firefox CI and the taskcluster.yml in WebRender CI.

Differential Revision: https://phabricator.services.mozilla.com/D90441
2020-09-16 18:02:45 +00:00
Cosmin Sabou
2a72f3b160 Backed out changeset 0e787c1b0a30 (bug 1663733) for eslint failure on content/print.js. CLOSED TREE 2020-09-16 21:22:56 +03:00
Cosmin Sabou
e9b4056dc4 Backed out 6 changesets (bug 1664312, bug 1664826) for valgrind bustages about ParserAtom.cpp.
Backed out changeset 71d14ede1fcb (bug 1664312)
Backed out changeset 15482e97aa4a (bug 1664312)
Backed out changeset 210475dc1429 (bug 1664312)
Backed out changeset 7c31676a20cd (bug 1664312)
Backed out changeset 8867b79ee8ea (bug 1664312)
Backed out changeset 2267cc975235 (bug 1664826)
2020-09-16 21:12:55 +03:00
Jonathan Watt
10e6b82d0e Bug 1663733. Add telemetry for the time from print initiation to FrameLoader.printPreview() call and completion. r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D90370
2020-09-16 15:46:22 +00:00
Chun-Min Chang
58d9623eec Bug 1665225 - Remove unnecessary to-main-thread dispatch r=alwu
The SMTC-thumbnail-update task is dispatched to main-thread from the
on-complete callback of the async image storing operation. However, the
callback is actually on the main-thread itself so the
thumbnail-update-task can be executed in that callback directly instead
of being dispatched. The task should be finished slightly faster if the
task dispatch is replaced by executing the task.

Differential Revision: https://phabricator.services.mozilla.com/D90331
2020-09-16 16:06:09 +00:00
John Lin
b3c72383ca Bug 1655915 - p3: make AndroidSharedBlitGL unique. r=jgilbert
AndroidSharedBlitGL is never shared with other objects and doesn't
have to be ref-counted.

Differential Revision: https://phabricator.services.mozilla.com/D89532
2020-09-09 00:05:20 +00:00
John Lin
40829db9bc Bug 1655915 - p2: correctly obtain/dispose samples. r=geckoview-reviewers,agi
All samples must be obtained and disposed to make sure they are
recycled instead of leaked.

Differential Revision: https://phabricator.services.mozilla.com/D89531
2020-09-16 17:08:48 +00:00
John Lin
a79f02d04e Bug 1655915 - p1: properly release surface. r=snorp,geckoview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D89530
2020-09-16 16:59:49 +00:00
Ricky Stewart
f44b26911e Bug 1663748 - Use mozfile.which in bootstrap r=mhentges,glandium
We don't need the homebrewed implementation any longer after bug 1647792.

Differential Revision: https://phabricator.services.mozilla.com/D89487
2020-09-16 16:46:28 +00:00
Julian Descottes
cd81a91915 Bug 1664821 - Remove What's New panel r=ochameau,Honza
Differential Revision: https://phabricator.services.mozilla.com/D90443
2020-09-16 16:43:10 +00:00
Bianca Danforth
6bd0932119 Bug 1664585 - Expose SameOriginWithTop to JavaScript; r=farre,nika
Differential Revision: https://phabricator.services.mozilla.com/D90143
2020-09-16 16:29:37 +00:00