This modifies the implementation to delete the registry keys via `DeleteSubKey` instead of `DeleteSubKeyTree`. This no longer throws when the DENY permission is set on a registry key as is the case for file association keys. This does throw when we are unable to delete a registry key as has been observed in newer versions of windows. Similar to the Win32 API implementation, this now halts execution and returns an error to the invoking process.
Differential Revision: https://phabricator.services.mozilla.com/D203069
By adding a separate parse node for `arguments.length` we will be able to
do bytecode generation differently in some circumstances.
Differential Revision: https://phabricator.services.mozilla.com/D203143
This was validated by doing a parallel implementation intially and making
sure that the two implementations both declared and indicated used in
the exact same circumstances.
Differential Revision: https://phabricator.services.mozilla.com/D203142
Adds styling for legal copy and updates above_button_config so it renders after tiles/MultiSelect but before action buttons.
Differential Revision: https://phabricator.services.mozilla.com/D200078
Automatic update from web-platform-tests
webrtc wpt: use receiver capabilities for setCodecPreferences
even though for audio this is symmetric.
BUG=None
Change-Id: I406b4799e3de768fc8636161b604f2134e5a7abb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5324902
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Florent Castelli <orphis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1265713}
--
wpt-commits: 079a2cb6a1226a3587ab776b22849e4cd83aaa91
wpt-pr: 44810
Automatic update from web-platform-tests
[text-box-trim] add parser for text-box-edge
The property is defined in
https://drafts.csswg.org/css-inline-3/#text-edges.
Now we're going to allow the following rule:
leading | [ text | cap | ex ] [ text | alphabetic ]?
ideographic and ideographic-ink are not implemented yet.
Bug: 41494590
Change-Id: I50a3111da0a8fd9f353494dfcca40e4836ba8520
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5237969
Commit-Queue: Lingqi Chi <lingqi@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1265659}
--
wpt-commits: 88803cebf503aa02f759a63fcccff4a55b2888f7
wpt-pr: 44221
Automatic update from web-platform-tests
[shared storage] Support cross-origin worklet
For the sharedStorage.createWorklet() API, relax the same-origin
restriction to additionally allow cross-origin script, in which case
a cross-origin worklet will be created.
How:
- Rely on CORS for the worklet to be created/used by the embedder.
- In general, we want to mimic the subframe's process allocation
behavior (i.e. it should end up using a process as if an iframe is
created with the script URL). It leverages the process allocation
and management logic from service workers and re-use SiteInstanceImpl::CreateForServiceWorker(). To keep this
CL focused, the refactoring will occur in a separate CL, as it
will involve refactoring other downstream components like
'UnmatchedServiceWorkerProcessTracker'.
Explainer: https://github.com/WICG/shared-storage/pull/130
Spec: https://github.com/WICG/shared-storage/pull/131
Design doc:
https://docs.google.com/document/d/1QTaaroCMeFVZVghI6JkUcDvmDQEacjvpyTfk6mpvQhA/edit?usp=sharing
Bug: 325302836
Change-Id: I11c1fc87bc76f4400c54d9fa809349d1d1781247
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5296843
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1265583}
--
wpt-commits: e8e7749139ca3a1bd1048d50966b3069e07a3f7e
wpt-pr: 44596
Automatic update from web-platform-tests
Shared Storage: Add web tests to verify entry limit no longer enforced
We add web tests for `set()` and `append()` to verify that the
previous entry limit of 10000 is no longer being enforced.
Bug: 325352528,1218540
Change-Id: I0d39185755fe1b8a07761ad96a56f62b56bf31a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5318315
Reviewed-by: Yao Xiao <yaoxia@chromium.org>
Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1265558}
--
wpt-commits: 07c97091416fd015de497feb72eea34f0440bd76
wpt-pr: 44767
Automatic update from web-platform-tests
[FedCM] Fix dom exception type for TooManyRequests
We have the right type in web_identity_requester.cc but not in these two
files.
Bug: None
Change-Id: Iadf6c6ef6cf7fcdfdc69e8abc660d201100918a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5323347
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Nicolás Peña <npm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1265498}
--
wpt-commits: 2a9fa3b5e2a898141a6373804b2b6e6f1c15957f
wpt-pr: 44793
Automatic update from web-platform-tests
[CompositeClipPathAnimation] Fix crash for global values
This CL fixes a bug where only 'fixed' falls back to main for composited clip path animation. This makes all global values fall back, to avoid crashing during paint.
Bug: 41493093
Change-Id: Ie510eb3ef2aa22a95192e3107d50af2c69b6e105
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5226767
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1265455}
--
wpt-commits: e229b5718c9fd9e920d2443a9c74dfc205166032
wpt-pr: 44133
Automatic update from web-platform-tests
Remove 'tentative' from paint-order-001.html WPT
This feature has shipped in Gecko, WebKit, and chromium.
Bug: chromium:41372165
Change-Id: I7d8facc1f24d9fd998167d856b0213cd39076670
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5323303
Auto-Submit: Stefan Zager <szager@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1265373}
--
wpt-commits: 0cc7291c1c3d1f3ec6ffee9cee78ba3d36b00818
wpt-pr: 44778
Automatic update from web-platform-tests
Revert "[FedCM] Allow button flow to replace widget flow"
This reverts commit a2783105732c27a57dd0c3e1100730cc4aec32e0.
Reason for revert: Suspected of causing failures on WebKit Linux Leak: https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20Leak/60801/overview (and other runs since)
Original change's description:
> [FedCM] Allow button flow to replace widget flow
>
> Since button flow implies stronger user login intention of, it should
> take precedence over the widget flow. In particular:
> 1. If there's an in-flight button request, reject any coming widget request
> 2. If there's an in-flight widget request, replace it with the button request
>
> This patch also fixes an issue where we persisted the rp_mode_ after a
> button flow.
>
> Bug: 41483050
> Change-Id: Ic75ba4ab359a9247f4c41b75ad84f7a3cabeb0c9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5321982
> Commit-Queue: Yi Gu <yigu@chromium.org>
> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1265238}
Bug: 41483050
Change-Id: I82728a8ea02194f46eed086015473975a4017dc4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5317868
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1265306}
--
wpt-commits: 4e124bd215d00032c69d87b499d4e04fa97595b3
wpt-pr: 44791
Automatic update from web-platform-tests
Activate output connection to AudioParam in AudioWorkletProcessor
This CL fixes an erroneous reporting in AudioNodeOutput for
outgoing connections by including connections to both AudioNodes
and AudioParams. This information can be used to provide a proper
audio bus to AudioWorkletProcessor from AudioWorkletHandler.
Fix confirmed with the repro: https://codepen.io/fr0stbyter/pen/eYXxMMp
Bug: 324293899
Test: external/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworkletprocessor-unconnected-outputs.https.window.js
Change-Id: If0e37318696b10c0cc6dbd5417743ae385043bff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5319838
Reviewed-by: Michael Wilson <mjwilson@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1265304}
--
wpt-commits: 043500fe8c9ea70d4a88061d309e29b055325535
wpt-pr: 44753
Automatic update from web-platform-tests
layout: Add line height from preserved segment breaks in quirks mode
In quirks mode, preserved segment breaks should add line height to
lines. This matches the behavior of WebKit and Blink, but not Gecko.
This also handles the special-case of `<br>` elements, which are
implemented with preserved segment breaks via `white-space: pre-line`.
This is an implementation detail though because `<br>` has a special
behavior if the line isn't empty -- it doesn't add any line height in
this case.
--
wpt-commits: b6bf2e7a488398dfcd5a9bb48756a06e17ecf6e2
wpt-pr: 44785
Automatic update from web-platform-tests
view-transition: Fix rendering of elements with clip-path on descendants
The visual overflow rect computation code in ViewTransition assumes that
if an element has a clip-path, its content will be sized to the bounds
of that clip-path. The clip-path extent can be larger than the contents
of that element.
The above assumption is only true if the element with the clip-path is
layerized. Otherwise the size of the overflow is an intersection of the
element's painted content with the clip-path. This leads to incorrect
overflow calculation for an element's overflow rect when its not
layerized.
Fix the above by forcing layerization on descendants of a named element
if it has a clip-path. This is easier than knowing whether the content
will be layerized by the paint step later.
Fixed: 324585402
Change-Id: Id35cf3aab2cb4e9f0d27dbe36afeaf37789d95dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5322398
Auto-Submit: Khushal Sagar <khushalsagar@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1265246}
--
wpt-commits: 0ad3dae083cabb967784aa1714092c7393475bec
wpt-pr: 44763
