It's unclear to me when they were disabled, but we do want to enable
these as otherwise there's no way to catch bindgen issues that can end
up in subtle bugs at best, or memory corruption at worst.
Differential Revision: https://phabricator.services.mozilla.com/D162997
To debug the idle trigger's interaction with OS sleep state, it's
helpful to know whether sleep/wake notifications were sent. This allows
most of the idle trigger activity to be logged to the console, if the
pref `messaging-system.log` is set to `debug`. The new logging will also
be used to debug the behavior reported in bug 1801301.
Differential Revision: https://phabricator.services.mozilla.com/D163010
When using images with drag & drop (or the clipboard) we use two or more different types:
- When dragging an image we put it into the DataTransfer object using the
type kNativeImageMime and the data as an imgIContainer object.
- When dropping an image we want to have some kind of image/ type,
but the data is already supposed to be a File or nsIInputStream when it comes from the OS.
This weird split usually works fine, because in our GTK, Windows and macOS code
we first convert imgIContainer to whatever native image format is required when
dragging something and then convert back to a file (or stream) when dropping.
What however doesn't work is when we never actually round-trip through the OS.
In that case we have the imgIContainer that we can't drop in a meaningful way.
(I actually already ran into this issue in bug 1396587 with the clipboard,
but we kind of resolved this by always doing the roundtrip through the OS's clipboard)
Differential Revision: https://phabricator.services.mozilla.com/D162493
This patch creates a base class of `EditorInlineStyle`, the name is
`EditorElementStyle`. It requires only attribute of HTML. However, it's
obviously different from `EditorInlineStyle`'s rule which is `mHTMLProperty`
cannot be `nullptr`. Therefore, the methods which can treat only
`EditorInlineStyle` do not want the data only whose attribute is not `nullptr`.
For solving this issue at build time, this approach is better than renaming
`EditorInlineStyle` and make it have the new mode.
Depends on D162513
Differential Revision: https://phabricator.services.mozilla.com/D162514
Fullscreen state on chrome window might not accurate as it might not be updated
yet, e.g. user clicks the window controls button to switch fullscreen mode on
macOS.
Differential Revision: https://phabricator.services.mozilla.com/D163028
To debug the idle trigger's interaction with OS sleep state, it's
helpful to know whether sleep/wake notifications were sent. This allows
most of the idle trigger activity to be logged to the console, if the
pref `messaging-system.log` is set to `debug`. The new logging will also
be used to debug the behavior reported in bug 1801301.
Differential Revision: https://phabricator.services.mozilla.com/D163010
Before bug 1798291, all rust libraries were built in the same target
directory, and rust programs were built in a separate target directory
each. Cargo would be allowed to run in parallel for each target
directory. After bug 1798291, everything rust hits the same target
directory, so the normal behavior for Cargo is to block itself if run
multiple times. What this means in terms of the build is that now those
Cargos that are waiting are taking a make token, preventing other work
from happening.
It also turns out that on Solaris, Cargo doesn't block, and those Cargos
running in parallel are stepping on each other's toes.
By serializing, we ensure this doesn't happen. This should have been
done at the same time as bug 1798291 but I overlooked this.
Differential Revision: https://phabricator.services.mozilla.com/D163019
