Commit Graph

690727 Commits

Author SHA1 Message Date
Harry Twyford
b52b6dfb21 Bug 1608336 - Disable Touch Bar for non-chrome windows. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D62259

--HG--
extra : moz-landing-system : lando
2020-02-11 09:49:11 +00:00
Brindusan Cristian
fd1c3e1623 Backed out changeset e687d00a3de0 (bug 1613101) for bc failures at browser_asrouter_whatsnewpanel.js. CLOSED TREE
--HG--
extra : histedit_source : 05b3c369e19230ca4871995207423485b948e7d4
2020-02-11 12:40:19 +02:00
Brindusan Cristian
a68356b907 Backed out 5 changesets (bug 1613378) for mochitest failures at test_general.html. CLOSED TREE
Backed out changeset f38b806ee78b (bug 1613378)
Backed out changeset cee4bbabc4b5 (bug 1613378)
Backed out changeset e3a2ab6d7267 (bug 1613378)
Backed out changeset 6fe76439f1d3 (bug 1613378)
Backed out changeset f3baf3407cbe (bug 1613378)
2020-02-11 12:27:49 +02:00
Liang-Heng Chen
2e5619cfe3 Bug 1602890 - use correct window/principal for cache; r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D61815

--HG--
extra : moz-landing-system : lando
2020-02-10 16:17:57 +00:00
Mirko Brodesser
b5693e486b Bug 1613378: part 10) Declare some table/Selection related method arguments const. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D62258

--HG--
extra : moz-landing-system : lando
2020-02-11 09:25:27 +00:00
Mirko Brodesser
67f10acb6f Bug 1613378: part 9) Clarify dependency to mFrameSelection in Selection when adding/removing ranges. r=smaug
Moreover, this is potentially more efficient because
`GetRangesForIntervalArray` doesn't have to be called when there's no
frame selection.

Differential Revision: https://phabricator.services.mozilla.com/D62198

--HG--
extra : moz-landing-system : lando
2020-02-11 09:25:45 +00:00
Mirko Brodesser
891a7a92a2 Bug 1613378: part 8) Add assertion to nsAutoScrollTimer::Init. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D62043

--HG--
extra : moz-landing-system : lando
2020-02-11 09:26:07 +00:00
Mirko Brodesser
931ef1e3fa Bug 1613378: part 7) Remove Selection's default constructor. r=smaug
Removes duplicated code and reveals the dependency to frame selection.

Differential Revision: https://phabricator.services.mozilla.com/D62040

--HG--
extra : moz-landing-system : lando
2020-02-11 09:26:07 +00:00
Mirko Brodesser
dd99b9338c Bug 1613378: part 6) Remove copy&pasted IsValidSelectionPoint function. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D62039

--HG--
extra : moz-landing-system : lando
2020-02-10 13:25:03 +00:00
Alexandre Poirot
07d03a2e68 Bug 1613119 - Test the inspector node picker from Multiprocess Browser Toolbox. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D61570

--HG--
extra : moz-landing-system : lando
2020-02-10 18:25:25 +00:00
Sylvestre Ledru
f9328d2021 Bug 1613526 - Create a code quality documentation and move the appropriate docs r=ahal
This for a few reasons:
* The summary becomes the landing page for code quality:
  https://firefox-source-docs.mozilla.org/tools/static-analysis/summary.html
* I don't think we need a full code quality category
* Closer to the source-code-doc
* All the files at the same place

Differential Revision: https://phabricator.services.mozilla.com/D61767

--HG--
rename : tools/lint/docs/coding-style/coding_style_java.rst => docs/code-quality/coding-style/coding_style_java.rst
rename : tools/lint/docs/coding-style/coding_style_other.rst => docs/code-quality/coding-style/coding_style_other.rst
rename : tools/lint/docs/coding-style/coding_style_python.rst => docs/code-quality/coding-style/coding_style_python.rst
rename : tools/lint/docs/coding-style/format_cpp_code_with_clang-format.rst => docs/code-quality/coding-style/format_cpp_code_with_clang-format.rst
rename : tools/clang-tidy/docs/summary.rst => docs/code-quality/index.rst
rename : tools/lint/docs/create.rst => docs/code-quality/lint/create.rst
rename : tools/lint/docs/index.rst => docs/code-quality/lint/index.rst
rename : tools/lint/docs/index.rst => docs/code-quality/lint/lint.rst
rename : tools/lint/docs/linters/codespell.rst => docs/code-quality/lint/linters/codespell.rst
rename : tools/lint/docs/linters/cpp-virtual-final.rst => docs/code-quality/lint/linters/cpp-virtual-final.rst
rename : tools/lint/docs/linters/eslint-plugin-mozilla.rst => docs/code-quality/lint/linters/eslint-plugin-mozilla.rst
rename : tools/lint/docs/linters/eslint-plugin-spidermonkey-js.rst => docs/code-quality/lint/linters/eslint-plugin-spidermonkey-js.rst
rename : tools/lint/docs/linters/eslint.rst => docs/code-quality/lint/linters/eslint.rst
rename : tools/lint/docs/linters/file-perm.rst => docs/code-quality/lint/linters/file-perm.rst
rename : tools/lint/docs/linters/file-whitespace.rst => docs/code-quality/lint/linters/file-whitespace.rst
rename : tools/lint/docs/linters/flake8.rst => docs/code-quality/lint/linters/flake8.rst
rename : tools/lint/docs/linters/l10n.rst => docs/code-quality/lint/linters/l10n.rst
rename : tools/lint/docs/linters/license.rst => docs/code-quality/lint/linters/license.rst
rename : tools/lint/docs/linters/lintpref.rst => docs/code-quality/lint/linters/lintpref.rst
rename : tools/lint/docs/linters/mingw-capitalization.rst => docs/code-quality/lint/linters/mingw-capitalization.rst
rename : tools/lint/docs/linters/perfdocs.rst => docs/code-quality/lint/linters/perfdocs.rst
rename : tools/lint/docs/linters/rstlinter.rst => docs/code-quality/lint/linters/rstlinter.rst
rename : tools/lint/docs/linters/rustfmt.rst => docs/code-quality/lint/linters/rustfmt.rst
rename : tools/lint/docs/usage.rst => docs/code-quality/lint/usage.rst
rename : tools/clang-tidy/docs/index.rst => docs/code-quality/static-analysis.rst
extra : moz-landing-system : lando
2020-02-11 09:11:44 +00:00
Eden Chuang
852445c77e Bug 1610881 - Get rid of ErrorResult.Throw(DOMException) in Payment code r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D61557

--HG--
extra : moz-landing-system : lando
2020-02-11 08:45:49 +00:00
Andrei Oprea
a6038dc186 Bug 1613101 - Enable the What's New panel provider in mochitests to use Remote Settings data r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D61576

--HG--
extra : moz-landing-system : lando
2020-02-10 15:40:25 +00:00
Gijs Kruitbosch
a3d7372669 Bug 1545167 - write default pdf behaviour to handlers.json without going to the OS, r=florian,mkaply
I'm taking the opportunity to remove isDefaultHandlerApp messaging as the
content-side calls were removed in bug 1353029.

Depends on D59788

Differential Revision: https://phabricator.services.mozilla.com/D59789

--HG--
extra : moz-landing-system : lando
2020-02-10 23:52:21 +00:00
Gijs Kruitbosch
a65f26ec64 Bug 1547693 - do not bother looking up protocol information with the OS just to store the default shipped options, r=florian
Differential Revision: https://phabricator.services.mozilla.com/D59788

--HG--
extra : moz-landing-system : lando
2020-02-10 23:51:43 +00:00
aarushivij
74792efe29 Bug 1554894 -Simplify devtools/client/shared/source-utils.js and remove eslint-disable complexity r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D62018

--HG--
extra : moz-landing-system : lando
2020-02-11 08:15:05 +00:00
Henri Sivonen
3ad0a42a86 Bug 1614314 - Use GitHub as upstream for the Java code of the HTML parser. r=alchen
Differential Revision: https://phabricator.services.mozilla.com/D62238

--HG--
extra : moz-landing-system : lando
2020-02-10 15:05:17 +00:00
Boris Zbarsky
c343055996 Bug 1614164. Stop using NS_ERROR_DOM_TYPE_ERR in IndexedDB. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D62153

--HG--
extra : moz-landing-system : lando
2020-02-11 07:25:44 +00:00
Masatoshi Kimura
948598bdd4 Bug 1614146 - Stop using byte literals in _hg_cleanenv. r=firefox-build-system-reviewers,glandium
Differential Revision: https://phabricator.services.mozilla.com/D62398

--HG--
extra : moz-landing-system : lando
2020-02-11 04:47:54 +00:00
Brindusan Cristian
615e78b5fc Backed out changeset a91870b97f09 (bug 1611886) for xpcshell failures at test_browserid_identity.js. CLOSED TREE 2020-02-11 09:03:03 +02:00
Brindusan Cristian
bd1db3c1fd Backed out changeset 33e43f085390 (bug 1608554) for bc failures at browser_searchbar_openpopup.js. CLOSED TREE 2020-02-11 09:02:01 +02:00
Hiroyuki Ikezoe
b9fb72c857 Bug 1599795 - Make IntersectionObserver work in fission world. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D61938

--HG--
extra : moz-landing-system : lando
2020-02-11 03:59:14 +00:00
Hiroyuki Ikezoe
1c0f15006d Bug 1599795 - Rename BrowserChild::GetRemoteDocumentRect to GetTopLevelViewportVisibleRectInBrowserCoords. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D62183

--HG--
extra : moz-landing-system : lando
2020-02-11 03:35:56 +00:00
Hiroyuki Ikezoe
03eb44ed69 Bug 1599795 - Trigger UpdateIntersectionObservation in response to APZ changes. r=emilio
In out-of-process iframes, the refresh driver for the iframe process doesn't
trigger the UpdateIntersectionObservation function in cases where ancestor
document's viewports change because there is no way to know it happens inside
the iframe process.  So instead, we trigger the function in
BrowserChild::RecvChildToParentMatrix which is called in response to APZ.

Differential Revision: https://phabricator.services.mozilla.com/D61937

--HG--
extra : moz-landing-system : lando
2020-02-11 03:35:38 +00:00
Hiroyuki Ikezoe
d4fa8f4fad Bug 1599795 - Change the remote document rect to size in gfx. r=emilio
What we really needed in the first place was the size not the rect.

Differential Revision: https://phabricator.services.mozilla.com/D62215

--HG--
extra : moz-landing-system : lando
2020-02-11 03:57:14 +00:00
sotaro
c3615f343f Bug 1611886 - Add VRManagerParent::Shutdown() r=nical
Differential Revision: https://phabricator.services.mozilla.com/D61144

--HG--
extra : moz-landing-system : lando
2020-02-05 09:42:37 +00:00
sotaro
b23e6dbb81 Bug 1554610 - Destroy CompositorWindow if BasicCompositor is used r=nical
When BasicCompositor is used, BasicCompositor does not use CompositorWindow.

Differential Revision: https://phabricator.services.mozilla.com/D61345

--HG--
extra : moz-landing-system : lando
2020-02-04 09:07:57 +00:00
Emilio Cobos Álvarez
f4734a4dca Bug 1614208 - Stop including nsStyleConsts.h from WebRenderTypes.h. r=jrmuizel
This is another one which is included everywhere. If the OOL call mattered we
could move these to a different header or something, but I suspect it won't.

Differential Revision: https://phabricator.services.mozilla.com/D62173

--HG--
extra : moz-landing-system : lando
2020-02-11 01:23:41 +00:00
Emilio Cobos Álvarez
49abab29a5 Bug 1614208 - Remove nsStyleConsts usage from TextRange.h. r=masayuki
Differential Revision: https://phabricator.services.mozilla.com/D62172

--HG--
extra : moz-landing-system : lando
2020-02-11 01:23:12 +00:00
Emilio Cobos Álvarez
b997cfcaf4 Bug 1614208 - Stop including PresShell.h and nsPresContext.h from Element.h. r=smaug
nsPresContext.h is only used for unit conversion, which can be done by Units.h
in a similar fashion.

PresShell.h was needed for some capturing-content stuff which can be moved out
of line.

Differential Revision: https://phabricator.services.mozilla.com/D62170

--HG--
extra : moz-landing-system : lando
2020-02-11 01:23:12 +00:00
Emilio Cobos Álvarez
6615ff9fad Bug 1614208 - Stop including AccessibleCaretEventHub and PresShell.h from Selection.h. r=TYLin
And fix a bunch of fallout as we now don't include nsDocShell.h everywhere.

Differential Revision: https://phabricator.services.mozilla.com/D62169

--HG--
extra : moz-landing-system : lando
2020-02-11 01:22:29 +00:00
Emilio Cobos Álvarez
14a5089845 Bug 1614208 - Remove unused WritingMode ipdl include. r=jfkthame
Differential Revision: https://phabricator.services.mozilla.com/D62168

--HG--
extra : moz-landing-system : lando
2020-02-11 01:22:22 +00:00
Emilio Cobos Álvarez
fb586787c5 Bug 1614208 - Remove more dependencies on nsStyleConsts.h / ServoStyleConsts.h. r=jfkthame
Mostly what I was seeing come up in the .deps files from my object directory
which sounded feasible.

Differential Revision: https://phabricator.services.mozilla.com/D62167

--HG--
extra : moz-landing-system : lando
2020-02-11 01:22:15 +00:00
Emilio Cobos Álvarez
298c598770 Bug 1614208 - Forward-declare StaticPresData in nsPresContext.h. r=jfkthame
This avoids including nsFont.h and a bunch of other stuff in nsPresContext.h

Differential Revision: https://phabricator.services.mozilla.com/D62166

--HG--
extra : moz-landing-system : lando
2020-02-11 01:23:37 +00:00
Emilio Cobos Álvarez
d7841a5f17 Bug 1614208 - Remove some include dependencies in nsStyleConsts.h. r=jfkthame,jgilbert
We include it everywhere because it's included from gfxTypes.h.

This should avoid including all the generated bindings _everywhere_.

Differential Revision: https://phabricator.services.mozilla.com/D62174

--HG--
extra : moz-landing-system : lando
2020-02-11 01:23:37 +00:00
MahakBansal
d58f7fe1b6 Bug 1614148 - Removes unused variable 'kMinMaxColorAttachments' in WebGLContextValidate.cpp r=jgilbert
Differential Revision: https://phabricator.services.mozilla.com/D62159

--HG--
extra : moz-landing-system : lando
2020-02-11 01:07:26 +00:00
James Teh
a534503c00 Bug 1608554: Initialize toolbartabstops in dynamically added widgets. r=Gijs
When ToolbarKeyboardNavigator initializes, it sets aria-hidden and adds a focus listener on toolbartabstop elements.
This is necessary for proper functionality of toolbar keyboard navigation.
However, widgets can be dynamically added by CustomizableUI after ToolbarKeyboardNavigator initializes.
The search bar is one such widget and it does contain toolbartabstop elements.
We now watch for this and initialize any toolbartabstop elements inside added widgets.

Differential Revision: https://phabricator.services.mozilla.com/D62178

--HG--
extra : moz-landing-system : lando
2020-02-10 10:18:17 +00:00
Markus Stange
89d18db033 Bug 1614514 - Insert new line in geckoview-quick-start.md after list in order to fix formatting.
Differential Revision: https://phabricator.services.mozilla.com/D62374

--HG--
extra : moz-landing-system : lando
2020-02-11 00:09:43 +00:00
David Major
c4e3b2d209 Bug 1613606 - Bonus cleanup of IPC::Principals r=nika
All of these call sites were unnecessarily converting nsIPrincipal* => IPC::Principal => nsIPrincipal*.

Differential Revision: https://phabricator.services.mozilla.com/D62327

--HG--
extra : moz-landing-system : lando
2020-02-10 20:52:56 +00:00
David Major
9457524c37 Bug 1613606 - Use nsIPrincipal in BlobURLRegistrationData r=nika
clang-10 hits a -Werror in IPDL headers about Principal's copy constructor not being explicitly defined. We could go and fix that constructor, but in light of bug 1443956, I'm guessing it's not really a bad thing to have a discouragement against Principal when nsIPrincipal is now usable directly.

Differential Revision: https://phabricator.services.mozilla.com/D62284

--HG--
extra : moz-landing-system : lando
2020-02-10 20:52:56 +00:00
Ehsan Akhgari
74836fb7e5 Bug 1610821 - Part 2: Ensure most of event handling works on input elements which are disconnected from a document; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D60672

--HG--
extra : moz-landing-system : lando
2020-02-10 22:35:44 +00:00
Ehsan Akhgari
a848f5fbdd Bug 1610821 - Part 1: Remove the unused nsPresContext argument of FireEventForAccessibility(); r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D62252

--HG--
extra : moz-landing-system : lando
2020-02-10 14:06:09 +00:00
Sebastian Hengst
3e6af4f0f6 Bug 1614309 - Disable offscreen-canvas/fill-and-stroke-styles/2d.gradient.radial.outside2.html on Windows ccov because it always fails. r=lsalzman DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D62237

--HG--
extra : moz-landing-system : lando
2020-02-10 22:14:49 +00:00
Dana Keeler
7e92a667e3 bug 1613729 - join the osclientcerts manager thread r=jcj
Differential Revision: https://phabricator.services.mozilla.com/D62330

--HG--
extra : moz-landing-system : lando
2020-02-10 21:27:56 +00:00
Tom Prince
d14d229add Bug 1527313: [mozharness] Fail if we can't find the marionette requirements file; r=ahal
The alternative code path was unused (as demonstrated by the presence of
`manifestdestiny` package). Remove that code path, so we can fail with a better
error message, if we don't have the right path to the requirements file.

Differential Revision: https://phabricator.services.mozilla.com/D62339

--HG--
extra : moz-landing-system : lando
2020-02-10 21:56:29 +00:00
Tom Prince
46347adf28 Bug 1527313: [mozharness] Fail if we can't find the mozbase requirements file; r=ahal
The alternative code path was unused (as demonstrated by the presence of
`manifestdestiny` package). Remove that code path, so we can fail with a better
error message, if we don't have the right path to the requirements file.

Differential Revision: https://phabricator.services.mozilla.com/D62338

--HG--
extra : moz-landing-system : lando
2020-02-10 21:11:18 +00:00
David Burns
5942abaa97 Bug 1588114 - [remote] Implement Network.setCookie and Network.setCookies. r=remote-protocol-reviewers,maja_zf
Differential Revision: https://phabricator.services.mozilla.com/D62119

--HG--
extra : moz-landing-system : lando
2020-02-10 21:14:16 +00:00
Viresh Gupta
96552e75e7 Bug 1612981 - Remove MatrixAxBToRowMajor r=jgilbert
Remove unused code from dom/canvas/WebGLContextGL.cpp

Differential Revision: https://phabricator.services.mozilla.com/D61664

--HG--
extra : moz-landing-system : lando
2020-02-11 01:11:27 +00:00
James Teh
c26825f5d1 Bug 1606932: Don't suppress blur events for file picker dialogs on Windows. r=NeilDeakin
Suppressing blur events prevents accessibility from firing focus events correctly when dismissing file picker dialogs.
This code was originally added in bug 68454 to fix a crash when bringing up a file picker dialog from the context menu on a window which calls self.close() on blur.
However, this crash can no longer be reproduced, so the code isn't needed any more.

Differential Revision: https://phabricator.services.mozilla.com/D62182

--HG--
extra : moz-landing-system : lando
2020-02-11 00:40:39 +00:00
alwu
48dc9c2f98 Bug 1613329 - part2 : add test. r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D61667

--HG--
extra : moz-landing-system : lando
2020-02-10 22:35:27 +00:00