Commit Graph

10775 Commits

Author SHA1 Message Date
Kris Maglione
9d78661f88 Bug 1649221: Update ChromeUtils.generateQI callers to pass strings. r=mccr8,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,preferences-reviewers,agi,whimboo,Bebe,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D81594
2020-07-10 23:58:28 +00:00
Kris Maglione
6a39211860 Bug 1464542: Part 3b - Add existing Services.jsm registrations to the new services cache. r=mccr8,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D81419
2020-07-09 21:42:25 +00:00
Csoregi Natalia
b355fcc4bf Backed out 6 changesets (bug 1464542) for xpcshell failures on test_Services.js. CLOSED TREE
Backed out changeset b50af9005851 (bug 1464542)
Backed out changeset 9d3a0ea2cf65 (bug 1464542)
Backed out changeset 71c3475fcbc2 (bug 1464542)
Backed out changeset 51ff93220a95 (bug 1464542)
Backed out changeset e84de1547c09 (bug 1464542)
Backed out changeset bbecc16d08eb (bug 1464542)
2020-07-09 23:19:26 +03:00
Kris Maglione
d09458dc51 Bug 1464542: Part 3b - Add existing Services.jsm registrations to the new services cache. r=mccr8,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D81419
2020-07-09 17:59:16 +00:00
Simon Giesecke
61e4a0be9b Bug 1649729 - Get rid of MOZ_ACCESS_THREAD_BOUND macro. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D81843
2020-07-01 13:13:23 +00:00
Simon Giesecke
9364b353d4 Bug 1648010 - Remove NS_NAMED_LITERAL_CSTRING and NS_NAMED_LITERAL_STRING macros. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D80631
2020-07-01 08:42:31 +00:00
Simon Giesecke
e3c223da3e Bug 1648010 - Fix uses of NS_LITERAL_STRING with C string literals. r=geckoview-reviewers,agi,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D80861
2020-07-01 08:34:12 +00:00
Simon Giesecke
cd8b8939b9 Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
Andrea Marchesini
788cd2c41f Bug 1649404 - Enforce the reading completeness in any PermissionManager methods, r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D81681
2020-06-30 18:34:51 +00:00
Andrea Marchesini
5b1b63de75 Bug 1648134 - Permission Manager does not save changes when scope is changed., r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D81292
2020-06-30 09:44:00 +00:00
Csoregi Natalia
adaed940e7 Backed out changeset 34d09061d827 (bug 1648134) for failures on test_permmanager_remove_add_update.js. CLOSED TREE 2020-06-29 20:43:54 +03:00
Andrea Marchesini
dc7bad122c Bug 1648134 - Permission Manager does not save changes when scope is changed., r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D81292
2020-06-29 14:37:19 +00:00
Tim Huang
1d1ef81356 Bug 1645997 - Use BrowsingContext to get the top-level window context in PermissionDelegateHandler.cpp r=baku
We used the Document::GetWindowContext() to get the window context
related to the doucment. But, this could return a nullptr if the
document is detached from the window or the docuemnt is destoried.

We move to use the BrowsingContext instead which won't return a nullptr
in these cases.

Differential Revision: https://phabricator.services.mozilla.com/D79897
2020-06-19 12:31:29 +00:00
Henri Sivonen
d5b9be12ce Bug 1603712 - Remove intl.charset.detector.ng.enabled pref and resulting dead code. r=Gijs,fluent-reviewers,valentin,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D79101
2020-06-15 15:32:21 +00:00
Tim Huang
f5adef2650 Bug 1587743 - Part 3: Using WindowContext to test delegated permissions. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D79134
2020-06-12 16:32:03 +00:00
Tim Huang
8422436b6c Bug 1587743 - Part 2: Removing mTopLevelPrincipal from the PermissionDelegateHandler. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D79133
2020-06-12 16:31:56 +00:00
Tim Huang
eab7aa2b87 Bug 1587743 - Part 1: Pre-compute the delegated permissions for the top-level content and store it in the WindowContext. r=baku,nika
In order to delegate the permission to the top-level window, in this
patch, we pre-compute the permissions of the top-level context and set
them to the top-level WindowContext. So, the cross-origin iframe can
know the permission of the top-level window through the WindowContext.
Thus, the permission can be delegated in Fission.

Differential Revision: https://phabricator.services.mozilla.com/D79132
2020-06-12 16:31:49 +00:00
Haik Aftandilian
b1f63ced7e Bug 1632845 - Firefox gets stuck when quit from the dock if the user cancels quitting from a beforeunload prompt r=Gijs,spohl,necko-reviewers,geckoview-reviewers,dragana,agi
Return NSTerminateCancel from applicationShouldTerminate when the user chooses to "Stay on Page".

Differential Revision: https://phabricator.services.mozilla.com/D78839
2020-06-09 18:20:36 +00:00
Dimi Lee
53b848ce2f Bug 1644073 - Remove storageAccessAPI permission from preload list r=baku
We add storageAccessAPI permission to perload list in Bug 1499442.

In the recent ETP fission works, we have ensured that the user interaction
permission check can only happen either in the parent process or in the
content processes that load principal to check. This means we don't need
to preload it anymore.

Differential Revision: https://phabricator.services.mozilla.com/D78639
2020-06-08 11:24:05 +00:00
Makoto Kato
b8d216c8f6 Bug 1637553 - Reduce array copy in spell checker loop. r=masayuki
Actually, we always clone spell checker range array per IPC call into spell
check loop. But we can use `std::move` to reduce unnecessary copy.

Also, `mozInlineSpellWordUtil::GetNextWord` always returns NS_OK, so
this should use boolean value to know whether loop is done.

Differential Revision: https://phabricator.services.mozilla.com/D75111
2020-05-27 14:33:12 +00:00
Emilio Cobos Álvarez
89958b377a Bug 1640605 - Remove IsInAnonymousSubtree / IsRootOfAnonymousSubtree. r=edgar
In favor of the NativeAnonymous versions which they forward to.

Done automatically with:

  rg -l 'IsInAnonymousSubtree' | xargs sed -i 's/IsInAnonymousSubtree/IsInNativeAnonymousSubtree/g'

And removing the function definitions afterwards.

Differential Revision: https://phabricator.services.mozilla.com/D76681
2020-05-25 11:43:51 +00:00
Johann Hofmann
badadf3f93 Bug 1596855 - Update browser_permmgr_sync.js for Fission. r=pbz
The test was updated to ensure that under Fission we're not syncing
all permission information to a "parent" content process, and instead
just to the specific iframe that needs it.

Differential Revision: https://phabricator.services.mozilla.com/D76103
2020-05-20 16:45:01 +00:00
Andrea Marchesini
68dab10ed9 Bug 1629274 - Fix Intermittent failure in test_permmanager_removeall.js, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D74590
2020-05-11 08:34:04 +00:00
Andrea Marchesini
8bc8cd34b1 Bug 1635693 - Ensure permissionManager DB connection is active only if the initialization completed, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D74385
2020-05-08 16:23:15 +00:00
Ian Moody
011b59d595 Bug 1536556 - Replace raw thrown Cr.ERRORs with Components.Exception. r=mossop,remote-protocol-reviewers,marionette-reviewers,whimboo,necko-reviewers,geckoview-reviewers,valentin,agi
Raw Cr.ERROR don't get stack information, same as throwing JS literals instead
of `new Error()`s.

This was done automatically with a new eslint rule that will be introduced in
the next commit.  One instance of a raw Cr.ERROR was not replaced since it is
used in a test that specifically checks the preservation of raw Cr values in
XPCJS.  The rule will be disabled for that instance.

Differential Revision: https://phabricator.services.mozilla.com/D28073
2020-05-05 17:41:36 +00:00
Simon Giesecke
6a983da8c3 Bug 1626570 - Improve handling of copying arrays in extensions/spellcheck. r=m_kato
Differential Revision: https://phabricator.services.mozilla.com/D72319
2020-04-30 09:36:26 +00:00
Andi-Bogdan Postelnicu
38afb32dc5 Bug 1626555 - Make dom/base buildable outside of unified-build environment. r=hsivonen
Differential Revision: https://phabricator.services.mozilla.com/D69183
2020-04-29 09:02:05 +00:00
Johann Hofmann
59f0df8747 Bug 1627220 - Skip expired permissions in getAllWithTypePrefix and getAllForPrincipal. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D72454
2020-04-27 17:26:04 +00:00
Daniel Varga
ce17a27917 Backed out changeset b1f668b65e69 (bug 1627220) for causing xpcshell failures at extensions/permissions/test/unit/test_permmanager_expiration.js
CLOSED TREE
2020-04-27 17:49:53 +03:00
Johann Hofmann
105e5e23f6 Bug 1627220 - Skip expired permissions in getAllWithTypePrefix and getAllForPrincipal. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D72454
2020-04-27 11:40:53 +00:00
Sebastian Streich
ea62971514 Bug 1623417 - Refactor nsPermission.cpp r=ckerschb
***

Differential Revision: https://phabricator.services.mozilla.com/D67371
2020-04-23 13:11:56 +00:00
Noemi Erli
b611a44386 Backed out changeset a2bff0eef797 (bug 1623417) for causing xpcshell failures in test_permmanager_matchesuri.js CLOSED TREE 2020-04-20 20:09:23 +03:00
Sebastian Streich
bb11628699 Bug 1623417 - Refactor nsPermission.cpp r=ckerschb
***

Differential Revision: https://phabricator.services.mozilla.com/D67371
2020-04-20 15:59:44 +00:00
Kershaw Chang
85532d60f8 Bug 1626076 - Make it possible to use DataStorage on socket process r=keeler,dragana,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D68877
2020-04-20 09:41:58 +00:00
Sebastian Streich
c0401ba16f Bug 1620402 - Refactor nsPermissionManager.cpp r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D65606
2020-04-20 09:53:40 +00:00
Magnus Melin
7be9697324 Bug 1629450 - reset built-in permissions earily also in test_permmanager_load_invalid_entries.js. r=baku
Started failing following https://hg.mozilla.org/mozilla-central/rev/f1d9689ea300

Differential Revision: https://phabricator.services.mozilla.com/D70930

--HG--
extra : moz-landing-system : lando
2020-04-15 07:23:11 +00:00
Magnus Melin
7e719a42a0 Bug 1629450 - Permissions manager tests (extensions/permissions/test/unit) failing in Thunderbird since it's running tests with a real profile. r=baku
After bug 1363541 the calls to Services.prefs.setCharPref("permissions.manager.defaultsUrl", ""); must be done early to have any effect. Otherwise the defaults will already be imported and tests do not get the expected starting point.

Differential Revision: https://phabricator.services.mozilla.com/D70675

--HG--
extra : moz-landing-system : lando
2020-04-14 08:34:17 +00:00
Andrea Marchesini
68d9c71f19 Bug 1629273 - Fix intermittent failure in test_permmanager_load_invalid_entries.js, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D70639

--HG--
extra : moz-landing-system : lando
2020-04-14 07:55:52 +00:00
Andrea Marchesini
98eff139c5 Bug 1363541 - Modernize the PermissionManager - part 6 - moving code around, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D70164

--HG--
extra : moz-landing-system : lando
2020-04-11 13:42:53 +00:00
Andrea Marchesini
9f0376cefe Bug 1363541 - Modernize the PermissionManager - part 5 - headers, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D70041

--HG--
extra : moz-landing-system : lando
2020-04-11 13:42:30 +00:00
Andrea Marchesini
13481ea877 Bug 1363541 - Modernize the PermissionManager - part 4 - mozilla namespace, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D70040

--HG--
rename : extensions/permissions/nsPermissionManager.cpp => extensions/permissions/PermissionManager.cpp
rename : extensions/permissions/nsPermissionManager.h => extensions/permissions/PermissionManager.h
extra : moz-landing-system : lando
2020-04-11 13:42:12 +00:00
Andrea Marchesini
a765ed14dd Bug 1363541 - Modernize the PermissionManager - part 3 - DB handling in a separate thread, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D69965

--HG--
extra : moz-landing-system : lando
2020-04-11 13:41:19 +00:00
Andrea Marchesini
5c1bc3ab01 Bug 1363541 - Modernize the PermissionManager - part 2 - PermissionDelegateHandler to mozilla::PermissionDelegateHandler, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D69964

--HG--
extra : moz-landing-system : lando
2020-04-10 08:36:46 +00:00
Andrea Marchesini
d0bfec4f79 Bug 1363541 - Modernize the PermissionManager - part 1 - nsPermission to mozilla::Permission, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D69963

--HG--
rename : extensions/permissions/nsPermission.cpp => extensions/permissions/Permission.cpp
rename : extensions/permissions/nsPermission.h => extensions/permissions/Permission.h
extra : moz-landing-system : lando
2020-04-10 08:36:37 +00:00
Razvan Maries
b74e338c98 Backed out 6 changesets (bug 1363541) for perma failures. CLOSED TREE
Backed out changeset a775f6e9eb41 (bug 1363541)
Backed out changeset 9212bfd89eca (bug 1363541)
Backed out changeset bf41b0c139f6 (bug 1363541)
Backed out changeset aa7c6668b249 (bug 1363541)
Backed out changeset 9f413a8a47bb (bug 1363541)
Backed out changeset 827a9a2866bd (bug 1363541)

--HG--
rename : extensions/permissions/Permission.cpp => extensions/permissions/nsPermission.cpp
rename : extensions/permissions/Permission.h => extensions/permissions/nsPermission.h
rename : extensions/permissions/PermissionManager.cpp => extensions/permissions/nsPermissionManager.cpp
rename : extensions/permissions/PermissionManager.h => extensions/permissions/nsPermissionManager.h
2020-04-10 11:31:20 +03:00
Andrea Marchesini
519961d263 Bug 1363541 - Modernize the PermissionManager - part 6 - moving code around, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D70164

--HG--
extra : moz-landing-system : lando
2020-04-09 22:08:03 +00:00
Andrea Marchesini
4adbfbb4d0 Bug 1363541 - Modernize the PermissionManager - part 5 - headers, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D70041

--HG--
extra : moz-landing-system : lando
2020-04-09 22:08:03 +00:00
Andrea Marchesini
b523b552a4 Bug 1363541 - Modernize the PermissionManager - part 4 - mozilla namespace, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D70040

--HG--
rename : extensions/permissions/nsPermissionManager.cpp => extensions/permissions/PermissionManager.cpp
rename : extensions/permissions/nsPermissionManager.h => extensions/permissions/PermissionManager.h
extra : moz-landing-system : lando
2020-04-09 22:08:02 +00:00
Andrea Marchesini
f78d7b4bd4 Bug 1363541 - Modernize the PermissionManager - part 3 - DB handling in a separate thread, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D69965

--HG--
extra : moz-landing-system : lando
2020-04-10 06:36:03 +00:00
Andrea Marchesini
3961346cfc Bug 1363541 - Modernize the PermissionManager - part 2 - PermissionDelegateHandler to mozilla::PermissionDelegateHandler, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D69964

--HG--
extra : moz-landing-system : lando
2020-04-09 22:08:02 +00:00