Automatic update from web-platform-testsAllows panning inside overflowing snap areas.
According to the spec[1], if an overflowing snap area covers the
snapport in one axis and the distance between the previous snap
position and the next snap position is larger than the size of the
snapport, the current scroll position is a valid snap position.
This patch also rewrites the data structure of SnapAreaData and
SnapContainerData so that they only keep the rect and calculate the
snap points, visible region, overflow condition only when scroll
occurs.
[1] https://drafts.csswg.org/css-scroll-snap-1/#snap-overflow
Bug: 826359
Cq-Include-Trybots: luci.chromium.try :android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iec1ebe48abe8d2653128ac2af4e6137a14c05502
Reviewed-on: https://chromium-review.googlesource.com/1075558
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570255}
--
wpt-commits: 83c33634aaf8495aa9acfe40e4612c242c45c184
wpt-pr: 11383
MozReview-Commit-ID: JmozXZZQzzx
Automatic update from web-platform-testsCSS: transform-origin does not accept top <length>
Spec:
https://drafts.csswg.org/css-transforms/#propdef-transform-origin
Blink no longer accepts transform-origin 'top 1px'. We previously
parsed it as 'top center 1px'.
Edge/Firefox/WebKit already reject such values.
BUG=855787
Change-Id: I8ac8745d41c867a2ef659ce9afe17143d60a1806
Reviewed-on: https://chromium-review.googlesource.com/1112883
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570139}
--
wpt-commits: 69a3483d7a05abb72161096baf204b37be7cc098
wpt-pr: 11635
Automatic update from web-platform-testsReland "[CSS Env Vars] Add some WPT tests"
This is a reland of 981a543f9e743001a6e492a006873de3a5953747
This adds a bugfix that adds a DetachFromParent method that
we call in StyleEngine. This stops the global environment
variables instance holding a reference to the document
one after the document has been disposed.
Original change's description:
> [CSS Env Vars] Add some WPT tests
>
> Adds some WPT tests to test env() with @supports as well
> as fallback values.
>
> BUG=825890
>
> Change-Id: I071f5c2582f8056fe39b4a50ab62140d579c577d
> Reviewed-on: https://chromium-review.googlesource.com/1111023
> Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#569852}
Bug: 825890
Change-Id: If828b977d62145fb1ea9bb710a48d76307a054d5
Reviewed-on: https://chromium-review.googlesource.com/1113877
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570117}
--
wpt-commits: 775bb3b7bf1e28c58d8381422e6755c3f6936b46
wpt-pr: 11658
Automatic update from web-platform-testsRevert "Move a test for min-content for a soft-hyphen to wpt"
This reverts commit d37409a17a223249ee661ae504def53bf51b4ce9.
Reason for revert: external/wpt/css/css-sizing/min-content-soft-hyphen-001.html failed on Windows 10
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/36928
Original change's description:
> Move a test for min-content for a soft-hyphen to wpt
>
> This tests when the inline-size is [min-content]:
> * A `­` produces a break opportunity when computing the
> min-content inline size.
> * The hyphen character generated by `­` is included into
> the min-content inline size.
>
> Originally developed in [CL:1111895].
>
> [min-content]: https://www.w3.org/TR/css-sizing-3/#valdef-width-min-content
> [CL:1111895] https://chromium-review.googlesource.com/c/chromium/src/+/1111895
>
> Bug: 636993
> Change-Id: Ib492b2db023a5169247ca00e5b745e42ec33d197
> Cq-Include-Trybots: luci.chromium.try :linux_layout_tests_layout_ng
> Reviewed-on: https://chromium-review.googlesource.com/1113085
> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570066}
TBR=cbiesinger@chromium.org,kojii@chromium.org
Change-Id: I3fb91c7c2d66e775a12994734a14afc566d05a3e
No-Presubmit: true
No-Tree-Checks: true
No-Try : true
Bug: 636993
Cq-Include-Trybots: luci.chromium.try :linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/1113667
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570109}
--
wpt-commits: ce2196e7a345f209ce095ec6c7356f3a6cf168d4
wpt-pr: 11660
MozReview-Commit-ID: A5fo6hI5Szs
Automatic update from web-platform-testsMove a test for min-content for a soft-hyphen to wpt
This tests when the inline-size is [min-content]:
* A `­` produces a break opportunity when computing the
min-content inline size.
* The hyphen character generated by `­` is included into
the min-content inline size.
Originally developed in [CL:1111895].
[min-content]: https://www.w3.org/TR/css-sizing-3/#valdef-width-min-content
[CL:1111895] https://chromium-review.googlesource.com/c/chromium/src/+/1111895
Bug: 636993
Change-Id: Ib492b2db023a5169247ca00e5b745e42ec33d197
Cq-Include-Trybots: luci.chromium.try :linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/1113085
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570066}
--
wpt-commits: cb5379322c3ae9f1fb203d6c0b9bc12e7f6af44d
wpt-pr: 11656
MozReview-Commit-ID: 9e7iLpwrmWG
Automatic update from web-platform-testsMerge pull request #11653 from mrego/contain-size-image-alt
[css-contain] Add alt on image at contain-size-013.html
--
wpt-commits: 9d5ca975b959ed3458bd585ff53e705c0551eb62
wpt-pr: 11653
Automatic update from web-platform-testssensors: Yield to the event loop in GenericSensorTestChromium.reset() (#11625)
Do so there instead of in `MockSensorProvider.reset()`, which is now a
regular function.
This brings the code more in line with Blink's own `sensor-helpers.js`, and
fixes one of the issues described in #10906: when a test failed, we'd end up
with the following code path
1. `sensor_tests()`'s calls `GenericSensorTestChromium.reset()`
2. `GenericSensorTestChromium.reset()` calls `MockSensorProvider.reset()`
3. This function `await`s on a promise that resolves inside `setTimeout()`
and yields control back to the event loop
4. The next test is run, and it fails because
`GenericSensorTest.testInternal` hasn't been reset yet.
5. After all tests run, we go back to the `setTimeout()` callbacks and
finish running `GenericSensorTest.reset()`.
which essentially caused all subsequent tests to failure because
`1initialize()` would complain `reset()` had not been run.
We now simplify things, and a test failure results in:
1. `sensor_tests()`'s calls `GenericSensorTestChromium.reset()`
2. `GenericSensorTestChromium.reset()` calls `MockSensorProvider.reset()`,
which runs synchronously and where we close the mojo binding and stop the
mojo interceptor
3. This function `await`s on a promise that resolves inside `setTimeout()`
and yields control back to the event loop to let the mojo shutdown
process finish. The next test may start running before this `sensor_test`
fully finishes, but it's not a problem since we're not running anything
after calling `GenericSensorTestChromium.reset()`
4. The next test runs as expected because `testInternal` has already been
reset
With this change, running `wpt run` with a recent Chromium master build on
accelerometer, generic-sensor, geolocation-sensor, gyroscope, magnetometer
and orientation-sensor yields 249 failures, down from 286.
--
wpt-commits: cc0999e09fac71d8c708445cc9986ee489d12cdb
wpt-pr: 11625
Automatic update from web-platform-testsFetch: split up fetch/api/request/request-keepalive-quota.html
Part of #11571.
--
wpt-commits: f17d9eef1f6b47edc2a6872cff3a53ceceb576b6
wpt-pr: 11593
Automatic update from web-platform-testsES Modules: Use an appropriate referrer policy for module script loading
This CL fixes ReferrerPolicy handling in module script loading. Before this CL,
FetchClientSettingsObjectSnapshot's referrer policy is used, but this is wrong.
The spec requires to use ScriptFetchOptions' referrer policy.
// The "set up the module script request" algorithm:
"Set request's cryptographic nonce metadata to options's cryptographic nonce,
..., and its referrer policy to options's referrer policy."
https://html.spec.whatwg.org/multipage/webappapis.html#set-up-the-module-script-request
Specifically, this CL introduces |referrer_policy_| field in ScriptFetchOptions
class as spec'ed and propagates it to the entire path of module script loading.
ScriptFetchOptions's referrer policy can be set to following values:
- <script>'s "referrerpolicy" attribute is used for <script type='module'>. This
hasn't been implemented yet (see https://crbug.com/841673), so the current
document's referrer policy is used to keep the backward compatibility.
// The "prepare a script" algorithm:
"20. Let referrer policy be the current state of the element's referrerpolicy
content attribute."
"22. Let options be a script fetch options whose cryptographic nonce is
cryptographic nonce, ..., and referrer policy is referrer policy."
https://html.spec.whatwg.org/multipage/scripting.html#prepare-a-script
- <link>'s "referrerpolicy" attribute is used for modulepreload.
// The "Link type "modulepreload"" algorithm:
"9. Let referrer policy be the current state of the element's referrerpolicy
attribute."
"10. Let options be a script fetch options whose cryptographic nonce is
cryptographic nonce, ..., and referrer policy is referrer policy."
https://html.spec.whatwg.org/multipage/links.html#link-type-modulepreload
- The default referrer policy is used for module workers and worklets. This is
the reason why this CL changes test expectations of workers and worklets.
// The "fetch a module worker script graph" algorithm:
"2. Let options be a script fetch options whose cryptographic nonce is the
empty string, ..., and referrer policy is the empty string."
https://html.spec.whatwg.org/multipage/webappapis.html#fetch-a-module-worker-script-tree
Change-Id: Ic0f9e6667cd1b84f74d86fcc948451c1d2f8191f
Bug: 842553, 855963
Reviewed-on: https://chromium-review.googlesource.com/1111743
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569967}
--
wpt-commits: 50b0943d82d36bb92977002bebd5a7990e0ed388
wpt-pr: 11626
Automatic update from web-platform-testswebdriver: remove ES6 constructs from WebDriver tests for IE support (#11637)
IE does not support array destructuring in a `let` statement. This commit
allows the newly added element_click tests to run on IE 11.
--
wpt-commits: f9d0147b58f595f23afb6f66326745e96e105e07
wpt-pr: 11637
Automatic update from web-platform-testsUpdate Web Platform Tests for Feature Policy integration into HTML spec.
Change-Id: Ibfcc3e8bc217aff8782d2aec4c1b73bb4a193e1e
Reviewed-on: https://chromium-review.googlesource.com/1053106
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569778}
--
wpt-commits: a5facbd6fb610d896eabffbebb45da59edfbff13
wpt-pr: 10966
Automatic update from web-platform-tests[css-grid] Fix positioned items in a grid with calc() gutters
In r543079 we added support for calc() in grid gutters.
In that patch we modified LayoutGrid::GridGap() but we forgot
to do the same in LayoutGrid::AvailableSpaceForGutters().
This patch just changes the IsPercent() call by IsPercentOrCalc()
that way calc() gutters are considered too when looking
for the available space.
BUG=816300
TEST=external/wpt/css/css-grid/abspos/grid-positioned-items-gaps-002.html
TEST=external/wpt/css/css-grid/abspos/grid-positioned-items-gaps-002-rtl.html
Change-Id: I3237d5dc73f508cea6d904b9f1fd3822bb9efe55
Reviewed-on: https://chromium-review.googlesource.com/1112237
Reviewed-by: Sergio Villar <svillar@igalia.com>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#569733}
--
wpt-commits: 95c2419892175edc877e24672d8bafb8df28cfdd
wpt-pr: 11629
Automatic update from web-platform-tests[css-tables] Make scrollbars visible on mac screenshots
wpt.fyi showed Safari passing these recently-added tests because the
scrollbars don't show in either the tests or their refs.
https://wpt.fyi/css/css-tables/height-distribution/percentage-sizing-of-table-cell-replaced-children-001.html
Aside:
Edge matches Safari's current and Chrome's previous behavior. But
they've confirmed it's a bug:
https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/17505131/
Firefox has a mostly-unrelated incompatibility that doesn't allow us to
check it.
Bug: 837408,838144
Change-Id: I82058d3c22d7668711e9a9a1c977047033d64b46
Reviewed-on: https://chromium-review.googlesource.com/1054770
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569698}
--
wpt-commits: 644c41319451e14d31430f659c00bda948ab078e
wpt-pr: 10959
Automatic update from web-platform-testsCorrectly resolve relative URLs for registered custom properties.
Relative URLs in registered custom properties must resolve against the
base URL of the originating stylesheet. For instance, consider a style-
sheet at /style/mystyle.css:
--foo: url("myimage.jpg");
And a document at /index.html:
<style>
background-image: var(--foo);
</style>
If the property --foo is registered with syntax <url>, then the background-
image should be /style/myimage.jpg.
This is contrary to non-registered properties, in which case the
background-image would be /myimage.jpg.
To implement this, this patch scans for URL tokens and 'url('-function
tokens after (var-)resolving the registered custom property
(see CSSVariableResolver::ResolveCustomProperty). The token containing
the relative URL is then rewritten (in-place) to contain an absolute URL
instead.
To avoid doing unnecessary work, we only scan the token stream if
CSSVariableData::needs_variable_resolution_ is set. This is set either
if needs_url_resolution_ is set (because var-references could produce
relative URLs), or if the token stream contains URL/function-tokens.
When a resolved CSSVariableData is created (::CreateResolved), it is
assumed that the incoming token stream contains no URLs that need to be
resolved.
R=futhark@chromium.org, timloh@chromium.org
Bug: 851490
Change-Id: I25b1e839fc92eb538f30670fe91fc92a1ad9d5ea
Reviewed-on: https://chromium-review.googlesource.com/1109975
Commit-Queue: Anders Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569663}
--
wpt-commits: 372c7ad36a7e42a89228aa2bb88b35da5f519fa5
wpt-pr: 11611
Automatic update from web-platform-tests[css-contain] Size containment replaced elements intrinsic size is zero
The spec is very clear about this
(https://drafts.csswg.org/css-contain/#containment-size):
"Replaced elements must be treated as having an intrinsic width
and height of 0."
The patch modifies LayoutReplaced::ComputeIntrinsicSizingInfo()
so that it returns zero for elements with "contain: size".
BUG=853441
TEST=external/wpt/css/css-contain/contain-size-013.html
Change-Id: I91490b120a110be20a91d564da4fdc3d9a11b70a
Reviewed-on: https://chromium-review.googlesource.com/1110819
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#569610}
--
wpt-commits: 46c8d39a9fde254df3398c681fd724990d289892
wpt-pr: 11622
Automatic update from web-platform-testsCompleted 'unsafe-hashes' per spec
'unsafe-hashed-attributes' renamed to 'unsafe-hashes'
'unsafe-hashes' matches style attributes correctly now
'unsafe-hashes' works for javascript: URLs
'unsafe-hashes' tests added and ammended
spec (approved and to be submitted at the same time as this CR):
https://github.com/w3c/webappsec-csp/pull/311
I2I: https://groups.google.com/a/chromium.org/d/msg/blink-dev/4dohVXDfEI4/tO6rhuv4AwAJ
Bug: 771922
Change-Id: I018cc0f73d492cb4057ff4c41d9be4df8438036c
Reviewed-on: https://chromium-review.googlesource.com/1095217
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569593}
--
wpt-commits: fb04aed6ac840bd35178406583af6da6759c3566
wpt-pr: 11457
Automatic update from web-platform-testsSec-Metadata: Strings are quoted in structured headers.
So this patch adds quotes.
See https://tools.ietf.org/html/draft-ietf-httpbis-header-structure-06#section-3.7
and 98f7c1253e.
Bug: 843478
Change-Id: I29dfa3a87e3c65a1b64009e173faa6d0f41b40f4
Reviewed-on: https://chromium-review.googlesource.com/1109819
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569554}
--
wpt-commits: d6020b4e6f97afaa89624f316611061673eb3f53
wpt-pr: 11605
Automatic update from web-platform-tests[testharness.js] Get title from the filename or a META comment if not given (#11403)
--
wpt-commits: f777ec99a11d0d0522e691a8dab93c70d70941f3
wpt-pr: 11403
Automatic update from web-platform-testsWPT: Add long timeout to service-worker/navigation-redirect.https.html test.
This test is slow because it does a lot of navigations.
Bug: 854913
Change-Id: I2b5f984ba4b656af0d735b3c2c14952fdac5867b
Reviewed-on: https://chromium-review.googlesource.com/1111493
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569544}
--
wpt-commits: 91c59efbec2e393f48c9983b5c84acc1aa55efd5
wpt-pr: 11620
