EMEMediaDataDecoderProxy doesn't override all inherited methods. Without
providing the same proxy thread, it's possible to break to the thread model.
Differential Revision: https://phabricator.services.mozilla.com/D122627
I'm not sure if this is needed in Gecko, but it matches the similar command in
standalone taskgraph so makes the two more in sync. I don't think having it
will hurt.
Differential Revision: https://phabricator.services.mozilla.com/D122527
This is a direct copy of the one in standalone taskgraph at this point in time.
Some modifications will be made in follow-up revisions so it's evident in the
review which changes will be out-of-sync.
Differential Revision: https://phabricator.services.mozilla.com/D122520
Fixes the case where credit card autofill incorrectly fills the expiration month due to input elements and placeholders on those input elements.
Enables unit tests for form autofill.
Additionally adds tests to ensure the previous behavior of autofilling expiration month using select elements.
Added workarounds in tests so that we don't change the reality of the mocked CC storage.
Differential Revision: https://phabricator.services.mozilla.com/D119659
To look up/instantiate platform fonts based on CSS font properties, we create a gfxFontGroup from an nsFont and other attributes; this is currently cached in an nsFontCache attached to the nsDeviceContext.
However, this assumes that the mapping to platform fonts will be the same for all documents using the given device context. In a world where visibility of platform fonts to the page may be restricted, and may depend on the individual document (e.g. if the user disables tracking protection for a particular site), the mapping represented by nsFontCache may vary, and determining how to resolve a given font request will need access to the requesting document in order to know what visibility it is allowed.
To support this, this patch moves the nsFontCache from nsDeviceContext to nsPresContext. In itself, this should cause no visible change in behavior, but it provides a basis for the patches that will follow in bug 1715501.
It's likely that this will have some effects on individual performance tests, depending on the exact content and sequencing of page loads, because of changed caching behavior. E.g. having a per-presContext cache may sometimes mean that we no longer take advantage of a cached gfxFontGroup that a previously-loaded page created; but on the other hand the caches will tend to be smaller and have faster lookups.
My testing so far suggests that we will see some apparent regressions, alongside some improvements, but that overall there should be little change. I'd like to get this change landed separately, before any of the actual font-visibility behavior changes, so that we can more clearly see and isolate any unexpected effects.
Differential Revision: https://phabricator.services.mozilla.com/D122715
It tries to delete a text node if it's invisible both selection start and
selection end. However, the selection range may be in a text node. If it's
an invisible, the node is deleted at first call of
`DeleteNodeIfInvisibleAndEditableTextNode()`, but it keep trying to remove
again with same method.
Differential Revision: https://phabricator.services.mozilla.com/D122561
The test overwrites a fluent-originating text content with its own,
but doesn't clear the fluent data-l10n-id attribute. As a result,
if it tries to write the textContent before the data-l10n-id pass
from fluent has run, fluent overwrites the textContent before we
do a search, and then the rest of the test gets bogus results
because it matches against the wrong text content.
This patch fixes this by removing the data-l10n-id attribute so
the fluent pass doesn't try to put text in these elements
anymore.
Differential Revision: https://phabricator.services.mozilla.com/D122659
When the parser encounters a `</template>` end tag and there are other
open elements, the HTML spec requires the parser to “generate all
implied end tags thoroughly”, which unlike “generate implied end tags”
also includes generating implied end tags for table-parts elements
(caption, colgroup, tbody, thead, tfoot, td, th, and tr).
Differential Revision: https://phabricator.services.mozilla.com/D82020
Doing `errUnclosedElements(eltPos, "template")` for EOF in the “in
template” state results in the error message “End tag `template` seen, but
there were open elements”, which is all wrong because the actual problem is
that though a `template` end tag was expected, EOF was reached without a
`template` end tag being seen.
So let’s instead when we reach this just report the list of open elements.
Differential Revision: https://phabricator.services.mozilla.com/D122598
By bug 1719110, we replace sync IPC's spell checker suggestion with async
version. So we should remove this sync IPC call.
Differential Revision: https://phabricator.services.mozilla.com/D122579
This will allow experimenting with different representations of
the spatial tree (such as interning and/or providing stable
indices during display list building). It may also simplify
future changes to the public API to expose the spatial tree
directly.
As part of these changes, refactor how the debug representation
for the capture format is (de)serialized, to make it simpler to
add different payload vector types in future.
Differential Revision: https://phabricator.services.mozilla.com/D122183
Automatic update from web-platform-tests
Remove non-invertible-transform-animation.html
The test added in https://crrev.com/911926 is failing on Safari:
https://staging.wpt.fyi/results/css/css-animations/non-invertible-transform-animation.html
This test only covered the behavior change in https://crrev.com/911926
when run manually because any runs of the lifecycle, such as the raf
run at the end of the test, would hide the bug. The test was re-written
using web animations which should pass reliably on Safari, but that
approach hides the original bug when running the test manually. Because
the WPT test is of minimal value, and the behavior change is tested via
a unit test, this patch just removes the test.
Bug: 1227011
Change-Id: I08f02d1c6e8f74eaddd036ed4cc479d9b47255d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3095427
Commit-Queue: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Auto-Submit: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#912002}
--
wpt-commits: 0bc996384524028f8608c311d35ee7ebdf29afca
wpt-pr: 30032
