BasicDllServices is used to gain access to the authenticode APIs in non-Gecko
contexts. One feature that WinDllServices provides is the ability to register
a callback interface to be notified when a DLL has been loaded.
This is not particularly useful in the BasicDllServices use case, and in the
"handle a launcher process failure on a background thread" use case, would
actually be harmful.
This patch modifies the DLLServices backend to offer a "basic" option that
omits the callback stuff.
Differential Revision: https://phabricator.services.mozilla.com/D19696
--HG--
extra : moz-landing-system : lando
Remove the ability for fake plugins to create frames. Fake plugins
aren't used anymore, so we can simplify nsFrameLoader a bit by
removing some of the related checks.
Differential Revision: https://phabricator.services.mozilla.com/D20430
--HG--
extra : moz-landing-system : lando
This may lose some tiny amount of performance since the existing code
duplicated a huge amount of code in order to avoid walking bits of the tree
that can't contain functions. I preserved a few of those hacks but some of the
bits seemed too small to bother with.
The expression `nparents_ - 1` is changed to `nparents_ - 2` because, as a
result of how ParseNodeVisitor control flow works, we now call gatherNameable
*after* pushing the current FunctionNode to the stack, rather than before.
(A new assertion checks that this is the case.)
Differential Revision: https://phabricator.services.mozilla.com/D20720
--HG--
extra : moz-landing-system : lando
This is meant as a sanity patch. Before, buf_ was a pointer to a local
variable, set in resolveFun() and just left dangling on exit. No bug, but
dangling pointers are bad.
I considered removing buf_ and passing around a reference to the local
StringBuffer, but this was quicker and seemed easier to review.
Differential Revision: https://phabricator.services.mozilla.com/D20719
--HG--
extra : moz-landing-system : lando
The `Expr` suffix is for nodes that can appear anywhere an expression could
appear. This kind of node can't; it's always the direct child of a tagged
template.
Differential Revision: https://phabricator.services.mozilla.com/D20717
--HG--
extra : moz-landing-system : lando
I tried making ParseNodeVisitor take all nodes as references, but that didn't
work nicely with the existing accept() method templates. That could have been
made to work using more template tricks, but I decided pointers are not so bad.
There still was no way to avoid the code duplication here without contortions.
Differential Revision: https://phabricator.services.mozilla.com/D20716
--HG--
extra : moz-landing-system : lando
Some functionality is intentionally unimplemented to make this patch
smaller and at a faster cadence: field initializers are stored on
this['.initializers'] instead of a local, derived classes are not
supported yet, and constant-folding/inline field initializers are not
implemented.
Differential Revision: https://phabricator.services.mozilla.com/D16343
--HG--
extra : moz-landing-system : lando
Support for `kind='task'` is still around to support Thunderbird release
promotion, which uses releaserunner3. Other actions shouldn't be using it.
Differential Revision: https://phabricator.services.mozilla.com/D20842
--HG--
extra : moz-landing-system : lando
I suspect these may have been cargo-culted from elsewhere.
We only need -Wno-sign-compare, which we can add regardless of compiler because clang-cl understands it natively in addition to the -wdNNNN form.
Differential Revision: https://phabricator.services.mozilla.com/D20616
--HG--
extra : moz-landing-system : lando
Switch to using DOMFormBeforeSubmit event instead of earlyformsubmit observer notifications.
Differential Revision: https://phabricator.services.mozilla.com/D16656
--HG--
extra : moz-landing-system : lando
Extend ActorChild for satchel's formSubmitListener in order to listen to the event.
Differential Revision: https://phabricator.services.mozilla.com/D16655
--HG--
rename : toolkit/components/satchel/formSubmitListener.js => toolkit/components/satchel/FormSubmitChild.jsm
extra : moz-landing-system : lando
The blur event doesn't bubble so this wouldn't actually listen to fields getting blurred. See bug 1138774.
Differential Revision: https://phabricator.services.mozilla.com/D20396
--HG--
extra : moz-landing-system : lando
It wasn't clear in callee code that the window was the top-window and it wasn't necessary in many cases. Relying on the top-window would also cause problems with Fission if the windows are in separate processes.
Differential Revision: https://phabricator.services.mozilla.com/D20395
--HG--
extra : moz-landing-system : lando
There were too many top-level objects in that large JSM and LoginHelper didn't exist when it was added.
Differential Revision: https://phabricator.services.mozilla.com/D20393
--HG--
extra : moz-landing-system : lando
