Adds a new event listener to `browser.urlbar` called `onResultPicked`. This event is fired for tip results when they don't specify a URL. Hypothetically it could be fired for any type of result that didn't specify a URL, but that's only tips for now.
The listener is passed two arguments: the payload of the result that was picked, and a "details" object whose properties depend on the type of result. For tips, details is `{ helpPicked }`, where `helpPicked` is true if the help button was picked and false if the main button was picked.
Differential Revision: https://phabricator.services.mozilla.com/D46254
--HG--
extra : source : febf4480bc0bce19a0c8883e0c9296c40013e01e
Adds a new event listener to `browser.urlbar` called `onResultPicked`. This event is fired for tip results when they don't specify a URL. Hypothetically it could be fired for any type of result that didn't specify a URL, but that's only tips for now.
The listener is passed two arguments: the payload of the result that was picked, and a "details" object whose properties depend on the type of result. For tips, details is `{ helpPicked }`, where `helpPicked` is true if the help button was picked and false if the main button was picked.
Differential Revision: https://phabricator.services.mozilla.com/D46254
--HG--
extra : moz-landing-system : lando
Adds a new event listener to `browser.urlbar` called `onResultPicked`. This event is fired for tip results when they don't specify a URL. Hypothetically it could be fired for any type of result that didn't specify a URL, but that's only tips for now.
The listener is passed two arguments: the payload of the result that was picked, and a "details" object whose properties depend on the type of result. For tips, details is `{ helpPicked }`, where `helpPicked` is true if the help button was picked and false if the main button was picked.
Differential Revision: https://phabricator.services.mozilla.com/D46254
--HG--
extra : moz-landing-system : lando
This patch allows geckodriver to interact with processes of
GeckoView packages on Android devices while running itself
on a host machine. The connection to and from the application
under test is done via adb forward ports.
Depends on D45363
Differential Revision: https://phabricator.services.mozilla.com/D44897
--HG--
extra : moz-landing-system : lando
On Android the platform name capability has to report "android" and not "linux".
Also for every application which is embedding GeckoView "firefox" will be used
as browser name. That way it behaves the same like Chrome, which does it for
every WebView embedding application.
Depends on D44896
Differential Revision: https://phabricator.services.mozilla.com/D45363
--HG--
extra : moz-landing-system : lando
This allows to port-forward using adb. Connecting to such ports
always establishes a TCP connection to the ADB daemon, but not all
such connections are to bound ports. Waiting for the Marionette
handshake ensures the connection is real, and not just partially
forwarded.
Depends on D44895
Differential Revision: https://phabricator.services.mozilla.com/D44896
--HG--
extra : moz-landing-system : lando
This implementation speaks the ADB wire protocol over TCP/IP. This is
in constrast to the Python implementation, which generally invokes adb
on the command line. In thousands of runs across multiple devices,
this implementation has proved surprisingly robust.
Differential Revision: https://phabricator.services.mozilla.com/D44895
--HG--
extra : moz-landing-system : lando
This approach does have some stacking issues. The way to fix this would
be to instrument the brush_image shader rather than adding debug rects.
Something like: #ifdef WR_FEATURE_SFW frag.color = vec4(0,1,1,1); #endif
That's slightly more involved though, so I'm going to leave it for now.
Differential Revision: https://phabricator.services.mozilla.com/D47155
--HG--
extra : moz-landing-system : lando
NFC. The select operator will be given an array of result types, so this commit
requisitions AstTernaryOperator to be a dedicated select ast node. There's no
other uses of AstTernaryOperator, so this is just a rename.
Differential Revision: https://phabricator.services.mozilla.com/D45865
--HG--
extra : moz-landing-system : lando
This commit renames TVar to represent the new Bottom type introduced in the
reference types spec.
Issue: https://github.com/WebAssembly/reference-types/issues/42
The only observable spec change so far is in validation of br_table which
requires that the operand type is a subtype of all label types. With a bottom
type, this may allow more code to validate than before.
Differential Revision: https://phabricator.services.mozilla.com/D46641
--HG--
extra : moz-landing-system : lando
Issue: https://github.com/WebAssembly/reference-types/issues/42
The existing select instruction contains no typing information. As more
complicated types are added, we will need to infer the result type as the
least upper bound of the operands. This may be a complicated operation,
so we will restrict the existing untyped instruction to operate only on
the MVP value types, and add a new select instruction with type information.
Differential Revision: https://phabricator.services.mozilla.com/D45863
--HG--
extra : moz-landing-system : lando
This changes:
1. Take `NumberOperandId` at the part which can use the result of `CacheIRWriter.guardIsNumber()`.
2. Use `NumberOperandId` as a function signature which would only take a number operand.
* There are some exceptions, i.e.`CacheIRWriter.writer.truncateDoubleToUInt32()`,
because `NumberOperandId` is not always `double`.
Differential Revision: https://phabricator.services.mozilla.com/D46707
--HG--
extra : moz-landing-system : lando
An error crept in, resulting in:
```
[task ...] InterpreterError: InterpreterError: infix: [..] expects integer [..] integer
```
At some point, `suite` became a string name and not an object with a
string `name` member. However, in the interim, the diversity of
`command` structures has made the template approach untenable.
Therefore, this commit converts `GeckoProfile` to a `TryConfig`. The
existing test clearly wasn't helpful, and it doesn't really map to a
`TryConfig` test, so it was removed.
Differential Revision: https://phabricator.services.mozilla.com/D41603
--HG--
extra : moz-landing-system : lando
