Commit Graph

667983 Commits

Author SHA1 Message Date
Barret Rennie
c48dcf7d7c Bug 1510569 - Port onSecurityChange from WebProgressChild.jsm to C++; remove WebProgressChild r=Ehsan,ochameau
This is the last message that WebProgressChild was sending to the
RemoteWebProgress in the parent process, so we can remove the module entirely.

Differential Revision: https://phabricator.services.mozilla.com/D35091

--HG--
extra : moz-landing-system : lando
2019-08-28 18:55:45 +00:00
Barret Rennie
b0cbc31990 Bug 1510569 - Implement serializers for nsITransportSecurityInfo, nsIX509Cert, and nsIX509CertList r=froydnj,keeler,mayhemer
As part of the ongoing effort to port the nsIWebProgress events from
RemoteWebProgress / WebProgressChild to BrowserParent / BrowserChild, we need
to (de)serialize the nsITransportSecurityInfo instance across the IPC layer.
The existing code was calling `NS_SerializeToString` which has the overhead of
(a) allocating a buffer and also performing base64 encoding/decoding. This
patch adds `IPC::ParamTraits` implementations for `nsITransportSecurityInfo`,
`nsIX509Certificate`, and `nsIX509CertList` that (de)serializes the params
directly onto and off of the IPC message so that we don't go through the
overhead of allocating and encoding/decoding an additional buffer.

This (de)serialization will address the performance issues present in the
current implementation.

As a side effect, I also make nsITransportSecurityInfo a builtinclass XPCOM
interface, since the existing serialization code was assuming it was, there is
only one implementation, and it is in C++.

Differential Revision: https://phabricator.services.mozilla.com/D35090

--HG--
extra : moz-landing-system : lando
2019-08-28 18:55:31 +00:00
Tom Ritter
004d9a25d7 Bug 1570597 - Pass the -delayload flag to lld correctly for MinGW builds r=firefox-build-system-reviewers,mshal
Differential Revision: https://phabricator.services.mozilla.com/D43455

--HG--
extra : moz-landing-system : lando
2019-08-28 14:18:29 +00:00
Aaron Klotz
7d3e1ba397 Bug 1577061: Modify nsUpdateDriver's GetCurrentWorkingDir to accept a nsACString& argument; r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D43711

--HG--
extra : moz-landing-system : lando
2019-08-28 17:29:06 +00:00
Dorel Luca
06a2578d2d Backed out changeset 3853d8979a55 (bug 1575240) for Devtools on devtools/client/webconsole/test/browser/browser_jsterm_inspect.js
--HG--
extra : rebase_source : a9ffc17ade0874f515e44152d78af257c10df334
2019-08-28 22:08:26 +03:00
Julian Descottes
5e92caeefc Bug 1575766 - Use chrome preferences for DevTools documents r=emilio
Depends on D43639

This will avoid applying High Contrast mode colors to devtools documents even when DevTools are loaded in a frame with type=content
This behavior can be disabled by setting devtools.toolbox.force-chrome-prefs to false

Differential Revision: https://phabricator.services.mozilla.com/D43614

--HG--
extra : moz-landing-system : lando
2019-08-28 13:09:36 +00:00
Julian Descottes
541fe531d2 Bug 1575766 - Set mIsDevToolsDocument on DevTools documents r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D43639

--HG--
extra : moz-landing-system : lando
2019-08-28 19:08:17 +00:00
Jeff Muizelaar
25ba978024 Bug 1577190. Don't treat Mask items like Filter items in DetectContainerLayerPropertiesBoundsChange. r=nical,mstange
This is a remnant from the previous implementation of masking. That
implementation was replaced in bug 1447880.

Differential Revision: https://phabricator.services.mozilla.com/D43763

--HG--
extra : moz-landing-system : lando
2019-08-28 18:51:45 +00:00
Ed Lee
7d74fb8a1e Bug 1572515 - mach lint complains about newtab logs missing license r=dmose
Exclude "built" logs/ directory from any linting

Differential Revision: https://phabricator.services.mozilla.com/D41263

--HG--
extra : moz-landing-system : lando
2019-08-28 17:20:18 +00:00
Dorel Luca
b09fe526aa Backed out 4 changesets (bug 1510569) for build bustage. CLOSED TREE
Backed out changeset d7db6a1935ce (bug 1510569)
Backed out changeset 03b7cf756a7f (bug 1510569)
Backed out changeset fa318eec0e76 (bug 1510569)
Backed out changeset cecb17bd8c03 (bug 1510569)
2019-08-28 21:46:40 +03:00
Chris Manchester
de2343b7fc Bug 1572880 - Package dist-toolchains from a specific directory. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D43696

--HG--
extra : moz-landing-system : lando
2019-08-28 18:34:29 +00:00
Chris Manchester
1dcf500d9c Bug 1577049 - Provide sccache and dist-toolchains during bootstrap on Windows. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D43700

--HG--
extra : moz-landing-system : lando
2019-08-28 18:31:23 +00:00
Barret Rennie
697c695a3c Bug 1510569 - Use nsIPrincipal and nsIContentSecurityPolicy in WebProgressLocationChangeData directly r=nika
Now that there is an {IPDL}ParamTraits implementation for nsIPrincipal* and
nsIContentSecurityPolicy*, we need not manually transform it to/form a
PrincipalInfo/CSPInfo ourselves.

Differential Revision: https://phabricator.services.mozilla.com/D36637

--HG--
extra : moz-landing-system : lando
2019-08-28 18:00:36 +00:00
Barret Rennie
d60f7b37a8 Bug 1510569 - Add nsIWebProgressListener2 to BrowserChild's interface map r=Ehsan
The members of nsIWebProgressListener2 were added to BrowserChild (then
TabChild) in commit 1028814583232487b52b9c20d47e3b38dc1c288a, but the interface
was never added to the interface map.

Differential Revision: https://phabricator.services.mozilla.com/D35134

--HG--
extra : moz-landing-system : lando
2019-08-28 18:00:27 +00:00
Barret Rennie
e0d50ea7ce Bug 1510569 - Port onSecurityChange from WebProgressChild.jsm to C++; remove WebProgressChild r=Ehsan,ochameau
This is the last message that WebProgressChild was sending to the
RemoteWebProgress in the parent process, so we can remove the module entirely.

Differential Revision: https://phabricator.services.mozilla.com/D35091

--HG--
extra : moz-landing-system : lando
2019-08-28 18:00:23 +00:00
Barret Rennie
4ab0fd7d38 Bug 1510569 - Implement serializers for nsITransportSecurityInfo, nsIX509Cert, and nsIX509CertList r=froydnj,keeler,mayhemer
As part of the ongoing effort to port the nsIWebProgress events from
RemoteWebProgress / WebProgressChild to BrowserParent / BrowserChild, we need
to (de)serialize the nsITransportSecurityInfo instance across the IPC layer.
The existing code was calling `NS_SerializeToString` which has the overhead of
(a) allocating a buffer and also performing base64 encoding/decoding. This
patch adds `IPC::ParamTraits` implementations for `nsITransportSecurityInfo`,
`nsIX509Certificate`, and `nsIX509CertList` that (de)serializes the params
directly onto and off of the IPC message so that we don't go through the
overhead of allocating and encoding/decoding an additional buffer.

This (de)serialization will address the performance issues present in the
current implementation.

As a side effect, I also make nsITransportSecurityInfo a builtinclass XPCOM
interface, since the existing serialization code was assuming it was, there is
only one implementation, and it is in C++.

Differential Revision: https://phabricator.services.mozilla.com/D35090

--HG--
extra : moz-landing-system : lando
2019-08-28 18:00:16 +00:00
Jeff Walden
39de34a911 Bug 1577065 - Fix an implicit-conversion-changes-value warning with new-enough clang in AtomicsObject.cpp by explicitly converting. r=lth
Differential Revision: https://phabricator.services.mozilla.com/D43706

--HG--
extra : moz-landing-system : lando
2019-08-28 06:44:50 +00:00
Jeff Walden
aeb4f741d0 Bug 1577051 - Fix an implicit-conversion-changes-value warning with new-enough clang by explicitly converting. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D43701

--HG--
extra : moz-landing-system : lando
2019-08-28 16:35:22 +00:00
James Willcox
746abdeae8 Bug 1343678 - Add WebPush support to GeckoView r=jcj,lina,agi,geckoview-reviewers,droeh,mt
Differential Revision: https://phabricator.services.mozilla.com/D41290

--HG--
extra : moz-landing-system : lando
2019-08-28 14:21:47 +00:00
James Willcox
8fca72b2b4 Bug 1343678 - Use window context for GeckoSessionTestRule.evaluateJS() r=geckoview-reviewers,droeh
Differential Revision: https://phabricator.services.mozilla.com/D41289

--HG--
extra : moz-landing-system : lando
2019-08-28 14:21:45 +00:00
James Willcox
3c29fb1982 Bug 1343678 - Enable web push pref for GeckoView r=geckoview-reviewers,droeh,smaug
Differential Revision: https://phabricator.services.mozilla.com/D41288

--HG--
extra : moz-landing-system : lando
2019-08-28 16:06:39 +00:00
Agi Sferro
2ad08f6d15 Bug 1576204 - Set remote flag in nsWindow for e10s. r=kmag,snorp
Chrome flags need to be set both on the `window` and the `browser` object.
Right now we only set them on the `browser` objects and that could lead to
unintended consequences. This patch sets the flags to the `window` accordingly.

Differential Revision: https://phabricator.services.mozilla.com/D43523

--HG--
extra : moz-landing-system : lando
2019-08-28 18:11:08 +00:00
Yura Zenevich
346739d4b9 Bug 1564968 - add keyboard audit filter/badge to the accessibility panel. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D43446

--HG--
rename : devtools/client/accessibility/components/TextLabelBadge.js => devtools/client/accessibility/components/KeyboardBadge.js
extra : moz-landing-system : lando
2019-08-28 13:09:17 +00:00
Yura Zenevich
722e0fdc59 Bug 1564968 - add keyboard check section within accessibility panel sidebar checks. r=gl,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D43445

--HG--
extra : moz-landing-system : lando
2019-08-28 13:09:19 +00:00
Yura Zenevich
00c46e63a1 Bug 1564968 - create Check component for a generic check result in the checks section of the accessibility panel sidebar. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D43444

--HG--
extra : moz-landing-system : lando
2019-08-28 13:09:21 +00:00
Yura Zenevich
f025c6403a Bug 1564968 - add highlighting support for keyboard issues. r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D43443

--HG--
rename : devtools/server/tests/browser/browser_accessibility_infobar_audit_text_label.js => devtools/server/tests/browser/browser_accessibility_infobar_audit_keyboard.js
extra : moz-landing-system : lando
2019-08-28 13:09:23 +00:00
Yura Zenevich
511b056b80 Bug 1564968 - adding keyboard audit type serverside support. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D43442

--HG--
extra : moz-landing-system : lando
2019-08-28 13:09:24 +00:00
Yura Zenevich
dae04e052b Bug 1564968 - add isElementThemed method to InspectorUtils to infer native theme styling such as focus. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D43441

--HG--
extra : moz-landing-system : lando
2019-08-28 17:49:22 +00:00
Gabriel Luong
7e80772a80 Bug 1568157 - Part 5: Move the NodePicker initialization into a getter. r=yulia
Differential Revision: https://phabricator.services.mozilla.com/D43567

--HG--
extra : moz-landing-system : lando
2019-08-28 12:03:30 +00:00
Gabriel Luong
8a3245ac6c Bug 1568157 - Part 4: Replace toolbox.walker with the contextual WalkerFront. r=yulia
Differential Revision: https://phabricator.services.mozilla.com/D40317

--HG--
extra : moz-landing-system : lando
2019-08-28 11:54:42 +00:00
Boris Zbarsky
58b843488c Bug 1569735. Move almost all uses of binaryNames out of Bindings.conf and into .webidl files. r=peterv
The one exception, apart from tests, is a place where the constructor is being
renamed, because there is no way to support that syntactically yet.  There will
be if https://github.com/heycam/webidl/issues/636 is fixed.

Differential Revision: https://phabricator.services.mozilla.com/D39792

--HG--
extra : moz-landing-system : lando
2019-08-28 17:51:37 +00:00
Luca Greco
99a260aa03 Bug 1562117 - Fix race in test_ext_normandyAddonStudy test cases. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D43742

--HG--
extra : moz-landing-system : lando
2019-08-28 17:32:28 +00:00
Justin Wood
5b39931720 Bug 1566298 - Followup, don't look for en-US langpacks in an 'en-US/' path. r=jlorenzo
Sign language packs via Autograph instead of AMO.

Differential Revision: https://phabricator.services.mozilla.com/D43595

--HG--
extra : moz-landing-system : lando
2019-08-28 17:18:14 +00:00
Aki Sasaki
310e1af8f5 Bug 1566298 - fix langpack-copy dependencies. r=nthomas a=release CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D43556

--HG--
extra : moz-landing-system : lando
2019-08-28 17:18:47 +00:00
Itiel
d28c64390c Bug 1576092 - Fix the breadcrumbs' arrow border color for white theme r=gl
Differential Revision: https://phabricator.services.mozilla.com/D43769

--HG--
extra : moz-landing-system : lando
2019-08-28 17:45:06 +00:00
Tim Nguyen
4fbf58d91c Bug 1577022 - Add spacing before copy buttons in about:logins. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D43791

--HG--
extra : moz-landing-system : lando
2019-08-28 17:45:32 +00:00
Jared Wein
04d36a184b Bug 1556658 - Middle-clicking on the origin should open the link. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D43526

--HG--
extra : moz-landing-system : lando
2019-08-28 17:44:06 +00:00
Jason Laster
b553db9b43 Bug 1575240 - inspect(x) should show x in the appropriate panel. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D42747

--HG--
extra : moz-landing-system : lando
2019-08-28 12:04:49 +00:00
Andrew Creskey
7134be5031 Bug 1575938 Convert dom/JSEnvironment GC timing constants to StaticPref r=edgar
Converted the following to StaticPrefs so that we can easily test variations:

NS_GC_DELAY
NS_SHRINK_GC_BUFFERS_DELAY
NS_FIRST_GC_DELAY
NS_FULL_GC_DELAY
NS_INTERSLICE_GC_DELAY

NS_USER_INTERACTION_INTERVAL

Differential Revision: https://phabricator.services.mozilla.com/D43112

--HG--
extra : moz-landing-system : lando
2019-08-26 15:51:01 +00:00
Coroiu Cristina
57a229355c Backed out changeset dd79fbdfac8d (bug 1507193) for wpt failures at media-source/mediasource-seek-beyond-duration.html on a CLOSED TREE 2019-08-28 20:40:18 +03:00
Coroiu Cristina
a52358e99a Backed out changeset dcd17905b58d (bug 1575645) for browser-chrome failures at browser/base/content/test/static/browser_parsable_css.js on a CLOSED TREE 2019-08-28 20:34:24 +03:00
Gurzau Raul
e4ce5cd90c Backed out changeset cbce223800c1 (bug 1540247) for xpcshell failures at test_obsoleteOrigins.js on a CLOSED TREE. 2019-08-28 19:47:27 +03:00
Edwin Gao
68e1e66469 Bug 1547820 - re-enable media-source wpt tests on windows10-aarch64 r=intermittent-reviewers,jmaher
Re-enabling the disabled manifest `testing/web-platform/meta/media-source/__dir__.ini` for windows10-aarch64 since the tests now pass.

Differential Revision: https://phabricator.services.mozilla.com/D43714

--HG--
extra : moz-landing-system : lando
2019-08-28 08:53:45 +00:00
Simon Giesecke
fc1e20f375 Bug 1540247 - Expose MozURL::Init to JS for QuotaManager tests r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D39207

--HG--
extra : moz-landing-system : lando
2019-08-27 18:14:35 +00:00
Tim Nguyen
8d8b904439 Bug 1542529 - Fix and unify delete icons. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D43732

--HG--
extra : moz-landing-system : lando
2019-08-28 15:36:43 +00:00
Frederic Wang
3f8a2878fa Bug 1548524 - Remove attributes deprecated from MathML3. r=emilio
See https://github.com/mathml-refresh/mathml/issues/5#issuecomment-475506856
and https://groups.google.com/forum/#!topic/mozilla.dev.platform/kl5c87mBlO0

This patch introduces a new preference
mathml.deprecated_style_attributes.disabled in order to disable legacy support
for attributes background, color, fontfamily, fontsize, fontstyle and
fontweight. Note that xlink:href will be handled separately in bug 1575870.

* A new counter and deprecation message is introduced for these attributes.
  In nsMathMLElement, the old WarnDeprecated calls are replaced with a single
  call to WarnOnceAbout for the deprecate attributes. Notice that for some
  reason, the color attribute used to send warning in both ParseAttribute and
  MapMathMLAttributesInto.
* sMtableStyles is removed and replaced with a simple comparison.
* sMathML3Attributes is split into two tables: one for script attributes which
  will be handled in bug 1548471 and one for style attributes, handled here.
  The attributes in this second table is now ignored when the feature flag is
  disabled.
* test_bug553917.html is updated so that it no longer checks the old warning
  messages for these attributes. New warning messages have been verified
  manually.
* Reftests checking support for these attributes are run with the support
  enabled.
* Finally, WPT tests are run with the support disabled and a new test
  is added to verify that these attributes are no longer mapped to CSS.

Differential Revision: https://phabricator.services.mozilla.com/D43111

--HG--
extra : moz-landing-system : lando
2019-08-28 14:59:55 +00:00
Carolina
231a277008 Bug 1575207 - Fixes undefined strings being rendering in Certificate Polices Section.r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D42655

--HG--
extra : moz-landing-system : lando
2019-08-28 13:51:28 +00:00
Nicolas Chevobbe
04f5f42266 Bug 1558417 - Add onboarding UI for Editor. r=Honza.
The onboarding UI is displayed on top of the Editor.
A dismiss button hides it forever (this is handled via
a pref that is set to false when clicking the button).

We take this as an opportunity to polish the Editor UI/wording
a bit.

Differential Revision: https://phabricator.services.mozilla.com/D43621

--HG--
rename : devtools/client/debugger/images/resume.svg => devtools/client/themes/images/webconsole/run.svg
extra : moz-landing-system : lando
2019-08-28 15:42:36 +00:00
Emilio Cobos Álvarez
e57b14dc52 Bug 1576817 - Fix a regression from bug 1490974 where we'll fail to find visibility: visible descendants of visibility: hidden nodes. r=bradwerth
The split between IsDisplayedNode and IsVisibleNode is pretty intentional, since
visibility: visible descendants of visiblity: hidden ancestors are in fact
visible.

We skip fully-invisible ranges in here instead:

https://searchfox.org/mozilla-central/rev/325c1a707819602feff736f129cb36055ba6d94f/toolkit/components/find/nsFind.cpp#776

Differential Revision: https://phabricator.services.mozilla.com/D43745

--HG--
extra : moz-landing-system : lando
2019-08-28 15:15:23 +00:00
Emilio Cobos Álvarez
ed9f59952f Bug 1576817 - Only allow finding editable anonymous nodes in form controls. r=bradwerth
We want to find the text inside the input that the user types, but not stuff
like the placeholder. So check that the anonymous subtree is editable, or skip
it otherwise.

Differential Revision: https://phabricator.services.mozilla.com/D43744

--HG--
extra : moz-landing-system : lando
2019-08-28 15:35:48 +00:00