On ESR[60] stub installer isn't designed to work, and we expect most users of esr will have no use for a stub installer. However this poses some problems where the taskgraph assumes that any Nightly generates a stub installer and thus it should be available along the way.
The patch hardcodes the list of branches that do not need a stub installer, though we'll want to clean up this specification in some way, as Thunderbird will likely need it to be cleaner and we may want on-change builds to use this logic (e.g. for on-change l10n).
Differential Revision: https://phabricator.services.mozilla.com/D1082
--HG--
extra : source : 2f091908b8839650961c3968b6beee1dd8d1084b
taskgraph: Make update tasks support esr60
MozReview-Commit-ID: 7ZUJueBiUwN
--HG--
extra : source : 60fc628ce8ba14cd27fe11f1a575f9beaa96e84b
extra : intermediate-source : 3a617bd3456bf23438b25a8d0b13c9976858226e
Fix all Java warnings in the Android codebase except deprecation and
serial warnings, and warnings in third-party code.
There is one required change to exoplayer2 code under thirdparty,
because that code is included directly in the geckoview project, instead
of the thirdparty project. I think I'll just make a pull-request to
upstream the change, instead of separating exoplayer2 into a
gv-thirdparty project.
kotlinc emits its warning/error messages as "w: <msg>" and "e: <msg>",
which Treeherder is unable to pick up. Rather than changing Treeherder,
it's best to make the change as close to the source of the message as
possible. I looked at changing mach to redirect the output of gradle and
make adjustments as necessary, but for some reason gradle doesn't want
to work with the pipes that mach sets up. So that leaves changing the
gradle build script itself.
This patch adds some code to detect the kotlin messages, and output an
adjusted version as necessary. It has the benefit of only dealing with
kotlinc output, so output from other tools should not be inadvertently
changed. However, due to the way it is implemented, it does duplicate
every warning/error output; for example, an error would now look like
this in the terminal:
<file>: error: <msg>
e: <file>: <msg>
I think this is an acceptable drawback.
- Refactor the logic for getting the grid highlighter settings into HighlightersOverlay.js
- Refactor the grid area and cell highlight into a single function in grid-inspector.js
- Change the order of the parameters for onHighlighterChange in grid-inspector.js
- Get the last highlighted state from the Redux store instead of storing them in a variable
The Fennec CrashReporter class is also renamed to
CrashReporterActivity. When running in Fennec, the Activity will be used
which retains what we do today, prompting for comments, email, etc. When
used in standalone GeckoView, we report the crash without user
interaction if the appropriate GeckoRuntimeSetting was set. The app will
want to ask for user permission at least once in order to set this.
We do not collect the URL, email, or logcat with GeckoView crashes.
Logcat and URL would be nice to have, but it's not clear what the API
for those would look like, and they can be addressed in followup
patches.
MozReview-Commit-ID: C5ROsUKreRe
Right now we pass a bundle to GeckoLoader.setupGeckoEnvironment() with
magic keys representing the environment variables. Instead of this,
simply pass a list of Strings.
MozReview-Commit-ID: D6mSTnYpnGu
- Refactor the logic for getting the grid highlighter settings into HighlightersOverlay.js
- Refactor the grid area and cell highlight into a single function in grid-inspector.js
- Change the order of the parameters for onHighlighterChange in grid-inspector.js
- Get the last highlighted state from the Redux store instead of storing them in a variable
Extract loading the grid highlighter setting into HighlightersOverlay. This
allows the grid highlighter toggle in the rule view to also show the grid
highlighter with the currently set highlight settings if the grid inspector
has not been initiated yet.
