Commit Graph

20134 Commits

Author SHA1 Message Date
Simon Giesecke
9cf654a99f Bug 1645429 - Do not use ReverseIterator in nsTObserverArray::NonObservingRange. r=froydnj
Depends on D79957

Differential Revision: https://phabricator.services.mozilla.com/D79958
2020-06-17 13:29:02 +00:00
Nicholas Nethercote
a8f5f49b8a Bug 1645982 - Rename some service getters in Services.py to better match the types. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D79791
2020-06-16 23:32:21 +00:00
Simon Giesecke
8c0f977ccd Bug 1645429 - Use std::reverse_iterator instead of mozilla::ReverseIterator where possible. r=froydnj
mozilla::ReverseIterator is required for "stashing iterators", but otherwise
std::reverse_iterator can be used and is potentially more efficient.

Also fix some other glitches in iterator type definitions.

Differential Revision: https://phabricator.services.mozilla.com/D79489
2020-06-16 10:14:01 +00:00
Simon Giesecke
08dfb8127e Bug 1645447 - Add ForwardIterator::Remove and EndLimitedIterator::Remove functions. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D79512
2020-06-15 17:04:08 +00:00
Simon Giesecke
94ae89f1d9 Bug 1645359 - Add a nsTObserverArray::NonObservingRange. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D79487
2020-06-15 08:43:54 +00:00
Simon Giesecke
0735ecafd8 Bug 1645382 - Remove unnecessary arguments from NS_OBSERVER_ARRAY_NOTIFY_* macros. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D79485
2020-06-15 09:05:00 +00:00
Simon Giesecke
298981065e Bug 1645339 - Use range-based for with nsTObserverArray in xpcom. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D79484
2020-06-15 08:55:27 +00:00
Andrea Marchesini
6cd06a958e Bug 1636823 - nsInputTransport must support blocking and async source - part 1 - Use NS_MakeAsyncNonBlockingInputStream, r=smaug,necko-reviewers,mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D78233
2020-06-12 22:48:07 +00:00
Narcis Beleuzu
f5fcf19b63 Backed out 4 changesets (bug 1636823) for bustages on TestReadStreamToString.cpp . CLOSED TREE
Backed out changeset 13ab343d2c45 (bug 1636823)
Backed out changeset 50dd67f96214 (bug 1636823)
Backed out changeset 9cdc2e31ee04 (bug 1636823)
Backed out changeset 7d220fd9ac49 (bug 1636823)
2020-06-13 01:13:40 +03:00
Andrea Marchesini
3b2a995725 Bug 1636823 - nsInputTransport must support blocking and async source - part 1 - Use NS_MakeAsyncNonBlockingInputStream, r=smaug,necko-reviewers,mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D78233
2020-06-12 15:51:38 +00:00
Csoregi Natalia
d321aa4f0b Backed out 4 changesets (bug 1636823) for build bustages. CLOSED TREE
Backed out changeset 1de589017a6b (bug 1636823)
Backed out changeset 007bbe713359 (bug 1636823)
Backed out changeset 2f5c418cb7a9 (bug 1636823)
Backed out changeset 43aa94cc6640 (bug 1636823)
2020-06-12 18:45:45 +03:00
Andrea Marchesini
1636f75a58 Bug 1636823 - nsInputTransport must support blocking and async source - part 1 - Use NS_MakeAsyncNonBlockingInputStream, r=smaug,necko-reviewers,mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D78233
2020-06-12 14:22:04 +00:00
Simon Giesecke
e3e7679770 Bug 1386838 - Add STL-style ranges for nsTObserverArray based on ForwardIterator/EndLimitedIterator/BackwardIterator. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D79284
2020-06-12 10:43:31 +00:00
Jean-Yves Avenard
d5528b6394 Bug 1641737 - P4. Add UseDirectTaskDispatch/UseSynchronousDispatch to MozPromiseHolder. r=bholley
The allows to not have to deal with MozPromise::Private directly.

Differential Revision: https://phabricator.services.mozilla.com/D78208
2020-06-12 05:56:39 +00:00
Jean-Yves Avenard
7b7d64db67 Bug 1641737 - P1. Set dispatch type to chained promises. r=bholley
When chaining a MozPromise set to be dispatched via the direct task queue (or synchronous), it makes sense for the chained promise to be dispatched in the same fashion.

All MozPromises generated by the IPC bindings are set to use the direct task queue in order to prevent the then runnable to run out of order with other IPC tasks.
We want to preserve that task ordering by default.

Differential Revision: https://phabricator.services.mozilla.com/D78178
2020-06-12 05:56:26 +00:00
Jean-Yves Avenard
4e41c1b386 Bug 1644009 - P14. Fallback to normal dispatch on release. r=bholley
We shouldn't ever get there, but just in case, better than a null deref.

Differential Revision: https://phabricator.services.mozilla.com/D79097
2020-06-12 05:10:57 +00:00
Jean-Yves Avenard
a56b255f0f Bug 1644009 - P13. Don't have AutoTaskGuard inherit from AutoTaskDispatcher. r=bholley.
This prevent being able to assert in the AutoTaskDispatcher that we are using it from the right thread/taskqueue as the SimpleTaskQueue object isn't thread-safe.

We want to assert that all nsIDirectTaskDispatcher methods are only ever accessed on the underlying thread. To do so require that the scope of AutoTaskDispatcher to terminate prior the AutoTaskGuard one.

Differential Revision: https://phabricator.services.mozilla.com/D79096
2020-06-12 05:10:55 +00:00
Jean-Yves Avenard
d846483194 Bug 1644009 - P10. Make MozPromise access direct task dispatcher using QI(nsIDirectTaskDispatcher). r=bholley
Differential Revision: https://phabricator.services.mozilla.com/D79094
2020-06-12 05:10:32 +00:00
Jean-Yves Avenard
1e2af615c7 Bug 1644009 - P9. Add nsIDirectTaskDispatcher interface. r=froydnj
We extract the dealing of direct tasks from the TailDispatcher object and move into to the existing nsThread and TaskQueue classes.
TaskQueue is made to work with do_QueryInterface.

We continue accessing the direct tasks dispatcher via the TailDispatcher for now, which itself will forward the dealing of such tasks to the underlying thread.

Differential Revision: https://phabricator.services.mozilla.com/D79093
2020-06-12 05:10:25 +00:00
Jean-Yves Avenard
974a9641a4 Bug 1644009 - P8. Add SimpleTaskQueue object. r=froydnj
We will use it later for implementing direct task dispatching where required.

Differential Revision: https://phabricator.services.mozilla.com/D79092
2020-06-12 05:10:12 +00:00
Simon Giesecke
5f046f94b5 Bug 1644642 - Fix ArrayType of nsTArray_Impl iterators. a=fix. CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D79253
2020-06-11 07:58:38 +00:00
Simon Giesecke
4ab55413a3 Bug 1644640 - Rename RemoveElementsAt(const_iterator, const_iterator) to RemoveElementsRange. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D79033
2020-06-11 07:17:25 +00:00
Valentin Gosu
aaf5f84d8f Bug 1644478 - Make nsPipeInputStream::mPriority Atomic r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D78938
2020-06-10 15:53:36 +00:00
Simon Giesecke
9029b95922 Bug 1643289 - Move elements where possible in nsTPriorityQueue instead of copying them. r=froydnj
Also remove redundant check in Push method on result of infallible operation,
and change its return type to void.

Differential Revision: https://phabricator.services.mozilla.com/D78249
2020-06-10 10:46:34 +00:00
Simon Giesecke
4fc33e202f Bug 1643289 - Make nsTPriorityQueue non-copyable and remove use of CopyableTArray. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D78248
2020-06-10 10:46:17 +00:00
Simon Giesecke
82dc9b2271 Bug 1642949 - Replace uses of RemoveElementAt by RemoveLastElement/PopLastElement where possible. r=necko-reviewers,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D78027
2020-06-10 10:46:14 +00:00
Bas Schouten
45104a7a29 Bug 1644292: Duplicate code for runnable telemetry for runnables executed inside TaskController. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D78888
2020-06-09 13:02:37 +00:00
Bas Schouten
c2dc5d2a40 Bug 1644288: Explicitly do not use timeDurationHelper when TaskController is enabled. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D78825
2020-06-09 12:42:24 +00:00
Valentin Gosu
cac985a474 Bug 1636888 - Allow specifying entire rust modules in MOZ_LOG r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D78265
2020-06-10 07:18:40 +00:00
Butkovits Atila
e3dce68834 Backed out 3 changesets (bug 1643289, bug 1642949) for causing failure at test_headless_screenshot.html. CLOSED TREE
Backed out changeset 98c420f73380 (bug 1643289)
Backed out changeset 9447ea8910aa (bug 1643289)
Backed out changeset 0c827da9d847 (bug 1642949)
2020-06-10 10:07:23 +03:00
Simon Giesecke
6944416c7e Bug 1643289 - Move elements where possible in nsTPriorityQueue instead of copying them. r=froydnj
Also remove redundant check in Push method on result of infallible operation,
and change its return type to void.

Differential Revision: https://phabricator.services.mozilla.com/D78249
2020-06-10 05:45:45 +00:00
Simon Giesecke
3371315ec2 Bug 1643289 - Make nsTPriorityQueue non-copyable and remove use of CopyableTArray. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D78248
2020-06-10 05:45:26 +00:00
Simon Giesecke
d419f0ff08 Bug 1642949 - Replace uses of RemoveElementAt by RemoveLastElement/PopLastElement where possible. r=necko-reviewers,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D78027
2020-06-10 05:49:28 +00:00
Simon Giesecke
ca2d0aaa68 Bug 1644403 - Fix inconsistent uses of CopyableAutoTArray and Clone. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D78893
2020-06-09 14:27:20 +00:00
Razvan Maries
caec984d54 Backed out 7 changesets (bug 1641737) assertion failures. CLOSED TREE
Backed out changeset 7f7b98339065 (bug 1641737)
Backed out changeset 32fba417ebd0 (bug 1641737)
Backed out changeset abd9cd77f3cb (bug 1641737)
Backed out changeset e3bf9a45db6a (bug 1641737)
Backed out changeset 94d47578009c (bug 1641737)
Backed out changeset 28bca5c5b8b4 (bug 1641737)
Backed out changeset 0296d0f6c1d1 (bug 1641737)
2020-06-09 18:55:08 +03:00
Jean-Yves Avenard
bb29b401bc Bug 1641737 - P4. Add UseDirectTaskDispatch/UseSynchronousDispatch to MozPromiseHolder. r=bholley
The allows to not have to deal with MozPromise::Private directly.

Differential Revision: https://phabricator.services.mozilla.com/D78208
2020-06-09 07:23:57 +00:00
Jean-Yves Avenard
0e3faed81f Bug 1641737 - P1. Set dispatch type to chained promises. r=bholley
When chaining a MozPromise set to be dispatched via the direct task queue (or synchronous), it makes sense for the chained promise to be dispatched in the same fashion.

All MozPromises generated by the IPC bindings are set to use the direct task queue in order to prevent the then runnable to run out of order with other IPC tasks.
We want to preserve that task ordering by default.

Differential Revision: https://phabricator.services.mozilla.com/D78178
2020-06-09 07:23:29 +00:00
alwu
0d200dff8a Bug 1640998 - part7 : create MediaController webidl. r=chunmin,smaug
This patch will
- create a chrome-only webdil interface `MediaController`
- expose supported keys via `MediaController` webidl interface

The advantage of doing so are
- to have a dedicated interface that is only used for MediaController that can be used for testing and our future plan (media hub)

More Details :
Currently, we access media controller's from `ChromeUtils` [1], but it causes a problem of creating a duplicated enum of the enum which we want to expose into Chrome JS.

Instead, we should create a media controller interface to access all its attibutes, which is more easier and clean.

In addition, we're planning to have a something like Chrome's media hub [2]. In order to do that, we have to expose some JS methods to allow us to control playback directly from Chrome JS.

[1] https://searchfox.org/mozilla-central/rev/559b25eb41c1cbffcb90a34e008b8288312fcd25/dom/chrome-webidl/ChromeUtils.webidl#485-493
[2] https://blog.google/products/chrome/manage-audio-and-video-in-chrome/

Differential Revision: https://phabricator.services.mozilla.com/D77757
2020-06-08 18:51:12 +00:00
Kashav Madan
c236372d7d Bug 1641929 - Add a fission.autostart getter, r=nika
This makes it easier to consider special conditions when checking the pref. It
currently returns false if safe mode is enabled.

Differential Revision: https://phabricator.services.mozilla.com/D78798
2020-06-08 22:59:43 +00:00
Dana Keeler
ac4d01ea49 Bug 1644224 - make nsTimerEvent::sCanDeleteAllocator atomic/sequentially consistent r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D78771
2020-06-08 19:59:40 +00:00
Simon Giesecke
ebbc7ae838 Bug 1642989 - Use RemoveLastElements instead of RemoveElementsAt where possible. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D78049
2020-06-08 08:50:15 +00:00
Simon Giesecke
f5561f73b7 Bug 1642988 - Add RemoveLastElements function. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D78048
2020-06-08 08:49:13 +00:00
Simon Giesecke
13502cf27c Bug 1642991 - Use RemoveElementsBy where easily possible. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D78055
2020-06-08 09:01:48 +00:00
Kartikaya Gupta
6fc65e6f89 Bug 1643747 - Filter rust logging on android by the underlying env_logger's filters. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D78536
2020-06-05 20:44:53 +00:00
Kartikaya Gupta
7ac36807b1 Bug 1643042 - Turn the scroll origin parameter into a strongly-typed enum. r=tnikkel
This patch is a fairly mechanical conversion. The old `nullptr` gets converted
to ScrollOrigin::NotSpecified, and all the other possible values get corresponding
values in the new ScrollOrigin enum. A few switch statements are introduced to
clean up big if statements, but other than that, additional cleanups will happen
in later patches.

Differential Revision: https://phabricator.services.mozilla.com/D78438
2020-06-05 09:37:51 +00:00
Kris Taeleman
a33030af01 Bug 1633937 - Add OS Build info to about:support r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D73345
2020-06-04 20:15:36 +00:00
Emma Malysz
c2ded60e72 Bug 1610134: revert late writes from nsTerminator. r=dthayer
After investigating the potential to reduce the nsTerminator's crash timeout from
1 min, to 20s, and then finally 40s, we have decided to this does not provide
significant gains to justify increasing the amount of shutdown hang crashes
and potential to lose data. We should maintain the crash timeout at 1 min.

Differential Revision: https://phabricator.services.mozilla.com/D77939
2020-06-04 19:18:21 +00:00
Andrea Marchesini
f3527b4c51 Bug 1643156 - Cleanup nsMultiplexInputStream - part 4 - support Seek(END) correctly, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D77100
2020-06-04 00:18:57 +00:00
Andrea Marchesini
ac5319c5e6 Bug 1643156 - Cleanup nsMultiplexInputStream - part 3 - tests, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D76998
2020-06-04 00:18:57 +00:00
Andrea Marchesini
8db10f63e0 Bug 1643156 - Cleanup nsMultiplexInputStream - part 2 - remove the use of nsITellable interface for substreams, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D76902
2020-06-04 00:18:57 +00:00