This removes the 'use-artifacts' mechanism in favour of fetches. There are a
few pieces here that need to land atomically:
1. Remove use-artifact related code
2. Call 'fetch-content' from the run-task script
3. Convert existing tasks on top of fetches (jsshell, python unittest)
4. Stop calling 'fetch-content' from toolchain setup tasks (as this now gets handled in run-task)
Depends on D2166.
Differential Revision: https://phabricator.services.mozilla.com/D2167
--HG--
extra : moz-landing-system : lando
On Api >=21 the Material DatePicker will have applied a Photon style.
Below Api 21 DatePicker will still be using spinners.
MozReview-Commit-ID: LuWP6C1o4Ej
--HG--
extra : rebase_source : 91eccfdeb0c4f17e9f0616fa25463d1b5558009a
On Api >=21 the Material TimePicker will have applied a Photon style.
Below Api 21 TimePicker will still be using spinners.
MozReview-Commit-ID: 2jZLPGCx4rI
--HG--
extra : rebase_source : a57376bf59077b6d64bcca8ba704ca1b6324383e
Previously we set this window size when restoring all default
values for a session during test teardown. Which means that
the very first test after the browser has been started will
run with the browser window default size.
This change enforces that all tests use the default window
size of 800x600.
MozReview-Commit-ID: Kiog3Ri2RJT
--HG--
extra : rebase_source : 971c1a17cdcc97d7880db8d8bdd50314369a2a91
This builds on bug 1428676 and introduces StyleAppearance, which replaces the
NS_THEME_* constants.
Really sorry for the size of the patch.
There's a non-trivial change in the gtk theme, which I submitted separately as
bug 1478385.
Differential Revision: https://phabricator.services.mozilla.com/D2361
MozReview-Commit-ID: DiSmMWK7Krp
We use the same setup WR uses, which is checking-in the files.
But I think it's much better than keeping the two things in sync manually :)
When you add a new value, you need to add it to the rust source, then run the
command, but since it doesn't need to build the style crate (it uses the Rust
AST, doesn't build) there's no problem.
Differential Revision: https://phabricator.services.mozilla.com/D2354
MozReview-Commit-ID: DnXkNAzP54H
This goes back to relying on rows being the same height.
Places where we replace the popup will likely not use the richlistbox,
and we no longer have code that changes the height or exceeds the maximum
number of visible children with a scrollbar, so we should be OK.
To determine the padding on the richlistbox and the height of the initial
row, I've used a promiseDocumentFlushed callback. It's possible this causes
flicker the first time the popup opens. I can't see any, but it's quite
possible I'm missing something.
Differential Revision: https://phabricator.services.mozilla.com/D2242
--HG--
extra : moz-landing-system : lando
IsComposited() does not reflect Visual selected by GLContextGLX::FindVisual()
which is used by WebRender which leads to shaped window rendering with WebRender.
IsComposited() is replaced by mHasAlphaVisual variable which is explicitly
set when we have an alpha visual and we don't need to use shape X11 extension.
MozReview-Commit-ID: 1kDLwkUyHte
--HG--
extra : rebase_source : 3a60fe8fd66f9e89bfcc729fe5e1fa9e1ce8920d
The test name was passed as a third argument to `ArrayBuffer.slice`, silently
ignored.
MozReview-Commit-ID: KHel7Bc2Qej
--HG--
extra : rebase_source : 4c5e300e140b18d62344cfec083bd39ea426f514
Some test files were affected by adding a new CoarseType, particularly in XPCShell tests. New rules were added to handle this CoarseType, and in a few cases the IDs of deserialized nodes had to be adjusted. The colors of CoarseTypes have also changed slightly and the resulting tests had to be updated.
--HG--
extra : rebase_source : 06d5203023251665adf933215898f83f991dbd1a
Wasm-via-IonMonkey creates accesses to indirect globals using a double
indirection of the form
* ( *(tls + imm_offset) )
The inner load produces a pointer to the global cell holding the global's
value, and the outer load or store reads or writes the actual value.
Currently both accesses are represented by a single MIR node,
WasmLoadGlobalVar or WasmStoreGlobalVar respectively. This has the
disadvantage that it inhibits CSEing of the |*(tls + imm_offset)| part,
which generates poor code when the same indirect global is referred to
repeatedly, which is a common idiom. For example
(set_global 0 (i32.add (get_global 0) (i32.const 1)))
produces
[Codegen] instruction WasmLoadGlobalVar
[Codegen] movq 0x40(%r14), %rcx
[Codegen] movl 0x0(%rcx), %eax
[Codegen] instruction AddI
[Codegen] addl $1, %eax
[Codegen] instruction WasmStoreGlobalVar
[Codegen] movq 0x40(%r14), %rcx <-- a load we want to avoid
[Codegen] movl %eax, 0x0(%rcx)
It also causes confusion in specifying the aliasing behaviour for
Wasm{Load,Store}GlobalVar. See bug 1467415.
This patch splits Wasm{Load,Store}GlobalVar in two:
* Wasm{Load,Store}GlobalVar is reduced in scope, so that it now loads/stores
*only* at |tls + imm_offset| -- the inner load/store in the description
above.
* Wasm{Load,Store}GlobalCell performs the outer load/store.
As a result, Wasm{Load,Store}GlobalVar no longer have an |isIndirect| boolean.
Instead, a direct global access is expressed using Wasm{Load,Store}GlobalVar
alone, and an indirect global access is expressed using WasmLoadGlobalVar to
acquire the cell address, followed by Wasm{Load,Store}GlobalCell to access the
cell.
MWasmLoadGlobal{Var,Cell}::mightAlias are updated accordingly. We believe the
resulting alias analysis to be non-optimal in that there are certain
known-not-to-alias cases that are not discovered.
Most of the changes are boilerplate:
* js/src/jit/AliasAnalysisShared.cpp GetObject(const MDefinition* ins)
- Handle new MIR node types.
* js/src/jit/CodeGenerator.cpp
- New functions {Load,Store}PrimitiveValue, to avoid code duplication
- CodeGenerator::visitWasmLoadGlobalVar
CodeGenerator::visitWasmLoadGlobalCell
CodeGenerator::visitWasmStoreGlobalVar
CodeGenerator::visitWasmStoreGlobalCell
CodeGenerator::visitWasmLoadGlobalVarI64
CodeGenerator::visitWasmLoadGlobalCellI64
CodeGenerator::visitWasmStoreGlobalVarI64
CodeGenerator::visitWasmStoreGlobalCellI64:
new/refactored code gen fns
* js/src/jit/Lowering.cpp
- LIRGenerator::visitWasmLoadGlobalVar
LIRGenerator::visitWasmLoadGlobalCell
LIRGenerator::visitWasmStoreGlobalVar
LIRGenerator::visitWasmStoreGlobalCell:
route through to the above code gen fns
- MWasmLoadGlobalVar::mightAlias
- MWasmLoadGlobalCell::mightAlias:
updated
- MWasmLoadGlobalVar::congruentTo: updated
- MWasmLoadGlobalCell::congruentTo: new function
* js/src/jit/MIR.h
- class AliasSet {
add WasmGlobalCell
- other classes:
remove |isIndirect| flag from MWasm{Load,Store}GlobalVar
add classes MWasm{Load,Store}GlobalCell{,I64}
* js/src/wasm/WasmIonCompile.cpp class FunctionCompiler
- loadGlobalVar(), storeGlobalVar():
actually take notice of |isIndirect|
and generate one or two MIR nodes accordingly
* js/src/jit-test/tests/wasm/globals-impl.js
- New test case.
--HG--
extra : rebase_source : 6944f01757421d4a6f07211166bb167fc714ec2d
