Automatic update from web-platform-testsMake longtask WPT layouttests less flaky
This CL improves tests in external/wpt/longtask-timing by:
* Increasing the length of a longtask from ~51 to ~60 to prevent a
coarse performance.now() granularity from affecting the tests.
* Wrapping the long tasks or iframes containing longtasks inside onload
handlers to ensure that the PerformanceObserver is registered by the
time the longtask is executed.
Test: third_party/blink/tools/run_web_tests external/wpt/longtask-timing
--iterations=1000 did not produce flakes.
Bug: 796668
Change-Id: Ic2ce59f7d221566f5443da9e9c7d36c7bd7bbe6f
Reviewed-on: https://chromium-review.googlesource.com/1138725
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575396}
--
wpt-commits: 930d2ef0ad1f16147953a4804abd808c89e244c9
wpt-pr: 12006
Automatic update from web-platform-tests[LayoutNG] Support rewinding unpositioned floats
This patch supports NGLineBreaker to rewind unpositioned
floats.
When rewinding floats occurs, LayoutNG either position them
incorrectly, or hit DCHECK in paint due to duplicated ID.
This patch fixes it for unpositioned foats by matching to
Edge and Gecko.
Blink considers such floats as if it were committed
(positioned in LayoutNG terminologies) and thus the position
is incorrect.
Bug: 636993
Cq-Include-Trybots: luci.chromium.try :linux_layout_tests_layout_ng
Change-Id: I884879b2034d2f63ae248f70de3edeb27d71cafe
Reviewed-on: https://chromium-review.googlesource.com/1136262
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575357}
--
wpt-commits: 53702f14ec8b654a9c1beb9a013cdc652703cb40
wpt-pr: 12000
MozReview-Commit-ID: 9ea37E6Spi2
Automatic update from web-platform-tests[WebXR] Use 'immersive' instead of 'exclusive'
The 'immersive' is more intuitive term than 'exclusive'[1].
[1] https://github.com/immersive-web/webxr/pull/371
Bug: 852524
Cq-Include-Trybots: luci.chromium.try :android_optional_gpu_tests_rel;luci.chromium.try :linux_optional_gpu_tests_rel;luci.chromium.try :linux_vr;luci.chromium.try :mac_optional_gpu_tests_rel;luci.chromium.try :win_optional_gpu_tests_rel
Change-Id: If5c5ab6563df40a783f9d346d319dceed1f7cc58
Reviewed-on: https://chromium-review.googlesource.com/1101601
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575344}
--
wpt-commits: 8da1b538cfd84d599d16f43be5a53007295e7a40
wpt-pr: 11541
MozReview-Commit-ID: L7fO5G7eHdv
Automatic update from web-platform-testswebdriver: add explicit call to session.end for delete session tests (#12004)
For the "delete session" command tests, the recent changes to the fixture
to create and delete sessions are bypassed. This means that at the end of
each delete session test, the harness thinks a valid session still exists.
Making an explicit call to `session.end()` at the end of each test will
put the tracking variables in the correct state for the harness to start a
new session with the next test.
--
wpt-commits: e385fa4925f71b4ac37de4c3ce235914748881f6
wpt-pr: 12004
Automatic update from web-platform-testswebdriver: remove expected focus event from file upload test (#12003)
The WebDriver specification states that only the "change" and "input"
events. We should not also be expecting the "focus" event.
--
wpt-commits: 2437f6f7405ddd2e7a76e666dc8a8dff9c83d17b
wpt-pr: 12003
Automatic update from web-platform-testsUpdating Safari executor to be able to execute wdspec tests (#11994)
Safaridriver also chokes on the selenium capabilities object, but replacing this with an empty capabilities object works.
--
wpt-commits: 1ef74288f808484bc12d1abbd49ac27d945296d1
wpt-pr: 11994
Automatic update from web-platform-testsChanging srcdoc from DOMString to HTMLString
A setter and a getter have been added to element.cc to support StringOrTrustedHTML
Bug: 739170
Change-Id: I2472d1920a08834e9bd4b1cb532f72f5305a699b
Reviewed-on: https://chromium-review.googlesource.com/1134994
Commit-Queue: Orsolya Bernadett Batiz <orsibatiz@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575240}
--
wpt-commits: 4b0008b5230f13161ecf5a4ab01905af857bacdd
wpt-pr: 11946
Automatic update from web-platform-testsUpdate the requestidlecallback IDL test (#9825)
--
wpt-commits: b1681c1d32cf1ca384b094dc9a7f2f7691a87f1c
wpt-pr: 9825
Automatic update from web-platform-testsHTMLBaseElement::href changed to accept TrustedTypes
Changed implementation of setHref(), older version is abandoned.
Added href() getter that accepts URLString as an argument.
Bug: 739170
Change-Id: I7703c1a33f037a912f1a105d8c79ef8fe5b4a289
Reviewed-on: https://chromium-review.googlesource.com/1136544
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Maja Kabus <kabusm@google.com>
Cr-Commit-Position: refs/heads/master@{#575232}
--
wpt-commits: bd2709244a313ed5ea8e08d83c22173955c1ed80
wpt-pr: 11967
Automatic update from web-platform-testsAdd the worklets IDL file and test (#9856)
--
wpt-commits: f582e7ad3b06d37fa65957aa93dc62bf7429e803
wpt-pr: 9856
Automatic update from web-platform-testsMove web-platform-tests/html-imports/ into Blink's LayoutTests
As discussed on dom-dev:
https://groups.google.com/a/chromium.org/d/msg/dom-dev/qfHM4fKckwk/nELu4mvaAwAJ
There was already a hello.html + hello-parent.html in LayoutTests, so
these are kept and already-in-import-map.html was tweaked slightly to
use those instead.
There was also an existing hello.css, which was different, but the
test (import-attribute.html) doesn't depend on it.
Change-Id: Ib97451ff33bae16a75a2c7c703a8bac270910e38
Reviewed-on: https://chromium-review.googlesource.com/1133161
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575207}
--
wpt-commits: a270ae8074cbb78f568af90f511ff143cd7b3eec
wpt-pr: 11918
Automatic update from web-platform-testsUpdate script to rename min-/max-content keywords (#11995)
Changes needed to land changes at bugzilla [bug 1475645](https://bugzilla.mozilla.org/show_bug.cgi?id=1475645)
--
wpt-commits: 673c2821353d4ab96662bfb8cc4d5a53e75b0fb2
wpt-pr: 11995
Automatic update from web-platform-testswebdriver: create multiple files in single temp directory for upload tests (#11993)
Some user agents do not support multiple files in input elements in the
file upload state if the files selected are in different directories.
This commit adds the ability to create multiple temporary files in a
single temp directory instead of creating each file in its own
directory. Additionally, it adds a test uploading multiple files in
different directories for coverage of that case.
--
wpt-commits: 2161258356b82724eb2a18b1267d2450884ac052
wpt-pr: 11993
Automatic update from web-platform-tests[css-properties-values-api] Support repeated values in Typed OM.
This patch fixes two similar problems:
1. Computed list-valued properties show up as a CSSStyleValue when calling
computedStyleMap().get(name).
2. Computed list-valued properties show up as a CSSStyleValue when calling
computedStyleMap().getAll(name).
The fixes are also similar:
1. StylePropertyMapReadOnly::get only checked property.IsRepeated() when
determining whether it should look inside a possible list. However,
CSSPropertyVariable is never repeated. This is because
CSSPropertyVariable does not represent a single, specific custom
property, but rather _all_ custom properties.
For CSSPropertyVariable, if we have a CSSValueList, it means that
it is registered with either '<foo>+', or '<foo>#', and that makes it
a "list valued property" [1].
2. Similar to (1), the value would be treated as unsupported if property.
IsRepeated() was false. Again, a situation of CSSPropertyVariable+
CSSValueList means that the property is registered as a list.
Note1: The value for a custom property can only be a CSSValueList if the
runtime enabled feature CSSVariables2 is enabled. In all other
cases, it's a CSSCustomPropertyDeclaration. See
ComputedStyleCSSValueMapping::Get ('registry' is nullptr without
the feature).
Note2: It might make more sense to ignore the repeatability of the
property, and instead just look at whether we actually have a
CSSValueList, but such a change would require a change of the
css-typed-om spec.
[1] https://drafts.css-houdini.org/css-typed-om-1/#list-valued-propertieshttps://drafts.css-houdini.org/css-typed-om-1/#reify-stylevalueR=chrishtr@chromium.org
Bug: 862152
Change-Id: Ic854f54f14313b6b683601d0677dcc1dd4205ccd
Reviewed-on: https://chromium-review.googlesource.com/1136295
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575166}
--
wpt-commits: 59fa23d519b9d6ef0892170ba86ef0b9aee6ad24
wpt-pr: 11964
Automatic update from web-platform-testsAdding custom pytest marker registration to WebDriver tests (#11990)
The WebDriver tests can now use a custom pytest marker to specify the
capabilities for a session in a specific test. The marker must be
registered with the system to be valid, however.
--
wpt-commits: af3df7d99f7f77daa69dd11f19969b48c2c34e46
wpt-pr: 11990
Automatic update from web-platform-tests[css-properties-values-api] Add test for cascading behavior.
Registered custom properties should behave as if they weren't registered
for parsing and cascading purposes. Only at computed-value time does the
syntax from the registration come into play.
R=chrishtr@chromium.org
Bug: 641877
Change-Id: I5ed5b334318e653da660b88b2dd912cc0b59f36d
Reviewed-on: https://chromium-review.googlesource.com/1136448
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575161}
--
wpt-commits: 255adeaa04cd95bb3ccb2ff8922885151f2dc882
wpt-pr: 11965
Automatic update from web-platform-testsReland "Correctly initialize and test SnapContainerData in cc."
This reverts commit 0fc70abb02f52598f0f98eafd7001490545bc0c9.
This patch increases the no-animation wait time to reduce
flakiness.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> Revert "Correctly initialize and test SnapContainerData in cc."
>
> This reverts commit 37061f875b167ab82f1a0ddca84b510b7c6802dc.
>
> Reason for revert:
> The layout tests added by this CL is failing on the CL:
> https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/37804
>
> Original change's description:
> > Correctly initialize and test SnapContainerData in cc.
> >
> > This patch initializes the rect_ field in SnapContainerData in copy
> > constructor and move constructor. Fixing a snapping issue in the
> > composited pages.
> >
> > We also adds external/wpt/css/css-scroll-snap/ to the virtual/threaded
> > test suite so that they are tested with the composited cases.
> >
> > snap-at-user-scroll-end-manual-automation.js calls
> > mouseClickInTarget() of pointerevent_common_input.js. That method
> > invokes programmatic scrolls. The test was written before programmatic
> > scroll snapping was implemented so it worked at that time. However,
> > with programmatic scroll snapping implemented, it will always snap
> > in mouseClickIntarget() and cannot test whether the user scroll snaps.
> > This patch adds a parameter shouldScrollToTarget to mouseClickInTarget
> > to avoid invoking programmatic scrolls in the test.
> >
> > This patch also checks nullptr for layout_box in
> > ScrollManager::SnapAtGestureScrollEnd() to fix a crash.
> >
> > Bug: 862406, 862571
> > Cq-Include-Trybots: luci.chromium.try :android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> > Change-Id: I6a53818cf74421a4100ad6f908158abf302a5b8e
> > Reviewed-on: https://chromium-review.googlesource.com/1132386
> > Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
> > Reviewed-by: Majid Valipour <majidvp@chromium.org>
> > Reviewed-by: Robert Flack <flackr@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#574781}
>
> TBR=flackr@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org
>
> Change-Id: I55c77c05c0381c8ac638bd106d2d18b1b4332745
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try : true
> Bug: 862406, 862571
> Cq-Include-Trybots: luci.chromium.try :android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Reviewed-on: https://chromium-review.googlesource.com/1136171
> Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
> Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574825}
TBR=flackr@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org,tzik@chromium.org
Change-Id: I85550f6f01b2466d8ceb03e44c15253079a5059c
No-Presubmit: true
No-Tree-Checks: true
No-Try : true
Bug: 862406, 862571
Cq-Include-Trybots: luci.chromium.try :android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1136613
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Reviewed-by: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574983}
--
wpt-commits: 8c497bd26ebfbd719dfcc580bc945e4e4cf6bce0
wpt-pr: 11970
MozReview-Commit-ID: XsdftlySZA
Automatic update from web-platform-testsReland "Correctly initialize and test SnapContainerData in cc."
This reverts commit 0fc70abb02f52598f0f98eafd7001490545bc0c9.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> Revert "Correctly initialize and test SnapContainerData in cc."
>
> This reverts commit 37061f875b167ab82f1a0ddca84b510b7c6802dc.
>
> Reason for revert:
> The layout tests added by this CL is failing on the CL:
> https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/37804
>
> Original change's description:
> > Correctly initialize and test SnapContainerData in cc.
> >
> > This patch initializes the rect_ field in SnapContainerData in copy
> > constructor and move constructor. Fixing a snapping issue in the
> > composited pages.
> >
> > We also adds external/wpt/css/css-scroll-snap/ to the virtual/threaded
> > test suite so that they are tested with the composited cases.
> >
> > snap-at-user-scroll-end-manual-automation.js calls
> > mouseClickInTarget() of pointerevent_common_input.js. That method
> > invokes programmatic scrolls. The test was written before programmatic
> > scroll snapping was implemented so it worked at that time. However,
> > with programmatic scroll snapping implemented, it will always snap
> > in mouseClickIntarget() and cannot test whether the user scroll snaps.
> > This patch adds a parameter shouldScrollToTarget to mouseClickInTarget
> > to avoid invoking programmatic scrolls in the test.
> >
> > This patch also checks nullptr for layout_box in
> > ScrollManager::SnapAtGestureScrollEnd() to fix a crash.
> >
> > Bug: 862406, 862571
> > Cq-Include-Trybots: luci.chromium.try :android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> > Change-Id: I6a53818cf74421a4100ad6f908158abf302a5b8e
> > Reviewed-on: https://chromium-review.googlesource.com/1132386
> > Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
> > Reviewed-by: Majid Valipour <majidvp@chromium.org>
> > Reviewed-by: Robert Flack <flackr@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#574781}
>
> TBR=flackr@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org
>
> Change-Id: I55c77c05c0381c8ac638bd106d2d18b1b4332745
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try : true
> Bug: 862406, 862571
> Cq-Include-Trybots: luci.chromium.try :android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Reviewed-on: https://chromium-review.googlesource.com/1136171
> Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
> Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574825}
TBR=flackr@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org,tzik@chromium.org
Change-Id: I4a9480b68c15e0dfcfd13df6ed6c0e6b8ab5a8e3
No-Presubmit: true
No-Tree-Checks: true
No-Try : true
Bug: 862406, 862571
Cq-Include-Trybots: luci.chromium.try :android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1136671
Reviewed-by: Sandra Sun <sunyunjia@chromium.org>
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574926}
--
wpt-commits: 7b9c0db081fc56c7d3b1ab5cd729172a04ace21c
wpt-pr: 11969
MozReview-Commit-ID: IcOob62I6xz
Automatic update from web-platform-testslocation.assign() and location.replace() changed to accept TrustedTypes
Previous versions of functions made private and named
assignFromString and replaceFromString,respectively.
assign wraps assignFromString.
replace wraps replaceFromString.
Bug: 739170
Change-Id: I3fd39a44fed1482f7e07524815297b9eec322b60
Reviewed-on: https://chromium-review.googlesource.com/1134987
Commit-Queue: Maja Kabus <kabusm@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574907}
--
wpt-commits: d886715e456fb9a2e23e310ceaf8f9edc38f24b2
wpt-pr: 11943
Automatic update from web-platform-testscreateContextualFragment changed to accept TrustedTypes
Previous version of function made private and named
createContextualFragmentFromString.
createContextualFragment wraps createContextualFragmentFromString.
Bug: 739170
Change-Id: I240f95d1a96e9022bed8fdaf3ec7a954ec9512c6
Reviewed-on: https://chromium-review.googlesource.com/1131188
Commit-Queue: Maja Kabus <kabusm@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574859}
--
wpt-commits: 9e4a93afa661c4a6ecb39ce810fcc77d73cd6405
wpt-pr: 11891
Automatic update from web-platform-tests[css-properties-values-api] Add tests for Typed OM reification.
How registered custom properties are reified is currently not specified
[1]. For computed values, it should hopefully be pretty obvious how it
should work. (For declared/inline style it is less clear).
This patch adds tests for the computed style only.
Note:
* <transform-function> is not tested, because it appears that this
syntax was re-added to the spec by mistake, so I expect support for
<transform-function> will be reverted.
* <transform-list> and list syntaxes in general are not tested, because
it's currently broken in Blink. Tests for list syntaxes will be added
along with the fix for that.
[1] https://drafts.css-houdini.org/css-typed-om-1/#reify-stylevalueR=chrishtr@chromium.org
Bug: 641877
Change-Id: Ic177bfe2b90897ec44ef4405c745171d8b226e82
Reviewed-on: https://chromium-review.googlesource.com/1134778
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574858}
--
wpt-commits: 5c9c5d9154fa3d32a83d5ff08205e85dc0bd597f
wpt-pr: 11942
Uses the same mozharness structured output parser configuration on Windows as
on Linux and osx, for consistency.
Removes the ineffective "structured_suites" configuration for Windows unit
tests, since that key is ignored in desktop_unittest.py.
Also changes desktop_unittest.py to use structured output by default in
the absence of the expected unstructured_flavors configuration.
