Automatic update from web-platform-tests
[FedCM] Don't use fedcm_get_and_select_first_account
We are expecting a mismatch dialog here, so selecting an account
is not necessary.
R=npm@chromium.org
Change-Id: Ieaf670e204544e866ce3c51cba0d0bbad1b6693f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5397957
Commit-Queue: Nicolás Peña <npm@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Nicolás Peña <npm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1278527}
--
wpt-commits: 6f346b0df5fc952747841fd76d11b3c4d24e5c8d
wpt-pr: 45347
Automatic update from web-platform-tests
webnn: fix coreml handling for large constant
Also add regression test in wpt for this case. It only verifies the
first 1000 result for now to ensure the speediness.
Change-Id: Ia72066103e240768cf96dacb39e65b1527320091
Bug: 331248175
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5394249
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Phillis Tang <phillis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1278459}
--
wpt-commits: 469d2d65c6861fdd7bf13d3321ba5d73ac0b8cf8
wpt-pr: 45321
Automatic update from web-platform-tests
Support default button in appearance:bikeshed <select>
This patch makes <select> with appearance:bikeshed work when the author
does not provide a child <button> element to slot in.
A fallback <button> is added in the UA shadowroot's button slot which
will get rendered and have all the behaviors added to it.
Bug: 1511354, 330534051, 330540965
Change-Id: I0c3c744fd2704b48ac62c533f3c78cf7a3ed4e55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5354708
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1278442}
--
wpt-commits: 9e2a8ff39e445b2dbf5d7337b0bc15e3c5603a3e
wpt-pr: 45223
Automatic update from web-platform-tests
Partially fix payment-extension-allowed-by-permissions-policy-attribute.https.sub.html
This test has been broken for a while, but the history is unclear. Its
TestExpectations entry was added in https://crrev.com/c/4197306 but it
is unclear what made the test start failing in the first place. Since
then, it seems to have deteriorated further.
- Adjust the code in the iframe the test communicates with; it was
sending the right data with the wrong key.
test_feature_availability_with_post_message_result() confusingly
expects messages in the "name" property, and any error message
explanations in the "message" property.
- Make the first test in the file pass again by updating the error
permissions policy error message it expects to receive.
- Remove the TestExpectations entry and add an -expected.txt file with a
specific failure that makes it easier to keep track of in case
anything changes again in the future.
Bug: 331237019
Change-Id: I5a91c380961ea48f4585a5da93f034fc7fda10d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5393366
Auto-Submit: Raphael Kubo Da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Raphael Kubo Da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/main@{#1278410}
--
wpt-commits: 1824eeff79b6aa5f7d6f15a08b825881a69e9bf6
wpt-pr: 45345
Automatic update from web-platform-tests
Fenced frame: fix CSP tests and CSP check in can load API.
The navigator.canLoadAdAuctionFencedFrame() API currently doesn't
properly handle the case when calling it in a document whose content
security policy is "fenced-frame-src: https:". This is because the API
isn't explicitly checking for that specific case. This CL modifies the
function to match the checks in `CheckCSPSource()` in `csp_source.cc`.
This would've been caught by the CSP WPTs, but those have a bug that
makes them ineffective in catching corner cases. When adding a CSP with
the <meta> tag, that is a strictly additive operation, and removing the
tag will have no effect on the document's CSP. Since the same page is
re-used through all the promise_tests in the file, each subsequent test
will load with all of the CSPs set in the prior tests. This CL fixes
that by having each test create a subframe that gets the CSP, and
running the test in that subframe.
This CL also refactors canLoadAdAuctionFencedFrame() to move the CSP
related checks into a helper function in the renderer's
ContentSecurityPolicy class.
Change-Id: Iea3238cc2b515976468f957ae808277df8c5adc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5378803
Reviewed-by: Caleb Raitto <caraitto@chromium.org>
Reviewed-by: Garrett Tanzer <gtanzer@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Liam Brady <lbrady@google.com>
Cr-Commit-Position: refs/heads/main@{#1278373}
--
wpt-commits: 698f2bfc6b662ff594c84f6a6beb9944125581b0
wpt-pr: 45255
Automatic update from web-platform-tests
Add ChromeiOS version support (#45326)
* Add ChromeiOS version support
* fix
* fix
* fix
--
wpt-commits: b847b1030f779d681c955f397a6e36bf6808cd41
wpt-pr: 45326
Automatic update from web-platform-tests
Fix table with rows but no column
We weren't generating any fragment for the rows, which meant that JS
APIs like clientWidth would be 0, and also outlines weren't painted.
This aligns Servo with Blink and WebKit. Gecko is broken, it distributes
twice the table height among the rows.
--
wpt-commits: 45e16d91c80302ea8eff75e22d44c7947fa78dac
wpt-pr: 45319
Automatic update from web-platform-tests
fix#45334 - Adds tests for gap serialization. (#45335)
Adds a couple of tests for testing the values when setting gap.
Fix#45334
--
wpt-commits: c399cf9e2773f36947383a12d90635562533a93c
wpt-pr: 45335
Automatic update from web-platform-tests
[css-anchor-position] Add basic position-visibility tests
This patch adds basic tests for the new position-visibility property.
The specification is in-progress and is based on:
https://github.com/w3c/csswg-drafts/issues/7758#issuecomment-1965540529
Bug: 329703412
Change-Id: I460662f1a131336d9b17cdd597eecf4879c2414e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5393391
Auto-Submit: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1278060}
--
wpt-commits: 88c9bc22612450e1bfd962f4b55b6158c4ce8ff1
wpt-pr: 45327
Automatic update from web-platform-tests
Revert "[Invokers] Only dispatch invoke for built-ins or actions containing '-'"
This reverts commit 87ca363c4a89ce638bb9dbfba8ad71b967e1bcbe.
Reason for revert: invoketarget-on-details-invalid-behavior.tentative.html failing on multiple builders
Original change's description:
> [Invokers] Only dispatch invoke for built-ins or actions containing '-'
>
> (This relands
> https://chromium-review.googlesource.com/c/chromium/src/+/5366502 after
> fixing timeout issues in
> https://chromium-review.googlesource.com/c/chromium/src/+/5372478)
>
> This change refactors the `HandleInvokeInternal` calls to use an enum
> class of known attribute values including a `kCustom` key which can determine if the invoke action meets the criteria for being
> a "custom" action - that is it includes a dash (see
> b40ba866cc).
>
> This also updates the tests to reflect this; only actions with a `-`, or
> otherwise known actions, will dispatch an event. All other actions do
> not, and must be manually dispatched. This does not preclude web authors
> from manually dispatching said events.
>
> Bug: 40947660
> Change-Id: Ie6efeac7991c449b54d0c8b7ed360501ae5c8d37
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5388656
> Reviewed-by: Joey Arhar <jarhar@chromium.org>
> Reviewed-by: Mason Freed <masonf@chromium.org>
> Auto-Submit: Keith Cirkel <chromium@keithcirkel.co.uk>
> Commit-Queue: Joey Arhar <jarhar@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1277851}
Bug: 40947660
Change-Id: I89f4d5efaba810d345c571d558cb826b263dd907
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5393427
Owners-Override: Matt Reynolds <mattreynolds@chromium.org>
Auto-Submit: Matt Reynolds <mattreynolds@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1278027}
--
wpt-commits: 42060952b73d4d25a12149adfdafbfe17c4562b9
wpt-pr: 45333
Automatic update from web-platform-tests
[css-anchor-position] Parsing and computing position-visibility
This patch implements the plumbing for the new position-visibility
property. The specification is in-progress and is based on:
https://github.com/w3c/csswg-drafts/issues/7758#issuecomment-1965540529
Bug: 329703412
Change-Id: I83650e01466fa89285bdbc95f0d04125b398be78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5390280
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1277987}
--
wpt-commits: e7126913cb4a726b4b1d336684637378bb45045b
wpt-pr: 45322
Automatic update from web-platform-tests
[FedCM] Normalize origins
In particular, on wpt.live, "origin" includes a default port of :443
but event.origin does not. Roundtrip both through new URL() so that
they get normalized the same way.
Bug: 331237776
Change-Id: I5a6857bda9d938232879e5da67cdd4fdace1417f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5394210
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Nicolás Peña <npm@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1277940}
--
wpt-commits: c5dbf3e68662f2a9aa1a9c0c39cea6ea5e161cb2
wpt-pr: 45323
Automatic update from web-platform-tests
[FedCM] Close the popup window after setting cookie
This is a bit nicer when running the tests manually.
Change-Id: I6d96e453836ac6534c75cb8c6e1e841bae5a08b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5394269
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Nicolás Peña <npm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1277945}
--
wpt-commits: 8882ec770f1a84c1c85ae46d467b63a2f4b6745e
wpt-pr: 45325
Automatic update from web-platform-tests
Make clicking only selected option in multi-select deselect it
This makes it so that if there is only a single option selected in a
<select multiple> element, clicking it will deselect it instead of
doing nothing.
This is to reduce user confusion about how to deselect options while
minimizing the impact on existing content, since the old do-nothing
behavior of this interaction is likely never a user's intention.
Bug: 327940247
Change-Id: If21cad16100155bc310745ca244ebf1dab0a691f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5360033
Reviewed-by: David Baron <dbaron@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1277858}
--
wpt-commits: 1a25adc1c9dda7890fbd008e69f524381e45724e
wpt-pr: 45064
Automatic update from web-platform-tests
[Invokers] Only dispatch invoke for built-ins or actions containing '-'
(This relands
https://chromium-review.googlesource.com/c/chromium/src/+/5366502 after
fixing timeout issues in
https://chromium-review.googlesource.com/c/chromium/src/+/5372478)
This change refactors the `HandleInvokeInternal` calls to use an enum
class of known attribute values including a `kCustom` key which can determine if the invoke action meets the criteria for being
a "custom" action - that is it includes a dash (see
b40ba866cc).
This also updates the tests to reflect this; only actions with a `-`, or
otherwise known actions, will dispatch an event. All other actions do
not, and must be manually dispatched. This does not preclude web authors
from manually dispatching said events.
Bug: 40947660
Change-Id: Ie6efeac7991c449b54d0c8b7ed360501ae5c8d37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5388656
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Auto-Submit: Keith Cirkel <chromium@keithcirkel.co.uk>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1277851}
--
wpt-commits: 1881c1e2fec3b1716f234d9a53204b15caf856ed
wpt-pr: 45288
Automatic update from web-platform-tests
Move test defaults to a dedicated function
Setting the test defaults doesn't belong in _generated_test. Moving
that out is the start of a larger cleanup aiming at improving
separation of concerns. _generate_test does way too many things, making
it hard to maintain and improve.
Bug: 330885075
Change-Id: I409b04ba0bd8173d6b17cef31d7a639d6646a34f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5376074
Reviewed-by: Andres Ricardo Perez <andresrperez@chromium.org>
Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1277618}
--
wpt-commits: 658197877d863fe2773f692cd63aa8109394cf27
wpt-pr: 45318
Automatic update from web-platform-tests
Clean up PendingBeaconAPI-related implementation (#45188)
It was an experimental API only enabled for OT from M107-M115 [1].
Since then, it has been replaced by the fetchLater API [2], which is
currently running in OT [3].
[1]: https://chromestatus.com/feature/5690553554436096
[2]: https://github.com/WICG/pending-beacon/blob/main/docs/fetch-later-api.md
[3]: https://chromestatus.com/feature/4654499737632768
OBSOLETE_HISTOGRAM[PendingBeaconHost.BatchAction]=Removed entire API
OBSOLETE_HISTOGRAM[PendingBeaconHost.Action]=Removed entire API
Bug: b:40213606
Change-Id: I391bb3d38cdf11b40f6dc7cd755eded0923deb7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5367498
Reviewed-by: Sean Harrison <harrisonsean@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Ming-Ying Chung <mych@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1276738}
Co-authored-by: Ming-Ying Chung <mych@chromium.org>
--
wpt-commits: af41a1105096fbd88d3a45ca75e233792b151d0c
wpt-pr: 45188
Automatic update from web-platform-tests
Refactor WPTs to support manual reportEvent beacons. (#45131)
We have a few different workstreams converging on manual
reportEvent beacon changes, but we can't really test
for them in the WPT environment. This CL registers a
click URL in the bidder's registerAdBeacon, along with some
additional refactoring and renaming to indicate that tests
support more than just automatic beacons now.
Change-Id: Ibf35acafd335bc1d6e195574b64db6479ee0e7ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5375043
Commit-Queue: Andrew Verge <averge@chromium.org>
Reviewed-by: Liam Brady <lbrady@google.com>
Cr-Commit-Position: refs/heads/main@{#1276494}
Co-authored-by: Andrew Verge <averge@chromium.org>
--
wpt-commits: 8132fec8ba02d03bd7a9dc350305d11afa0c87a9
wpt-pr: 45131
Automatic update from web-platform-tests
[Invokers] mark clickon tests as long (#45196)
This change aims to avoid timeouts on invoker tests that are occurring
because of the long time between clickOn calls, which can take the test
runs over the timeout threshold on some builds on slower hardware.
Bug: 40943183
Change-Id: I5976d824dd8b98355eb69991908d7b5e57937f35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5372478
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1276602}
Co-authored-by: Keith Cirkel <chromium@keithcirkel.co.uk>
--
wpt-commits: 49e8a846d9b1e9778c0cd4bdeb54bd796a5211fc
wpt-pr: 45196
Automatic update from web-platform-tests
Remove the '_' hack to remove variant names from filename
For some variants, we do not want to automatically insert the variant
names in the generated filename. This used to be done by prefixing the
variant names with '_'. Later, an 'append_variants_to_name' param was
added. This is cleaner and more explicit and we should get rid of the
'_' hack in favor of this new param.
Bug: 330885075
Change-Id: Ibcded647146945ecea60bea5e3d76747c338f1aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5377283
Reviewed-by: Andres Ricardo Perez <andresrperez@chromium.org>
Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1277613}
--
wpt-commits: 38d12c53a760ba763d86bd1ff3b36df3de5b9764
wpt-pr: 45316
Automatic update from web-platform-tests
Port animation-*-event-destroy-renderer to WPT (#45169)
Though the test is effectively a crash test, it cannot be implemented
as such since the ported test uses variants. Authored as a promise
test. The test triggers a change during event handling that will
result in animations being cancelled, which must be handled gracefully.
Bug: 40662869
Change-Id: I69dd392ceccdcdc70c4806e0e3f3787d88851abe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5374677
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1276410}
Co-authored-by: Kevin Ellis <kevers@google.com>
--
wpt-commits: 43e73ae7d6dc9036abfefe074d3fd1308c1b8d0e
wpt-pr: 45169