In the particular case of this bug's crashtest, a dataavailable callback from
the track encoder was raised at a point when
VP8TrackEncoder::GetEncodedPartitions would not actually return any data.
This would make VP8TrackEncoder::GetEncodedTrack propagate the error and set the
recorder in an error state, and cancel any ongoing recordings.
VP8TrackEncoder::GetEncodedPartitions was changed in bug 1333341 to distinguish
end-of-stream from other, real, errors; but callsites were not updated.
This patch fixes the callsites.
Depends on D36509
Differential Revision: https://phabricator.services.mozilla.com/D36510
--HG--
extra : moz-landing-system : lando
It leads to a race with MediaRecorder::Session::Shutdown where the RunOnGraph
runner was dispatched to the graph before, but tries to dispatch to the encoder
thread after, the encoder thread had BeginShutdown() called on it.
Allowing the encoder thread dispatch to fail in this case is reasonable and
safe.
Depends on D36508
Differential Revision: https://phabricator.services.mozilla.com/D36509
--HG--
extra : moz-landing-system : lando
Some tests still disabled due to either test environment weirdness or actual breakage.
Differential Revision: https://phabricator.services.mozilla.com/D36531
--HG--
extra : moz-landing-system : lando
This patch adds two tests. One for ensuring the mini panel is working
correctly. Another for check the correctness of the TP switch flow.
Differential Revision: https://phabricator.services.mozilla.com/D36332
--HG--
extra : moz-landing-system : lando
This patch adds the badge at the side of TP switch toggle. The badge
will only show when the TP switch toggles to off.
Differential Revision: https://phabricator.services.mozilla.com/D36019
--HG--
extra : moz-landing-system : lando
This patch makes the mini panel been shown after page reload due to
switch the tracking protection state. The mini panel will be auto hidden
after certain time, which can be configured by the pref
'browser.protections_panel.mini_panel_auto_hide_timing'. The default
value is 5 seconds.
This also implements the behavior that showing the protections panel on
clicking the mini panel.
Differential Revision: https://phabricator.services.mozilla.com/D36018
--HG--
extra : moz-landing-system : lando
This patch implements the capability for opening the protections panel
as a mini panel. The mini panel is a protections panel which only displays
the header section.
Differential Revision: https://phabricator.services.mozilla.com/D36017
--HG--
extra : moz-landing-system : lando
This patch implements the toggle switch flow for the TP switch section.
It adds a strip background to the TP switch section after toggled the
switch to off. Changing the string in the TP switch section. And the
breakage link should be remained after TP switch to off from on until
the page refreshs.
Differential Revision: https://phabricator.services.mozilla.com/D36016
--HG--
extra : moz-landing-system : lando
This patch makes the 'hasException' attribtion to be toggled right after
toggling the TP switch. In order to do styling after the toggling.
Differential Revision: https://phabricator.services.mozilla.com/D36015
--HG--
extra : moz-landing-system : lando
Adds includePinned and includeSearchShortcuts options to the topSites API, so
that it's possible to get a list of results like it's shown on the newtab page.
Both options default to false, so that the existing behavior is preserved.
The API gets disabled on Android; this API always depended on APIs not well
supported there, and the test is disabled on Android, so it was untested.
Differential Revision: https://phabricator.services.mozilla.com/D36467
--HG--
extra : moz-landing-system : lando
For content like:
<select>
<optgroup style="overflow: scroll">
<option>
the existing rules would match the <xul:scrollbar> elements that are
generated for the <optgroup>, since they use descendant selectors after
the `select:not([size]):not([multiple])`, even though the intention
(probably!) is to match only the scrollbars created for the <select>
itself.
On Android, we don't actually render <select> elements in the page;
instead we use some system UI popup. So in practice the difference in
rendering here isn't relevant. (It's possible we could remove these
rules entirely.)
Differential Revision: https://phabricator.services.mozilla.com/D36449
--HG--
extra : moz-landing-system : lando
