The estimated memory is based on the maximum observed memory usage when running
the Java script attached to the bug report.
Differential Revision: https://phabricator.services.mozilla.com/D51087
--HG--
extra : moz-landing-system : lando
Depends on D51054
Summary of the changes here:
- move DOMHelpers.jsm to dom-helpers.js
- remove all unused methods
- converted to a static helper to avoid instanciating DOMHelpers objects for no reason
- updated call sites accordingly
Differential Revision: https://phabricator.services.mozilla.com/D51065
--HG--
rename : devtools/shared/DOMHelpers.jsm => devtools/shared/dom-helpers.js
extra : moz-landing-system : lando
In the future we should re-write this checker but for now this solution is acceptable.
Differential Revision: https://phabricator.services.mozilla.com/D51242
--HG--
extra : moz-landing-system : lando
Automatic update from web-platform-tests
CSS: WPT tests property values are supported.
test_computed_value now checks that the value is supported.
Change-Id: Ic8c38df6030b3689f4fdec30a55f230d6cc113d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866498
Reviewed-by: Alison Maher <almaher@microsoft.com>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708034}
--
wpt-commits: 32ffb13f7f7fce355bfb8065f7748fa708bf654b
wpt-pr: 19755
Automatic update from web-platform-tests
Add test cases for changing scroll position with scroll behavior (#19837)
Add test cases for changing scroll attributes with scroll behavior. Smooth scroll behavior should also trigger scroll animation for changing scroll attributes.
--
wpt-commits: a3dd2ad02c65588ad280ceac378d82e9250d1045
wpt-pr: 19837
Automatic update from web-platform-tests
[Azure Pipelines] work around safaridriver issue with plist hack (#19846)
Adapted from a successful workaround on STP 91:
f31328c4c2
That workaround stopped working in STP 92:
https://github.com/web-platform-tests/wpt/pull/19142#issuecomment-532827391
There's a non-trivial risk that it will stop working for Safari stable
as well, but right now it works and is better than no results.
--
wpt-commits: df2cd5d98cd4475c9d43b7af31f009f4ce3bd700
wpt-pr: 19846
Automatic update from web-platform-tests
Convert tabs to spaces in css/ directories with few lint errors (#19832)
This follows the same approach as in https://github.com/web-platform-tests/wpt/pull/19824
to identify directories in css/ with few lint errors and removes the
lint.whitelist exceptions for those.
For css/css-counter-styles/ some newlines were also added/removed to
arrive at a reasonable style.
--
wpt-commits: 5af91f79216344d5a243f2fc133e373b39e1322e
wpt-pr: 19832
Automatic update from web-platform-tests
[LayoutNG] Reland flex-item alignment
We were stretching items that had auto cross margins. This patch sets a
flag on FlexItem when it needs relayout due to stretching. It's not
elegant but is also not intrusive.
This reverts commit 2390edbd75a34b6c6f42ee7586f8f86af3329781.
Bug: 845235, 1015475
Change-Id: Iebefb670f2d3ae4047565077776a6d7a1ff2c2fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867434
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708455}
--
wpt-commits: 854827cfcdf3142b122cac91774f40708bbcf1f7
wpt-pr: 19775
Automatic update from web-platform-tests
[Azure Pipelines] unpin Safari Technology Preview (#19783)
This goes back to the state before https://github.com/web-platform-tests/wpt/pull/17187,
using the newest version of STP in homebrew-cask-versions.
--
wpt-commits: 37ddae9c2cf865fb5aa229eb9ec1ae0b0bce1cee
wpt-pr: 19783
Automatic update from web-platform-tests
Use a new temporary directory for manifest generation in CI (#19802)
In https://github.com/web-platform-tests/wpt/pull/19580 retry for
manifest generation was introduced, to make it more robust in case of
network errors or the GitHub search API not indexing the merged PR
fast enough.
However, an accidental commit to master showed that this won't work:
https://github.com/web-platform-tests/wpt/runs/265191690
It first failed with "No PR found for 9e1d0a26f155ccb088d342b0036e535d033423c1"
because there was no PR, just a direct push to master. Retries then
failed with "File exists: '/home/runner/meta'".
Use a new temporary directory every time to deal with this. Don't
attempt to remove the directory when done as this script is run in a
CI system where all state is thrown away on completion.
--
wpt-commits: 3b13e3a1313e08cf4bc5270ab59c149a2bc56260
wpt-pr: 19802
Automatic update from web-platform-tests
reftests: if images hashes don't match, try to compare pixels. (#19825)
* When comparing the result of a reftest, checking if the hash of
the expected result matches the hash of the test is not enough.
An image can have different hash, but still be the very same
image (same pixels).
* This patch implements checks for pixel equality between the two
images when the hashes are different.
* It has been observed that in WebKit based browsers (Safari, WebKitGTK)
this happens and many tests are beeing flagged incorrectly as failing.
--
wpt-commits: 9c38c341f55ea17a92eae621cf369d22c5a4980b
wpt-pr: 19825
Automatic update from web-platform-tests
Using Android device when retrieving version in browser.
ChromeAndroidBase.version, AndroidWebview.find_binary, and
ChromeAndroidBrowser._adb_run were not using the device serial
supplied by the --device-serial command-line option.
Additionally the device serial number was not being passed
to the webdriver when running tests for Chromium on Android.
Bug: None
Change-Id: I3f79191a9cb556f119f7b167f363bf596591c2c8
TESTING: Manually for both Chromium and WebView.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860676
Commit-Queue: Chris Mumford <cmumford@google.com>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708268}
--
wpt-commits: 76fb17d6cac9c6c56ef3b4e2fbea1765abd926e3
wpt-pr: 19709
Automatic update from web-platform-tests
Amend test_designMode to accept either empty string or br tag (#18470)
* Changed test_designMode to check for empty string instead of br tag
* Accept both <br> and empty string
--
wpt-commits: 2f293bc9a0b276b0fd58af0b8fbc2f5875e56360
wpt-pr: 18470
Automatic update from web-platform-tests
wake lock: Expand IDL harness tests (#19826)
As mentioned in #19738, the IDL tests need more content, especially now that
interfaces/wake-lock.idl has been updated to match the latest version of the
spec.
* Add Navigator/WorkerNavigator to the objects we test.
* Add WakeLockSentinel to the objects we test by actually requesting and
then releasing a lock.
--
wpt-commits: 977a8e18be0adad48ced728de64e0b4497ca723b
wpt-pr: 19826
Automatic update from web-platform-tests
[WebNFC] Add data attribute to NDEFRecord
This CL adds the data attribute to NDEFRecord as specified in
https://github.com/w3c/web-nfc/pull/379
Bug: 520391
Change-Id: Icab2c69d6cec95540e6f8525354e86a6937aa4e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871369
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#708167}
--
wpt-commits: ad93565efd7161ee146a44e92c02d7339dbaf8e1
wpt-pr: 19804
Automatic update from web-platform-tests
Convert tabs to spaces in directories with few lint errors (#19824)
To find the candidates for this change, the "INDENT TABS" exceptions
in lint.whitelist were removed and ./wpt lint` run.
The output was piped through `grep '^ERROR:lint:' | cut -d: -f3 | sort
| uniq | cut -d/ -f1 | uniq -c | sort -n`, giving the following list:
```
1 pointerlock
1 shadow-dom
1 webaudio
2 docs
2 webvtt
7 content-security-policy
9 encoding
203 conformance-checkers
5011 css
```
Based on that, conformance-checkers, css and encoding were left alone.
--
wpt-commits: 3abb74d89e92b91567d16653e0b63d27f15a7022
wpt-pr: 19824
Automatic update from web-platform-tests
Replace "TaskCluster" with "Taskcluster" where possible (#19822)
This matches the Taskcluster website and our label:
https://tools.taskcluster.net/https://github.com/web-platform-tests/wpt/labels/Taskcluster
Command use:
> git grep -l TaskCluster | xargs sed -i 's/TaskCluster/Taskcluster/g'
Occurences in tools/taskcluster/testdata/ were left alone, as they
match real historical commits/PRs with "TaskCluster" in them.
--
wpt-commits: 237825fc22f06ca12a3bff5011a668ce0f101a7c
wpt-pr: 19822
Automatic update from web-platform-tests
Don't generate pseudo element inside display:none.
We checked for non-null GetComputedStyle(), but it may also be non-null
inside display:none when ensured from getComputedStyle(). Skip
generating pseudo elements for that case. This caused a DCHECK failure
due to an incorrect marking for layout tree re-attachment inside
display:none.
Bug: 1013570
Change-Id: I75318b9d3bed1ed68dab232d90bbdc9b68655152
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872096
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708147}
--
wpt-commits: 03f4ea383cd4d9c5e8f46f9f405833e96a3a4809
wpt-pr: 19815
Automatic update from web-platform-tests
[Azure Pipelines] upgrade to Ubuntu 18.04 (from 16.04)
These jobs only run `./wpt test-jobs` and `curl`, but it's just as
well to upgrade them well before Ubuntu 16.04 is no longer supported.
--
wpt-commits: 0740bf536a0dbdb60ef76dd0cb15980ebcc86c7d
wpt-pr: 19820
This warns because an expression with a side effect is inside a `static_assert` or
`sizeof`.
Differential Revision: https://phabricator.services.mozilla.com/D51243
--HG--
extra : moz-landing-system : lando
The problem is that a GC can be triggered in a number of ways, so scheduling zones in nsJSContext::GarbageCollectNow is not effective. This patch schedules these zones in the GC callback, which is always called at the start of GC. This means we have to change the internal logic slightly to allow the GC callback to schedule addional zones; previously this state was saved and restored before/after running the callback.
Differential Revision: https://phabricator.services.mozilla.com/D51145
--HG--
extra : moz-landing-system : lando
The idea of these are not to penalize legit uses of scroll anchoring, and
catching pathological cases fast.
The current algorithm I thought of is just whether the average of all the
consecutive scroll anchoring adjustments is less than a given threshold.
If the average adjustment is close to zero and the user is not scrolling, it
means that we're not making much progress.
It is important that zero adjustments don't get counted, since those are common
during window resizes and don't have side-effects anyway.
Exact number may need tuning, let me know if you want it
nightly-and-early-beta-only for now or something.
Depends on D51038
Differential Revision: https://phabricator.services.mozilla.com/D51024
--HG--
extra : moz-landing-system : lando
This makes HeapPtr members const where it was easy to do so. Flagging jimb for review since most of these were in the debugger.
Differential Revision: https://phabricator.services.mozilla.com/D50624
--HG--
extra : moz-landing-system : lando
This replaces GCPtr members with const GCPtr where trival to do so.
Depends on D50618
Differential Revision: https://phabricator.services.mozilla.com/D50619
--HG--
extra : moz-landing-system : lando
The main change is to make BarrieredBase::unsafeUnbarrieredForTracing() const and use const_cast to get return the non-const pointer. This makes sense because the GC is allowed to update the pointer used while preseving the logical value of the cell, e.g. when compacting.
Differential Revision: https://phabricator.services.mozilla.com/D50618
--HG--
extra : moz-landing-system : lando
This warns because an expression with a side effect is inside a `static_assert` or
`sizeof`.
Differential Revision: https://phabricator.services.mozilla.com/D51243
--HG--
extra : moz-landing-system : lando
