Commit Graph

7606 Commits

Author SHA1 Message Date
Marco Zehe
36b5ca6aa6 Bug 1509222 - XUL toolbarbutton with checked="true' but not type="checkbox" doesn't get the pressed state, r=Jamie
Simply decouple the check for the checked attribute from the one for the type attribute.

Differential Revision: https://phabricator.services.mozilla.com/D12632

--HG--
extra : moz-landing-system : lando
2018-11-22 22:39:51 +00:00
Marco Zehe
f86d40d773 Bug 1508935 - Create more accessibles from the HTML markup map rather than layout frame types, r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D12639

--HG--
extra : moz-landing-system : lando
2018-11-23 06:49:00 +00:00
Tim Nguyen
044d8ca731 Bug 1508142 - Remove remains of tree cell-based selection code. r=bzbarsky,bgrins
Differential Revision: https://phabricator.services.mozilla.com/D12225

--HG--
extra : moz-landing-system : lando
2018-11-22 09:59:02 +00:00
Marco Zehe
ccd63db4b3 Bug 1508870 - Make a distinction between an empty returned string versus a null pointer, r=Jamie
When determining if an author provided an empty alt attribute versus no alt attribute at all, our image accessible name is either an empty string or a null string. Screen readers can then choose to guess the name from the source if the author did not explicitly provide an empty alt text and thus marked the image as decorative.

The accessible handler for the Windows remote processes did not account for this distinction, always returning what appeared to be an empty string. This was found while determining why NVDA wasn't guessing the SRC from a non-labelled graphical link. NVDA checks to see if the name returned by the link accessible is null, and then decides to look for the graphical children if that is the case.

Differential Revision: https://phabricator.services.mozilla.com/D12532

--HG--
extra : moz-landing-system : lando
2018-11-22 06:09:31 +00:00
Marco Zehe
2d841c76b1 Bug 1507365 - Allow labels inside toolbarbuttons to participate in accessible name calculation, r=Jamie
Toolbar buttons in XUL can now have labels inside them to provide the actual caption for the button. Adjust the accessibility module to allow label elements as acceptable children for the toolbarbutton element so the algorithm can pick up their text for the button's name.

Differential Revision: https://phabricator.services.mozilla.com/D12527

--HG--
extra : moz-landing-system : lando
2018-11-22 05:57:48 +00:00
Eitan Isaacson
30fe7d0849 Bug 1509111 - Populate viewIdResourceName correctly. r=yzen
Differential Revision: https://phabricator.services.mozilla.com/D12583

--HG--
extra : moz-landing-system : lando
2018-11-21 21:07:20 +00:00
Paolo Amadini
37ad34fc88 Bug 1429940 - Null-check the GetContent call on the parent. r=Jamie
--HG--
extra : rebase_source : 1f2692152b608d9283990a6051091410ad0f6fea
2018-11-21 15:24:13 +00:00
Jonathan Watt
181d407b43 Bug 1510167. Mark some nsGkAtom* arguments as const in DOM code. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D13049

--HG--
extra : rebase_source : 66db700ce58e88ab95c24e9dbc70ba4815e94df1
2018-11-13 12:48:21 +00:00
Gerald Squelart
1bd6a1fd4e Bug 1435091 - p4. Use profiler_thread_is_being_profiled() instead of profiler_is_active() around profiler_add_marker()s - r=mstange
(Unless there were other profiler actions, as I'm not sure yet whether it would
be safe to skip them when the profiler is paused; another bug should
investigate that.)

Differential Revision: https://phabricator.services.mozilla.com/D11308

--HG--
extra : moz-landing-system : lando
2018-11-19 06:29:15 +00:00
shindli
95b9b72836 Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-11-20 23:50:05 +02:00
Tom Schuster
5a9d2a428c Bug 1493292 - Remove aDataLen parameters from nsITransferable.getTransferData. r=smaug
Depends on D11200

Differential Revision: https://phabricator.services.mozilla.com/D11201

--HG--
extra : moz-landing-system : lando
2018-11-20 16:59:56 +00:00
Csoregi Natalia
df7483024d Backed out 6 changesets (bug 1493292) for bustage on /nsTransferable.cpp. CLOSED TREE
Backed out changeset f198bf91320b (bug 1493292)
Backed out changeset 6487aa307123 (bug 1493292)
Backed out changeset f2cabd69c568 (bug 1493292)
Backed out changeset 71430fceb4a3 (bug 1493292)
Backed out changeset 3a9b6d65d8c7 (bug 1493292)
Backed out changeset 55769869037c (bug 1493292)
2018-11-20 17:13:18 +02:00
Tom Schuster
b292ec7c2c Bug 1493292 - Remove aDataLen parameters from nsITransferable.getTransferData. r=smaug
Depends on D11200

Differential Revision: https://phabricator.services.mozilla.com/D11201

--HG--
extra : moz-landing-system : lando
2018-11-20 14:47:02 +00:00
Paolo Amadini
4d52da3cb2 Bug 1429940 - Part 1 - Use the first "label" element instead of the one inside "caption" to describe the "groupbox" element. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D11793

--HG--
extra : rebase_source : eec887ae45eb1a2b1356cef2f6cbbf24a5427f39
2018-11-15 12:05:09 +00:00
Paolo Amadini
b2a83ffc85 Bug 1499947 - Part 1 - Remove XULProgressMeterAccessible and its base template class. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D12144

--HG--
extra : rebase_source : 81275b233770a7e9716a2b811a08060fc5006e1b
2018-11-20 14:10:38 +00:00
Boris Zbarsky
47f81c215b Bug 1507540 part 7. Use notxpcom more in dom/. r=mccr8 2018-11-19 20:20:17 -05:00
Lina Cambridge
994f3a458c Bug 1494713 - Add nsWindow::From. r=jchen
Differential Revision: https://phabricator.services.mozilla.com/D11289

--HG--
extra : moz-landing-system : lando
2018-11-16 17:31:58 +00:00
Timothy Guan-tin Chien
2b5881e46b Bug 1503019 - Part I, Remove dom.webcomponents.shadowdom.enabled r=smaug
This patch removes the dom.webcomponents.shadowdom.enabled pref and all its
references, including the following functions:

* nsContentUtils::IsShadowDOMEnabled()
* nsIDocument::IsShadowDOMEnabled()
* nsDocument::IsShadowDOMEnabled(JSContext* aCx, JSObject* aGlobal)
* nsDocument::IsShadowDOMEnabled(const nsINode* aNode)
* nsTextNode::IsShadowDOMEnabled(JSContext* aCx, JSObject* aObject)

This function is renamed and updated to nsDocument::IsCallerChromeOrAddon():

* nsDocument::IsShadowDOMEnabledAndCallerIsChromeOrAddon(JSContext* aCx, JSObject* aObject)

I didn't change the tests that load Shadow DOM tests in an iframe, in the interest of keeping hg annotation history.

Differential Revision: https://phabricator.services.mozilla.com/D11183

--HG--
extra : moz-landing-system : lando
2018-11-15 06:51:07 +00:00
Andreea Pavel
d51566f085 Backed out 2 changesets (bug 1503019) for failing crashtests at dom/base/crashtests/1505811.html on a CLOSED TREE
Backed out changeset 06b12fd41ff1 (bug 1503019)
Backed out changeset 7b845eac9dd7 (bug 1503019)
2018-11-15 01:52:30 +02:00
Andreea Pavel
9cabbb0b47 Merge mozilla-central to autoland. a=merge on a CLOSED TREE 2018-11-15 00:35:07 +02:00
Cristina Coroiu
60654b0cda Bug 1503084 - disable browser_caching_name.js for frequent failures r=gbrown
--HG--
extra : histedit_source : 71daa8098bf1d42a05c479f9bb708925b1bbfced
2018-11-14 07:21:00 +02:00
Timothy Guan-tin Chien
c0cc4f74e7 Bug 1503019 - Part I, Remove dom.webcomponents.shadowdom.enabled r=smaug
This patch removes the dom.webcomponents.shadowdom.enabled pref and all its
references, including the following functions:

* nsContentUtils::IsShadowDOMEnabled()
* nsIDocument::IsShadowDOMEnabled()
* nsDocument::IsShadowDOMEnabled(JSContext* aCx, JSObject* aGlobal)
* nsDocument::IsShadowDOMEnabled(const nsINode* aNode)
* nsTextNode::IsShadowDOMEnabled(JSContext* aCx, JSObject* aObject)

This function is renamed and updated to nsDocument::IsCallerChromeOrAddon():

* nsDocument::IsShadowDOMEnabledAndCallerIsChromeOrAddon(JSContext* aCx, JSObject* aObject)

I didn't change the tests that load Shadow DOM tests in an iframe, in the interest of keeping hg annotation history.

Differential Revision: https://phabricator.services.mozilla.com/D11183

--HG--
extra : moz-landing-system : lando
2018-11-14 19:34:52 +00:00
rosston
8f54bcb47f Bug 1501904 - Fire accessibility focus events when using readline nav in url bar r=dao,Jamie
Differential Revision: https://phabricator.services.mozilla.com/D10058

--HG--
extra : moz-landing-system : lando
2018-11-08 14:14:57 +00:00
Eitan Isaacson
413fe38c65 Bug 1479039 - Update SessionAccessibility cache and state from events. r=snorp,yzen
Differential Revision: https://phabricator.services.mozilla.com/D11217

--HG--
extra : moz-landing-system : lando
2018-11-12 16:42:37 +00:00
Eitan Isaacson
f312bc912b Bug 1479039 - Update cached focus path bounds on scroll. r=snorp,yzen
Differential Revision: https://phabricator.services.mozilla.com/D11216

--HG--
extra : moz-landing-system : lando
2018-11-12 16:42:03 +00:00
Eitan Isaacson
956b93179f Bug 1479039 - Implement java portion of focus path cache. r=snorp,yzen
Differential Revision: https://phabricator.services.mozilla.com/D11215

--HG--
extra : moz-landing-system : lando
2018-11-12 16:41:40 +00:00
Eitan Isaacson
970933ad81 Bug 1479039 - Extend BatchData struct and added focus path cache. r=yzen
Differential Revision: https://phabricator.services.mozilla.com/D11214

--HG--
extra : moz-landing-system : lando
2018-11-12 16:41:38 +00:00
Eitan Isaacson
5b5349d41f Bug 1479039 - Refactor ToBundle to have a multiple argument version. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D11213

--HG--
extra : moz-landing-system : lando
2018-11-12 16:41:33 +00:00
Eitan Isaacson
3e98aa79f5 Bug 1479039 - Move PersistentPropertiesToArray to nsAccUtils. r=Jamie
In order to send send attributes in BatchData we will need to convert
them to an array. Here we factor out the private function that does that
and put it in nsAccUtils.

Differential Revision: https://phabricator.services.mozilla.com/D11211

--HG--
extra : moz-landing-system : lando
2018-11-12 16:41:31 +00:00
Marco Zehe
ab92f98230 Bug 1506041 - Code cleanup: Convert more static functions to lambdas in the markup map, r=Jamie
All static functions from nsAccessibilityService that were either only called once from the markup map, or are simple one-liners that were only called up to three times, were converted to lambdas in the markup map.

the static function that creates HyperTextAccessibleWrap has remained untouched because it is called a lot from the markup map, even though its implementation is actually just a one-liner.

The other untouched static function is the templated one for html:dt or html:dd.

Differential Revision: https://phabricator.services.mozilla.com/D11458

--HG--
extra : moz-landing-system : lando
2018-11-11 23:13:35 +00:00
Emilio Cobos Álvarez
ea43a5393a Bug 1196668 - Make images without alt generate a replaced box regardless of src. r=bz
Behavior-wise this only removes the HasAttr(src) check, and adds the IsEmpty()
check to the alt attribute value, since this function is only called for <img>
and <input>.

But it also cleans up a bit.

Differential Revision: https://phabricator.services.mozilla.com/D11194
2018-11-09 18:10:14 +01:00
Gurzau Raul
139c9b897f Backed out 2 changesets (bug 1196668) for assertion count failures at child-constraints/available-size-for-percentages-vrl-htb.https.html
Backed out changeset ff03b0b8ed81 (bug 1196668)
Backed out changeset 8e423aa1c94e (bug 1196668)
2018-11-09 06:33:16 +02:00
Emilio Cobos Álvarez
54599e6187 Bug 1196668 - Make images without alt generate a replaced box regardless of src. r=bz
Behavior-wise this only removes the HasAttr(src) check, and adds the IsEmpty()
check to the alt attribute value, since this function is only called for <img>
and <input>.

But it also cleans up a bit.

Differential Revision: https://phabricator.services.mozilla.com/D11194

--HG--
extra : source : 803b224d52a0940b4fb4b3b9cffc6a1fa6e5d4ee
2018-11-07 18:26:17 +01:00
Gurzau Raul
ecadb55316 Backed out changeset 803b224d52a0 (bug 1196668) for failures at dom/html/reftests/468263-2.html on a CLOSED TREE 2018-11-09 05:00:56 +02:00
Emilio Cobos Álvarez
b0577a5771 Bug 1196668 - Make images without alt generate a replaced box regardless of src. r=bz
Behavior-wise this only removes the HasAttr(src) check, and adds the IsEmpty()
check to the alt attribute value, since this function is only called for <img>
and <input>.

But it also cleans up a bit.

Differential Revision: https://phabricator.services.mozilla.com/D11194
2018-11-09 02:56:56 +01:00
Bogdan Tara
388d7c8b5a Merge inbound to mozilla-central. a=merge 2018-11-08 20:48:31 +02:00
Marco Zehe
b96e455eb6 Bug 1503964 - Prevent crashes when dealing with crazy table row and column role constructs, r=Jamie
Made IsTableCell() only check the generic type, not the ARIA map entry that gets checked in HasGenericType. This prevents the crash and also fixes IsTableCell() and AsTableCell() not being in sync.

Differential Revision: https://phabricator.services.mozilla.com/D10713

--HG--
extra : moz-landing-system : lando
2018-11-08 10:54:09 +00:00
Mike Hommey
229e466656 Bug 1504906 - Add another -Werror exception for G_DEFINE_TYPE_EXTENDED. r=gps
Versions of glib newer than the one we currently use adds a function we
don't use.

Differential Revision: https://phabricator.services.mozilla.com/D11136
2018-11-08 19:49:38 +09:00
Mike Hommey
ad2fed0601 Backed out 6 changesets (bug 1504906 and bug 1505652) to give time to toolchains and docker images to build without blocking other landings.
Backed out changeset 2fe1e2b7d9c6 (bug 1504906)
Backed out changeset 27b4002951a4 (bug 1504906)
Backed out changeset f7a685b16579 (bug 1504906)
Backed out changeset f8064dbb8009 (bug 1504906)
Backed out changeset f899fbb4a5d7 (bug 1504906)
Backed out changeset 3f71db4aef73 (bug 1505652)
2018-11-08 17:18:05 +09:00
Mike Hommey
53f7817573 Bug 1504906 - Add another -Werror exception for G_DEFINE_TYPE_EXTENDED. r=gps
Versions of glib newer than the one we currently use adds a function we
don't use.

Differential Revision: https://phabricator.services.mozilla.com/D11136
2018-11-08 17:13:20 +09:00
Eitan Isaacson
7befdbc6f7 Bug 1502187 - Implement native part of viewport caching. r=Jamie
Depends on D9865

Differential Revision: https://phabricator.services.mozilla.com/D9866

--HG--
extra : moz-landing-system : lando
2018-11-06 04:35:51 +00:00
Eitan Isaacson
82efc98977 Bug 1502187 - Add Batch protocol to PDocAccessible. r=Jamie
This protocol is meant to be used by platform wrappers to push bulk data
to the chrome process.

Depends on D9689

Differential Revision: https://phabricator.services.mozilla.com/D9864

--HG--
extra : moz-landing-system : lando
2018-11-06 04:22:08 +00:00
Narcis Beleuzu
9b3f73e696 Merge mozilla-central to inbound. CLOSED TREE 2018-11-05 23:54:03 +02:00
Jonathan Kingston
4248b4c554 Bug 1490257 - Pass triggeringPrincipal to test code. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D10882

--HG--
extra : moz-landing-system : lando
2018-11-05 14:05:47 +00:00
Eitan Isaacson
485bf4e802 Bug 1503728 - Get proxy's SessionAccessible from its chrome doc. r=Jamie 2018-11-02 13:12:00 -04:00
Marco Zehe
a7b776042d Bug 1501273 - Expose an html:form element as a landmark role if it has an accessible name, r=Jamie
If html:form has a name given via ARIA, expose it as a landmark to platform APIS that require it. At the time of this submission, this is the case for ATK.

Differential Revision: https://phabricator.services.mozilla.com/D9552

--HG--
extra : moz-landing-system : lando
2018-11-02 01:06:56 +00:00
Marco Zehe
50ba1dd30c Bug 1104947 - Complete the accessibility mapping for aria-current, r=Jamie
We already mapped aria-current to the correct attribute, but we did so unconditionally unless the value was false or undefined. However, if the value was an invalid token, it would not be mapped to "true" as per spec. Now, any bogus value for aria-current will be mapped as if the author had specified "true".

In addition, this patch adds aria-current to the known set of attributes with rules, which causes NSAccessibilityService::MustBeAccessible to make sure an accessible gets created if aria-current is set, even if that accessible is a html:span element. This fixes bug 1365904.

Differential Revision: https://phabricator.services.mozilla.com/D10331

--HG--
extra : moz-landing-system : lando
2018-11-02 06:40:47 +00:00
Daniel Varga
77036132f7 Merge autoland to mozilla-central. a=merge 2018-11-02 00:26:12 +02:00
Julian Descottes
079a123093 Bug 1467712 - Simplify calls to ok to use only 2 arguments;r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D10416

--HG--
extra : moz-landing-system : lando
2018-11-01 13:48:48 +00:00
Csoregi Natalia
faba2c8c15 Backed out 4 changesets (bug 1467712) for multiple failures with: Too many arguments passed to ok. CLOSED TREE
Backed out changeset 9ce0ac2b9d71 (bug 1467712)
Backed out changeset 026eb1f6dc6e (bug 1467712)
Backed out changeset 0088a09d869a (bug 1467712)
Backed out changeset 1b19ea76aad6 (bug 1467712)
2018-11-01 15:22:52 +02:00
Julian Descottes
b50a5ba4dc Bug 1467712 - Simplify calls to ok to use only 2 arguments;r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D10416

--HG--
extra : moz-landing-system : lando
2018-11-01 11:09:48 +00:00
Gurzau Raul
424b125b93 Backed out changeset 523ff2753dea (bug 1490257) for causing Bug 1503757 a=backout 2018-11-01 15:27:30 +02:00
Jonathan Kingston
873b26107e Bug 1490257 - Add asserts into loadURI where we imply SystemPrincipal. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D10221

--HG--
extra : moz-landing-system : lando
2018-10-31 18:00:40 +00:00
Narcis Beleuzu
8d8917f40b Bug 1462638 - Disable browser_treeupdate_canvas.js on Win10 opt/pgo for frequent failures. r=jmaher 2018-11-05 13:04:47 +02:00
Julian Descottes
f6a4b55fda Bug 1503169 - Remove missing layout.js loadScript calls;r=yzen
Depends on D10191
I would like to update browser-test.js to stop swallowing exceptions
when calling loadSubScript from head.js.

It looks like those head files are trying to load a layout.js helper
that I could not find in any revision. Can you check it can be
removed?

Differential Revision: https://phabricator.services.mozilla.com/D10193

--HG--
extra : moz-landing-system : lando
2018-10-30 14:13:25 +00:00
Alexander Surkov
08eb9dff6a Bug 1487311 - accessibility doesn't assosiate ids in shadow DOM, r=jamie, sr=smaug 2018-10-30 08:17:04 +08:00
James Teh
39e736f7dd Bug 1052866 part 2: Handle QI to IAccessibleText for tables. r=MarcoZ
The first patch inherits from the right classes, but because tables have additional interfaces, QueryInterface is overridden.
It had to be updated to also include HyperTextAccessibleWrap.
Rows worked correctly because they don't have any specific interfaces and thus don't override QI.
They just inherit their QI implementation from their base class.

Differential Revision: https://phabricator.services.mozilla.com/D10022

--HG--
extra : moz-landing-system : lando
2018-10-29 06:36:51 +00:00
Alexander Surkov
4536232292 Bug 1052866 - Expose IAccessibleText on tables, rows, etc., r=tbsaunde. Bustage fix by MarcoZ. 2018-10-26 11:07:27 +02:00
Brindusan Cristian
a663055a3b Backed out changeset a69a426bdb14 (bug 1052866) for mochitest failures on test_selection.html. CLOSED TREE 2018-10-26 11:51:22 +03:00
Alexander Surkov
cda4486cbb Bug 1052866 - Expose IAccessibleText on tables, rows, etc., r=tbsaunde
--HG--
extra : rebase_source : 993e03d0f304a02654e11d1c3d7c9abfd85da273
2018-10-26 09:54:20 +02:00
Eitan Isaacson
72450b73d0 Bug 1501496 - Don't send accessible GeckoBundle in sendEvent, class names is enough. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D9689

--HG--
extra : moz-landing-system : lando
2018-10-25 21:49:28 +00:00
Marco Zehe
d66ed81dfa Bug 1501595 - Return the correct region-specific role for named html:section elements, r=Jamie
Bug 1210630 introduced a mapping of the html:section element to roles::LANDMARK, however roles::REGION is more appropriate since that is also used by the WAI-ARIA role mapping and contains specific mappings for regions, e. g. on Mac.

Differential Revision: https://phabricator.services.mozilla.com/D9651

--HG--
extra : moz-landing-system : lando
2018-10-25 01:41:15 +00:00
Margareta Eliza Balazs
77db58fd5a Backed out changeset 02d8210b8904 (bug 1501353) on request from MarcoZ
--HG--
extra : rebase_source : c8ac92b3ed860b783b1cc87b5ef8c231ac75101e
2018-10-24 11:36:25 +03:00
Marco Zehe
c5581dfc0f Bug 1210630 - Section elements with accessible names should be mapped the same as ARIA role region, r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D9480

--HG--
extra : moz-landing-system : lando
2018-10-24 05:34:22 +00:00
Marco Zehe
5104d78a7d Bug 1501353 - Change the exposed accessible role for a named region from region to landmark, r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D9554

--HG--
extra : moz-landing-system : lando
2018-10-24 00:34:21 +00:00
Masayuki Nakano
b42fc1b48b Bug 1498151 - part 2: Fix simple warnings r=aklotz,Jamie
In AccessibleWrap.cpp, VARIANT instances are initialized with {VT_I4}.
However, clang claims they should be initialized with {{{VT_I4}}}.

In CompatibilityUIA, the capturing variable is reference to static variable.
So, this patch makes it refer the static variable directly.

Differential Revision: https://phabricator.services.mozilla.com/D8511

--HG--
extra : moz-landing-system : lando
2018-10-23 17:35:35 +00:00
Masayuki Nakano
309ee2192c Bug 1498151 - part 1: Make IUnknownImpl.h define ATTRIBUTE_UNUSED as __attribute__((unused)) when built with clang r=Jamie
IMPL_IUNKNOWN_QUERY_HEAD defines HRESULT as hr.  However, if its user uses
IMPL_IUNKNOWN_QUERY_TAIL_AGGREGATED, it's never used.  Therefore, it causes
unused variable warning.  hr is defined with ATTRIBUTE_UNUSED.  However,
this is empty when built with clang.

IUnknownImpl.h already defines ATTRIBUTE_UNUSED as __attribute__((unused)) when
built with gcc.  So, same warnings should be prevented when built with clang
too.

Differential Revision: https://phabricator.services.mozilla.com/D8510

--HG--
extra : moz-landing-system : lando
2018-10-23 07:13:33 +00:00
Ciure Andrei
09e4040e94 Merge autoland to mozilla-central. a=merge 2018-10-23 19:48:47 +03:00
Julian Descottes
2fcd6cb020 Bug 1499096 - Update tests using ok() to is();r=Standard8
This changeset updates all the test that were wrongly using ok() and wanted to
use is() AND for which the assert is still passing without any modification
required.

Differential Revision: https://phabricator.services.mozilla.com/D8739

--HG--
extra : moz-landing-system : lando
2018-10-23 07:12:23 +00:00
Marco Zehe
f1a7d75388 Bug 614572 - Expose the correct new landmark role for HTML aside, header, footer, main and nav elements, r=Jamie
According to the HTML Accessibility API mappings spec, aside, footer, header, main and nav elements should be mapped to the WAI-ARIA landmark role exposure. For footer and header, this is only true if scoped to the body element.

This patch changes the exposed roles to the new landmark mapping for the various platforms.

Differential Revision: https://phabricator.services.mozilla.com/D9413

--HG--
extra : moz-landing-system : lando
2018-10-23 06:11:59 +00:00
Margareta Eliza Balazs
bd786693fb Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-10-23 12:33:44 +03:00
Paolo Amadini
42c8938dfc Bug 1493844 - Part 2 - Remove the "caption" and "groupbox" bindings. r=bgrins,dao,jaws,johannh,surkov
Proper native "groupbox" styling depends on the structure of the XBL binding. By restyling the Page Info dialog, the native styling is now unused except for the Print Page Setup dialog on Windows. The native apperance is thus not applied by default anymore, and the "groupbox" element can just be used semantically for accessibility. The Print Page Setup dialog applies the native styling on its own in a way that still works on Windows.

The only other consumers of "groupbox" are the in-content Preferences pages and dialogs. These are updated to use simpler styles that don't depend on the binding structure.

Differential Revision: https://phabricator.services.mozilla.com/D8752

--HG--
extra : rebase_source : af36d911980517f9b53036f4cd4f800c5e20ad22
2018-10-23 10:14:06 +01:00
Eitan Isaacson
0716f068cd Bug 1499209 - Send abbreviated source bundles with accessibility events. r=Jamie
Depends on D8778

Differential Revision: https://phabricator.services.mozilla.com/D8779

--HG--
extra : moz-landing-system : lando
2018-10-22 18:15:34 +00:00
Eitan Isaacson
41167ad214 Bug 1499209 - Refactor AccessibleWrap::ToBundle 1/2. r=Jamie
This refactor does a few things:
1. Unifies the composition of the GeckoBundle, so that some tricky edge
cases don't need to be implemented twice.
2. Allows us to be more frugal with round trip sync ipc calls. Instead
of retrieving everything from the start, only progressivley retrieve
what we need.
3. Sets the groundwork for the next patch that will return from this
function earlier with a smaller bundle.

Differential Revision: https://phabricator.services.mozilla.com/D8778

--HG--
extra : moz-landing-system : lando
2018-10-22 18:15:27 +00:00
Emilio Cobos Álvarez
93668f7672 Bug 1500416 - Fixup to avoid triggering the trailing commas lint on a CLOSED TREE. 2018-10-22 09:35:40 +02:00
Emilio Cobos Álvarez
ba51516ba5 Bug 1500416 - Account for display: contents in ScheduleContentInsertion. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D9338
2018-10-22 09:17:18 +02:00
Sebastian Hengst
15bd86014b No bug - update code after eslint change from merge and remove files removed by 1451484 and restored during merge 2018-10-20 14:32:35 +03:00
Daniel Varga
9a610a8759 Merge mozilla-central to mozilla-inbound. a=merge
--HG--
rename : mobile/android/extensions/webcompat/webextension/background.js => mobile/android/extensions/webcompat/injections.js
rename : mobile/android/extensions/webcompat/webextension/injections/js/bug0000000-dummy-js-injection.js => mobile/android/extensions/webcompat/injections/js/bug0000000-dummy-js-injection.js
rename : mobile/android/extensions/webcompat/webextension/injections/js/bug1452707-window.controllers-shim-ib.absa.co.za.js => mobile/android/extensions/webcompat/injections/js/bug1452707-window.controllers-shim-ib.absa.co.za.js
rename : mobile/android/extensions/webcompat/webextension/injections/js/bug1457335-histography.io-ua-change.js => mobile/android/extensions/webcompat/injections/js/bug1457335-histography.io-ua-change.js
rename : mobile/android/extensions/webcompat/webextension/injections/js/bug1472075-bankofamerica.com-ua-change.js => mobile/android/extensions/webcompat/injections/js/bug1472075-bankofamerica.com-ua-change.js
rename : mobile/android/extensions/webcompat/webextension/injections/js/bug1472081-election.gov.np-window.sidebar-shim.js => mobile/android/extensions/webcompat/injections/js/bug1472081-election.gov.np-window.sidebar-shim.js
rename : mobile/android/extensions/webcompat/webextension/injections/js/bug1482066-portalminasnet.com-window.sidebar-shim.js => mobile/android/extensions/webcompat/injections/js/bug1482066-portalminasnet.com-window.sidebar-shim.js
2018-10-20 13:32:54 +03:00
Gurzau Raul
0468dba8b1 Backed out 2 changesets (bug 1499209) for Accessibility crashes [@ mozilla::a11y::Accessible::Proxy() const] on a CLOSED TREE
Backed out changeset c8d88737a20e (bug 1499209)
Backed out changeset 6a22bf58801f (bug 1499209)
2018-10-20 04:22:52 +03:00
Eitan Isaacson
45919aed72 Bug 1499209 - Send abbreviated source bundles with accessibility events. r=Jamie
Depends on D8778

Differential Revision: https://phabricator.services.mozilla.com/D8779

--HG--
extra : moz-landing-system : lando
2018-10-19 23:26:10 +00:00
Eitan Isaacson
af39427a8f Bug 1499209 - Refactor AccessibleWrap::ToBundle 1/2. r=Jamie
This refactor does a few things:
1. Unifies the composition of the GeckoBundle, so that some tricky edge
cases don't need to be implemented twice.
2. Allows us to be more frugal with round trip sync ipc calls. Instead
of retrieving everything from the start, only progressivley retrieve
what we need.
3. Sets the groundwork for the next patch that will return from this
function earlier with a smaller bundle.

Differential Revision: https://phabricator.services.mozilla.com/D8778

--HG--
extra : moz-landing-system : lando
2018-10-19 23:26:02 +00:00
Emilio Cobos Álvarez
5ebe7949ae Bug 1487312 - Fix content insertion accessibility notifications in Shadow DOM. r=Jamie,surkov
The issue was specific to content insertion directly under a shadow root, the
rest should work (see bug 1427825 for the fix for other similar occurrences).

The removal of the aContainer argument follows the same pattern as bug 1442207.

Differential Revision: https://phabricator.services.mozilla.com/D6431
2018-10-20 01:19:08 +02:00
Mark Banner
ceaeb93550 Bug 1486741 - Enable ESLint rule comma-dangle for all of mozilla-central (automatic fixes). r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D8389

--HG--
extra : moz-landing-system : lando
2018-10-19 12:55:39 +00:00
Marco Zehe
c90a496216 Bug 1492393 - Make our table index methods aware of cells spanning multiple columns, r=surkov
Sometimes, when cells have display:block, and a different cell in the same row has a column span, our index methods did not take these into account. Also, when regular tables encounter such a cell, index calculation failed.

Differential Revision: https://phabricator.services.mozilla.com/D7867

--HG--
extra : moz-landing-system : lando
2018-10-19 08:18:04 +00:00
arthur.iakab
9f8f1698db Backed out 2 changesets (bug 1499209)for failing Android geckoview on AccessibilityTest.testCheckbox
Backed out changeset 12527d50a493 (bug 1499209)
Backed out changeset 4b8f36f9896b (bug 1499209)
2018-10-19 03:27:20 +03:00
Eitan Isaacson
429f00ea83 Bug 1499209 - Send abbreviated source bundles with accessibility events. r=Jamie
Depends on D8778

Differential Revision: https://phabricator.services.mozilla.com/D8779

--HG--
extra : moz-landing-system : lando
2018-10-18 22:54:10 +00:00
Eitan Isaacson
0ed46eeee9 Bug 1499209 - Refactor AccessibleWrap::ToBundle 1/2. r=Jamie
This refactor does a few things:
1. Unifies the composition of the GeckoBundle, so that some tricky edge
cases don't need to be implemented twice.
2. Allows us to be more frugal with round trip sync ipc calls. Instead
of retrieving everything from the start, only progressivley retrieve
what we need.
3. Sets the groundwork for the next patch that will return from this
function earlier with a smaller bundle.

Differential Revision: https://phabricator.services.mozilla.com/D8778

--HG--
extra : moz-landing-system : lando
2018-10-18 22:54:06 +00:00
arthur.iakab
3d3730188f Backed out changeset 89663382dd1e (bug 1499209),for Android build bustages on AccessibleWrap.cpp:416 2018-10-19 01:27:24 +03:00
arthur.iakab
83433f41f3 Backed out changeset 7d3a598c1285 (bug 1499209),for Android build bustages on AccessibleWrap.cpp:416 2018-10-19 01:26:11 +03:00
Eitan Isaacson
57af45b1bf Bug 1499209 - Send abbreviated source bundles with accessibility events. r=Jamie
Depends on D8778

Differential Revision: https://phabricator.services.mozilla.com/D8779

--HG--
extra : moz-landing-system : lando
2018-10-16 15:48:31 +00:00
Eitan Isaacson
629239b628 Bug 1499209 - Refactor AccessibleWrap::ToBundle 1/2. r=Jamie
This refactor does a few things:
1. Unifies the composition of the GeckoBundle, so that some tricky edge
cases don't need to be implemented twice.
2. Allows us to be more frugal with round trip sync ipc calls. Instead
of retrieving everything from the start, only progressivley retrieve
what we need.
3. Sets the groundwork for the next patch that will return from this
function earlier with a smaller bundle.

Differential Revision: https://phabricator.services.mozilla.com/D8778

--HG--
extra : moz-landing-system : lando
2018-10-16 15:48:23 +00:00
Eitan Isaacson
d220e1c023 Bug 1499188 - Make accessibility entry input type an int in bundle message. r=jchen,Jamie
Differential Revision: https://phabricator.services.mozilla.com/D8871

--HG--
extra : moz-landing-system : lando
2018-10-16 16:43:16 +00:00
Marco Zehe
639f76f388 Bug 1499702 - Clean up break statements in EventQueue::CoalesceEvents(), r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D8971

--HG--
extra : moz-landing-system : lando
2018-10-18 07:06:45 +00:00
Eitan Isaacson
fb91501986 Bug 1499182 - Make Android role class names enums. r=jchen,Jamie
Differential Revision: https://phabricator.services.mozilla.com/D8764

--HG--
extra : moz-landing-system : lando
2018-10-17 20:43:49 +00:00
Dorel Luca
451e26f0c6 Backed out changeset 8d7987ea4fb1 (bug 1490257) for causing android failures. CLOSED TREE 2018-10-15 14:39:00 +03:00
Jonathan Kingston
8bcd10a7ab Bug 1490257 - Add asserts and remove implied system triggering principal code r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D8368

--HG--
extra : moz-landing-system : lando
2018-10-15 06:29:45 +00:00
Emilio Cobos Álvarez
40b1e83d81 Bug 1498734 - Always compute angle values to degrees. r=xidorn
This matches the spec, https://drafts.csswg.org/css-values/#angles, which says:

> All <angle> units are compatible, and deg is their canonical unit.

And https://drafts.csswg.org/css-values/#compat, which says:

>When serializing computed values [...], compatible units [...] are converted into a single canonical unit.

And also other implementations (Blink always serializes angles as degrees in
computed style for example).

Also allows us to get rid of quite a bit of code, and makes computed angle value
representation just a number, which is nice.

Differential Revision: https://phabricator.services.mozilla.com/D8619

--HG--
extra : moz-landing-system : lando
2018-10-13 00:41:03 +00:00
Sylvestre Ledru
dd5741407b Bug 1498586 - Add clang-format off to avoid the reformatting of the data structures r=Ehsan
Too hard/impossible for the tool to format correctly these structs

Differential Revision: https://phabricator.services.mozilla.com/D8569

--HG--
extra : moz-landing-system : lando
2018-10-12 20:48:24 +00:00
Eitan Isaacson
3bb071595c Bug 1479037 - Introduce native event support 4/4. r=jchen,yzen?jamie
Depends on D6683

Differential Revision: https://phabricator.services.mozilla.com/D6684

--HG--
extra : moz-landing-system : lando
2018-10-11 16:22:11 +00:00
Eitan Isaacson
65050213b6 Bug 1479037 - Implement native accessible tree 3/4. r=Jamie
Depends on D6682

Differential Revision: https://phabricator.services.mozilla.com/D6683

--HG--
extra : moz-landing-system : lando
2018-10-11 16:21:09 +00:00
Eitan Isaacson
5c76903078 Bug 1479037 - Remove virtual content node, js autofill, and event support 2/4. r=jchen,yzen
Disabled most jsunit tests temporarily in this patch. Will modify and bring them
back up in later patches, as stuff is reimplemented.

Disabled most jsat mochitests. Will have a followup for but reënabling or
porting, depending on the test.

Depends on D6681

Differential Revision: https://phabricator.services.mozilla.com/D6682

--HG--
extra : moz-landing-system : lando
2018-10-11 16:21:01 +00:00
Eitan Isaacson
fb79ae0fda Bug 1479037 - Assign a 32bit ID to each accessible, and make them retrievable from root 1/4. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D6681

--HG--
extra : moz-landing-system : lando
2018-10-11 16:20:54 +00:00
Daniel Varga
4f26bbce63 Merge autoland to mozilla-central. a=merge 2018-10-10 19:07:16 +03:00
Dorel Luca
92a3152cee Backed out 4 changesets (bug 1479037) on dev's request for causing android crashes. a=backout
Backed out changeset 85f8ca59f747 (bug 1479037)
Backed out changeset 630601f0663e (bug 1479037)
Backed out changeset c926c6470235 (bug 1479037)
Backed out changeset f8a20bd86895 (bug 1479037)
2018-10-10 18:52:59 +03:00
Masayuki Nakano
9b40433ef6 Bug 1461708 - part 7: Make EventStateManager::HandleMiddleClickPaste() dispatch ePaste event by itself r=smaug
This is preparation of the last patch.  Even if no editor is clicked with
middle button, we need to do:
- collapse Selection at the clicked point.
- dispatch "paste" event.

Therefore, HandleMiddleClickPaste() should dispatch ePaste event by itself
and each editor methods should have a bool argument which the caller wants
ePaste event automatically.

Note that Chromium dispatches "paste" event and pastes clipboard content
into clicked editor even if preceding "auxclick" event is consumed.
However, our traditional behavior is not dispatching "paste" event nor
pasting clipboard content.  Unless Chromium developer keeps their odd
behavior, we should keep our traditional behavior since our behavior is
conforming to DOM event model.

Differential Revision: https://phabricator.services.mozilla.com/D7854

--HG--
extra : moz-landing-system : lando
2018-10-10 12:05:39 +00:00
Eitan Isaacson
8102b1e502 Bug 1479037 - Introduce native event support 4/4. r=jchen,yzen?jamie
Depends on D6683

Differential Revision: https://phabricator.services.mozilla.com/D6684

--HG--
extra : moz-landing-system : lando
2018-10-09 17:21:01 +00:00
Eitan Isaacson
f3d88538aa Bug 1479037 - Implement native accessible tree 3/4. r=jchen,yzen
Depends on D6682

Differential Revision: https://phabricator.services.mozilla.com/D6683

--HG--
extra : moz-landing-system : lando
2018-10-09 17:20:53 +00:00
Eitan Isaacson
3d1cc19600 Bug 1479037 - Remove virtual content node, js autofill, and event support 2/4. r=jchen,yzen
Disabled most jsunit tests temporarily in this patch. Will modify and bring them
back up in later patches, as stuff is reimplemented.

Disabled most jsat mochitests. Will have a followup for but reënabling or
porting, depending on the test.

Depends on D6681

Differential Revision: https://phabricator.services.mozilla.com/D6682

--HG--
extra : moz-landing-system : lando
2018-10-09 17:20:46 +00:00
Eitan Isaacson
98a32cc36b Bug 1479037 - Assign a 32bit ID to each accessible, and make them retrievable from root 1/4. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D6681

--HG--
extra : moz-landing-system : lando
2018-10-09 17:20:41 +00:00
Tim Nguyen
6e26790a43 Bug 1416363 - Remove colorpicker binding and related code. r=bgrins,surkov
Depends on D7575

Differential Revision: https://phabricator.services.mozilla.com/D7576

--HG--
extra : moz-landing-system : lando
2018-10-04 01:03:19 +00:00
Narcis Beleuzu
b9b1c8ff17 Merge inbound to mozilla-central. a=merge 2018-10-04 18:48:04 +03:00
Marco Zehe
9998d72afc Bug 1494707 - Add a null check for a retrieved row accessible in HTMLTableAccessible::CellAt, r=surkov
When checking for an accessible if it is a table row instead of a table cell, when retrieving the actual row at the given index, null check it to make sure we don't pass an invalid accessible to the TableAccessible::CellInRowAt method. I accidentally omitted that null check in the updated patch for bug 1486668.

Differential Revision: https://phabricator.services.mozilla.com/D7162

--HG--
extra : moz-landing-system : lando
2018-10-04 06:30:06 +00:00
Alexander Surkov
ff145aa9c4 Bug 1491197 - replace progressmeter XBL binding by a custom element, r=paolo
--HG--
rename : toolkit/content/widgets/progressmeter.xml => toolkit/content/widgets/progressmeter.js
2018-10-03 11:13:05 +05:00
Jim Chen
713d1d9d23 Bug 1492308 - 5. Make various objects use the new disposal mechanism; r=snorp
Make LayerViewSupport, NPZCSupport, GeckoEditableSupport, and
SessionAccessibility use the new disposal mechanism to ensure the
disposal is performed safely.

Differential Revision: https://phabricator.services.mozilla.com/D7110

--HG--
extra : moz-landing-system : lando
2018-10-02 19:59:40 +00:00
Nicholas Nethercote
8478f8d66e Bug 1489047 - Change almost all DOMString occurrences in XPIDL files to AString. r=nika
Because they have almost identical semantics.

--HG--
extra : rebase_source : ea9074bcac2a1d190b88a5d1afc15997593659b7
2018-09-06 18:02:43 +10:00
Ehsan Akhgari
5f0be07390 Bug 1493563 - Part 5: Present the old state and the content blocking log to the web progress listeners; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D6595
2018-09-28 14:46:02 -04:00
Noemi Erli
4419e20e14 Backed out 12 changesets (bug 1493563) for failures in test_css-logic-getCssPath.html CLOSED TREE
Backed out changeset d2e83655082f (bug 1493563)
Backed out changeset 1ce58f004593 (bug 1493563)
Backed out changeset 344298c73ee7 (bug 1493563)
Backed out changeset 02b8b073f7d7 (bug 1493563)
Backed out changeset 3ef707008502 (bug 1493563)
Backed out changeset bb2720a401fe (bug 1493563)
Backed out changeset ce0211be57a1 (bug 1493563)
Backed out changeset 83d6c2bf8dc6 (bug 1493563)
Backed out changeset 1844af4cc25b (bug 1493563)
Backed out changeset c8ab17addb7a (bug 1493563)
Backed out changeset a1ff0cd62563 (bug 1493563)
Backed out changeset 932b41e211e0 (bug 1493563)
2018-09-28 21:31:18 +03:00
Ehsan Akhgari
f0108e78c2 Bug 1493563 - Part 5: Present the old state and the content blocking log to the web progress listeners; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D6595
2018-09-28 13:24:41 -04:00
shindli
a8d55dae12 Merge inbound to mozilla-central. a=merge 2018-09-27 00:52:12 +03:00
arthur.iakab
e1e94e3d20 Merge mozilla-central to autoland 2018-09-26 15:57:12 +03:00
Marco Zehe
aa436fb77a Bug 1486668 - <td> with display: block doesn't get table cell semantics, r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D6158

--HG--
extra : moz-landing-system : lando
2018-09-26 08:47:35 +00:00
Alexander Surkov
afc9faadbe Bug 1463962 - crash near null in [@ mozilla::a11y::DocAccessible::BindToDocument], r=jamie 2018-09-26 12:06:57 +08:00
Tiberius Oros
70e8d3a299 Backed out 11 changesets (bug 1493563) for failures on dom/workers/test/test_sharedworker_event_listener_leaks.html on a CLOSED TREE
Backed out changeset 0bb55b604bfd (bug 1493563)
Backed out changeset 8e25c301675a (bug 1493563)
Backed out changeset 4f608b8801d4 (bug 1493563)
Backed out changeset f58d0b1ca088 (bug 1493563)
Backed out changeset eae105f2bf6d (bug 1493563)
Backed out changeset 7a8a0d1cfd69 (bug 1493563)
Backed out changeset dbba8451aab1 (bug 1493563)
Backed out changeset a6141dbd0328 (bug 1493563)
Backed out changeset f4ca3d8fa90e (bug 1493563)
Backed out changeset 56bab7fae64d (bug 1493563)
Backed out changeset 66787e603401 (bug 1493563)
2018-09-26 06:16:22 +03:00
Ehsan Akhgari
4ced8fedcb Bug 1493563 - Part 5: Present the old state and the content blocking log to the web progress listeners; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D6595
2018-09-25 21:02:51 -04:00
Coroiu Cristina
881a3c5664 Merge inbound to mozilla-central a=merge 2018-09-24 12:48:00 +03:00
James Teh
68c3948d7e Bug 1493403: AccGroupInfo::TotalItemCount: Don't assume a container has children. r=eeejay
The code does check for the case where a container has no children.
However, before it does so, it tries to check whether it needs to skip a text leaf child.
This check previously assumed there was a child to check, which crashed for a container with no children.

Differential Revision: https://phabricator.services.mozilla.com/D6588

--HG--
extra : moz-landing-system : lando
2018-09-24 05:02:13 +00:00
Tiberius Oros
8acb878ef1 Backed out 11 changesets (bug 1493563) for failures on browser_blockingCookies.js on a CLOSED TREE
Backed out changeset d755b96837ac (bug 1493563)
Backed out changeset 651f87dca51f (bug 1493563)
Backed out changeset 68de8f0866d0 (bug 1493563)
Backed out changeset 205d69890f50 (bug 1493563)
Backed out changeset 5f922cd6c21e (bug 1493563)
Backed out changeset 84dc54c1a9c1 (bug 1493563)
Backed out changeset 287666ecdd17 (bug 1493563)
Backed out changeset c64a2ea15b7b (bug 1493563)
Backed out changeset 9085269938cd (bug 1493563)
Backed out changeset de06604fefcb (bug 1493563)
Backed out changeset f9bac5e73bd4 (bug 1493563)
2018-09-25 23:12:03 +03:00
Eitan Isaacson
0206ea9620 Bug 1479034 - Make GeckoView's SessionAccessibility a JNIObject associated with a nsWindow. r=jchen 2018-09-21 16:03:35 -07:00
Chris Peterson
eaa59c7fc4 Bug 1336712 - a11y: Drop test check for OS X 10.6. r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D6577

--HG--
extra : source : 96447888db56e219bbb44f066b08344f50946f77
extra : histedit_source : 7d1234f2564f00bb594f436c1530d6ba60544412
2018-09-13 21:47:36 -07:00
Eitan Isaacson
dc59a7f112 Bug 1489324 - Add 'child-item-count' and 'hierarchical' attributes to collection containers. r=Jamie 2018-09-21 13:02:20 -07:00
Neil Deakin
0a19485e1f Bug 326944, remove nsIComboboxControlFrame interface, r=mats 2018-09-26 10:41:12 -04:00
Neil Deakin
5c44db8004 Bug 328680, remove nsIListControlFrame interface, r=mats 2018-09-26 10:41:01 -04:00
Masatoshi Kimura
c4ef6c371c Bug 1493413 - Suppress warnings from MIDL generated files and re-enable warnings as errors on clang-cl in accessible/ipc/win/. r=aklotz
The compiler is not smart enough to infer that MOZ_RELEASE_ASSERT(false, ...)
will never return. Using MOZ_CRASH instead.

--HG--
extra : rebase_source : 0791f203592b4edf46a517d7945cf720a197d2da
extra : intermediate-source : 44c07680d016d5d72f77c92d968e647dd8d1b6b9
extra : source : 155877282932ab2678069c9d00672191c655e5b1
2018-07-20 19:53:49 +09:00
Alexander Surkov
af50d56f28 Bug 1491742 - UBSan: load of value which is not a valid value for type 'bool' in ImageAccessible.cpp, r=jamie 2018-09-21 13:52:50 +08:00
Nathan Froyd
e7b3b3140d Bug 1415980 - make hash keys movable and not copyable; r=erahm
Everything that goes in a PLDHashtable (and its derivatives, like
nsTHashtable) needs to inherit from PLDHashEntryHdr. But through a lack
of enforcement, copy constructors for these derived classes didn't
explicitly invoke the copy constructor for PLDHashEntryHdr (and the
compiler didn't invoke the copy constructor for us). Instead,
PLDHashTable explicitly copied around the bits that the copy constructor
would have.

The current setup has two problems:

1) Derived classes should be using move construction, not copy
   construction, since anything that's shuffling hash table keys/entries
   around will be using move construction.

2) Derived classes should take responsibility for transferring bits of
   superclass state around, and not rely on something else to handle that.

The second point is not a huge problem for PLDHashTable (PLDHashTable
only has to copy PLDHashEntryHdr's bits in a single place), but future
hash table implementations that might move entries around more
aggressively would have to insert compensation code all over the
place. Additionally, if moving entries is implemented via memcpy (which
is quite common), PLDHashTable copying around bits *again* is
inefficient.

Let's fix all these problems in one go, by:

1) Explicitly declaring the set of constructors that PLDHashEntryHdr
   implements (and does not implement). In particular, the copy
   constructor is deleted, so any derived classes that attempt to make
   themselves copyable will be detected at compile time: the compiler
   will complain that the superclass type is not copyable.

This change on its own will result in many compiler errors, so...

2) Change any derived classes to implement move constructors instead of
   copy constructors. Note that some of these move constructors are,
   strictly speaking, unnecessary, since the relevant classes are moved
   via memcpy in nsTHashtable and its derivatives.
2018-09-20 11:20:36 -04:00
Bogdan Tara
e7c653959c Merge inbound to mozilla-central. a=merge 2018-09-20 00:58:18 +03:00
Narcis Beleuzu
04ab391b65 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-09-19 19:44:24 +03:00
Eitan Isaacson
c712a2aaaa Bug 1490840 - Only delete text in ReplaceText if the string is empty. r=Jamie 2018-09-18 16:16:00 -04:00
Timothy Guan-tin Chien
bfae552010 Bug 1484048 - Part III, Wait for audio source to load before starting a11y tests r=surkov
Appearently with UA Widget the page loads quicker, so the tests must now
explicitly wait for the audio source to load to test on the video controls
UI in its stable state.

Depends on D3840

Differential Revision: https://phabricator.services.mozilla.com/D3841

--HG--
extra : moz-landing-system : lando
2018-09-17 20:49:16 +00:00
Narcis Beleuzu
94e37e71ff Merge inbound to mozilla-central. a=merge 2018-09-19 13:00:20 +03:00
James Teh
1999ca1f89 Bug 1485097: When handling aria-owns relocation and an owned child doesn't yet have an accessible, skip it if the owned child is actually an ancestor of its owner. r=surkov
This can easily be reproduced if the ancestor being owned has role="presentation", but there are other cases as well.
If we don't prevent this, we end up with a loop.

Differential Revision: https://phabricator.services.mozilla.com/D4051

--HG--
extra : moz-landing-system : lando
2018-09-19 02:15:55 +00:00
Ted Mielczarek
de99592416 Bug 1399870 - make DEFFILE a Path instead of a string; r=gps
All but one of the current uses of DEFFILE use `SRCDIR + '/file.def'` to
get a srcdir-relative path anyway, and the other one wants an
objdir-relative path, so using Path makes everything clearer.

This makes it more straightforward to translate the paths for the WSL
build.
2018-09-18 15:50:19 -04:00
Alexander Surkov
ed5f3a33f3 Bug 1491210 - stop using nsIDOMXULLabeledControlElement, r=jamie 2018-09-19 09:06:31 +08:00
Eitan Isaacson
0aa327aaa4 Bug 1491480 - Change class mapping for spinner. r=Jamie
A gecko SPINBUTTON is a composite widget with an input field child. It should not have an EditText class.
2018-09-18 10:43:18 -07:00
Eitan Isaacson
8a0557e2dd Bug 1479033 - Introduce Android accessibility directory. r=Jamie 2018-09-18 10:43:18 -07:00
Eitan Isaacson
76fcb09332 Bug 1491479 - Add event type to ProxyScrollingEvent. r=Jamie 2018-09-18 10:43:18 -07:00
arthur.iakab
d2e647e133 Backed out 10 changesets (bug 1485305)for failing browser chrome tests on browser_loadDisallowInherit.js
Backed out changeset 138b8596a9cd (bug 1485305)
Backed out changeset d9f04aeeeef7 (bug 1485305)
Backed out changeset cd063d8afe4e (bug 1485305)
Backed out changeset 2f8a5a03ccb5 (bug 1485305)
Backed out changeset 8085d1eefd7c (bug 1485305)
Backed out changeset 3aaccb374a59 (bug 1485305)
Backed out changeset 3a111e9e5c9c (bug 1485305)
Backed out changeset 61aa1cfb0b01 (bug 1485305)
Backed out changeset bca973d90acc (bug 1485305)
Backed out changeset 4eb33bf25d6f (bug 1485305)
2018-09-18 20:30:07 +03:00
Jonathan Kingston
038c8e8573 Bug 1485305 - accessible/ Ensure loadURI always passes a triggeringPrincipal() r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D4550

--HG--
extra : source : f33d4832f8a34681bc389792698d880ebe29d542
extra : intermediate-source : 609dab5dcf7b4545252f91213f562cc4d01622bf
2018-08-29 15:39:16 +01:00
Brindusan Cristian
1db0587c0e Backed out 10 changesets (bug 1485305) for browser-chrome failures on docshell/test/browser/browser_loadURI.js. CLOSED TREE
Backed out changeset 50439ec01661 (bug 1485305)
Backed out changeset a05e40ef7215 (bug 1485305)
Backed out changeset c99b97b4348b (bug 1485305)
Backed out changeset 75220b2f6669 (bug 1485305)
Backed out changeset e698f2fc1c1a (bug 1485305)
Backed out changeset acce14683c13 (bug 1485305)
Backed out changeset 323773a395cc (bug 1485305)
Backed out changeset 1b74152cabc1 (bug 1485305)
Backed out changeset 4b5c9d5929fc (bug 1485305)
Backed out changeset 238d92348159 (bug 1485305)
2018-09-19 18:47:27 +03:00
Jonathan Kingston
b81ad8c8ab Bug 1485305 - accessible/ Ensure loadURI always passes a triggeringPrincipal() r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D4550

--HG--
extra : source : 99a052d21ca0a7d7c1c224cfa1c65396e1d43bab
2018-08-29 15:39:16 +01:00
Ciure Andrei
d3c2cc41fe Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-09-18 10:44:51 +03:00
Ehsan Akhgari
5d9d4af0cd Bug 1491574 - Part 2: Remove the XPCOM registration for nsPersistentProperties; r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D5950
2018-09-18 00:58:52 -04:00
Coroiu Cristina
40028657f0 Backed out 3 changesets (bug 1491574) for build bustage at builds/worker/workspace/build/src/netwerk/base/nsNetUtil.cpp on a CLOSED TREE
Backed out changeset 5390b485f7e4 (bug 1491574)
Backed out changeset 3d11b69de826 (bug 1491574)
Backed out changeset e7e8f3f70f8b (bug 1491574)
2018-09-18 07:10:20 +03:00
Ehsan Akhgari
d4f6bad00a Bug 1491574 follow-up: Address more of the review comment 2018-09-17 23:55:01 -04:00
Ehsan Akhgari
9b9060a876 Bug 1491574 - Part 2: Remove the XPCOM registration for nsPersistentProperties; r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D5950
2018-09-17 22:05:34 -04:00
James Teh
6b89ed218b Bug 1331755: Refactor handling of accessibility focus in the URL bar so focus never moves to suggestions while the user is editing. r=Gijs,MarcoZ
When the user is editing the text in the URL bar (typing, backspace, etc.), the first suggestion is always selected.
Because accessibility clients require autocomplete items to be "focused", the code needs to differentiate between explicit selection (e.g. via down/up arrow) and auto selection (e.g. when typing).
Otherwise, the focus continually moves away from the text box while the user is typing, as was previously occurring.
This makes it very difficult for the user to edit text, particularly backspace/delete.

There was a previous attempt to handle this, but it was somewhat fragile and broke completely some time ago.
Now, rather than trying to handle this based on autocomplete events, it is handled in the input and key press events.
For input events, accessibility focus is forced back to the text box and further accessibility focus events are suppressed.
For down arrow, up arrow, etc. key presses, accessibility focus events for suggestions are enabled.
This makes it easier to understand and predict the user experience, rather than relying on underlying autocomplete implementation details.

This is tested using an accessibility browser test, which makes it easier to make assertions about accessibility focus.
This also means that if the underlying implementation details change (e.g. HTML + aria-activedescendant instead of XUL + DOMMenuItemActive events), this test should still be valid and allow us to catch regressions.

Differential Revision: https://phabricator.services.mozilla.com/D5987

--HG--
extra : moz-landing-system : lando
2018-09-18 05:10:35 +00:00
Jonathan Kingston
d67cb9e4a6 Bug 1485305 - accessible/ Ensure loadURI always passes a triggeringPrincipal() r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D4550

--HG--
extra : source : f33d4832f8a34681bc389792698d880ebe29d542
2018-08-29 15:39:16 +01:00
Jonathan Kew
6f42f167fb Bug 1490402 - Use UTF-8 strings (in place of UTF-16) for font family/face names in the system font list, to reduce memory footprint. r=lsalzman 2018-09-12 20:34:57 +01:00
Cosmin Sabou
6294a344fe Merge mozilla-central to mozilla-inbound. a=merge 2018-09-11 13:17:29 +03:00
Cosmin Sabou
c56ce0a961 Bug 1445513 - Disable accessible/tests/browser/tree/browser_aria_owns.js on all platforms for frequent failures. r=jmaher
--HG--
extra : rebase_source : 91f1ecfdbeae97fe8846052e0418758b9aa200d0
2018-09-11 12:29:26 +03:00
Marco Zehe
812e2003df Bug 1489934 - accessible/tests/browser/events/browser_test_docload.js calls waitForEvents incorrectly, r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D5400

--HG--
extra : moz-landing-system : lando
2018-09-10 22:50:31 +00:00
Sylvestre Ledru
aa37bde79b Bug 1489454 - Remove all trailing whitespaces (again) r=Ehsan
This also includes moving some files to the regular format.

Differential Revision: https://phabricator.services.mozilla.com/D5249

--HG--
extra : moz-landing-system : lando
2018-09-07 14:47:51 +00:00
Emma Malysz
696ceb303f Bug 1465219, use XULMenuElement, a subclass of nsXULElement, instead of MenuBoxObject for menu and menulist elements, r=paolo,bz
MozReview-Commit-ID: 5253hAlxbhw

--HG--
rename : dom/webidl/MenuBoxObject.webidl => dom/chrome-webidl/XULMenuElement.webidl
rename : layout/xul/MenuBoxObject.cpp => dom/xul/XULMenuElement.cpp
rename : layout/xul/MenuBoxObject.h => dom/xul/XULMenuElement.h
2018-07-31 12:30:17 -07:00
Tiberius Oros
b830a9d3a5 Merge inbound to mozilla-central. a=merge 2018-09-06 01:25:01 +03:00
Brian Grinstead
40796f9ec0 Bug 1488755 - Replace childNodes with children in test_tabbrowser.xul;r=yzen
For browser.xhtml childNodes includes whitespace nodes, while browser.xul
doesn't. This was done with other mochitests that load the browser window
in Bug 1482667.

Differential Revision: https://phabricator.services.mozilla.com/D5032

--HG--
extra : moz-landing-system : lando
2018-09-05 13:53:21 +00:00
Margareta Eliza Balazs
0a38d82d7b Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-09-05 15:43:59 +03:00
Eliza Balazs
500ab718cc Bug 1421307 - Disable browser_shutdown_acc_reference.js on linux64 debug for frequent failures. r=jmaher 2018-09-05 05:28:00 +03:00
James Teh
5fad83caf4 Bug 1488109: If the focused element has aria-activedescendant and the target id is moved to another node, move accessible focus to the new target. r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D4832

--HG--
extra : moz-landing-system : lando
2018-09-05 04:43:18 +00:00
Masayuki Nakano
56966c4975 Bug 1347040 - Prevent -Woverloaded-virtual of AccessibleWrap.h when __clang__ defined r=Jamie
Some classes of a11y are defined from both IUnknown and nsISupports.  Both of
them have QueryInterface().  So, one of them is overridden by a sub class
hides the other and this is warned by clang.   However, AccessibleWrap.h
prevents this warning since it's by design when the compiler is GCC.
So, it should do same thing when the compiler is clang.

Differential Revision: https://phabricator.services.mozilla.com/D4310

--HG--
extra : moz-landing-system : lando
2018-09-05 04:13:30 +00:00
Mark Banner
c6885f5391 Bug 1488445 - Remove and replace obsolete ESLint rules. r=mossop
This removes a number of references to rules that are now deprecated or removed from ESLint.

- no-native-reassign is replaced with no-global-assign
- no-spaced-func is replaced with func-call-spacing (where enabled)

Depends on D4944

Differential Revision: https://phabricator.services.mozilla.com/D4946

--HG--
extra : moz-landing-system : lando
2018-09-04 18:08:43 +00:00
Zibi Braniecki
096a9c36b0 Bug 1488286 - Use a dummy data: URI as a default URL for accessibility tests. r=mconley
--HG--
extra : rebase_source : e4f39a4c2db74b54ca3c378b87e9b366d555807a
2018-09-03 21:59:56 +01:00
Gijs Kruitbosch
ef7146a4be Bug 1486824 - change BrowserTestUtils to just call OpenBrowserWindow so it does the same thing as opening a window normally, r=mconley,nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D4466

--HG--
extra : rebase_source : e51b66bb18d0e600814b48d5cd3ec9d5dea3028a
extra : source : 96b5a88ac0041a1bd382a731749e1fca9aa911ed
2018-09-03 14:43:38 +01:00
James Teh
fca9213cd0 Bug 1322621: If aria-activedescendant is removed or changed to an invalid id while an element is focused, move accessible focus to the element itself. r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D4732

--HG--
extra : moz-landing-system : lando
2018-08-31 07:00:59 +00:00
Eitan Isaacson
f8996dd01f Bug 1486887 - Use binding parent for input[type] retrieval. r=surkov 2018-08-31 15:11:00 +03:00
Dave Townsend
e63bb1c465 Bug 1487246: Enable the eslint no-sequences rule. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D4681

--HG--
extra : rebase_source : ae253571d7d47c4a113a98a8b7c29bf712a0d764
2018-08-29 16:15:33 -07:00
Dave Townsend
e1f6637191 Bug 1487246: Remove uses of comma sequences in linted code. r=Standard8
Two cases were hiding permanently failing tests. I've commented those out and
filed bug 1487431.

Differential Revision: https://phabricator.services.mozilla.com/D4680

--HG--
extra : rebase_source : 232fa6173de8844a9c47d59926ec8e39d0640ecd
2018-08-29 16:12:55 -07:00
Margareta Eliza Balazs
edc8edfcd7 Merge inbound to mozilla-central. a=merge 2018-08-31 12:23:17 +03:00
Margareta Eliza Balazs
5ddcd7b745 Backed out changeset 96b5a88ac004 (bug 1486824) for causing frequent failures e.g: browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js a=backout 2018-08-31 12:17:27 +03:00
Gurzau Raul
6b4d87cf7c Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-08-31 07:08:44 +03:00
Alexander Surkov
ef0cc6d04c Bug 1487313 - stop using nsIDOMXULLabelElement and nsIDOMXULDescriptionElement in a11y, r=jamie 2018-08-31 09:17:38 +08:00
Gijs Kruitbosch
9d70cb3843 Bug 1486824 - change BrowserTestUtils to just call OpenBrowserWindow so it does the same thing as opening a window normally, r=mconley,nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D4466

--HG--
extra : moz-landing-system : lando
2018-08-30 15:07:36 +00:00
Narcis Beleuzu
1bb581bc8f Merge mozilla-central to inbound.
--HG--
extra : rebase_source : 063f3df7ad6d834fa3e72cd6825c31792716586b
2018-08-30 16:09:37 +03:00
Narcis Beleuzu
a4ec006bb0 Backed out changeset 4e195f7b2d6b (bug 1486824) for clipboard failures on OSX browser_editcontrols_update. a=backout 2018-08-30 15:59:59 +03:00
Gijs Kruitbosch
a8e2b8e702 Bug 1486824 - change BrowserTestUtils to just call OpenBrowserWindow so it does the same thing as opening a window normally, r=mconley,nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D4466

--HG--
extra : moz-landing-system : lando
2018-08-29 17:58:25 +00:00
Paolo Amadini
5aaf848c8b Bug 1457218 - Part 3 - Remove the "menu-button" binding. r=surkov,bgrins
Differential Revision: https://phabricator.services.mozilla.com/D4531

--HG--
extra : rebase_source : 502aa0ff24d0e3d46ef60c7a14498e25c66d1c81
2018-08-29 14:04:25 +01:00
Alexander Surkov
e36505da67 Bug 1486671 - stop using nsIDOMXULCheckboxElement, r=jamie 2018-08-29 15:42:31 +08:00
Paolo Amadini
bfef02108d Bug 1457216 - Remove support for editable menulists. r=surkov,bgrins
Differential Revision: https://phabricator.services.mozilla.com/D4306

--HG--
extra : rebase_source : e8b4946c8f657e2283bc96cb08de802493e3a826
2018-08-24 15:44:38 +01:00
Xidorn Quan
47b25bfcca Bug 1486329 - Fix some clang-cl warnings in accessible. r=eeejay
Specifically this fixes pessimizing-move warnings and some others.

Differential Revision: https://phabricator.services.mozilla.com/D4302

--HG--
extra : moz-landing-system : lando
2018-08-27 15:49:01 +00:00
Eitan Isaacson
dd36aade7d Bug 1485862 - Set correct text-input-type for input[type=number]. r=surkov 2018-08-24 13:34:00 +03:00
Tiberius Oros
2ee9341d01 Merge inbound to mozilla-central. a=merge 2018-08-24 12:43:45 +03:00
James Teh
2a8cad4bfc Bug 1479678: Fix incorrect start offset when retrieving accessible text attributes if the last spelling error is not within this accessible. r=surkov
When dealing with an editor which contains multiple accessibles, the previous spelling error range might be in a previous accessible, not the accessible currently being queried.
In this case, DOMPointToOffset will return the length of this accessible.
Previously, we weren't checking for this and were overriding the start offset of the returned range regardless, resulting in broken offsets.
Now, we leave the start offset alone in this case.

Differential Revision: https://phabricator.services.mozilla.com/D3960

--HG--
extra : moz-landing-system : lando
2018-08-24 03:08:28 +00:00
Kris Maglione
3a5c05e76f Bug 1484496: Part 5e - Convert remaining nsISimpleEnumerator users to use JS iteration. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D3733

--HG--
extra : rebase_source : c0fac176d7b3d840c4dbb14f8d95ccfc7f83a5a8
extra : histedit_source : a92c40117d0808a3ad68c972f622a7a42c9ae8ba
2018-08-18 18:13:14 -07:00
Eitan Isaacson
4cba5259d5 Bug 1484778 - Null-check scroll frame in DispatchScrollingEvent. r=surkov 2018-08-21 10:24:00 -04:00
Eitan Isaacson
57a25953a0 Bug 1483911 - Defer scrolling events until after ipc doc construction. r=Jamie 2018-08-20 15:51:00 +03:00
Joanmarie Diggs
7471d4968b Bug 1484248 - Accessible name calculation from label content should include cells. r=surkov
Change the name calculation rule of HTML 'table' element from eNoNameRule
to eNameFromSubtreeIfReqRule. That way the table won't get an accessible
name, but will be descended when building a name from a parent element's
contents.

--HG--
extra : rebase_source : 218aec9f90b0c420a5f6785e929e5512b6704567
2018-08-17 08:14:00 +03:00
Yura Zenevich
ff402b25e1 Bug 1481924 - use WINDOW_CONTENT_CHANGED instead of WINDOW_STATE_CHANGED when viewport changes to ensure accessible bounds are re-drawn correctly. r=eeejay, jchen
MozReview-Commit-ID: 92bKGZMwJkP
2018-08-17 09:46:55 -04:00
Nicholas Nethercote
36c48819d1 Bug 1451169 - Use nsStaticAtom* instead of nsStaticAtom** in Element.h. r=baku
--HG--
extra : rebase_source : db09f7ab93a1c41ace03a645623f78a27ecfff8c
2018-04-03 13:21:06 +10:00
Nicholas Nethercote
fb0c912a86 Bug 1451169 - Use nsStaticAtom* const instead of nsStaticAtom** in DocAccessible.cpp. r=davidb
--HG--
extra : rebase_source : fb518d946f193c5237fb3fb7e28a8b1f7e3559e3
2018-04-03 22:15:30 +10:00
Nicholas Nethercote
3f02242dff Bug 1451169 - Use nsStaticAtom* instead of nsStaticAtom** in nsAccessibilityService.h. r=davidb
--HG--
extra : rebase_source : 8717ea3053499405afc6cd776ca0133bd8525baa
2018-04-03 11:20:13 +10:00
Nicholas Nethercote
7de7b7aae3 Bug 1451169 - Change nsRoleMapEntry::roleAtom from nsStaticAtom** to nsStaticAtom* const. r=davidb
--HG--
extra : rebase_source : 3a7101328e9ffcb6adeef42c98afa26d0531ca1c
2018-04-03 10:55:33 +10:00
Ehsan Akhgari
59e50ba2d0 Bug 1493563 - Part 5: Present the old state and the content blocking log to the web progress listeners; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D6595
2018-09-25 13:51:47 -04:00
Eitan Isaacson
8d5dad89ed Bug 1479591 - Introduced accessibility scrolling event and interface. r=surkov 2018-08-15 13:07:00 -04:00
Cosmin Sabou
c2b1fcd31c Backed out changeset dad95d849302 (bug 1479591) for causing linux debug leaks and security issues. 2018-08-15 04:39:43 +03:00
Eitan Isaacson
0f281891a2 Bug 1479591 - Introduced accessibility scrolling event and interface. r=surkov 2018-08-14 11:46:00 +03:00
Daniel Varga
9355025fd5 Merge mozilla-central to mozilla-inbound 2018-08-14 01:09:48 +03:00
Ting-Yu Lin
48d02834a5 Bug 1482665 Part 2 - Remove nsPresContext::AppUnitsPerCSSPixel() and replace it with mozilla::AppUnitsPerCSSPixel(). r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D3155
2018-08-13 14:29:28 -07:00
Adrian Wielgosik
be0c1a4f55 Bug 1481645 - Remove some redundant uses of do_QueryInterface. r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D2893

--HG--
extra : moz-landing-system : lando
2018-08-13 09:05:19 +00:00
James Teh
0912c08892 Bug 1480060: Support aria-multiselectable on role tablist. r=MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D3076

--HG--
extra : moz-landing-system : lando
2018-08-13 06:28:35 +00:00
Masayuki Nakano
c0e869978e Bug 1482012 - part 2: Create TextEditor::PasteAsAction() as non-virtual method for outer C++ code r=m_kato
User may paste a lot with pressing Accel+V for a while (i.e., with auto repeat).
So, calling nsIEditor::Paste() may be in a hot path and we can now make
non-virtual public method with AsHTMLEditor().

Differential Revision: https://phabricator.services.mozilla.com/D2993

--HG--
extra : moz-landing-system : lando
2018-08-13 04:37:56 +00:00
Kris Maglione
637cac1ea7 Bug 1481024: Stop relying on lexical variables being available across frame scripts. r=yzen
The accessibility tests currently rely, in many places, on lexical variables
defined in global frame scripts being available to other non-global frame
scripts. While that is currently the case, it will stop being so soon.

And, while the simplest solution would be to define them as properties on the
frame message manager by using `var` rather than `let`, storing references to
the current content window in a frame script scope is unsafe at best, and
should be avoided at all costs.

MozReview-Commit-ID: 4FCGtLgcFzl

--HG--
extra : rebase_source : d21206c9f119ca0ce61f9956f84a2e2d11484bca
2018-08-02 20:19:50 -07:00
Yura Zenevich
e0c82272d3 Bug 1481924 - added GevkoView accessibility tests for scrolling. r=eeejay, jchen
MozReview-Commit-ID: ATGNFruDGAI
2018-08-10 13:13:35 -04:00
Yura Zenevich
2b1f8c8ae8 Bug 1481922 - add support for select action and view selected event. r=eeejay, jchen
MozReview-Commit-ID: FaLz7majPhz
2018-08-10 13:13:27 -04:00
Eitan Isaacson
704a28b360 Bug 1478727 - Move IDSet out of windows to base for Android use. r=jteh
--HG--
rename : accessible/windows/msaa/IDSet.h => accessible/base/IDSet.h
2018-08-09 14:56:00 +03:00
Eitan Isaacson
4561e8e337 Bug 1479036 - Android classes role additions. r=surkov
--HG--
extra : rebase_source : a3612efad26d164c33e7724079722c3163b5cf71
2018-08-09 14:43:00 +03:00
Gabriele Svelto
15adf94f4d Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov
This introduces the machinery needed to generate crash annotations from a YAML
file. The relevant C++ functions are updated to take a typed enum. JavaScript
calls are unaffected but they will throw if the string argument does not
correspond to one of the known entries in the C++ enum. The existing whitelists
and blacklists of annotations are also generated from the YAML file and all
duplicate code related to them has been consolidated. Once written out to the
.extra file the annotations are converted in string form and are no different
than the existing ones.

All existing annotations have been included in the list (and some obsolete ones
have been removed) and all call sites have been updated including tests where
appropriate.

--HG--
extra : source : 4f6c43f2830701ec5552e08e3f1b06fe6d045860
2018-07-05 15:42:11 +02:00
Jonathan Kingston
2f0987a202 Bug 1362034 - Tests for addTab() to provide the correct triggering principal. r=ckerschb r?=gijs
Summary: Depends on D2046

Reviewers: ckerschb!, Gijs!

Tags: #secure-revision

Bug #: 1362034

Differential Revision: https://phabricator.services.mozilla.com/D2047

--HG--
extra : source : 33884d05cc94463950b31fab1fd2f37ada9becef
extra : intermediate-source : 72471adb75d5ec3dc2b0c8f972a6f1f26bfd3ae2
extra : histedit_source : f384cbab58401575afc3443c9a431b73cff806d4
2018-07-06 21:16:29 +01:00
Mike Hommey
6d197a0707 Bug 1481719 - Disable profile-instr-out-of-date warnings explicitly rather than allowing all warnings where they appear. r=dmajor 2018-08-09 06:07:33 +09:00
dvarga
12f19b94e9 Backed out 2 changesets (bug 1362034) for failure at browser/tools/mozscreenshots/primaryUI/browser_primaryUI.js on a CLOSED TREE
Backed out changeset 1c3329958b8a (bug 1362034)
Backed out changeset f68b1b76af36 (bug 1362034)

--HG--
extra : histedit_source : 6169c5ffe856266d3bc8b2ca32f4b67054c71bbe
2018-08-08 22:11:56 +03:00
Jonathan Kingston
c15f69d427 Bug 1362034 - Tests for addTab() to provide the correct triggering principal. r=ckerschb,Gijs
Summary: Depends on D2046

Reviewers: ckerschb, Gijs

Reviewed By: ckerschb, Gijs

Bug #: 1362034

Differential Revision: https://phabricator.services.mozilla.com/D2047

--HG--
extra : rebase_source : ccded0f06a0dc4567b827f42ee29f4b8954154fe
extra : amend_source : 94da8ecc053e56958fa4137d7e497362fa2c11f1
2018-08-08 20:05:30 +03:00
James Teh
5a83999558 Bug 1480058 part 3: Support accessible selection retrieval methods for XUL tabs with aria-multiselectable. r=surkov
The XULSelectControlAccessible selection methods don't handle ARIA selection.
Therefore, if aria-multiselectable is set, use the base implementation of the selection retrieval methods.
We don't bother overriding the selection setting methods because implementations (e.g. browser tabs) don't support setting of aria-selected by the a11y engine and we still want to be able to set the primary selected item according to XUL.
Being able to retrieve multiple selection programmatically is far more important than being able to set it.

MozReview-Commit-ID: CmVp9KyieMY

--HG--
extra : rebase_source : e3fa93aad4726b322956babb5422dceebfa0fbb2
2018-08-03 13:31:43 +10:00
James Teh
46ba6df249 Bug 1480058 part 2: Add nsAccUtils::IsARIAMultiSelectable and make nsAccUtils::ISARIASelected const. r=surkov
We need to be able to call these methods from const methods, so they must take a const Accessible*.

MozReview-Commit-ID: CDsWZG1ik31

--HG--
extra : rebase_source : 4721669afcd9101cb017361bd8f87fb8a860664a
2018-08-02 16:27:18 +10:00
James Teh
6647aa6cc0 Bug 1480058 part 1: Expose states for aria-selected/aria-multiselectable on XUL tab/tabs. r=surkov
MozReview-Commit-ID: JeV5vBffQIq

--HG--
extra : rebase_source : 3e6979e1e1995e62951250937d0c28f1128dcbac
2018-08-02 16:25:09 +10:00
Andreea Pavel
f5c1119983 Backed out 2 changesets (bug 1362034) for failing damp | inspector/cold-open.js on a CLOSED TREE
Backed out changeset 8c8925b75aa2 (bug 1362034)
Backed out changeset ff6b05c96094 (bug 1362034)
2018-08-06 20:42:44 +03:00
Jonathan Kingston
4ca581ffed Bug 1362034 - Tests for addTab() to provide the correct triggering principal. r=ckerschb,Gijs
Summary: Depends on D2046

Reviewers: ckerschb, Gijs

Reviewed By: ckerschb, Gijs

Bug #: 1362034

Differential Revision: https://phabricator.services.mozilla.com/D2047

--HG--
extra : rebase_source : 4bb9e7feb0704239756e6e38623c0fea81669f7b
extra : amend_source : 9417f96547735fbdc55ea23666327a5cb86ac92f
2018-08-06 19:56:37 +03:00
Tokio Kajitsuka
0b25579f2d Bug 1480971 - add AccessibleNode::mRelationProperties to NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE r=surkov
change the type of AccessibleNode::mRelationProperties to nsRefPtrHashtable and add it to NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE
2018-08-04 19:47:50 +09:00
Masatoshi Kimura
3b21b7868b Bug 1090497 - Re-enable warnings as errors on clang-cl. r=froydnj
--HG--
extra : rebase_source : c09366fb93e5b0f72abe1e99d3094e3d96a934fb
extra : intermediate-source : 5950c9d63c3b4fd63a25464a7b50944aaec7079f
extra : source : ca1b9a2bcc4381795f556fea2fb59066567c30f3
2018-07-31 22:10:07 +09:00
Boris Zbarsky
d4993da381 Bug 1476142 part 4. Remove some unnecessary QIs on window in various parts of the tree. r=kmag
The crashtest was not testing anything useful, because getInterface is no longer exposed to web content.
2018-08-02 15:26:48 -04:00
Brian Hackett
05a7f56ce7 Bug 1479585 - Use replayable IDs in PDocAccessible IPC, r=davidb.
--HG--
extra : rebase_source : 40e1b80174483e5bce3a76f5a82c5b4951a38e63
2018-08-02 17:30:17 +00:00
Cosmin Sabou
de8c2bd891 Backed out changeset 5950c9d63c3b (bug 1090497) for build bustages on several files. CLOSED TREE 2018-08-02 19:59:53 +03:00
Masatoshi Kimura
feea19030c Bug 1090497 - Re-enable warnings as errors on clang-cl. r=froydnj
--HG--
extra : rebase_source : a62521fdc66def4e4d5d7bf52e68365a786b5c55
extra : source : ca1b9a2bcc4381795f556fea2fb59066567c30f3
2018-07-31 22:10:07 +09:00
Boris Zbarsky
754087a992 Bug 1446940 part 5. Stop getting docshells from windows via getInterface in dom/editor/etc code. r=kmag 2018-08-01 13:07:11 -04:00
Nika Layzell
4d1911e395 Bug 1474369 - Part 3: Add generic type parsing support to xpidl, r=mccr8
Summary:
This patch allows parsing generic types, such as Sequence<T>, in XPIDL. It does
this by introducing a new type, TypeId, which contains both the name string and
an optional list of generic parameters.

Various places which use the xpidl.py library had to be updated to construct one
of these TypeId objects, as TypeId and `str` are not compatible types.

Depends On D2106

Reviewers: mccr8!

Tags: #secure-revision

Bug #: 1474369

Differential Revision: https://phabricator.services.mozilla.com/D2109
2018-07-31 17:53:00 -04:00
shindli
f0d8729e09 Merge inbound to mozilla-central. a=merge 2018-07-31 12:50:32 +03:00
James Teh
d585de6620 Bug 1479642: Make Windows XULMenuitemAccessibleWrap::Name const so it overrides AccessibleWrap::Name. r=surkov
This again exposes the accelerator (e.g. Ctrl+T for New Tab) for menu items via IAccessible::accName on windows.

Bug 1438193 made Accessible::Name const.
On Windows, XULMenuitemAccessibleWrap::Name is overridden to append the accelerator to the name.
Unfortunately, this override was missed when converting Name to const (and wasn't a compile error because it didn't use the override keyword).
As such, this override stopped being called; we always called the const version, since that's the one inherited into AccessibleWrap.
Making this const causes this override to be called.

MozReview-Commit-ID: 7Gb199mzhHa

--HG--
extra : rebase_source : 41d15042a09e4743d127fb12378c775099aa09a0
2018-07-31 11:22:59 +10:00
James Teh
2a45f8f49d Bug 903187: Map HTML ins/del to accessible roles. r=MarcoZ
IA2 now has IA2_ROLE_CONTENT_INSERTION/DELETION.
Mac has AXInsert/DeleteStyleGroup subroles.
We now create accessibles for these elements and expose the appropriate role.
For ATK, there is no specific role for these, so we just use the generic ATK_ROLE_SECTION.

MozReview-Commit-ID: 2khzRa7BQ6z

--HG--
extra : rebase_source : e1c84bdef9a23b225e9870660050790df94c4beb
2018-07-27 16:40:50 +10:00
Kris Maglione
031076f2f3 Bug 1463291: Move docShell getter from Document to Window. r=bz
DocShells are associated with outer DOM Windows, rather than Documents, so
having the getter on the document is a bit odd to begin with. But it's also
considerably less convenient, since most of the times when we want a docShell
from JS, we're dealing most directly with a window, and have to detour through
the document to get it.

MozReview-Commit-ID: LUj1H9nG3QL

--HG--
extra : source : fcfb99baa0f0fb60a7c420a712c6ae7c72576871
extra : histedit_source : 5be9b7b29a52a4b8376ee0bdfc5c08b12e3c775a
2018-05-21 16:58:23 -07:00
Kris Maglione
02ba563399 Bug 1463016: Part 5 - Add domWindow property to DocShellTreeItem and update callers to use it. r=nika
MozReview-Commit-ID: FRRAdxLHRtG

--HG--
extra : source : 0d69b4fb1ed43751cfcbc0b4f2fe3b6a49bc0494
extra : histedit_source : d0ce31513ffaae2fd7f01f6567a97b6d2d96b797%2Cfff837de7a00fa90809d2c3e755097180dfd56d8
2018-05-20 18:10:16 -07:00
Narcis Beleuzu
561ccb2ceb Backed out 2 changesets (bug 1463016, bug 1463291) for geckoview failures
Backed out changeset fcfb99baa0f0 (bug 1463291)
Backed out changeset 0d69b4fb1ed4 (bug 1463016)
2018-07-29 03:55:23 +03:00
Kris Maglione
cb1ee1e34d Bug 1463291: Move docShell getter from Document to Window. r=bz
DocShells are associated with outer DOM Windows, rather than Documents, so
having the getter on the document is a bit odd to begin with. But it's also
considerably less convenient, since most of the times when we want a docShell
from JS, we're dealing most directly with a window, and have to detour through
the document to get it.

MozReview-Commit-ID: LUj1H9nG3QL

--HG--
extra : rebase_source : a13c59d1a5ed000187c7fd8e7339408ad6e2dee6
2018-05-21 16:58:23 -07:00
Kris Maglione
636f1839e5 Bug 1463016: Part 5 - Add domWindow property to DocShellTreeItem and update callers to use it. r=nika
MozReview-Commit-ID: FRRAdxLHRtG

--HG--
extra : rebase_source : 36565ef5e74360aad14062005e5bdab2939e888b
2018-05-20 18:10:16 -07:00
Eitan Isaacson
329ee2b3cc Bug 1477002 - Use message broadcaster to manage jsat content scripts. r=yzen
This patch does several things:
 1. When "domwindowopened" is dispatched it often doesn't have a
document yet, so we need to wait for it to load before determining if we
should attach it.
 2. Instead of managing individual message managers use a broadcaster
and load delayed scripts. This makes new window additions more robust.
 3. A content script now doesn't need a ready/start message but
initializes in-line. This added more complexity which we don't need. All
the info that we passed to it in AccessFu:Start can be gotten in other
ways (also, Services.appinfo.ID now works in child processes, so no need
for that).
 4. Tweaked the tests to support inline frame script initilization.
 5. Removed the scroll callback from content-script.js that was not used
anymore.
2018-07-27 15:19:00 +03:00
Tokio Kajitsuka
a7d855f037 Bug 1468110 - add AccessibleNode relation attributes, r=yzen, qdot
based on ARIA and AOM's ARIA reflection specs (https://wicg.github.io/aom/spec/aria-reflection.html)
2018-07-17 08:37:37 +09:00
James Teh
303c6c89cf Bug 1478568 part 2: Map BLOCKQUOTE role to IA2_ROLE_BLOCK_QUOTE. r=MarcoZ
MozReview-Commit-ID: KxGnO0R1dRJ

--HG--
extra : rebase_source : e09c1a1846b402ba0498773f44be255468154ce6
2018-07-27 10:30:25 +10:00
Brian Grinstead
6a6ca1a08c Bug 1475342 - Move document.getElementsByAttribute[NS] to ParentNode so it'll work for HTML document and elements;r=bz
It's currently only accessible on XULDocument and XULElement, but that makes porting existing
JS to run in an HTML document inconvenient. We could alternatively change calling JS, but
this can be easily moved and exposed in chrome contexts.

MozReview-Commit-ID: JitYET20NSE

--HG--
extra : rebase_source : 75d823c688cba8d84dc19705e83284be383962f2
2018-07-26 13:40:13 -07:00
Mark Banner
15c57e5bee Bug 1478308 - Remove unnecessary ChromeUtils.imports in accessible/ r=surkov
MozReview-Commit-ID: 2l6rvxykrWB

--HG--
extra : rebase_source : c62d614acda9ed1a77c3893ee91c493f1fbbaeec
2018-07-25 11:07:07 +01:00
Narcis Beleuzu
d47c829065 Backed out 4 changesets (bug 1478308) for ESlint failure on AttributionCode.jsm. CLOSED TREE
Backed out changeset a809b45ff49b (bug 1478308)
Backed out changeset c68131530742 (bug 1478308)
Backed out changeset 0e4ba7a6dc1a (bug 1478308)
Backed out changeset 32a27f317a77 (bug 1478308)
2018-07-26 11:13:28 +03:00
Mark Banner
58e5c3e98f Bug 1478308 - Remove unnecessary ChromeUtils.imports in accessible/ r=surkov
MozReview-Commit-ID: 2l6rvxykrWB

--HG--
extra : rebase_source : 9bfe49a329b0ef38e45b5886070e2c1af1edecbe
2018-07-25 11:07:07 +01:00
Boris Zbarsky
922bc3548a Bug 1476145 part 2. Stop using getInterface(nsIDOMWindowUtils) in accessible/. r=kmag 2018-07-24 19:47:40 -04:00
Narcis Beleuzu
80c1cde899 Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-07-25 01:22:42 +03:00
Brian Grinstead
96dc530924 Bug 1476333 - Refer to AppConstants.BROWSER_CHROME_URL to get the browser URL from the frontend;r=Gijs
Before this change, we accessed the browser URL in the following ways:

- "chrome://browser/content/browser.xul"
- "chrome://browser/content/" (which redirects to chrome://browser/content/browser.xul)
- Services.prefs.getCharPref("browser.chromeURL") which returns "chrome://browser/content/"
- getBrowserURL() from utilityOverlay.js

MozReview-Commit-ID: I5vtRke1x9t

--HG--
extra : rebase_source : c525350a1954740873e85b045cbb14a8b43aa89d
2018-07-24 08:12:50 -07:00