The only remotely clever bit here is the macro that generates calls to VMFunctionDataHelper. By making valuesToPop a variadic argument, we will either generate `PopValues()` (if there is no third argument) or `PopValues(N)` (if the third argument is N).
Depends on D182433
Differential Revision: https://phabricator.services.mozilla.com/D182434
This is no longer an action but a custom method on Preview/index.js.
Also fix the missing clearPreview method passed manually from Popup to ExceptionPopup.
Differential Revision: https://phabricator.services.mozilla.com/D182408
This patch does two things:
1. It makes it so that a corrupt database doesn't result in several retries to
requery the database, as it's extremely unlikely that a corrupt database is
going to somehow get repaired in the interim.
2. It makes it so that if any Chrome-based browser resource fails to be acquired
properly, it still allows other resources from the same (and other!) profiles
to be imported.
Differential Revision: https://phabricator.services.mozilla.com/D182737
This allows to fall back to the autodetection of the SDK from the host
on mac machines. While not ideal, it's better than the status quo where
when Apple removes the SDK from its servers, configure plain fails.
Differential Revision: https://phabricator.services.mozilla.com/D182685
The goal of this change is to detect content-initiated file URI loads
earlier such that crash stacks give us a better idea of what is
responsible for starting these loads.
These assertions explicitly only fire for system-principal triggered
loads of file URIs, as those should never be happening from within a web
content process.
Differential Revision: https://phabricator.services.mozilla.com/D182223
Use `setStoredLoginsAsync`, which will clear logins leftovers.
Also as a drive by: use `add_task` and co, remove the use of `gTestDependsOnDeprecatedLogin`.
Differential Revision: https://phabricator.services.mozilla.com/D182714
In a previous change to this logic, we missed a hidden early return in
the `MMAP_FAULT_HANDLER_CATCH()` macro which can early return on both
Linux and Windows. If this is hit, we could end up blocking at various
points waiting for the StartupCache to be prefetched.
This patch changes the logic to notify to happen in a ScopeExit instead,
ensuring that it'll happen on all return paths.
In addition, there was another potential deadlock due to the
ThreadedPrefetch thread acquiring mTableLock. This was fixed by passing
in the pointers in the runnable instead. This should be OK as we are
making sure to block on ThreadedPrefetch before we clear the startup
data already.
Differential Revision: https://phabricator.services.mozilla.com/D182732
In a previous change to this logic, we missed a hidden early return in
the `MMAP_FAULT_HANDLER_CATCH()` macro which can early return on both
Linux and Windows. If this is hit, we could end up blocking at various
points waiting for the StartupCache to be prefetched.
This patch changes the logic to notify to happen in a ScopeExit instead,
ensuring that it'll happen on all return paths.
In addition, there was another potential deadlock due to the
ThreadedPrefetch thread acquiring mTableLock. This was fixed by passing
in the pointers in the runnable instead. This should be OK as we are
making sure to block on ThreadedPrefetch before we clear the startup
data already.
Differential Revision: https://phabricator.services.mozilla.com/D182732
Firefox 115 is the last version to support macOS versions < 10.15 (bug 1836375). Firefox (like Safari and Chrome) already caps the UA string's macOS version at 10.15 to avoid webcompat breakage from sites not expecting macOS versions >= 11.0 (bug 1679929).
Since the UA string's macOS version will no longer be < 10.15 or > 10.15, we can now hard code the UA string's macOS version as 10.15.
Differential Revision: https://phabricator.services.mozilla.com/D182585
Also avoid unecessary other re-renders by tweaking props between index.js and breakpoint.js.
And get rid of the new function reference (checkSourceOnIgnoreList) causing a re-render for all state changes.
Differential Revision: https://phabricator.services.mozilla.com/D181620
This changeset, combined with the previous removes the last usages of the "menus" modules
which have been forked into the context-menus actions.
Also fix a bug in blackboxing where CodeMirror wasn't correctly showing blackboxed lines.
It wasn't showing the last blackboxed line as blackboxed.
When blackboxing only one line... it wasn't showing the line as blackboxed.
Differential Revision: https://phabricator.services.mozilla.com/D181618
