Commit Graph

665923 Commits

Author SHA1 Message Date
Markus Stange
dac6adef26 Bug 1491442 - Fold DoWidgetCleanup and DetachWidget into Compositor::Destroy. r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D40867

--HG--
extra : moz-landing-system : lando
2019-08-16 01:09:48 +00:00
Markus Stange
62430de27f Bug 1491442 - Add CompositorWidget::DoCompositorCleanup() to give the widget a chance to clean up any state from PreRender/PostRender on the correct thread. r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D40514

--HG--
extra : moz-landing-system : lando
2019-08-16 01:09:26 +00:00
Markus Stange
327b689a51 Bug 1491442 - Make reftest readback read from the current render target. r=mattwoodrow
This removes the assumption that there is a default framebuffer to read from,
in order to prepare for a world in which all rendering goes into non-default
framebuffers.
The current render target's framebuffer is already bound when this function is
called.

Differential Revision: https://phabricator.services.mozilla.com/D40513

--HG--
extra : moz-landing-system : lando
2019-08-16 01:09:03 +00:00
Makoto Kato
3bf7ba667c Bug 1574077 - Add credui.dll to delayload DLL. r=dmajor
Bug 1498518 adds credui.dll to use OS's authenticate dialog for WebAuth support, but this isn't required at start up etc. So we should move this to delay load DLL list.

Differential Revision: https://phabricator.services.mozilla.com/D42079

--HG--
extra : moz-landing-system : lando
2019-08-15 18:47:45 +00:00
Maliha Islam
29a67174de Bug 1568053 - Redesign contrast info in color picker (front-end), r=yzen,gl
Differential Revision: https://phabricator.services.mozilla.com/D40925

--HG--
extra : moz-landing-system : lando
2019-08-16 00:55:27 +00:00
Maliha Islam
0a8eb5c95e Bug 1568053 - Create node actor method for getting complex bg color data for text nodes and refactor existing contrast calculation methods, r=yzen,gl
Differential Revision: https://phabricator.services.mozilla.com/D40086

--HG--
extra : moz-landing-system : lando
2019-08-16 00:55:26 +00:00
Logan Smyth
6dc3f59caa Bug 1541631 - Part 8: Store breakable-line and breakpoint-position data in the source-actor store. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D42033

--HG--
extra : moz-landing-system : lando
2019-08-15 21:44:48 +00:00
Logan Smyth
f8d117facf Bug 1541631 - Part 7: Convert memoizeableAction to be AsyncValue-based for easy interop. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D42032

--HG--
extra : moz-landing-system : lando
2019-08-15 21:45:47 +00:00
Logan Smyth
bab62aad61 Bug 1541631 - Part 6: Remove unused action return values. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D42031

--HG--
extra : moz-landing-system : lando
2019-08-15 21:45:48 +00:00
Logan Smyth
463cc14e60 Bug 1541631 - Part 5: Remove exitEarly option from memoizableAction since it isn't needed. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D42030

--HG--
extra : moz-landing-system : lando
2019-08-15 21:45:50 +00:00
Logan Smyth
98281d7b19 Bug 1541631 - Part 4: Use resource utility for SourceWithContent caching. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D42029

--HG--
extra : moz-landing-system : lando
2019-08-15 21:45:52 +00:00
Logan Smyth
058e9d445b Bug 1541631 - Part 3: Merge 'content' onto the source itself and rely on query caching. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D42028

--HG--
extra : moz-landing-system : lando
2019-08-16 00:25:56 +00:00
Logan Smyth
0d284b2f54 Bug 1541631 - Part 2: Convert Source to be a generic minimal Source interface. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D42027

--HG--
extra : moz-landing-system : lando
2019-08-15 21:44:45 +00:00
Logan Smyth
ec00db2167 Bug 1541631 - Part 1: Rename mock threadFront file to better name since it isn't a Front. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D42025

--HG--
rename : devtools/client/debugger/src/actions/tests/helpers/threadFront.js => devtools/client/debugger/src/actions/tests/helpers/mockCommandClient.js
extra : moz-landing-system : lando
2019-08-15 21:44:47 +00:00
Nathan Froyd
f21661fdf8 Bug 1571759 - add nsTArray::EmplaceBack; r=erahm
Much preferred to `AppendElement(T(...))`.

Differential Revision: https://phabricator.services.mozilla.com/D42024

--HG--
extra : moz-landing-system : lando
2019-08-16 00:18:57 +00:00
Tim Nguyen
7234393e73 Bug 1572475 - Make the about:logins sidebar have a fixed width. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D42228

--HG--
extra : moz-landing-system : lando
2019-08-15 22:57:37 +00:00
Imanol Fernandez
efb7b0fed5 Bug 1574218 - Fix broken VRManagerChild::NotifyPresentationGenerationChanged event. r=kip
Fix broken VRManagerChild::NotifyPresentationGenerationChanged event.

Differential Revision: https://phabricator.services.mozilla.com/D42164

--HG--
extra : moz-landing-system : lando
2019-08-15 23:18:41 +00:00
Nicholas Nethercote
b634df9005 Bug 1573720 - Convert dom.storage.default.quota to a static pref. r=mccr8
This one was VarCached to two different variables in two different modules.

Differential Revision: https://phabricator.services.mozilla.com/D41920

--HG--
extra : moz-landing-system : lando
2019-08-15 05:31:38 +00:00
Nicholas Nethercote
048727ff15 Bug 1573720 - Convert canvas.image.cache.limit to a static pref. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D41919

--HG--
extra : moz-landing-system : lando
2019-08-15 05:31:24 +00:00
Nicholas Nethercote
e3f4932e1c Bug 1573720 - Convert dom.mapped_arraybuffer.enabled to a static pref. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D41918

--HG--
extra : moz-landing-system : lando
2019-08-15 05:31:10 +00:00
Nicholas Nethercote
735faa5294 Bug 1573720 - Convert intl.charset.fallback.tld to a static pref. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D41917

--HG--
extra : moz-landing-system : lando
2019-08-15 05:30:56 +00:00
Nicholas Nethercote
14e8c9129a Bug 1573720 - Convert layers.force-active to a static pref. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D41916

--HG--
extra : moz-landing-system : lando
2019-08-15 05:30:37 +00:00
Markus Stange
54166343c6 Bug 1573668 - Add MacIOSurface::GetAsDrawTargetLocked. r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D41844

--HG--
extra : moz-landing-system : lando
2019-08-15 04:54:57 +00:00
Markus Stange
352f3971ce Bug 1573668 - Teach MacIOSurface about the kCVPixelFormatType_32BGRA pixel format. r=mattwoodrow
Depends on D41843

Differential Revision: https://phabricator.services.mozilla.com/D41971

--HG--
extra : moz-landing-system : lando
2019-08-15 03:33:58 +00:00
Markus Stange
0d99ec9a50 Bug 1573668 - Use CFTypeRefPtr for managing the IOSurfaceRef in MacIOSurface. r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D41843

--HG--
extra : moz-landing-system : lando
2019-08-14 14:53:45 +00:00
Markus Stange
c31b8d8a28 Bug 1573668 - Use the real IOSurfaceRef type in MacIOSurface. r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D41841

--HG--
extra : moz-landing-system : lando
2019-08-14 14:50:25 +00:00
Oana Pop Rus
cc55a912e9 Backed out changeset 6d823f106e69 (bug 1533057) for Android mochitest failure in AndroidAlerts.cpp on a CLOSED TREE 2019-08-16 02:28:42 +03:00
Micah Tigley
6de8405695 Bug 1573837 - Add utm_* params to the "View full report on Firefox Monitor" link. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D42144

--HG--
extra : moz-landing-system : lando
2019-08-15 22:57:09 +00:00
Markus Stange
cd5788b20f Bug 1545262 - Update BasicCompositor's mFullWindowRenderTarget before we capture the screenshot for the current frame. r=mattwoodrow
In the past, mFullWindowRenderTarget was updated in EndFrame, so the captured
screenshots (which were captured before EndFrame) were always one frame behind.
This affected both profiler screenshots and window recording screenshots.

This also fixes a bug with the destination offset in the call to
mFullWindowRenderTarget->mDrawTarget->CopySurface(): In the case where mTarget
was non-null, those calls would use mTargetBounds.TopLeft() as the destination
offset, which is very much unrelated to anything in mFullWindowRenderTarget.
Now the destination offset for mFullWindowRenderTarget is always zero -
mFullWindowRenderTarget->mDrawTarget's device space is the same as window space.

This patch also moves the creation of mFullWindowRenderTarget down to where we
have mRenderTarget->mDrawTarget, so that we can create a DrawTarget of a type
that can efficiently copy from mRenderTarget->mDrawTarget. I think this is
important on Windows where mRenderTarget->mDrawTarget will be the Cairo/pixman
re-wrapped DrawTarget and mDrawTarget is some kind of Windows/GDI DrawTarget.

Depends on D41612

Differential Revision: https://phabricator.services.mozilla.com/D41613

--HG--
extra : moz-landing-system : lando
2019-08-14 06:34:24 +00:00
Markus Stange
ff3fb7eef1 Bug 1545262 - Stop clearing mFullWindowRenderTarget. r=mattwoodrow
These areas only need to be cleared in rt->mDrawTarget. Once the invalid area gets
copied over to mFullWindowRenderTarget, any cleared pixels will be copied over and
clear those pixels in mFullWindowRenderTarget.
This clear wasn't only necessary, it also sometimes cleared to much, because the
clip to the invalid region that the caller sets does not apply to this DrawTarget.

Differential Revision: https://phabricator.services.mozilla.com/D41612

--HG--
extra : moz-landing-system : lando
2019-08-14 01:18:07 +00:00
Emilio Cobos Álvarez
d8298290d7 Bug 1574101 - Use the right parent frame for block ruby if it's out of flow. r=mats
I should've caught this when reviewing, in fairness.

Differential Revision: https://phabricator.services.mozilla.com/D42163

--HG--
extra : moz-landing-system : lando
2019-08-15 22:21:35 +00:00
Markus Stange
dfad7a59cc Bug 1567319 - Discard payloads for no-op composites. r=bas
Differential Revision: https://phabricator.services.mozilla.com/D40569

--HG--
extra : moz-landing-system : lando
2019-08-15 17:54:17 +00:00
Tim Nguyen
a938574c60 Bug 1573132 - Prevent long titles from shrinking login-item favicon. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D42216

--HG--
extra : moz-landing-system : lando
2019-08-15 22:17:01 +00:00
Tim Nguyen
d0b9568ea8 Bug 1573159 - Only call scrollIntoView() on login-list item if it isn't in view. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D41886

--HG--
extra : moz-landing-system : lando
2019-08-15 21:27:42 +00:00
Daniel Holbert
0a772dbcbb Bug 1574310: clang-reformat the layout directory. (no review, just doing automated reformatting)
This patch is auto-generated by the following command:
./mach clang-format -p layout/

Differential Revision: https://phabricator.services.mozilla.com/D42218

--HG--
extra : moz-landing-system : lando
2019-08-15 22:13:49 +00:00
Ehsan Akhgari
ad211ea815 Bug 1574019 follow-up: Actually fix the ESLint error CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com//D42215

--HG--
extra : amend_source : e6e36dd258d246b0327110300407b279edf74020
2019-08-16 01:07:36 +03:00
Noemi Erli
7244716bb5 Backed out changeset 4d8eb840fc2e (bug 1574101) so it can reland without unrelated reformatting changes r=dholbert CLOSED TREE 2019-08-16 01:00:14 +03:00
Kris Maglione
c28dd3bf97 Bug 1574071: Handle DocAddSizeOf after unlink. r=mccr8
Under some odd circumstances, the devtools heap snapshot code tries to record
a Document after the cycle collector has unlinked it, which leads to a crash
when trying to add the size of the (now null) CSS loader.

Differential Revision: https://phabricator.services.mozilla.com/D42176

--HG--
extra : moz-landing-system : lando
2019-08-15 21:43:55 +00:00
Timothy Nikkel
de5bd6d66a Bug 1438996. Don't construct a unneeded temporary range object in RangeUtils::CompareNodeToRange. r=masayuki
nsContentUtils::ComparePoints just immediately deconstructs the range boundary into container and offset and calls a version of nsContentUtils::ComparePoints that takes containers/offsets instead of range boundaries.

This also avoids a warning in the RangeBoundary constructor.

Differential Revision: https://phabricator.services.mozilla.com/D42071

--HG--
extra : moz-landing-system : lando
2019-08-15 21:13:54 +00:00
Kris Maglione
560795ea18 Bug 1574221: Hack around tests that sometimes try to snapshot 0 width/height rects. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D42166

--HG--
extra : moz-landing-system : lando
2019-08-15 21:34:29 +00:00
Ehsan Akhgari
7365fc4214 Bug 1574019 follow-up: Fix the ESLint error
Differential Revision: https://phabricator.services.mozilla.com/D42211

--HG--
extra : moz-landing-system : lando
2019-08-15 21:33:40 +00:00
Noemi Erli
5759dc0940 Backed out 8 changesets (bug 1541631) for permafailing in debugger/cold-open.js CLOSED TREE
Backed out changeset bc99fb7a9d12 (bug 1541631)
Backed out changeset 696e24030686 (bug 1541631)
Backed out changeset 6db731f26958 (bug 1541631)
Backed out changeset 9f928da98d32 (bug 1541631)
Backed out changeset 53b83b8e37e0 (bug 1541631)
Backed out changeset 1d7a76a1fac8 (bug 1541631)
Backed out changeset 4f94c700f977 (bug 1541631)
Backed out changeset 41f6c078e950 (bug 1541631)

--HG--
rename : devtools/client/debugger/src/actions/tests/helpers/mockCommandClient.js => devtools/client/debugger/src/actions/tests/helpers/threadFront.js
2019-08-16 00:41:23 +03:00
Hiroyuki Ikezoe
5e47b0f499 Bug 1574061 - Use the target window object for waitForAnimationFrames in observeStylingInTargetWindow. r=boris
Also waitForAnimationReadyToRestyle should use owner window object instead of
global `window`.

Differential Revision: https://phabricator.services.mozilla.com/D42078

--HG--
extra : moz-landing-system : lando
2019-08-15 21:20:45 +00:00
Mike Hommey
2d9d6639b7 Bug 1574058 - Backout changeset c5acba2f11e0 (bug 1418425). r=froydnj
It was remaining from an earlier iteration of bug 1418425 that uses
zlib's crc32 function, but ended up unused because in the end it was
done differently.

Interestingly, the corresponding host objects are not built currently,
and actually fail to build when built manually (or with build system
changes that make them built).

Differential Revision: https://phabricator.services.mozilla.com/D42073

--HG--
extra : moz-landing-system : lando
2019-08-15 13:17:39 +00:00
Nick Alexander
b64c6171a1 Bug 1533465 - Add Gradle script for substituting local GeckoView into downstream consumers. r=sebastian
Differential Revision: https://phabricator.services.mozilla.com/D22552

--HG--
extra : moz-landing-system : lando
2019-08-15 21:18:24 +00:00
Emilio Cobos Álvarez
ad39790be6 Bug 1574101 - Use the right parent frame for block ruby if it's out of flow. r=mats
I should've caught this when reviewing, in fairness.

Differential Revision: https://phabricator.services.mozilla.com/D42163

--HG--
extra : moz-landing-system : lando
2019-08-15 21:14:34 +00:00
Nicholas Nethercote
5f247b395a Bug 1572590 - Indent conditionally-defined prefs in firefox-branding.js. r=KrisWright
Differential Revision: https://phabricator.services.mozilla.com/D41318

--HG--
extra : moz-landing-system : lando
2019-08-15 21:07:50 +00:00
Nicholas Nethercote
00f929e261 Bug 1572590 - Indent conditionally-defined prefs in geckoview-prefs.js. r=KrisWright
Differential Revision: https://phabricator.services.mozilla.com/D41317

--HG--
extra : moz-landing-system : lando
2019-08-15 21:07:38 +00:00
Nicholas Nethercote
e39e833d20 Bug 1572590 - Indent conditionally-defined prefs in mobile.js. r=KrisWright
Differential Revision: https://phabricator.services.mozilla.com/D41316

--HG--
extra : moz-landing-system : lando
2019-08-15 21:07:26 +00:00
Nicholas Nethercote
8f4aafad33 Bug 1572590 - Indent conditionally-defined prefs in firefox.js. r=KrisWright
The patch also removes several comments from the top of the file, every single
one of which is incorrect.

Differential Revision: https://phabricator.services.mozilla.com/D41315

--HG--
extra : moz-landing-system : lando
2019-08-15 21:07:12 +00:00