allow support in .ini files for subtest units and lower_is_better values; implement this for speedometer.
Differential Revision: https://phabricator.services.mozilla.com/D4465
--HG--
extra : moz-landing-system : lando
This does a few things that should help:
(1) Run the timeout only after resize events have stopped.
(2) Increase the timeout from 30ms to 100ms. It doesn't need to be so fast.
(3) Add a parameter to formatValue that bypasses actually formatting the value and instead only ensures the host is visible. There's no need in this case to keep removing the formatting and then adding it back. Having a "formatValue" method take a parameter to skip formatting is kind of weird, though. At first I tried factoring out the make-host-visible part, but that requires also factoring out all the logic that determines whether the value is a formattable URL, and that ended up being ugly. I'm open to better ideas.
Based on an earlier patch by Marco Bonardo <mbonardo@mozilla.com>
Differential Revision: https://phabricator.services.mozilla.com/D4502
--HG--
extra : moz-landing-system : lando
This is on top of bug 1486623.
While at it removed the 'stale computed styles' report, since it was unused
since I removed the undisplayed maps.
Differential Revision: https://phabricator.services.mozilla.com/D4453
--HG--
extra : moz-landing-system : lando
This moves all the node-specific reporting to nsIDocument.
OrphanReporter delegates all the reporting to that and then returns the sum of
all sizes, which is not ideal but was pre-existing.
Also, I moved the main mStyleSheets size reporting to DocumentOrShadowRoot for
it to be shared between document and ShadowRoot.
I'll add memory reporting for the computed stylesheet maps and such in the
ShadowRoot in a followup.
I went through all the XBL bindings, though it seems I could just use
GetBindingWithContent(), since according to:
https://searchfox.org/mozilla-central/rev/55da592d85c2baf8d8818010c41d9738c97013d2/dom/xbl/nsXBLBinding.cpp#615
We don't allow multiple bindings to contribute anon content. Anyway it was the
same amount of code...
Differential Revision: https://phabricator.services.mozilla.com/D4433
--HG--
extra : moz-landing-system : lando
Fix Lollipop crashes because of android.content.res.ColorStateList.addFirstIfMissing()
The default app theme will be applied for the material Date/Time pickers on
API 21 and API 22. After this, on API >=23 they will be Photon themed.
Differential Revision: https://phabricator.services.mozilla.com/D4464
--HG--
extra : moz-landing-system : lando
In the Pocket dropdown, the Tag input field has an auto-complete. In the case
that the user is enrolled in a A/B experiment, a "Send to Phone" section will
be added to the panel. The tag auto-complete field, when active, appears
behind the experiment section.
Differential Revision: https://phabricator.services.mozilla.com/D4580
--HG--
extra : moz-landing-system : lando
the Mingw Clang build failed because a 3-argument form of wcstok could not
be found, despite it apparently being part of the C++ standard. Multiple
forms of header files were tried.
By comparison, wcstok_s is already used (e.g. widget/windows/WinUtils.cpp)
and does the correct thing. So change the functions over to that one.
Differential Revision: https://phabricator.services.mozilla.com/D4568
--HG--
extra : moz-landing-system : lando
This patch removes the 'ScreenOrientationInternal' type from
dom/base/ScreenOrientation.h and moves it into the
HalScreenConfiguration.h header, renaming it simply to 'ScreenOrientation'
in the process. This has several knock-off effects:
- It allows files that needed ScreenOrientationInternal to include a much
smaller header than before
- It greatly reduces the number of headers pulled in when including Hal.h
- It clarifies the role of the type. The 'Internal' part in the name had
nothing to do with it being part of the implementation. The type was public
and called that way only to avoid clashing with the 'ScreenOrientation'
class. Since we moved it into a different namespace it can be renamed
safely.
- It allows a file that was manually re-declaring 'ScreenConfigurationInternal'
type to use the original one
- Finally this fixes a few files which were missing headers they actually
required but that would still build because unified compilation put them into
units that already had those headers thanks to ScreenConfiguration.h
Differential Revision: https://phabricator.services.mozilla.com/D4458
--HG--
extra : moz-landing-system : lando
This adds a simple empty box that is displayed when we're still loading an icon
but are no longer showing the throbber. Ideally I'd like to keep showing the
throbber and maintain the busy state but that seems more risky for now.
Differential Revision: https://phabricator.services.mozilla.com/D2364
--HG--
extra : moz-landing-system : lando
Prior to this patch, getHSTSPreloadList.js would queue an XHR for every preload
list candidate site. This meant that there would be ~50,000 requests in flight
simultaneously. Simply processing these requests caused them to all time out,
and no useful work was done. This patch resolves them in batches of 250 to
avoid this issue.
Differential Revision: https://phabricator.services.mozilla.com/D3622
--HG--
extra : moz-landing-system : lando
Filed bug 1487036 for a fix that would avoid triggering events for the
placeholder when it's not showing, though realistically I'm not going to have
cycles to fix it.
Probably moving the <input> to Shadow DOM would allow such a solution, but it's
not clear we want to do that just yet at least.
Differential Revision: https://phabricator.services.mozilla.com/D4525
--HG--
extra : moz-landing-system : lando
The completion node was wrongly positioned as soon as the input overflowed.
We fix this by setting the completionNode height in resizeInput,
like we do for the inputNode.
The inputNode takes the whole remaining vertical space
when starting the console. But when typing, the height
is computed and set according to what's in the input.
Which means the input wasn't taking the remaining space
anymore, which could be weird (e.g. if the user wants
to select some text by starting dragging below the actual
input, although the UI would indicate it is possible).
The autocompletionPopup was a bit off due to 2 things:
- in the function that was returning the chevronWidth, we
were subtracting the autocomplete popup padding. But the
autocomplete popup already handles that itself.
- in the function that was computing the character width,
we were using offsetWidth which returned a rounded value.
This means that the further the autocompletion was displayed
at, the more the popup would be off. We use getBoundingClientRect().width
instead which gives us a decimal value.
And we also make sure to not alter the scrolling position in the inputNode
when accepting an autocompletion result (a test is added).
Differential Revision: https://phabricator.services.mozilla.com/D4207
--HG--
extra : moz-landing-system : lando
In Bug 1478435 a selector was removed causing the background
of the SearchBox autocomplete to be transparent and without
box-shadow.
This patch add the needed rule in the CSS. We take this as an
opportunity to fix a small positioning issue by making sure
the element stick to the left.
Differential Revision: https://phabricator.services.mozilla.com/D4421
--HG--
extra : moz-landing-system : lando
When `document.blockParsing()` is called, the nsIParser is suspended
until the document is unblocked. For about:blank documents, this is a
nsParser.
When a document is unblocked, nsParser::ContinueInterruptedParsingAsync
is invoked, which delegates its implementation to nsIContentSink, which
is a nsHTMLContentSink for about:blank documents. Due to a missing
implementation of nsHTMLContentSink::ContinueInterruptedParsingAsync,
the parser was never resumed, causing bug 1465388 and bug 1407501.
This patch fixes the problem, by implementing the required method (and
using a load blocker to ensure that the (about:blank) document does not
finish before the parser finishes).
This patch is tested through extension tests: Currently document_start
stylesheets always activate the parser blocker, and document_start
scripts trigger the parser blocker when the script has not been
preloaded yet (e.g. at the first run).
Before this patch, the test failed due to the assertion failure as
reported in the linked bugs. After this patch, the tests pass.
Differential Revision: https://phabricator.services.mozilla.com/D4352
--HG--
extra : moz-landing-system : lando
The command "Take Element Screenshot" expects the web element as
parameter, and not as part of the body.
--HG--
extra : rebase_source : 6ca78d005cae65273d0d6045ac60e80e993b55bd