The most important part is the `GetPHCAddrInfo()` function in
`exception_handler.cc`, which extracts a crash address from an
`EXCEPTION_POINTERS` object.
The commit also changes the code so that it works if MozStackWalk() returns an
empty stack trace. This happens in practice on Windows on automation sometimes,
I'm not sure why.
The rest of the commit is just plumbing and the smoothing over of minor
platform differences.
Differential Revision: https://phabricator.services.mozilla.com/D39841
--HG--
extra : moz-landing-system : lando
I copy-pasted the implementation of Debugger.Script.prototype.startLine, and added a test and documenation. To make it work, I made JSScript::column_ mandatory, like lineno_. The only place where lineno_ was set and it was not was in JSScript::fullyInitFromEmitter, which copies the line number from BytecodeEmitter::firstLine, which is itself set in BytecodeEmitter's constructors. I followed the easiest path and added a new column field to BytecodeEmitter and all of its constructors.
Differential Revision: https://phabricator.services.mozilla.com/D37157
--HG--
extra : moz-landing-system : lando
Now that we no longer create debugger entries in the cross compartment wrapper map we can remove all the associated infrastructure.
Differential Revision: https://phabricator.services.mozilla.com/D40042
--HG--
extra : moz-landing-system : lando
This removes the code to create CCWs for all debugger wrapper objects and updates compartment checks to query the debugger weakmaps.
Differential Revision: https://phabricator.services.mozilla.com/D40041
--HG--
extra : moz-landing-system : lando
Debuggers and debuggees are swept in the same sweep group and that is accomplished by adding edges in both directions between the debugger and debuggee zones for all debugger wrapper objects. Currently this happens by examining the cross compartment wrapper map. This patch changes this to use the debugger's weakmaps instead.
Differential Revision: https://phabricator.services.mozilla.com/D40040
--HG--
extra : moz-landing-system : lando
The previous implementation checked for a registration's active worker on the
main thread using `ServiceWorkerManager::GetRegistration`. This has two
problems:
- `ServiceWorkerManager` can't be relied upon in parent-intercept mode, and
- `SWM:GetRegistration` won't return the registration if `.unregister()` has
been called.
Differential Revision: https://phabricator.services.mozilla.com/D40104
--HG--
extra : moz-landing-system : lando
It seems a bit more sensible to me that if any filtering needs to happen
from content insertions, it should happen in the doc and not the
notification controller.
Differential Revision: https://phabricator.services.mozilla.com/D40132
--HG--
extra : moz-landing-system : lando
Call GeckoThread.onPause() and onResume() on GeckoRuntime lifecycle events.
Differential Revision: https://phabricator.services.mozilla.com/D40078
--HG--
extra : moz-landing-system : lando
On its own (without the previous patch), this fixes bug 1406291.
Combined with the previous patch, this patch fixes this bug (bug
1420528) when column-span is not enabled (today's configuration), and
also fixes 1411799.
Differential Revision: https://phabricator.services.mozilla.com/D39818
--HG--
extra : moz-landing-system : lando
This patch fixes bug 1420528 when column-span is enabled, and it also
fixes bug 1468654.
Differential Revision: https://phabricator.services.mozilla.com/D39582
--HG--
extra : moz-landing-system : lando
Note that I introduced a blank line to make the intent of the NOTE
clearer, which I had to research. I think it's clear it covers the
three tests below it based on
https://hg.mozilla.org/mozilla-central/rev/53489b3e14f1 and
https://bugzilla.mozilla.org/show_bug.cgi?id=967311#c0 .
I'm also running this test both with and without the column-span pref,
because those two states will be fixed by different patches.
Co-authored-by: L. David Baron <dbaron@dbaron.org>
Co-authored-by: Daniel Holbert <dholbert@cs.stanford.edu>
Differential Revision: https://phabricator.services.mozilla.com/D39581
--HG--
extra : moz-landing-system : lando
These tests were marked as `fails-if(geckoview&&!webrender)`. They are
failing on geckoview because of bug 1558513: there is an offset
between the emojis in the test and reference images.
The reason that they were passing on webrender previously was because
the emojis weren't being drawn at all, so both the test and reference
images were blank. Bug 1562316 fixed the emojis being drawn with
webrender, but bug 1558513 remains (they are still offset).
Differential Revision: https://phabricator.services.mozilla.com/D40191
--HG--
extra : moz-landing-system : lando
This test _can_ run on non-Android if we reconfigure GetCurrentProduct in
TelemetryCommon to not have an #ifdef for Android.
Differential Revision: https://phabricator.services.mozilla.com/D38741
--HG--
extra : moz-landing-system : lando
This introduces a pref "toolkit.telemetry.isGeckoViewStreaming" to control
whether gecko view products (those with "toolkit.telemetry.isGeckoViewMode"
set) are of the variety that use the upcoming streaming Telemetry API.
Differential Revision: https://phabricator.services.mozilla.com/D38738
--HG--
extra : moz-landing-system : lando
We shouldn't show an update doorhanger message if the default action is to save as a new login.
Differential Revision: https://phabricator.services.mozilla.com/D40107
--HG--
extra : moz-landing-system : lando
