Commit Graph

841 Commits

Author SHA1 Message Date
Paul Adenot
e34a6067fb Bug 1355798 - Fix a division by zero in PannerNode.cpp. r=dminor
This happens when the listener and a PannerNode are at the same position, and
a cone gain has been specified.

The issue is that our implementation of 3d vector normalization does not
special-case vectors that have all components at zero, that dividing by zero
results in infinity, and multiplying by infinity produces NaN.

This end up setting the volume member for the output AudioChunk to NaN, and this
breaks everything downstream, of course. In practice, silence is output, with
some clicks (on linux/pulse at least).

MozReview-Commit-ID: 8u54LixvYMu

--HG--
extra : rebase_source : 3b37970b42e5c60cd6e39d3197b580edc63b5ac9
2017-04-12 15:44:19 +02:00
Sebastian Hengst
1828ea89ca Backed out changeset 7fdcabdbb675 (bug 1024669) for failing mda, GTest and talos jobs. r=backout on a CLOSED TREE 2017-04-10 19:05:44 +02:00
Cervantes Yu
364e524eca Bug 1024669 - Part 1: Annotate crash reports with thread names. r=gsvelto
MozReview-Commit-ID: 4RpAWzTuvPs
2017-02-07 18:57:23 +08:00
Carsten "Tomcat" Book
02ddc23c74 Backed out changeset 7a52d887bcea (bug 1024669) for bustage 2017-04-10 11:43:49 +02:00
Cervantes Yu
ece1ce1a7d Bug 1024669 - Part 1: Annotate crash reports with thread names. r=gsvelto
MozReview-Commit-ID: 4RpAWzTuvPs
2017-02-07 18:57:23 +08:00
Paul Adenot
57ca60efa3 Bug 1341549 - Label runnables in dom/media/webaudio/ r=billm
MozReview-Commit-ID: 1SG1KoVjivS

--HG--
extra : rebase_source : 3a4eb33a3402eca8a6fce31cd90e8edcc81c3eda
2017-04-04 13:47:47 +02:00
Karl Tomlinson
1b6a37c1b9 bug 1353246 adjust int/float comparison to treat floats just outside the range of int as outside r=padenot
float(numeric_limits<int>::max()) can round up and so this inequality was
false even when f was (float)0x80000000 (without rounding) and could not be
represented by an int.

--HG--
extra : rebase_source : 758b66fcab9ec540cf444e573f7f3a7bf9c06ba2
2017-04-04 16:10:26 +12:00
Paul Adenot
6d9a0e3387 Bug 1351456 - Don't assume that window.load will be called after the pref has been flipped. r=pehrsons
MozReview-Commit-ID: 2r6d6a5vIa

--HG--
extra : rebase_source : ed7ba96903fd92e51ccddb320213313e3b368e17
2017-04-03 13:20:33 +02:00
Paul Adenot
26e9175c0d Bug 1351456 - Fix test logging.
MozReview-Commit-ID: KpyHg95FKcv
2017-03-31 18:51:01 +02:00
Paul Adenot
93f23173cb Bug 1351456 - Add some instrumentation to try to understand a test timeout. irc-r=jesup
MozReview-Commit-ID: 935bdFmhwTq

--HG--
extra : rebase_source : 69f29432b714dffbb2eb9c51098d603744e4ceb6
2017-03-31 17:41:31 +02:00
Alastor Wu
4c0c1f059d Bug 1346872 - part1 : notify audible state change when AudioDestinationNode was muted or suspended. r=Ehsan
Web audio should also notify AudioChannelService about its audible state change.

MozReview-Commit-ID: BtjUkHKPETg

--HG--
extra : rebase_source : 809549258b652cb1e531dedfd6aee869d32aa4e4
2017-03-30 14:25:37 +08:00
Kaku Kuo
990f2963e1 Bug 1351527 - Label runnables in dom/media/webaudio/MediaBufferDecoder.cpp; r=jwwang
MozReview-Commit-ID: LbuwnrGCXah

--HG--
extra : rebase_source : 66418e5d78799230a6ae9d731f65da0c6038e328
2017-03-29 10:42:48 +08:00
Paul Adenot
863a1ccd9e Bug 1343550 - Mochitest. r=baku
MozReview-Commit-ID: 72V86HrbVCl

--HG--
extra : rebase_source : 8f561de253021c7566e5d3160bb6b8f43ff0319f
extra : intermediate-source : b258ffe9ee50b38cecbd4eb8fb00c02d30f42376
extra : source : 1aa20dad5c31bc1629516af77266266e1074fb26
2017-03-09 14:09:48 +01:00
Paul Adenot
838b5a8cad Bug 1343550 - Prevent creating AudioNodes on an AudioContext that has been disconnected from its owner. r=baku
Spec (being written): https://github.com/WebAudio/web-audio-api/issues/1139

Bug 1343550 - Prevent touching promises when shutting down an AudioContext, when the global is going away soon. r=baku

MozReview-Commit-ID: F6en9KEbNNf

--HG--
extra : rebase_source : 04076caa38bba980cdff776b5997f33e24516d9e
extra : intermediate-source : 4f2cd3f715a218dc3bca55e89720b6aa1040d35c
extra : source : 69cd9c72bd4ed419e3f7f7b5ab64ee0fa8bd89a2
2017-03-15 17:36:40 +01:00
Alastor Wu
d8197f5d08 Bug 1347758 - part4 : add audio channel log. r=Ehsan
MozReview-Commit-ID: 3zVYtD86O82

--HG--
extra : rebase_source : 3a7726760d6e4941cdbe2e6c9ee7132420482bb4
2017-03-24 14:44:18 +08:00
Iris Hsiao
26a234de5d Backed out 6 changesets (bug 1347758) for eslint failure
Backed out changeset 9becd55242c1 (bug 1347758)
Backed out changeset 2abce19f5001 (bug 1347758)
Backed out changeset 80232d4c85d5 (bug 1347758)
Backed out changeset 1fd084ec34d4 (bug 1347758)
Backed out changeset cafb3c12027b (bug 1347758)
Backed out changeset 85846edfe957 (bug 1347758)
2017-03-24 16:58:08 +08:00
Alastor Wu
e81c17d1b2 Bug 1347758 - part4 : add audio channel log. r=Ehsan
MozReview-Commit-ID: LNXzRZx2rC2

--HG--
extra : rebase_source : eef0ad3d65161c422d3cab57e6e081796452bdd1
2017-03-24 12:04:15 +08:00
JW Wang
989380307c Bug 1349145. P2 - revert the changes in bug 1203047 for MediaBufferDecoder.cpp. r=jya
MozReview-Commit-ID: sxacIjDp2Y

--HG--
extra : rebase_source : 82c554d6a85aaeef71f76fd80620478feba71a71
2017-03-22 11:25:23 +08:00
Dan Minor
62b1eb1bac Bug 1305136 - Disable testAudioContext test in audioContextSuspendResumeClose.html on Linux; r=karlt
This also removes the extra logging I added in loadFile which did not end up
helping anything after all.

MozReview-Commit-ID: FZT5ZShhcG0

--HG--
extra : rebase_source : f5eca9ae169c99dabfbb02dd148b66524325d352
2017-03-03 13:48:45 -05:00
Dan Minor
f3d81cd73f Bug 1305136 - Add additional status messages to loadFile function; r=padenot
It seems like adding these extra "todos" decreases the frequency of this
intermittent. I think it makes sense to land these temporarily while we look
for a root cause.

MozReview-Commit-ID: 4RiXtT3yBzG

--HG--
extra : rebase_source : fc107091d0a34943df3bf3ca579d978b97de877f
2017-02-22 10:59:47 -05:00
Vedant Sareen
7d4bd52fae Bug 1330907 - Rename Telemetry::ID to Telemetry::HistogramID. r=dexter
Changed |print("enum ID : uint32_t {", file=output)| to |print("enum HistogramID : uint32_t {", file=output)| at line 53 of the file |toolkit/components/telemetry/gen-histogram-enum.py|, and then replaced all the textual occurrences of |Telemetry::ID| to |Telemetry::HistogramID| and |ID| to |HistogramID| in 43 other files.
2017-02-16 00:45:15 +05:30
Wes Kocher
f85117da36 Merge m-c to inbound, a=merge
MozReview-Commit-ID: 1c81Eie63Pe
2017-02-14 14:45:40 -08:00
Jean-Yves Avenard
4ee48a05fa Bug 1336358: P4. Disable some noisy tests on Android. r=padenot
Issue tracked in bug 1339449 and bug 1339448

MozReview-Commit-ID: GmlS56bI4Ki

--HG--
extra : rebase_source : 4b85907a840c9ffa03ee8b757deec3ea5539d28b
2017-02-14 16:10:11 +01:00
Bill McCloskey
225fab4ac5 Bug 1337537 - Avoid SystemGroup assertion during WebAudio test (r=ehsan)
MozReview-Commit-ID: 9GbXnkF4fvZ
2017-02-13 17:03:05 -08:00
Paul Adenot
f7e4a455e2 Bug 1339438 - Fix the test that checks that MediaElementAudioSourceNode are working correctly. r=pehrsons
MozReview-Commit-ID: Fazp4QsbxHk
2017-02-14 19:28:04 +01:00
Ehsan Akhgari
8a998d9134 Bug 1336484 - Don't throttle timeouts in background tabs that are playing audio; r=baku
In websites such as Facebook Live, timeout chains are used to drive the
playback of a video or something similar in JavaScript.  Throttling the
minimum timeout values a tab playing a video from such websites in the
background could make the timeout based scheduling of video playback to
not work correctly, and cause audio buffer under-runs that are audible.

In order to address this, other major browsers don't throttle timeouts
in tabs that are playing audio.  This brings us to parity to other
browsers (even though we already do this for websites that use Web Audio
since we've had similar bug reports using the Web Audio API.)

The current audio agent setup that drives the tab audio notification
icons is currently tracking whether a Window is playing audio.  We use
this setup to decide whether to throttle timeouts when a window goes
into background.
2017-02-10 12:08:25 -05:00
Beekill95
b8a8dc861a Bug 1308437 - Part 3: Change expected error to TypeError when testing setValueCurveAtTime with non-finite elements in TestAudioEventTimeline.cpp. r=dminor, a=padenot
--HG--
extra : rebase_source : b3b2d2d3f5e2c1ac974faf2aa2e57e2f28294826
2017-02-07 22:12:06 +07:00
Beekill95
050a685aa9 Bug 1308437 - Part 2: Add test case to verify TypeError is thrown when calling setValueCurve on non-finite elements. r=dminor r=padenot
--HG--
extra : rebase_source : 211c205d53a60647c39723a85da97f02a86909f4
2017-02-06 22:18:04 +07:00
Beekill95
0412139325 Bug 1308437 - Part 1: Change the exception thrown by 'setValueCurve' on non-finite elements to TypeError. r=dminor
--HG--
extra : rebase_source : 3fe7493e7d8933365c873ef652946975983427ea
2017-02-06 22:14:58 +07:00
Jean-Yves Avenard
b7844bd5c3 Bug 1319987: P9. More coding style fixes. r=gerald
MozReview-Commit-ID: DhFRqkWQZny

--HG--
extra : rebase_source : 03ed44efc83fe9cab7fc975229ac4e5746aff96b
2017-01-27 13:20:37 +01:00
Paul Adenot
b51488fd48 Bug 1320705 - Add a test to check that decoding an Opus file does to produce a long tail. r=jya
MozReview-Commit-ID: B4IlW1cWYlX
2017-01-27 15:18:58 +01:00
Paul Adenot
0ac29668f5 Bug 1336098 - When the input is silent, AnalyserNode.getFloatFrequencyData should put -Infinity in the buffer. r=pehrsons 2017-02-02 17:13:13 +01:00
Beekill95
ebd1ad47ba Bug 1308434 - Add testcase for calling DecodeAudioData on detached buffer. r=padenot,dminor
MozReview-Commit-ID: 25zz7RfVHxO

--HG--
extra : rebase_source : 35f8364bf8025a5c440934add359d440c09af9bb
2017-01-26 13:45:51 +07:00
Beekill95
0dc2d443bb Bug 1308434 - Throw TypeError if calling decodeAudioData on a detached buffer. r=padenot,dminor
MozReview-Commit-ID: JxFyFCECTeK

--HG--
extra : rebase_source : c69df64616cfe014684f1049c6e2b2b84b899b64
2017-01-21 13:11:46 +07:00
Bevis Tseng
72d516ef01 Bug 1314833 - Part 2.2: Use AbstractThread::CreateDirectTaskDrainer() to Drain Direct Tasks Dispatched to MediaStreamGraph. f=rjesup,r=padenot,jwwang
MozReview-Commit-ID: 1KgE3uKu4CG

--HG--
extra : rebase_source : 2ad950afe84675fb9bc4c449e53e7c0d52270175
2016-12-07 22:00:12 -10:00
Bevis Tseng
f2bdbd8fd1 Bug 1314833 - Part 2.1: Factor out AbstractThread::MainThread() used in Media Playback. r=billm,jwwang
MozReview-Commit-ID: 9yJi3iDtVZG

--HG--
extra : rebase_source : 39c720ccc576ed9247b5e8abb70d99d7873b3ad6
2016-11-29 13:03:36 +08:00
Boris Zbarsky
03dbb8c08b Bug 851892 part 10. Convert CSSNamespaceRule to WebIDL. r=peterv,heycam 2017-01-13 10:41:03 -05:00
Sebastian Hengst
e21b4b941f Backed out changeset 9dee4f98503c (bug 851892) 2017-01-20 19:30:23 +01:00
Boris Zbarsky
1e1b760bf1 Bug 851892 part 10. Convert CSSNamespaceRule to WebIDL. r=peterv,heycam 2017-01-13 10:41:03 -05:00
Wes Kocher
54c460dbd6 Merge inbound to m-c a=merge
MozReview-Commit-ID: 3cGydlfeaPN
2017-01-18 14:17:10 -08:00
Gerald Squelart
f17dd305d6 Bug 1331289 - Use MediaContainerType in MediaResource, SourceBuffer, TrackBuffersManager, and dependencies - r=jya
Continuing the work of replacing MIME strings with MediaContainerType, starting
from MediaResource and following the dependencies.

Most changes are mechanical: Just change ns*String into MediaContainerType, and
MIME string literals into MEDIAMIMETYPE("a/b").
Some checks for empty/invalid strings and lowercase comparisons can go, thanks
to the always-valid always-lowercase-MIME invariants of MediaContainerType.

One special case in is MediaSourceResource, which used to have an empty string
as its type (because its own type is not relevant, but its SourceBuffers carry
types). Because the inherited GetContentType *must* be overridden, and must
return a MediaContainerType, we needed a valid type even though it should not
be seen in the real world. I've chosen "application/x.mediasource" for that.

MozReview-Commit-ID: 1aCH75Kh2e6

--HG--
extra : rebase_source : 0d9cd9b69c264e5dcfc3845f80ee107f4bcbcd9a
2016-12-28 18:59:02 +11:00
Gerald Squelart
5745998021 Bug 1331770 - Rename 'MediaContentType' to 'MediaContainerType' - r=jya
MozReview-Commit-ID: F0BWai8vPyo

--HG--
rename : dom/media/MediaContentType.cpp => dom/media/MediaContainerType.cpp
rename : dom/media/MediaContentType.h => dom/media/MediaContainerType.h
extra : rebase_source : 640ada96750b4496055087e80ae3f600c9df31c9
2017-01-18 11:59:03 +11:00
Florian Quèze
85611a7b6d Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws.
--HG--
extra : rebase_source : a22344ee1569f58f1f0a01017bfe0d46a6a14602
2017-01-17 11:50:25 +01:00
Ehsan Akhgari
b89a8163fa Bug 1328422 - Make WebAudioDecodeJob not be refcounted, and instead manage its lifetime explicitly; r=padenot 2017-01-16 15:53:45 +08:00
Phil Ringnalda
c4129ca15b Merge autoland to m-c, a=merge 2017-01-15 12:31:23 -08:00
Phil Ringnalda
686006613e Backed out 20 changesets (bug 851892) for load failures in Android crashtest-4
Backed out changeset b9c4115cdeac (bug 851892)
Backed out changeset 5f491bf49b85 (bug 851892)
Backed out changeset 9bf5bcb3e8c5 (bug 851892)
Backed out changeset a9cab46e8b45 (bug 851892)
Backed out changeset 73858e15c8c0 (bug 851892)
Backed out changeset a25638588b6b (bug 851892)
Backed out changeset d58e0e5069ef (bug 851892)
Backed out changeset d8da2a3d8f10 (bug 851892)
Backed out changeset a8da3c34983f (bug 851892)
Backed out changeset 29cf8acbd21e (bug 851892)
Backed out changeset c53cd7bdf8b3 (bug 851892)
Backed out changeset e841a2796375 (bug 851892)
Backed out changeset 2eab85b00159 (bug 851892)
Backed out changeset ca4b1fb9cae4 (bug 851892)
Backed out changeset 74c0ba66f108 (bug 851892)
Backed out changeset 719bb9f41e5b (bug 851892)
Backed out changeset d6aa4c6192df (bug 851892)
Backed out changeset dc81a167a75d (bug 851892)
Backed out changeset 65422477b3a5 (bug 851892)
Backed out changeset 3089dd379077 (bug 851892)
2017-01-15 11:50:10 -08:00
Boris Zbarsky
72579551f8 Bug 851892 part 10. Convert CSSNamespaceRule to WebIDL. r=peterv,heycam 2017-01-13 10:41:03 -05:00
Gerald Squelart
882af395f0 Bug 1330284 - Use MediaContentType in CreateReader and MediaBufferDecoder - r=jya
MozReview-Commit-ID: E9yVaxNdLad

--HG--
extra : rebase_source : 35828ab34adcc2fca6d607459d3dbb3c3c16d5cd
2016-12-22 11:57:48 +11:00
Xidorn Quan
a8e64a94e1 Bug 1298756 - Use uint8_t/uint16_t as underlying type for enums from webidl. r=bz
MozReview-Commit-ID: 3uS9s5ZrPFd

--HG--
extra : rebase_source : ff64b4468ee99ba08fd8638298a27711b7fb6393
2017-01-12 12:23:37 +11:00
Andrea Marchesini
2abf88ce1f Bug 1329744 - AudioBuffer ctor updated, r=padenot 2017-01-10 21:30:28 +00:00