Changed NotificationClient to use stopService instead of calling startService
with a null notification in order to stop NotificationService.
This way, we always have a guaranteed call to startForeground in our service,
abiding by Android Oreo regulations.
MozReview-Commit-ID: 4CzM4pvANJt
--HG--
extra : rebase_source : ce601c7817ed6dd52eed61e2a4b3a044f6a4b673
Automatic update from web-platform-tests[css-contain] Disable size containment for certain elements
Text from the spec
(https://drafts.csswg.org/css-contain/#containment-size):
"... if the element is an internal table element, or if the element
is an internal ruby element, or if the element’s principal box
is a non-atomic inline-level box, size containment has no effect."
The patch disables "contain: size" for internal table elements,
internal ruby elements and non-atomic inline-level boxes.
BUG=843329
TEST=external/wpt/css/css-contain/contain-size-005.html
TEST=external/wpt/css/css-contain/contain-size-006.html
TEST=external/wpt/css/css-contain/contain-size-007.html
TEST=external/wpt/css/css-contain/contain-size-008.html
TEST=external/wpt/css/css-contain/contain-size-009.html
TEST=external/wpt/css/css-contain/contain-size-010.html
TEST=external/wpt/css/css-contain/contain-size-011.html
TEST=external/wpt/css/css-contain/contain-size-012.html
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ie3264b5c76eb04ec97064b3da8706d840924597f
Reviewed-on: https://chromium-review.googlesource.com/1080799
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#563586}
--
wpt-commits: e2fe8bbd62a081282326d64dc2e80035799bc9fa
wpt-pr: 11284
Automatic update from web-platform-testsCheck if a type is a sequence through idlType.generic
idlType.sequence was removed in https://github.com/w3c/webidl2.js/pull/175, as the same check can be achieved through `idlType.generic === "sequence"`. Move to this more updated syntax so that updating webidl2.js will require less work the next time we do it.
--
wpt-commits: b1a1415cdf23bb3dc5c2f2ccb58a7abe87b93961
wpt-pr: 11286
Automatic update from web-platform-testsAdd Priority Hints support to link and img elements
This adds Priority Hints support to link and img elements under a
runtime-enabled flag. The support for link elements do not extend
<link rel=modulepreload>s due to the nature of module script fetching.
Support for this as well as script elements in general will come at a
later time due to the significant changes to the module script loading
infrastructure.
Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/65lfM2f0eeMR=kinuko@chromium.org, kouhei@chromium.org, yhirano@chromium.org, yoav@yoav.ws
Bug: 821464
Change-Id: I5ab0a114ee2b2fce9f0df6c4c5e1f7a487980d0a
Reviewed-on: https://chromium-review.googlesource.com/1067245
Commit-Queue: Dominic Farolino <domfarolino@gmail.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563550}
--
wpt-commits: 5aa06e74524c68cf1135dd918699f527449b25c2
wpt-pr: 11263
Automatic update from web-platform-tests[web-animations] Fix timeout/0 tests in unsupporting browsers
Part of #11269.
--
wpt-commits: ee6c9d315b05a2afe40a13cbf26d3126d52c34a0
wpt-pr: 11276
Automatic update from web-platform-testsAvoid uncaught exception in iframe if WebNFC is not supported (#11271)
Part of #11269.
--
wpt-commits: dcdd59c1c0902c1a3fa79ab4ead6321f26ddc4bd
wpt-pr: 11271
Automatic update from web-platform-testsCorrect serialization of URL in background-332.html (#10478)
* Correct serialization of URL in background-332.html
According to https://drafts.csswg.org/cssom/#serialize-a-url, the serialization of a URL always includes double-quotes, and per https://drafts.csswg.org/css-values/#relative-urls, if a URL appears in a computed style, it is resolved to an absolute URL. Adjust background-332.html to match the spec, and update the test description to clarify the computed style is being tested.
--
wpt-commits: b792706b1001a1e8d93b26e8cea341ecffe8417e
wpt-pr: 10478
Automatic update from web-platform-testsWorker: Change the default credentials option from 'omit' to 'same-origin'
This is a follow-up for the spec change:
https://github.com/whatwg/html/pull/3656
Note that ES Modules for dedicated workers is still behind the flag and this
change doesn't affect applications in the real world.
Bug: 848247
Change-Id: I25083f3f11f9d13663e16e2f4c137095e9b12b01
Reviewed-on: https://chromium-review.googlesource.com/1080668
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563465}
--
wpt-commits: 72c7cfed684554c0d65b7a33d413df9ae1c5999f
wpt-pr: 11274
Automatic update from web-platform-tests[css-grid] Baseline alignment inside the tracks sizing algorithm
We have identified several cases where the Baseline Alignment accounts
for the grid's intrinsic size. Since we depend on the track sizing
algorithm to compute the grid's intrinsic size, the only way to handle
all these cases is to integrate the baseline alignment logic in the
algorithm.
Additionally, the CSSWG has identified several cases that can't be
solved properly; such cases have in common that they imply cyclic
dependencies between the item's and grid area's size. The CSSWG has
resolved that these items don't participate in baseline alignment:
https://github.com/w3c/csswg-drafts/issues/1365
There are also other related issues with some examples and relevant
discussions about this topic:
https://github.com/w3c/csswg-drafts/issues/1039https://github.com/w3c/csswg-drafts/issues/1409
Bug: 704713
Change-Id: I817b16eb43aa76f4827deb8f1f20efb7fde3dc22
Reviewed-on: https://chromium-review.googlesource.com/923261
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#562406}
--
wpt-commits: 82b278966038f26cb83ceeb67404b0ce7e13a74c
wpt-pr: 9553
Automatic update from web-platform-testsRemove tests for the crop property (#10556)
There is a comment in the test that it wasn't implemented in anywhere, and it seems to have been removed from the spec (per 7f3fb42152). Remove the reference to the property from the testcases.
--
wpt-commits: f6867415601bc07b2801900b5d1cae9359612d07
wpt-pr: 10556
Automatic update from web-platform-tests[PageLifecycle] Add WPT test for lifecycle's onfreeze callback
Since the onfreeze callback is invoked based on an internal decision
from the browser, to be able to test the callback, we are adding support
for it from chromeGPUBenchmak as well as in chromedriver/WebDriver.
This CL focuses on the chromeGPUBenchmark solution.
The WPT test itself, verifies that the onfreeze callback is called, and
it also verifies that only fetch keepalive is allowed from withing the
callback.
Bug: chromium:837709
Change-Id: Ia4cb16dc10625f478ec270617da1a26395a9d29d
Reviewed-on: https://chromium-review.googlesource.com/1072899
Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563338}
--
wpt-commits: 3d6920b84bac82c45a8da5c8b04b6da0c64f02fd
wpt-pr: 11165
Automatic update from web-platform-testsMerge pull request #11281 from csnardi/cookie-store-idl
Allow cookie-store IDL test to run even if objects not defined
--
wpt-commits: f172b83c6b6bea611e99d0a79bde72ddbdd60e62
wpt-pr: 11281