This commit implements the actual UI changes. A follow-up commit adds the
tests for the changes. The CSS is a little bit awkard since it uses lots of
ID selectors rather than class selectors. I wanted to be able to write quick
selects, since it's selecting across the entire browser document. I feel
a little conflicted with the approach, as I would prefer to use classes in
general.
The panel.jsm.js file collects all of the UI handling changes rather than
having everything in menu-button.jsm.js, as the latter can get loaded
at startup. I'm not sure if it's completely worth the trouble of having
two files, as most of it should be pretty light.
This commit does not handle localization for the panel, as we should be moving
to Fluent. Rather than solve that here, I will follow-up with it in Bug 1599774.
Differential Revision: https://phabricator.services.mozilla.com/D62914
--HG--
extra : moz-landing-system : lando
This commit removes the old popup implementation, but does not implement the new one
yet. This is in a follow-up commit. The client is in a bit of an awkard state where
it is mid-transition to a new architecture. Some of the code comments and documentation
were updated to reflect the changes coming up.
Differential Revision: https://phabricator.services.mozilla.com/D62913
--HG--
extra : moz-landing-system : lando
The presets in recording-utils.js couldn't be shared via the ChromeUtils.import
mechanism. When they were in recording-utils.js they could only be loaded in
via the DevTools require() loader. This commit changes it so that they are
stored in a jsm, and are also injected to each UI interface where the
ChromeUtils.import function is available (only in the initializers).
Differential Revision: https://phabricator.services.mozilla.com/D62912
--HG--
extra : moz-landing-system : lando
If the profiler unexpectedly stops, this is fine, as the new recording infrastructure
is most likely in control of it. This was leading to lots of spurious errors when
working on the new about:profiling infrastructure.
Differential Revision: https://phabricator.services.mozilla.com/D62911
--HG--
extra : moz-landing-system : lando
NS_Convert* has small string optimizations and doesn't require an extra strlen()
call from Adopt().
Differential Revision: https://phabricator.services.mozilla.com/D64191
--HG--
extra : moz-landing-system : lando
Automatic update from web-platform-tests
CSP nonce: correct some SVG assertions
Chrome implements nonce reflection incorrectly for SVG and the tests (used to) reflect that...
Also change assertion order of a custom element test to be more useful.
--
wpt-commits: 085b675a6a7dabadc080b34711f632d26ec2b634
wpt-pr: 21934
Automatic update from web-platform-tests
service worker: Add test for FetchEvent.handled
The spec PR is: https://github.com/w3c/ServiceWorker/pull/1496
--
wpt-commits: 59be92336b2e8563207a1323250c6f1092a03d80
wpt-pr: 21652
Automatic update from web-platform-tests
Adding core support for WebXR squeezestart / squeeze / squeezeend events
New WebXR spec has a new set of input events. This commit adds core support for those. Still must be hooked up to the actual HW-specific code (I've added code for Oculus Rift (S) as an example).
Bug: 1051247,1019144
Change-Id: Iac0e66a39eff68c567af2234e583780af6dcaed2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051369
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743715}
--
wpt-commits: 6c0160d3c0e99ffa3d3156b5f1b52d0c34b62b3f
wpt-pr: 21759
We don't need to package tests for builds that we don't actually run
tests from, but it is tricky to align this correctly by setting
MOZ_AUTOMATION_PACKAGE_TESTS=0 in relevant mozconfigs. Instead we can
set the environment variable in the task definition, and use a full
taskgraph verification check to ensure that the flag is only set on
builds that have tests.
The one tricky area is the win64-aarch64 builds, which have a workaround
by specifying the new skip-verify-test-packaging attribute.
In one case, win64-aarch64-shippable has tests that run against it, but
it copies those tests from a win64-aarch64-shippable-no-eme task, which
itself has no tests. Both of those tasks need to skip the verify check
as a result.
In another case, the win64-aarch64-eme task is an artifact build that
grabs test packages from the win64-aarch64 build. Since the win64-aarch64
build doesn't have tests, it needs to skip the verify check.
Differential Revision: https://phabricator.services.mozilla.com/D59426
--HG--
extra : moz-landing-system : lando
This covers most cycle collected objects which support weak references, but
not the ones which inherit from a cycle collected class and don't do any cycle
collection on their own.
Differential Revision: https://phabricator.services.mozilla.com/D63962
--HG--
extra : moz-landing-system : lando
Some tests needed to be updated to account for an `Intl` constructor whose
prototype doesn't have a `resolvedOptions` method.
Differential Revision: https://phabricator.services.mozilla.com/D61875
--HG--
extra : moz-landing-system : lando
Canonicalises the `tlang` subtag of a transform extension per the usual rules
for canonicalising the base name parts of a locale identifier. In addition to
that, deprecated `tvalue` subtags are now also replaced with their preferred
replacements according to the `alias` data from CLDR.
Differential Revision: https://phabricator.services.mozilla.com/D61873
--HG--
extra : moz-landing-system : lando
Unicode extension subtags are now canonicalised for all operations, so we no
longer need the UnicodeExtensionCanonicalForm enum.
Unicode extension types provided through option objects are also canonicalised
to ensure no uncanonicalised locales are exposed. This also avoids triggering
various assertions where we assume we only expose fully canonicalised locales.
Also see: https://github.com/tc39/proposal-intl-locale/issues/96
Differential Revision: https://phabricator.services.mozilla.com/D61872
--HG--
extra : moz-landing-system : lando
Variant subtag canonicalisation is back, but with slightly different semantics
compared to IANA BCP 47 canonicalisation.
Differential Revision: https://phabricator.services.mozilla.com/D61871
--HG--
extra : moz-landing-system : lando
Parts 3 and 5 will implement the missing canonicalisation steps for variant
and transform extension subtags.
Differential Revision: https://phabricator.services.mozilla.com/D61870
--HG--
extra : moz-landing-system : lando
Branching on `undefined` in the newly added `ThrowBadDerivedReturnOrUninitializedThis`
function makes it possible to differentiate when `ThrowUninitializedThis()` and when
`ThrowBadDerivedReturn()` needs to be called.
Differential Revision: https://phabricator.services.mozilla.com/D63670
--HG--
extra : moz-landing-system : lando
Only the receiver in a super property access can be a primitive value, the
holder value is guaranteed to be an object, because it's computed from
SuperBase, which always returns an object.
Differential Revision: https://phabricator.services.mozilla.com/D64045
--HG--
extra : moz-landing-system : lando
This was inadvertently enabled and it has memory and likely
other perf impact that we're not yet ready to evaluate.
Differential Revision: https://phabricator.services.mozilla.com/D63343
--HG--
extra : moz-landing-system : lando
We only support writable Animation.timeline attribute on nightly
build, so use nightly build flag in WebIDL and Animation.h/cpp.
For the test expectations, we also use this build flag to skip them or
mark them as expected fail if necessary.
Differential Revision: https://phabricator.services.mozilla.com/D63432
--HG--
extra : moz-landing-system : lando
Some of the BaseProfile headers are always available, even when BaseProfiler
itself is disabled, so we should test these in all cases.
Differential Revision: https://phabricator.services.mozilla.com/D63230
--HG--
extra : moz-landing-system : lando
These were the worrisome missing null checks I noticed, and crash-stat shows that there areactually crashes in these two places
Differential Revision: https://phabricator.services.mozilla.com/D64162
--HG--
extra : moz-landing-system : lando
