Commit Graph

11 Commits

Author SHA1 Message Date
Victor Porof
f9f5914039 Bug 1561435 - Format browser/base/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36041

--HG--
extra : source : 96b3895a3b2aa2fcb064c85ec5857b7216884556
2019-07-05 09:48:57 +02:00
Myk Melez
25349d2601 Bug 1518283 - prohibit blank lines at the beginning and end of blocks (eslint padded-blocks) r=mossop,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D17526

--HG--
extra : moz-landing-system : lando
2019-01-30 17:26:25 +00:00
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Coroiu Cristina
83cdfe7284 Merge mozilla-central to inbound a=merge on a CLOSED TREE 2018-08-31 19:35:06 +03:00
Mark Banner
691543ee89 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439

--HG--
extra : moz-landing-system : lando
2018-08-31 05:59:17 +00:00
Dave Townsend
e1f6637191 Bug 1487246: Remove uses of comma sequences in linted code. r=Standard8
Two cases were hiding permanently failing tests. I've commented those out and
filed bug 1487431.

Differential Revision: https://phabricator.services.mozilla.com/D4680

--HG--
extra : rebase_source : 232fa6173de8844a9c47d59926ec8e39d0640ecd
2018-08-29 16:12:55 -07:00
Jonathan Kew
4df17075f0 Bug 1469104 - Fix testcase in browser_sanitize-timespans to not fail immediately after midnight. r=mak 2018-06-20 12:34:05 +01:00
sreeise
470642124d Bug 1448081 - Replaced tests using updatePlaces with PlaceTestUtils.addVisits. r=Standard8
PlacesTestUtils.addVisits provides a better api for adding history visits to the database for testing.

MozReview-Commit-ID: 3VIeWz59ErM
2018-04-22 00:33:55 -07:00
Dorel Luca
24c46f522e Backed out changeset 9c339f571d35 (bug 1448081) for browser chrome failures on browser/components/places/tests/browser/browser_library_downloads.js. a=backout" 2018-04-21 04:49:45 +03:00
sreeise
77fc8912b8 Bug 1448081 - Replaced tests using updatePlaces with PlaceTestUtils.addVisits. r=Standard8
PlacesTestUtils.addVisits provides a better api for adding history visits to the database for testing.

MozReview-Commit-ID: 3VIeWz59ErM
2018-04-20 16:24:10 +01:00
Johann Hofmann
8a87220e95 Bug 1167238 - Part 4 - Move sanitize tests into a topical directory and clean up sanitize.js usage. r=mak
We're changing the way sanitize.js/Sanitizer.jsm works and need to adjust a lot of tests to that.
I'm using this opportunity to also move the sanitization tests into their
own topical directory and out of b/b/c/test/general.

MozReview-Commit-ID: GHOqr4hT52b

--HG--
rename : browser/base/content/test/general/browser_purgehistory_clears_sh.js => browser/base/content/test/sanitize/browser_purgehistory_clears_sh.js
rename : browser/base/content/test/general/browser_bug409624.js => browser/base/content/test/sanitize/browser_sanitize-formhistory.js
rename : browser/base/content/test/general/browser_sanitize-passwordDisabledHosts.js => browser/base/content/test/sanitize/browser_sanitize-passwordDisabledHosts.js
rename : browser/base/content/test/general/browser_sanitize-sitepermissions.js => browser/base/content/test/sanitize/browser_sanitize-sitepermissions.js
rename : browser/base/content/test/general/browser_sanitize-timespans.js => browser/base/content/test/sanitize/browser_sanitize-timespans.js
rename : browser/base/content/test/general/browser_sanitizeDialog.js => browser/base/content/test/sanitize/browser_sanitizeDialog.js
extra : rebase_source : 10577846b8a407d12f7459b270a5c5573cd425ad
2018-01-18 16:05:36 +01:00