Commit Graph

646852 Commits

Author SHA1 Message Date
Barret Rennie
f584c090db Bug 1536170 - Replace all usage of Async.yieldingIterator with Async.yieldingForEach r=tcsc
Differential Revision: https://phabricator.services.mozilla.com/D26593

--HG--
extra : moz-landing-system : lando
2019-04-12 19:07:26 +00:00
Barret Rennie
72551e1659 Bug 1536170 - Add unit tests for Async.yieldingForEach() r=tcsc
Differential Revision: https://phabricator.services.mozilla.com/D26592

--HG--
extra : moz-landing-system : lando
2019-04-12 19:07:08 +00:00
Barret Rennie
27e15849d2 Bug 1536170 - Replace Async.jankYielder r=tcsc,markh,eoger
`Async.jankYielder` is known to, unfortunately, cause jank by creating a lot of
immediately resolved promises that must be then GCed. For a collection of 50
items, it will create 50 promises and 49 of them will immediately resolve.

Instead of `Async.jankYielder`, we now have `Async.yieldState`, which simply
keeps track of whether or not the caller should yield to the event loop. Two
higher level looping constructs are built on top of it:

* `Async.yieldingIterator`, which has been rewritten to not create extraneous
  promises; and
* `Async.yieldingForEach`, which is a replacement for awaiting
  `Async.jankYielder` in a loop. Instead, it accepts the loop body as a
  function.

Each of these can share an instance of an `Async.yieldState`, which allows an
object with multiple loops to yield every N iterations overall, instead of
every N iterations of each loop, which keeps the behaviour of using one
`Async.jankYielders` in multiple places.

Differential Revision: https://phabricator.services.mozilla.com/D26229

--HG--
extra : moz-landing-system : lando
2019-04-12 19:07:00 +00:00
Logan Smyth
46fb1ab6f9 Bug 1543754 - Part 7: Allow each source actor to have a unique index. r=jlast
Right now we can end up with Source objects with multiple source actors that
share the same ID, since nothing tries to make them unique. This patch
makes sources created in Jest tests each get an incrementing actor ID.

Differential Revision: https://phabricator.services.mozilla.com/D27134

--HG--
extra : moz-landing-system : lando
2019-04-12 19:06:23 +00:00
Logan Smyth
94937c6fcc Bug 1543754 - Part 6: Remove newSources action and rely entirely on newGenerated/newOriginalSources. r=jlast
With the previous commits done, the 'newSources' actions expose implementation details that we want
to keep private within the file. Nothing outside of these actions should be instantiating Source
objects anymore.

Differential Revision: https://phabricator.services.mozilla.com/D27133

--HG--
extra : moz-landing-system : lando
2019-04-12 18:56:07 +00:00
Logan Smyth
595ea2ea81 Bug 1543754 - Part 5: Move generated source creation into the newSources after debouncing. r=jlast
We move source creation into the action itself so that the action can inspect the current
state of the store in order to decide how to create the source, where previously we were
forced to insert the source and have the reducer itself handle cases where the source
already existed.

Differential Revision: https://phabricator.services.mozilla.com/D27132

--HG--
extra : moz-landing-system : lando
2019-04-12 18:55:41 +00:00
Logan Smyth
2bb523c30c Bug 1543754 - Part 4: Move creation of original source actors into a separate phase after debouncing. r=jlast
We want the source actions to be responsible for creating the Source objects rather than creating
them ahead of time. This means that the action itself can make decisions about how to handle new
sources appearing, where right now that decision is made too early by the logic queueing the items.

Differential Revision: https://phabricator.services.mozilla.com/D27131

--HG--
extra : moz-landing-system : lando
2019-04-12 18:55:16 +00:00
Logan Smyth
ff8c4164ce Bug 1543754 - Part 3: Distinguish original and generated source data in the source queue. r=jlast
We want the two types of queue items to have different datatypes, so we clearly distinguish the
two types of sources that are queued.

Differential Revision: https://phabricator.services.mozilla.com/D27130

--HG--
extra : moz-landing-system : lando
2019-04-12 19:06:15 +00:00
Logan Smyth
1e67481a7c Bug 1543754 - Part 2: Split the SET_WORKERS action into INSERT/REMOVE actions. r=jlast
Reducers should be able to use actions to tell what is happening to the workers, and
by combining them into one action they are unable to know what is being added and
what is being removed. Splitting them up means reducers have more information.

Differential Revision: https://phabricator.services.mozilla.com/D27128

--HG--
extra : moz-landing-system : lando
2019-04-12 19:06:19 +00:00
Logan Smyth
d074c1744a Bug 1543754 - Part 1: Update SourcePayload type to match response. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D27127

--HG--
extra : moz-landing-system : lando
2019-04-12 18:53:57 +00:00
Logan Smyth
d8d6b2e0b1 Bug 1544073 - Upgrade eslint-plugin-import to version 2.16.0. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D27356

--HG--
extra : moz-landing-system : lando
2019-04-12 18:35:29 +00:00
Mike Shal
63403bb0df Bug 1522931 - always check the OSX SDK version; r=firefox-build-system-reviewers,chmanchester
Bug 1500504 added a version check for the SDK, but it only does the
check if --with-macos-sdk is used. We should also check the version when
using the default SDK.

Note that this means we now set MACOS_SDK_DIR to be the default SDK even
if it wasn't set explicitly from --with-macos-sdk

Differential Revision: https://phabricator.services.mozilla.com/D17727

--HG--
extra : moz-landing-system : lando
2019-04-12 19:00:13 +00:00
Mike Shal
b64b81d0c5 Bug 1522931 - Vendor biplist; r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D26390

--HG--
extra : moz-landing-system : lando
2019-04-12 19:00:15 +00:00
Csoregi Natalia
c8286ff9c4 Backed out changeset 883a5cbce017 (bug 1534389) for devtools failures on browser_animation_current-time-scrubber-rtl.js. CLOSED TREE 2019-04-12 22:10:41 +03:00
Byron Campen [:bwc]
6aed5170c6 Bug 1531914: Fix and re-enable this test-case. r=jib
Differential Revision: https://phabricator.services.mozilla.com/D26788

--HG--
extra : moz-landing-system : lando
2019-04-12 18:39:41 +00:00
Jason Laster
2149f0c9b6 Bug 1543731 - When map scopes is disabled we should not compute mappings. r=loganfsmyth
Differential Revision: https://phabricator.services.mozilla.com/D27154

--HG--
extra : moz-landing-system : lando
2019-04-12 17:52:26 +00:00
Geoff Brown
46b69e7a79 Bug 1544062 - Run windows/aarch64 xpcshell in 3 chunks; r=egao
Reduce chunks from 8 to 3. Each test task has at least a couple of minutes
of overhead, so fewer chunks improves overall efficiency. At 3 chunks, each
one still completes reasonably quickly (less than 20 minutes).

Differential Revision: https://phabricator.services.mozilla.com/D27339

--HG--
extra : moz-landing-system : lando
2019-04-12 18:08:23 +00:00
Brian Hackett
ac964a170e Bug 1542560 - Watch for missing symbols, r=loganfsmyth.
Differential Revision: https://phabricator.services.mozilla.com/D27111

--HG--
extra : moz-landing-system : lando
2019-04-12 17:33:58 +00:00
Brian Hackett
7615275cf6 Bug 1542502 - Wait for breakpoint to appear after pretty printing, r=loganfsmyth.
Differential Revision: https://phabricator.services.mozilla.com/D27113

--HG--
extra : moz-landing-system : lando
2019-04-12 17:34:02 +00:00
Andi-Bogdan Postelnicu
c9b234eafc Bug 1543492 - for clang based static-analysis and formating add a package version that represents a baseline if we continue the analysis or prompt for an update. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D27042

--HG--
extra : moz-landing-system : lando
2019-04-11 09:58:59 +00:00
Florin Strugariu
debe0f9baf Bug 1513835 Add LinkedIn to tp6 r=davehunt
Differential Revision: https://phabricator.services.mozilla.com/D26896

--HG--
extra : moz-landing-system : lando
2019-04-12 17:03:32 +00:00
Botond Ballo
6bb3e05a9d Bug 1543501 - Add operator<< to ScaleFactor. r=kats
This allows it to be used more easily with MOZ_DBG().

Differential Revision: https://phabricator.services.mozilla.com/D27000

--HG--
extra : moz-landing-system : lando
2019-04-12 16:49:00 +00:00
Botond Ballo
55b741f5f7 Bug 1543501 - Make MOZ_DBG() work on Android. r=heycam
stderr does not go anywhere by default on Android. Debugging output is
conventionally sent to the Android log via special functions like
__android_log_print.

We already have logic for handling this in nsCRTGlue's printf_stderr, but
I don't think we can use that in MFBT.

Differential Revision: https://phabricator.services.mozilla.com/D26985

--HG--
extra : moz-landing-system : lando
2019-04-12 16:48:51 +00:00
Botond Ballo
422903589d Bug 1543501 - Print a 'token' that allows output from MOZ_DBG() to be easily grepped for among other output. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D26984

--HG--
extra : moz-landing-system : lando
2019-04-12 16:49:56 +00:00
Brian Grinstead
4bfebae0ab Bug 1543834 - Migrate test_largemenu.xul to test_largemenu.html to make sure intermittent tracking on treeherder survives a rename r=bdahl
This is the intermittent bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1410000

Differential Revision: https://phabricator.services.mozilla.com/D27185

--HG--
rename : toolkit/content/tests/chrome/test_largemenu.xul => toolkit/content/tests/chrome/test_largemenu.html
extra : moz-landing-system : lando
2019-04-12 16:47:58 +00:00
Will Hawkins
4e47836648 Bug 1539006: Properly implement Performance Timeline Level 2 w3c spec. r=mstange,baku
Differential Revision: https://phabricator.services.mozilla.com/D27008

--HG--
extra : moz-landing-system : lando
2019-04-12 16:29:48 +00:00
Ricky Rosario
69064e8d22 Bug 1517306 - keep the original provider ID for the remote settings provider r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D27325

--HG--
extra : moz-landing-system : lando
2019-04-12 15:49:22 +00:00
Geoff Brown
ea66abe473 Bug 1543993 - Run remaining Talos ccov tasks only on try; r=jmaher
Stop running Tss(tp6) and T(bcv) on ccov builds on central -- the remaining 2 cases
missed in the previous bug.

Differential Revision: https://phabricator.services.mozilla.com/D27313

--HG--
extra : moz-landing-system : lando
2019-04-12 15:41:07 +00:00
Christian Holler
8e514a52b7 Bug 1514346 - Add --enable-gczeal to fuzzing/asan jsshell builds. r=sfink
Differential Revision: https://phabricator.services.mozilla.com/D27318

--HG--
extra : moz-landing-system : lando
2019-04-12 16:05:25 +00:00
shindli
5c5840dbdd Merge mozilla-central to autoland. a=merge CLOSED TREE 2019-04-12 19:16:38 +03:00
Narcis Beleuzu
bbf97a2497 Backed out changeset 4cf10c7b68ad (bug 1544008) for XPCShell crashes on test_csp_upgrade_insecure_request_header.js. CLOSED TREE 2019-04-12 18:52:39 +03:00
shindli
266dff621d Merge inbound to mozilla-central. a=merge 2019-04-12 18:48:02 +03:00
Mike Conley
a80a761780 Bug 1534389 - Send normal mouse events when cursor is over a draggable region on Windows. r=jmathies
Differential Revision: https://phabricator.services.mozilla.com/D23231

--HG--
extra : moz-landing-system : lando
2019-04-12 13:10:23 +00:00
Jason Laster
5e3effc808 Bug 1543821 - Mochitests should use dbg helper (eslint fix).
Differential Revision: https://phabricator.services.mozilla.com/D27323

--HG--
extra : moz-landing-system : lando
2019-04-12 15:43:28 +00:00
Frederik Braun
d372b94f5f Bug 1544008 - re-allow systemprincipal load for discovery pane r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D27291

--HG--
extra : moz-landing-system : lando
2019-04-12 15:06:13 +00:00
Mark Banner
385ad0d913 Bug 1525548 - Centralise closing the address bar popup into the head file for urlbar tests. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D26759

--HG--
extra : moz-landing-system : lando
2019-04-12 12:52:50 +00:00
Dão Gottwald
4ce84a7849 Bug 724457 - Stop using graytext for shortcuts in menus. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D27275

--HG--
extra : moz-landing-system : lando
2019-04-12 12:42:48 +00:00
Jon Coppeard
b068fc3d17 Bug 1543950 - Fix build errors in gc/Verifier.cpp in --disable-debug --enable-gczeal builds r=allstars.chh
Differential Revision: https://phabricator.services.mozilla.com/D27256
2019-04-12 12:32:10 +01:00
Andreas Tolfsen
2f8f89c648 bug 1543946: geckodriver: clarify that Marionette is used in README; r=me a=doc
DONTBUILD
2019-04-12 11:40:06 +01:00
Andreas Tolfsen
2984d0e60d bug 1543946: geckodriver: move license info to bottom of README; r=me a=doc
DONTBUILD
2019-04-12 11:38:43 +01:00
Andreas Tolfsen
530f561f23 bug 1543946: geckodriver: clarify where source code is in README; r=me a=doc
DONTBUILD
2019-04-12 11:36:16 +01:00
Andreas Tolfsen
b7a05ab2c6 bug 1543946: geckodriver: link to developer docs in README; r=me a=doc
DONTBUILD
2019-04-12 11:32:44 +01:00
shindli
95139e07c8 Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-04-12 12:35:56 +03:00
Mike Hommey
96c3246049 Bug 1543895 - Move test-platform keying of fetches in tests to individual fetch types. r=tomprince
So, instead of fetches['by-test-platform']['fetch'], we have
fetches['fetch']['by-test-platform'].

Differential Revision: https://phabricator.services.mozilla.com/D27227

--HG--
extra : moz-landing-system : lando
2019-04-12 05:31:03 +00:00
Ehsan Akhgari
7d6e7d5d64 Bug 1543869 - Make sure that browser_referrerDefaultPolicy passes by packaging its depenencies correctly; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D27197

--HG--
extra : moz-landing-system : lando
2019-04-12 05:22:57 +00:00
Mark Banner
ebd599c0cc Bug 1541924 - Enforce that BookmarkJSONUtils.importFromURL can only be used with chrome and file URLs. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D26921

--HG--
extra : moz-landing-system : lando
2019-04-12 12:34:44 +00:00
Kershaw Chang
d6000c3224 Bug 1541114 - Check mIPCOpen before sending messages r=mayhemer
To avoid sending ipc messages after the ipc channel is closed, check |mIPCOpen| before sending messages.

Differential Revision: https://phabricator.services.mozilla.com/D26089

--HG--
extra : moz-landing-system : lando
2019-04-12 05:04:22 +00:00
Cosmin Sabou
c64f16b342 Backed out 3 changesets (bug 1538279) for mass test failures. CLOSED TREE
Backed out changeset af07f58d18cc (bug 1538279)
Backed out changeset 508ee4cf9ea2 (bug 1538279)
Backed out changeset 6f2e7c819c11 (bug 1538279)
2019-04-12 07:47:53 +03:00
Daosheng Mu
0e6aee236e Bug 1537967 - Skipping running refresh driver and compositing in VR mode. r=mstange,kip
MozReview-Commit-ID: 4L3PygFSFCB

Differential Revision: https://phabricator.services.mozilla.com/D26834

--HG--
extra : moz-landing-system : lando
2019-04-12 04:42:28 +00:00
Cosmin Sabou
a2ee592ecd Merge mozilla-central to mozilla-inbound. 2019-04-12 06:50:43 +03:00