Instead of just replace `mozilla::ArrayLength` with `std::size`, replace the
whole loop statement with a call to `std::find_if`.
Differential Revision: https://phabricator.services.mozilla.com/D102304
We're already using the `constexpr` calls to `std::char_traits<T>::length()` in
other code, so this fallback code doesn't seem necessary anymore.
(The code in "NumberFormat.cpp" predates the GCC version bump in bug 1536848.)
Differential Revision: https://phabricator.services.mozilla.com/D102297
Calling `mozilla::ArrayLength()` on strings requires to subtract one to account
for the trailing null-character. This isn't necessary when `js_strlen` is used.
`constexpr` evaluation of `js_strlen` requires its input to be a `constexpr`
string. A handful of strings were therefore changed from `const` to `constexpr`.
Differential Revision: https://phabricator.services.mozilla.com/D102296
Automatic update from web-platform-tests
[TablesNG] Fix DCHECKs when painting rows/sections with absolute children
Painting code assument that:
- all child fragments of a section are rows
- all child fragments of a row are cells
This is not true when row/section is a absolute container.
Modified wpt test to trigger the crash
Change-Id: Ife8102412a2ef3f2d5bae07a6031739759c3c994
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636881
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845792}
--
wpt-commits: 64cc817eedc570d93adc05dd63fad957da908cd8
wpt-pr: 27245
Automatic update from web-platform-tests
Add external/wpt/svg/extensibility/foreignObject/will-change-in-foreign-object-paint-order.html
It fails in pre-CompositeAfterPaint and succeeds in CompositeAfterPaint.
Bug: 148499
Change-Id: I8c755bb3c12d01a7187bd175aa5b871e83e16766
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643045
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845781}
--
wpt-commits: d5f6b408a32761e5864b97ba80d4a89d315e5e3a
wpt-pr: 27277
Automatic update from web-platform-tests
Prevent underinvalidation of <pattern> with template
If the pattern resource is marked for layout via a mechanism that does
not invalidate its attributes - for example by changing a style property
that only requires paint invalidation - a call to
LayoutSVGResourceContainer::InvalidateCacheAndMarkForLayout() will fail
to properly invalidate attributes, which leaves the pattern in an
inconsistent state.
Drop the early-out check for SelfNeedsLayout() in said method so that
RemoveAllClientsFromCache() is called in the above case as well.
Bug: 1167563
Change-Id: Ib5896da9e52a103b86dc6eb7ad08e30a572b6d22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642777
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#845766}
--
wpt-commits: 26f07871f053fdf2b3d3b6c2015f9e63babbfc3c
wpt-pr: 27275
Automatic update from web-platform-tests
Mark multiTouchPointsReleaseSecondPoint as flaky in Chrome (#27278)
This is needed for infra PRs to merge
--
wpt-commits: b1a922114610f076c71e6e10813b9b0228058a23
wpt-pr: 27278
Automatic update from web-platform-tests
[resources] Fix conftest.py for pytest>6
Handle the shift away from Node constructors to from_parent, whilst
keeping a backwards-compatible path for earlier versions of pytest.
See https://docs.pytest.org/en/stable/deprecations.html#node-construction-changed-to-node-from-parent
--
wpt-commits: 28b0b6f4ab415d4632d028339e8df6ee657bc4cc
wpt-pr: 27273
Automatic update from web-platform-tests
Deflake wpt test about CSPEE.
The test was timing out. This is likely caused by not running as "slow"
and having many promise_test running in sequence.
This patch:
- Make them run in parallel.
- Fix an error "is-disallowed" vs "is-not-allowed"
- Fix an error HTTP vs HTTPS. The "same-origin" case is now useful.
- For injecting a script, prefer document.write over javascript-url. The
Javascript-url might be canceled by
Document::CancelPendingJavaScriptUrls() and this might be another
reason to explain the flakes.
Bug: chromium:1163751
Change-Id: Id0fe915c551cc464df23fa4235090216b8f701ad
Fixed: chromium:1163751
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640615
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Antonio Sartori <antoniosartori@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845706}
--
wpt-commits: c788d7b979d0e2791c298da4b7c1aa9bc844f803
wpt-pr: 27257
Automatic update from web-platform-tests
Move CSPEE to the NavigationRequest. (#27076)
Move CSPEE code from the AncestorThrottle toward the NavigationRequest.
Why?
1) AncestorThrottle is a NavigationThrottle. NavigationThrottle doesn't
run for several URLs like about:blank. This fixes two two test case
introduced recently for bug 1163174
2) CSPEE can add a 'sandbox' directive. This might modify the origin.
The origin needs to be computed before running the
NavigationThrottle. So this isn't possible to check CSPEE in the
NavigationThrottle. Taking CSPEE into accounts for sandbox will be
fixed in a follow-up.
Bug: 1163174
Change-Id: I193d7821b7819339912a6ba92bdb28e8fa893256
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611269
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Antonio Sartori <antoniosartori@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845560}
Co-authored-by: arthursonzogni <arthursonzogni@chromium.org>
--
wpt-commits: 3f78171b9b3d1799efc24ae12ad5c0865b336805
wpt-pr: 27076
Automatic update from web-platform-tests
[wptserve] Change the default log level for 'wpt serve' to INFO (#27246)
Fixes https://github.com/web-platform-tests/wpt/issues/26461
--
wpt-commits: f6d908e34788102b65f98a0516c4dc8559ab9367
wpt-pr: 27246
Automatic update from web-platform-tests
wpt computing-row-measure-0.html fix
2 tests in this test suite seem inconsistent:
test#2 asserts that
tbody.height=10px > tr.height=1px > td.height=1px
implies td.offsetHeight = 1px
test#4 asserts that
tbody.height=10px > tr > td.height=1px
implies td.offsetHeight = 10px
Edge 17 is the only browser that agrees with #2 and #4
FF agrees with #2, but not #4
Chrome agrees with #4, but not #2
Safari agrees with #4, but not #2
To me, #2 and #4 seem to be in conflict.
Either tbody height propagates to rows, or it does not.
The problem is that #2 is overconstrained.
My suggestion is that tbody height always propagates to tr.
Bug: 958381
Change-Id: I28bfd108c67968d31d0372b536c316c997d2d958
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586097
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845515}
--
wpt-commits: 133ca044f481c49a8efd3f14f34f4b6a1b316f58
wpt-pr: 27265
Automatic update from web-platform-tests
Add more tests for cross-origin WebBundles
A follow-up to https://crrev.com/c/2617167.
Note that the test fails in the current implementation.
See the https://crbug.com/1168449 for details.
The test is now marked as Timeout.
Bug: 1149816, 1168449
Change-Id: I2552f64ea12ac5030c9740f30a94edef2760986c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639337
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845498}
--
wpt-commits: 72aeb6e4a223fb29d1b485c668e50284df8490ca
wpt-pr: 27254
Automatic update from web-platform-tests
[GridNG] Apply justify-content, alignment-content.
As above. This patch implements the core content alignment logic. E.g.
determining the offset at which the tracks should start, and the space
between them (gutter-size - this include the grid-gap if any).
Creates a new struct "TrackAlignmentGeometry" which contains these
two values. Effectively the process is now:
GridGap -> TrackAlignmentGeometry -> SetOffsets.
The most significant difference is that TrackAlignmentGeometry includes
the grid-gap, and the BorderScrollPadding start offset.
Bug: 1045599
Change-Id: Idb4d550f0d8b2aca306945a46d41b5a30a20bca4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622586
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ethan Jimenez <ethavar@microsoft.com>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#845494}
--
wpt-commits: c71b45a1c65da368339f4db424a3740d7f8ea7f3
wpt-pr: 27158
Automatic update from web-platform-tests
Stop-color, flood-color, and lighting-color in forced colors mode
When investigating CL:2627779, I had noticed a few other color
properties we weren't adjusting for in forced colors mode:
stop-color, flood-color, and lighting-color. In most cases, this
shouldn't make a difference since SVG elements are set to
'forced-color-adjust: none' by default, but I figured these would
be good to include for consistency.
Bug: 1166911
Change-Id: I47d16b20309565d28e24e1410115b5a36f22a662
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633944
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#845474}
--
wpt-commits: e4ccc12bbc1d948057d9931ccc2aa06c83d43313
wpt-pr: 27206
Automatic update from web-platform-tests
FontAccess: Selection option support for chooser
This change restricts the fonts displayed to the user when a chooser is
shown. This constraint to the list is implemented as an exact-match
with items supplied in a list with the postscript names of the available
fonts.
Fixed: 1164077
Change-Id: If3e3e0cba91de83bc0a39ffe382f13cb38f7be35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626117
Commit-Queue: Olivier Yiptong <oyiptong@chromium.org>
Auto-Submit: Olivier Yiptong <oyiptong@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845473}
--
wpt-commits: 0b8a55a5131c7c9e104457ec8b929374ab948c64
wpt-pr: 27191
