Commit Graph

698575 Commits

Author SHA1 Message Date
Emilio Cobos Álvarez
f846b9b159 Bug 1098151 - Make empty editable blocks at least one line-height tall. r=jfkthame
Differential Revision: https://phabricator.services.mozilla.com/D68586

--HG--
extra : moz-landing-system : lando
2020-03-30 13:50:04 +00:00
Emilio Cobos Álvarez
675035d9f5 Bug 1625809 - Remove nsIFrame::ContentStatesChanged. r=smaug
The only user is nsFileControlFrame, which can just use the attribute change
callback instead to sync the disabled attribute value with the button.

Syncing tabindex in that attribute callback was wrong since bug 505355.

Differential Revision: https://phabricator.services.mozilla.com/D68740

--HG--
extra : moz-landing-system : lando
2020-03-30 12:58:09 +00:00
Simon Giesecke
df70dae59a Bug 1625871 - InitializedOnce<const T> should be a literal type for literal types T. r=froydnj
Depends on D68758

Differential Revision: https://phabricator.services.mozilla.com/D68759

--HG--
extra : moz-landing-system : lando
2020-03-30 12:27:10 +00:00
Simon Giesecke
b30450b50d Bug 1625869 - Maybe<T> should be trivially destructible for move-only T. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D68758

--HG--
extra : moz-landing-system : lando
2020-03-30 12:26:58 +00:00
Tim Nguyen
6a61b2e4fa Bug 1625681 - Clean up synced tabs sidebar searchbox styling. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D68696

--HG--
extra : moz-landing-system : lando
2020-03-30 13:38:06 +00:00
Tim Nguyen
28cd004d4f Bug 1624488 - Scope dropmarker.css to dropmarker custom element. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D67957

--HG--
extra : moz-landing-system : lando
2020-03-30 13:21:20 +00:00
Alexandre Poirot
238a79003a Bug 1623699 - Add tests against Resources.watch for console messages. r=nchevobbe
This copies assertions from existing actor/front tests in order to be able to later
drop startListeners and getCachedMessages on the console actor.

Differential Revision: https://phabricator.services.mozilla.com/D67531

--HG--
extra : moz-landing-system : lando
2020-03-30 13:15:25 +00:00
Alexandre Poirot
111958713d Bug 1620234 - Use the Resources API for console messages. r=jdescottes,nchevobbe
This demonstrates using the Resources API for the console messages,
using the existing actor methods. It helps proving that this will work against old runtimes.
But the plan is to followup in bug 1620243 so that we implement this code on the server side.
This will help getting rid of this LegacyImplementation code and have a simplier code on the server.

Differential Revision: https://phabricator.services.mozilla.com/D65526

--HG--
extra : moz-landing-system : lando
2020-03-30 13:15:17 +00:00
Alexandre Poirot
f8a471355a Bug 1576624 - Prototype a Resources API. r=jdescottes,nchevobbe
This focus on implementing a client side version of the Resources API.
This helps demonstrate that this API can works against existing and old Firefox runtimes, using existing actor APIs.
A following changeset (bug 1620243) will introduce a server-side implementation, which will help listening to resources early.
And will help getting rid of the LegacyListeners object which is introduced by the next changeset (bug 1620234).

Differential Revision: https://phabricator.services.mozilla.com/D65527

--HG--
extra : moz-landing-system : lando
2020-03-30 13:15:15 +00:00
Mihai Tabara
1bf12577c5 Bug 1621636 - enable Flatpak push to stable for m-r. r=rail
Differential Revision: https://phabricator.services.mozilla.com/D66395

--HG--
extra : moz-landing-system : lando
2020-03-30 13:13:20 +00:00
Johann Hofmann
43f625b74c Bug 1619244 - Rewrite browser_purge_trackers.js in xpcshell. r=ewright
Differential Revision: https://phabricator.services.mozilla.com/D67947

--HG--
extra : moz-landing-system : lando
2020-03-30 12:54:12 +00:00
Daisuke Akatsuka
3e41ac61f3 Bug 1625812: Move the compatibility tab into between Changes and Fonts. r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D68743

--HG--
extra : moz-landing-system : lando
2020-03-30 12:35:39 +00:00
Kartikaya Gupta
7eff2fe35d Bug 1625492 - Avoid null dereference when layers.dump-decision is true. r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D68587

--HG--
extra : moz-landing-system : lando
2020-03-29 21:46:00 +00:00
Dão Gottwald
bb5b482bc6 Bug 1625896 - Rename scrollbox.css to arrowscrollbox.css. r=ntim
Differential Revision: https://phabricator.services.mozilla.com/D68777

--HG--
rename : toolkit/themes/shared/scrollbox.css => toolkit/themes/shared/arrowscrollbox.css
extra : moz-landing-system : lando
2020-03-30 11:49:31 +00:00
Logan Smyth
e1063cc671 Bug 1624507 - Part 7: Simplify lazy service and require getters. r=ochameau
The lazy service function has tons of unused parameters that we might as well
clean up, and the require getter can easily used more shared code for its
implementation.

Differential Revision: https://phabricator.services.mozilla.com/D67982

--HG--
extra : moz-landing-system : lando
2020-03-30 08:24:40 +00:00
Logan Smyth
97e0078b58 Bug 1624507 - Part 6: Avoid lazy getters when unnecessary. r=ochameau
These all look like they were changed to be lazy to allow for features of
WebReplay to swap out the implementations, but now that Replay has been
removed from the codebase, these can be treated the same way other globals are.

Differential Revision: https://phabricator.services.mozilla.com/D67981

--HG--
extra : moz-landing-system : lando
2020-03-30 08:24:28 +00:00
Logan Smyth
0d172217ca Bug 1624507 - Part 5: Make AMD support an opt-in feature of the loader. r=ochameau
Since base-loader's job is to handle this kind of thing, and it already
requires a special case to populate the descriptor anyway, so it seems a lot
easier to provide this as builtin optional feature of base-loader.

Differential Revision: https://phabricator.services.mozilla.com/D67979

--HG--
extra : moz-landing-system : lando
2020-03-30 08:24:05 +00:00
Logan Smyth
f6c04c8106 Bug 1624507 - Part 4: Remove per-module DOMParser and console bindings. r=ochameau
I can't see any reason why these need to be scoped into the per-file target
environment, and they both feel like strange special cases, so might
as well remove them now.

Differential Revision: https://phabricator.services.mozilla.com/D67978

--HG--
extra : moz-landing-system : lando
2020-03-30 08:23:22 +00:00
Logan Smyth
95caced895 Bug 1624507 - Part 3: Remove unused sandboxes property. r=ochameau
This is never used so it seems like there isn't much reason to keep it around.

Differential Revision: https://phabricator.services.mozilla.com/D67977

--HG--
extra : moz-landing-system : lando
2020-03-30 08:23:01 +00:00
Logan Smyth
eda2822847 Bug 1624507 - Part 2: Remove unused Timer module. r=ochameau
This module doesn't appear to ever be used, and we already provide setTimeout
and such as globals so presumable we're using those in the places where we
need functional timers.

Differential Revision: https://phabricator.services.mozilla.com/D67976

--HG--
extra : moz-landing-system : lando
2020-03-30 08:22:54 +00:00
Logan Smyth
3b77bf88b0 Bug 1624507 - Part 1: Remove unused lazyRequire(Module). r=ochameau
These functions don't appear to ever be used by devtools since we instead
use the `loader.lazyRequireGetter` utility.

Differential Revision: https://phabricator.services.mozilla.com/D67975

--HG--
extra : moz-landing-system : lando
2020-03-30 08:22:52 +00:00
Bogdan Tara
37fc52aff0 Backed out changeset 05de83a88c61 (bug 1566780) for devtools failures complaining about browser_net_ws-early-connection.js CLOSED TREE 2020-03-30 14:43:38 +03:00
Karl Tomlinson
9199513a35 Bug 1625446 revert test_audioWorklet_WASM.html and test_audioWorklet_options.html to disabled on beta r=baku
This reverts some of the changes made in
https://hg.mozilla.org/mozilla-central/rev/02f562ee1c81#l3.6

dom.postMessage.sharedArrayBuffer.bypassCOOP_COEP.insecure.enabled is locked to false on beta
https://searchfox.org/mozilla-central/rev/9c6e7500c0015a2c60be7b1b888261d95095ce27/modules/libpref/init/all.js#4973

Differential Revision: https://phabricator.services.mozilla.com/D68744

--HG--
extra : moz-landing-system : lando
2020-03-30 08:45:04 +00:00
Ken VanDine
f377d047a2 Bug 1622282 - extract gnome-3-28-1804 platform snap to be used in the cleanup part r=jlorenzo
Differential Revision: https://phabricator.services.mozilla.com/D67629

--HG--
extra : moz-landing-system : lando
2020-03-30 10:21:03 +00:00
Ken VanDine
866ea7e844 Bug 1622282 - Find files provided by the base and platform snap and ensure they aren't duplicated in this snap r=jlorenzo
Differential Revision: https://phabricator.services.mozilla.com/D66778

--HG--
extra : moz-landing-system : lando
2020-03-30 10:20:48 +00:00
Kishlaya Jaiswal
0ecf3ed767 Bug 1566780 - Added another filter frame type for viewing control frames separately r=Honza
Correcting linter errors

Added new logic for toggling control frames by adding a new control frame check variable and toggle function

Preserve controlFrames option when clearing frames. Changed Control Frames to Control in locale

Correct linter errors

Added a separator between received and control. Changed the dropdown title to reflect control frame state

Changed controlFramesEnabled to showControlFrames

Added a comment about showControlFrames and toggleControlFrames

Differential Revision: https://phabricator.services.mozilla.com/D67849

--HG--
extra : moz-landing-system : lando
2020-03-30 10:18:11 +00:00
Bogdan Tara
e304198a5e Backed out changeset 278b86784e72 (bug 1625727) for LoadInfo related wpt crashes CLOSED TREE 2020-03-30 13:16:44 +03:00
Emilio Cobos Álvarez
c8bd3df8c2 Bug 1625608 - Improve some web-animations error messages. r=birtles
Differential Revision: https://phabricator.services.mozilla.com/D68695

--HG--
extra : moz-landing-system : lando
2020-03-30 09:48:06 +00:00
Andrei Oprea
5f98b09bb3 Bug 1623905 - The CFR button is not minimized when clicking cancel r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D68071

--HG--
extra : moz-landing-system : lando
2020-03-27 13:26:00 +00:00
Mirko Brodesser
edab46f37b Bug 1623858: part 21) Add some const correctness to nsDocumentEncoder::SerializeSelection. r=hsivonen
Depends on D68580

Differential Revision: https://phabricator.services.mozilla.com/D68581

--HG--
extra : moz-landing-system : lando
2020-03-30 08:48:19 +00:00
Mirko Brodesser
4412b5b8cf Bug 1623858: part 20) Assert Selection::NotifyAutoCopy is only called for eNormal Selections. r=hsivonen
Depends on D68579

Differential Revision: https://phabricator.services.mozilla.com/D68580

--HG--
extra : moz-landing-system : lando
2020-03-30 08:48:16 +00:00
Mirko Brodesser
30d9bc74b0 Bug 1623858: part 19) Remove superfluous nsAutoScrollTimer::Init. r=hsivonen
Depends on D68578

Differential Revision: https://phabricator.services.mozilla.com/D68579

--HG--
extra : moz-landing-system : lando
2020-03-30 08:41:52 +00:00
Mirko Brodesser
02491f934f Bug 1623858: part 18) Assert Selection::StopAutoScrollTimer is only called for eNormal Selections. r=hsivonen
Depends on D68577

Differential Revision: https://phabricator.services.mozilla.com/D68578

--HG--
extra : moz-landing-system : lando
2020-03-30 08:39:08 +00:00
Mirko Brodesser
5589f817d9 Bug 1623858: part 17) Assert accessible caret methods in Selection are only called for eNormal Selections. r=hsivonen
Depends on D68576

Differential Revision: https://phabricator.services.mozilla.com/D68577

--HG--
extra : moz-landing-system : lando
2020-03-30 08:36:55 +00:00
Mirko Brodesser
e7cdb1cf10 Bug 1623858: part 16) Annotate nsFrameSelection::HandleTableSelection with [[nodiscard]]. r=hsivonen
Depends on D68575

Differential Revision: https://phabricator.services.mozilla.com/D68576

--HG--
extra : moz-landing-system : lando
2020-03-30 08:35:36 +00:00
Mirko Brodesser
4c2e63fddc Bug 1623858: part 15) Remove some conditions in nsFrameSelection::TakeFocus which are always true. r=hsivonen
Differential Revision: https://phabricator.services.mozilla.com/D68575

--HG--
extra : moz-landing-system : lando
2020-03-30 08:32:42 +00:00
Nicolas Chevobbe
37570fde05 Bug 1625084 - Display content process pid in a more explicit manner. r=ochameau.
This patch changes the Content Processes names from
'Content Process 1234' to 'Content Process (pid 1234)',
which is less confusing for the user.

Differential Revision: https://phabricator.services.mozilla.com/D68328

--HG--
extra : moz-landing-system : lando
2020-03-30 09:08:22 +00:00
Eden Chuang
a56e1226e4 Bug 1623928 - Cu.reportError with 0 innerWindowID should be from chrome context r=baku
Differential Revision: https://phabricator.services.mozilla.com/D68383

--HG--
extra : moz-landing-system : lando
2020-03-30 09:01:06 +00:00
Julian Descottes
33a9959898 Bug 1515008 - Move connection-manager from devtools/shared to devtools/client/shared/remote-debugging r=daisuke
Depends on D68598

Differential Revision: https://phabricator.services.mozilla.com/D68599

--HG--
extra : moz-landing-system : lando
2020-03-30 06:56:39 +00:00
Julian Descottes
1ce70ac1b0 Bug 1515008 - Move adb from devtools/shared to devtools/client/shared/remote-debugging r=daisuke
Differential Revision: https://phabricator.services.mozilla.com/D68598

--HG--
rename : devtools/shared/adb/adb-addon.js => devtools/client/shared/remote-debugging/adb/adb-addon.js
rename : devtools/shared/adb/adb-binary.js => devtools/client/shared/remote-debugging/adb/adb-binary.js
rename : devtools/shared/adb/adb-client.js => devtools/client/shared/remote-debugging/adb/adb-client.js
rename : devtools/shared/adb/adb-device.js => devtools/client/shared/remote-debugging/adb/adb-device.js
rename : devtools/shared/adb/adb-process.js => devtools/client/shared/remote-debugging/adb/adb-process.js
rename : devtools/shared/adb/adb-running-checker.js => devtools/client/shared/remote-debugging/adb/adb-running-checker.js
rename : devtools/shared/adb/adb-runtime.js => devtools/client/shared/remote-debugging/adb/adb-runtime.js
rename : devtools/shared/adb/adb-socket.js => devtools/client/shared/remote-debugging/adb/adb-socket.js
rename : devtools/shared/adb/adb.js => devtools/client/shared/remote-debugging/adb/adb.js
rename : devtools/shared/adb/commands/index.js => devtools/client/shared/remote-debugging/adb/commands/index.js
rename : devtools/shared/adb/commands/list-devices.js => devtools/client/shared/remote-debugging/adb/commands/list-devices.js
rename : devtools/shared/adb/commands/moz.build => devtools/client/shared/remote-debugging/adb/commands/moz.build
rename : devtools/shared/adb/commands/prepare-tcp-connection.js => devtools/client/shared/remote-debugging/adb/commands/prepare-tcp-connection.js
rename : devtools/shared/adb/commands/run-command.js => devtools/client/shared/remote-debugging/adb/commands/run-command.js
rename : devtools/shared/adb/commands/shell.js => devtools/client/shared/remote-debugging/adb/commands/shell.js
rename : devtools/shared/adb/commands/track-devices.js => devtools/client/shared/remote-debugging/adb/commands/track-devices.js
rename : devtools/shared/adb/moz.build => devtools/client/shared/remote-debugging/adb/moz.build
rename : devtools/shared/adb/xpcshell/.eslintrc.js => devtools/client/shared/remote-debugging/adb/xpcshell/.eslintrc.js
rename : devtools/shared/adb/xpcshell/adb.py => devtools/client/shared/remote-debugging/adb/xpcshell/adb.py
rename : devtools/shared/adb/xpcshell/test_adb.js => devtools/client/shared/remote-debugging/adb/xpcshell/test_adb.js
rename : devtools/shared/adb/xpcshell/xpcshell-head.js => devtools/client/shared/remote-debugging/adb/xpcshell/xpcshell-head.js
rename : devtools/shared/adb/xpcshell/xpcshell.ini => devtools/client/shared/remote-debugging/adb/xpcshell/xpcshell.ini
extra : moz-landing-system : lando
2020-03-30 06:56:57 +00:00
Christoph Kerschbaumer
89717542fd Bug 1625727: Remove unnecessary fallback initialization for null loadinfos, r=baku
Differential Revision: https://phabricator.services.mozilla.com/D68716

--HG--
extra : moz-landing-system : lando
2020-03-30 08:45:16 +00:00
Emilio Cobos Álvarez
2153b0cb92 Bug 1625571 - Invalidate canvas background in ImageLoader rather than nsDisplayBackgroundImage. r=tnikkel
This is less error prone and also less code.

Differential Revision: https://phabricator.services.mozilla.com/D68732

--HG--
extra : moz-landing-system : lando
2020-03-30 08:35:34 +00:00
Cosmin Sabou
2db886518c Backed out changeset 848221b2e156 (bug 1620402) for causing several test failures.
CLOSED TREE
2020-03-30 11:35:20 +03:00
Jan de Mooij
34f632706d Bug 1625765 - Add missing OOM check to SrcNoteWriter::writeNote. r=arai
Differential Revision: https://phabricator.services.mozilla.com/D68752

--HG--
extra : moz-landing-system : lando
2020-03-30 07:53:25 +00:00
Florin Strugariu
2ecf86537d Bug 1624114 - Intermittent visual-metrics failure: ZeroDivisionError: float division by zero r=tarek,sparky,barret
Differential Revision: https://phabricator.services.mozilla.com/D68186

--HG--
extra : moz-landing-system : lando
2020-03-30 07:42:29 +00:00
Sebastian Streich
e23cc2cd7f Bug 1620402 - Refactor nsPermissionManager.cpp r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D65606

--HG--
extra : moz-landing-system : lando
2020-03-30 07:34:37 +00:00
Florin Strugariu
0faac1b540 Bug 1624813 - Update raptor cold tests to mitm 5.0.1 r=perftest-reviewers,sparky
Differential Revision: https://phabricator.services.mozilla.com/D68574

--HG--
extra : moz-landing-system : lando
2020-03-27 15:21:22 +00:00
Makoto Kato
fa2df28a49 Bug 1618754 - Part 2. Unnecessary to use equalsIgnoreCase for inputmode. r=geckoview-reviewers,agi
`inputmode` is lower case except to `mozAwesomebar`. So it is unnecessary to
use `equalsIgnoreCase`.

Also, `mozAwesomebar` is for `inputmode`, not `type`. So this changeset has
this fix.

Differential Revision: https://phabricator.services.mozilla.com/D68332

--HG--
extra : moz-landing-system : lando
2020-03-26 18:16:38 +00:00
Makoto Kato
86298c9983 Bug 1618754 - Part 1. Support inputmode=none to hide software keyboard. r=geckoview-reviewers,snorp
`inputmode=none` has to close software keyboard. `inputmode` value is lower
case except to `mozAwesomebar` by bug 1618763, so we don't have to use
`equalsIgnoreCase` for `inputmode`.

Differential Revision: https://phabricator.services.mozilla.com/D67459

--HG--
extra : moz-landing-system : lando
2020-03-26 18:22:47 +00:00
Dickson Tan
d684f54703 Bug 1545727 - make the JSON tree viewer more accessible. r=Honza
Make the JSON tree view more accessible.

1. Automatically set focus to the first node on initial focus. Previously, the only way to interact with the tree view through the keyboard was to click on a node so that subsequent key presses would register.
2. Fix inaccurate aria-level and aria-expanded attributes causing confusing announcements for screen reader users.
3. Previously, pressing left arrow the first time on a leaf child node would not move focus to its parent, but subsequent tries would work. This has been fixed.
4. Implement first-letter navigation for quick movement via keyboard.

Differential Revision: https://phabricator.services.mozilla.com/D28274

--HG--
extra : moz-landing-system : lando
2020-03-29 09:32:58 +00:00