Commit Graph

656029 Commits

Author SHA1 Message Date
Gijs Kruitbosch
fa4c2a54c9 Bug 1519434 - only allow perma-enabling non-flash plugins, r=jmathies,aswan
Differential Revision: https://phabricator.services.mozilla.com/D34213

--HG--
extra : moz-landing-system : lando
2019-06-12 18:49:42 +00:00
Gijs Kruitbosch
7a17996536 Bug 1519434 - remove plugin click to play pref as running without it won't make sense anymore, r=aswan
Differential Revision: https://phabricator.services.mozilla.com/D34212

--HG--
extra : moz-landing-system : lando
2019-06-12 18:49:30 +00:00
Olli Pettay
05d684ebd3 Bug 1558546, ensure range element has a frame before starting drag operation, r=hsivonen
This should be the minimal patch to fix the issue (should be safe for branches too).

Reusing an existing mouse/touch test for the crash testing.

Differential Revision: https://phabricator.services.mozilla.com/D34717

--HG--
extra : moz-landing-system : lando
2019-06-12 15:53:48 +00:00
Luca Greco
51f4010b77 Bug 1558305 - Fix sideload and file-url install_method values in AbuseReporter.getReportData method. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D34414

--HG--
extra : moz-landing-system : lando
2019-06-12 18:24:39 +00:00
Iain Ireland
2b3a84dee5 Bug 1401624: Part 7: Update gdb pretty-printer r=sfink
This is a bit gross, but it passes all the tests that were not already failing.

Differential Revision: https://phabricator.services.mozilla.com/D29057

--HG--
extra : moz-landing-system : lando
2019-06-12 17:51:02 +00:00
Iain Ireland
b1d0f80ddf Bug 1401624: Part 6: Update Rust bindings r=fitzgen
We are changing the representation of values on 64-bit. Part 5 of this patch stack has more details on the changes.

Differential Revision: https://phabricator.services.mozilla.com/D29056

--HG--
extra : moz-landing-system : lando
2019-06-12 17:51:04 +00:00
Iain Ireland
b4d7776503 Bug 1401624: Part 5: Change Value representation r=tcampbell,jwalden
This patch is where the actual changes to our value representation happens. A few notes:

1. We did some weird macro tricks to work around a GCC bug with enums in bitfields. Those bitfields were only useful for poking at values in gdb, and the trick no longer worked with object-biased nanboxing, so I removed it. I also got rid of asDouble_, because it's no longer possible to read the double value right out of the enum without unboxing.

2. In the previous boxing scheme, there was a mechanical conversion between a JSValueType and a JSValueTag. That's no longer true, which is why the big conversion switches exist.

3. Waldo, you were included as a reviewer specifically to look at Value.h and make sure that our gross bit twiddling is just gross and not undefined.

Differential Revision: https://phabricator.services.mozilla.com/D29055

--HG--
extra : moz-landing-system : lando
2019-06-12 17:51:06 +00:00
Iain Ireland
fad6a2fe27 Bug 1401624: Part 4: Add PushBoxed for float registers r=mgaudet
Similarly to Part 3: when we push a double value, we currently don't distinguish between pushing a boxed double and pushing an unboxed double. This has to change for object-biased NaN-boxing.

Differential Revision: https://phabricator.services.mozilla.com/D29054

--HG--
extra : moz-landing-system : lando
2019-06-12 17:50:54 +00:00
Iain Ireland
6a104f733c Bug 1401624: Part 3: Convert store/loadDouble to box/unboxDouble r=tcampbell,mgaudet
In the past, we have been somewhat sloppy when storing / loading double values, because a boxed double and an unboxed double had the same representation. This is no longer true with object-biased NaN-boxing. This patch goes through and cleans up those cases.

Differential Revision: https://phabricator.services.mozilla.com/D29053

--HG--
extra : moz-landing-system : lando
2019-06-12 18:30:12 +00:00
Iain Ireland
6eb2847903 Bug 1401624: Part 2: Improve comments in TraceDataRelocations r=sfink
It took me a while to convince myself that this code was still okay for 0-tagged object Values. Adding a comment to make it clearer for future readers (and in the hope that a reviewer will notice my mistake if I am wrong.)

Differential Revision: https://phabricator.services.mozilla.com/D29052

--HG--
extra : moz-landing-system : lando
2019-06-12 17:50:58 +00:00
Iain Ireland
ee009dec33 Bug 1401624: Part 1: Stop zero-initializing Value arrays r=jandem
Using the old NaN-boxing scheme, a zero-initialized value was a double, which was safe to trace. Under the new scheme, it is a null object pointer.

This patch manually initializes Value arrays to Undefined.

Differential Revision: https://phabricator.services.mozilla.com/D29051

--HG--
extra : moz-landing-system : lando
2019-06-12 17:51:00 +00:00
Andreas Pehrson
a410e8138e Bug 1554699 - Await play promise in case timeupdate events happened before it resolved. r=jib
Since the media element is playing directly after play(), not waiting for the
readyState to advance before play()ing could leave the play promise from play()
unhandled until cleanup, when it would be rejected by the load algorithm.

This would happen if a timeupdate event is raised before the first frame comes
in to update the readyState, which resolves the play promise.

Waiting for the readyState to advance before play()ing seems like the cleanest
fix wrt testing currentTime after the first timeupdate event.

Depends on D33655

Differential Revision: https://phabricator.services.mozilla.com/D34686

--HG--
extra : moz-landing-system : lando
2019-06-12 18:28:12 +00:00
Andreas Pehrson
b6db26bf80 Bug 1554699 - The loop attribute should not have any effect on a media element playing a MediaStream. r=jib
Differential Revision: https://phabricator.services.mozilla.com/D33655

--HG--
extra : moz-landing-system : lando
2019-06-12 08:50:57 +00:00
Andreas Pehrson
6571c8612d Bug 1554699 - Don't fire "timeupdate" in PlayInternal as it's against spec, v2. r=jya
This FireTimeUpdate(false) dates back to bug 611994. Perhaps it was spec
compliant back in the day, but it surely isn't now.

Differential Revision: https://phabricator.services.mozilla.com/D33651

--HG--
extra : moz-landing-system : lando
2019-06-11 11:49:35 +00:00
Andreas Pehrson
59ee4efe41 Bug 1554699 - Don't fire "timeupdate" in PlayInternal as it's against spec. r=jya,alwu
Bug 1279865 introduced this under the premise of
"Run TimeMarchesOn() at the beginning of play.", but it did a bit too much.

This makes us spec compliant for this particular case again.

Differential Revision: https://phabricator.services.mozilla.com/D33650

--HG--
extra : moz-landing-system : lando
2019-06-11 11:49:26 +00:00
Andreas Pehrson
187fd1801a Bug 1554699 - Report real duration after playing a MediaStream ended. r=jib
Differential Revision: https://phabricator.services.mozilla.com/D33649

--HG--
extra : moz-landing-system : lando
2019-06-11 11:49:17 +00:00
Andreas Pehrson
8dcdeb0011 Bug 1554699 - Ignore setting currentTime synchronously with assigning a MediaStream. r=jib
Differential Revision: https://phabricator.services.mozilla.com/D33648

--HG--
extra : moz-landing-system : lando
2019-06-11 11:49:07 +00:00
Andreas Pehrson
4bad2d59ff Bug 1554699 - Split up and elaborate on MediaStream-MediaElement-srcObject.https.html. r=jib
This does several things:
- Split the test up, so one assert doesn't fail the entire test suite
- Check preload, playbackRate and defaultPlaybackRate attributes after unsetting srcObject
- Check setting currentTime before loading (default playback start position),
  and after loading (official playback position) separately
- Check that duration is changed to a real number on ending
- Check that HAVE_ENOUGH_DATA is reached by only assigning srcObject
- And other minor things and formatting

Differential Revision: https://phabricator.services.mozilla.com/D33647

--HG--
extra : moz-landing-system : lando
2019-06-11 11:48:51 +00:00
Andreas Pehrson
0966599b32 Bug 1554699 - Update mochitest framework expectations. r=jib
Differential Revision: https://phabricator.services.mozilla.com/D33098

--HG--
extra : moz-landing-system : lando
2019-06-11 11:48:42 +00:00
Andreas Pehrson
951b7c244c Bug 1554699 - Update WPT expectations. r=jib
Differential Revision: https://phabricator.services.mozilla.com/D33097

--HG--
extra : moz-landing-system : lando
2019-06-11 11:48:33 +00:00
Andreas Pehrson
0f0c5a8595 Bug 1554699 - HTMLMediaElement.preload: Ignore setting and always get "none" when playing a MediaStream. r=jib
Differential Revision: https://phabricator.services.mozilla.com/D33096

--HG--
extra : moz-landing-system : lando
2019-06-11 11:48:21 +00:00
Andreas Pehrson
81b4437bf9 Bug 1554699 - HTMLMediaElement.playbackRate/defaultPlaybackRate: Ignore setting and always get 1.0 when playing a MediaStream. r=jib
Differential Revision: https://phabricator.services.mozilla.com/D33095

--HG--
extra : moz-landing-system : lando
2019-06-11 11:48:14 +00:00
Gijs Kruitbosch
a9c77b7f11 Bug 1553540 - switch disk information collection in system info off the main thread, r=aklotz,chutten,jya,arai
Differential Revision: https://phabricator.services.mozilla.com/D34417

--HG--
extra : moz-landing-system : lando
2019-06-12 15:56:59 +00:00
Drew Willcoxon
747c25b6dc Bug 1557555 - Quantumbar: Autofill only when text is entered, never when it's removed (e.g., on backspace). r=mak
Autofill only when the user enters text -- i.e., when event.data in _on_input is non-empty. That allows us to simplify autofill quite a bit. We can get rid of the edit action listener that we previously used to detect selection deletion, and we also don't need the prefix check (lastSearchStartsWithNewSearch).

Therefore this fixes both this bug (bug 1557555) and bug 1545731/719888.

This makes one other change: We can check event.inputType in _on_input to tell whether the user is pasting, rather than keeping a _valueIsPasted property that we set in _on_paste.

Differential Revision: https://phabricator.services.mozilla.com/D34645

--HG--
extra : moz-landing-system : lando
2019-06-12 17:43:18 +00:00
Ting-Yu Lin
0702152462 Bug 1549867 - Add a crashtest. r=jfkthame
This test no longer crashes after fixing bug 1524431.

Differential Revision: https://phabricator.services.mozilla.com/D34221

--HG--
extra : moz-landing-system : lando
2019-06-11 16:23:29 +00:00
Zibi Braniecki
77b7b9399f Bug 1558306 - Clean up app-startup category/topics for readability. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D34573

--HG--
extra : moz-landing-system : lando
2019-06-12 17:50:13 +00:00
Zibi Braniecki
97b22563e5 Bug 1558306 - Switch L10nRegistry initialization to happen right before the first content process gets created. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D34572

--HG--
extra : moz-landing-system : lando
2019-06-12 17:49:56 +00:00
Boris Chiou
d6e5792aff Bug 1542064 - Add MOZ_DBG support for AnimationValue. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D33357

--HG--
extra : moz-landing-system : lando
2019-06-12 18:14:18 +00:00
Edwin Gao
2706d1d19e Bug 1555454 - migrate awsy over to macosx1014 r=gbrown
Changes:
- migrate awsy and marionette-media to macosx1014

Differential Revision: https://phabricator.services.mozilla.com/D34644

--HG--
extra : moz-landing-system : lando
2019-06-12 14:24:28 +00:00
Andreea Pavel
9eda2afac1 Backed out 7 changesets (bug 1401624) for build bustages at MacroAssembler-inl.h on a CLOSED TREE
Backed out changeset 46030572ffde (bug 1401624)
Backed out changeset bccc5a509ebe (bug 1401624)
Backed out changeset 1a488ead5ac5 (bug 1401624)
Backed out changeset caac1da9ae80 (bug 1401624)
Backed out changeset 8f02092ab0b4 (bug 1401624)
Backed out changeset 90a104231405 (bug 1401624)
Backed out changeset d5d97222de6f (bug 1401624)
2019-06-12 20:47:42 +03:00
Andreea Pavel
af8aab10a0 Backed out 2 changesets (bug 1550137) for perma-failing bug 1553196 on a CLOSED TREE
Backed out changeset e6cc0fd6e665 (bug 1550137)
Backed out changeset 4c8faa218f64 (bug 1550137)
2019-06-12 20:43:06 +03:00
Andreea Pavel
1adae3f54d Backed out 2 changesets (bug 1558306) on request on a CLOSED TREE
Backed out changeset a09644bb0e6e (bug 1558306)
Backed out changeset 7832d4ed2c61 (bug 1558306)
2019-06-12 20:40:00 +03:00
Brendan Dahl
da359a0016 Bug 1558686 - Enable XUL default button behavior for any doc that allows XUL. r=Jamie
Fixes test 'accessible/tests/mochitest/relations/test_general.xul' when
loaded as XHTML.

Differential Revision: https://phabricator.services.mozilla.com/D34655

--HG--
extra : moz-landing-system : lando
2019-06-12 03:16:33 +00:00
Iain Ireland
d3868c05b8 Bug 1401624: Part 7: Update gdb pretty-printer r=sfink
This is a bit gross, but it passes all the tests that were not already failing.

Differential Revision: https://phabricator.services.mozilla.com/D29057

--HG--
extra : moz-landing-system : lando
2019-06-03 15:57:55 +00:00
Iain Ireland
40460c1e69 Bug 1401624: Part 6: Update Rust bindings r=fitzgen
We are changing the representation of values on 64-bit. Part 5 of this patch stack has more details on the changes.

Differential Revision: https://phabricator.services.mozilla.com/D29056

--HG--
extra : moz-landing-system : lando
2019-06-03 15:57:43 +00:00
Iain Ireland
ae7d6752b5 Bug 1401624: Part 5: Change Value representation r=tcampbell,jwalden
This patch is where the actual changes to our value representation happens. A few notes:

1. We did some weird macro tricks to work around a GCC bug with enums in bitfields. Those bitfields were only useful for poking at values in gdb, and the trick no longer worked with object-biased nanboxing, so I removed it. I also got rid of asDouble_, because it's no longer possible to read the double value right out of the enum without unboxing.

2. In the previous boxing scheme, there was a mechanical conversion between a JSValueType and a JSValueTag. That's no longer true, which is why the big conversion switches exist.

3. Waldo, you were included as a reviewer specifically to look at Value.h and make sure that our gross bit twiddling is just gross and not undefined.

Differential Revision: https://phabricator.services.mozilla.com/D29055

--HG--
extra : moz-landing-system : lando
2019-06-12 15:56:52 +00:00
Iain Ireland
21a6ecba07 Bug 1401624: Part 4: Add PushBoxed for float registers r=mgaudet
Similarly to Part 3: when we push a double value, we currently don't distinguish between pushing a boxed double and pushing an unboxed double. This has to change for object-biased NaN-boxing.

Differential Revision: https://phabricator.services.mozilla.com/D29054

--HG--
extra : moz-landing-system : lando
2019-06-03 15:57:23 +00:00
Iain Ireland
d0af63e506 Bug 1401624: Part 3: Convert store/loadDouble to box/unboxDouble r=mgaudet
In the past, we have been somewhat sloppy when storing / loading double values, because a boxed double and an unboxed double had the same representation. This is no longer true with object-biased NaN-boxing. This patch goes through and cleans up those cases.

Differential Revision: https://phabricator.services.mozilla.com/D29053

--HG--
extra : moz-landing-system : lando
2019-06-03 16:46:25 +00:00
Iain Ireland
8589b1e1ba Bug 1401624: Part 2: Improve comments in TraceDataRelocations r=sfink
It took me a while to convince myself that this code was still okay for 0-tagged object Values. Adding a comment to make it clearer for future readers (and in the hope that a reviewer will notice my mistake if I am wrong.)

Differential Revision: https://phabricator.services.mozilla.com/D29052

--HG--
extra : moz-landing-system : lando
2019-06-03 15:56:58 +00:00
Iain Ireland
3454eb68f3 Bug 1401624: Part 1: Stop zero-initializing Value arrays r=jandem
Using the old NaN-boxing scheme, a zero-initialized value was a double, which was safe to trace. Under the new scheme, it is a null object pointer.

This patch manually initializes Value arrays to Undefined.

Differential Revision: https://phabricator.services.mozilla.com/D29051

--HG--
extra : moz-landing-system : lando
2019-06-03 15:56:48 +00:00
Aaron Klotz
fc89fe9925 Bug 1532470: Part 5 - Update TestDllInterceptor to test new ARM64 capabilities; r=handyman
Update the tests for ARM64 to include additional functions that are now
supported via 4 byte patching.

We also convert the TEST macros to accept the DLL names as strings, as this
works better with clang-format.

Differential Revision: https://phabricator.services.mozilla.com/D32209

--HG--
extra : moz-landing-system : lando
2019-06-12 01:11:37 +00:00
Aaron Klotz
e311b07d92 Bug 1532470: Part 4 - Add 4-byte patching to ARM64 interceptor; r=handyman
This patch modifies arm64 so that detours are peformed via two passes:
1. The first pass uses a null trampoline to count how many bytes are available
   for patching the original function.
2. If we have >= 16 bytes to patch, we reuse existing trampoline space. If we
   have less than 16 bytes to patch, we reserve trampoline space within 128MB
   of the function, allowing for a 4 byte patch.
3. Then we recurse, this time using a real trampoline.

Note that we still do a single-pass on x86(-64).

Differential Revision: https://phabricator.services.mozilla.com/D32193

--HG--
extra : moz-landing-system : lando
2019-06-12 01:11:36 +00:00
Aaron Klotz
4460a190f9 Bug 1532470: Part 3 - Modify trampolines to support trampoline pools and null trampolines; r=handyman
A null trampoline is just a trampoline that is not backed by a VM reservation.
These are used for tracking the number of bytes that are needed to make a patch.

This patch also contains the changes needed to work with TrampolinePool.

Differential Revision: https://phabricator.services.mozilla.com/D32192

--HG--
extra : moz-landing-system : lando
2019-06-12 01:11:36 +00:00
Aaron Klotz
74b57fa236 Bug 1532470: Part 2 - Modify VM sharing policies to use trampoline pools and support the ability to specify a desired memory range when reserving address space; r=handyman
VMSharingPolicyShared needs to become much smarter. This patch modifies that
policy to track different VM reservations and reuse them whenever possible.

We add TrampolinePools to abstract away the differences between VM policies
with respect to the caller who is making the reservation.

Differential Revision: https://phabricator.services.mozilla.com/D32191

--HG--
extra : moz-landing-system : lando
2019-06-12 01:11:36 +00:00
Aaron Klotz
2c8e5e76b3 Bug 1532470: Part 1 - Add ability to specify desired memory range when reserving memory; r=handyman
In order to support 4-byte patches on ARM64, we need to be able to reserve
trampoline space within +/- 128 MB of the beginning of a function.

These changes allow us to make such reservations using OS APIs when
available.

Differential Revision: https://phabricator.services.mozilla.com/D32190

--HG--
extra : moz-landing-system : lando
2019-06-12 17:27:16 +00:00
Michael Kaply
1e222b2b52 Bug 1558499 - DownloadDirectory policy should prevent selecting "ask every time" r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D34585

--HG--
extra : moz-landing-system : lando
2019-06-12 16:27:20 +00:00
Dan Minor
f1e1443538 Bug 1558524 - Fix handling of incoming mDNS candidates; r=bwc
This must have been broken while addressing review comments in Bug 1548841,
the first commit has it right and the last commit in the series breaks it.
Since we don't yet generate mDNS addresses in Firefox, the unit tests would not
catch this problem, and interoperability with other browsers would continue to
work due to peer reflex candidates.

We will have test coverage for this once we land generating our own mDNS
candidates. ICE will fail in the mochitests if we don't support resolving
mDNS addresses properly, which is how I discovered this bug.

Differential Revision: https://phabricator.services.mozilla.com/D34579

--HG--
extra : moz-landing-system : lando
2019-06-12 17:21:15 +00:00
Alexander Surkov
861987223e Bug 1557869 - do not deinitialize searchbar internals if the searchbar was not yet initialized r=mak
Differential Revision: https://phabricator.services.mozilla.com/D34368

--HG--
extra : moz-landing-system : lando
2019-06-12 08:21:38 +00:00
Andrew Swan
c70deb1b4b Bug 1540368 Fix XPIDatabase migration when skipping schema versions r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D34424

--HG--
extra : moz-landing-system : lando
2019-06-12 16:56:04 +00:00
Kartikaya Gupta
1cccbb6069 Bug 1557970 - Put the root metadata on the zoom container if there is one, for the WR codepath. r=botond
Same fix as in bug 1553045, but for the WebRender codepath.

Differential Revision: https://phabricator.services.mozilla.com/D34626

--HG--
extra : moz-landing-system : lando
2019-06-12 16:51:22 +00:00