I used three lines instead of two because in my testing the space above and below the Sign In button allowed for some extra text to be shown without strecthing out of the container. I would prefer to err on the side of showing the full text instead of just the elided text since we cannot add a tooltip (title attribute) without changing the FTL key.
Differential Revision: https://phabricator.services.mozilla.com/D49014
--HG--
extra : moz-landing-system : lando
The crashtest contains an absolute positioning <dialog> multicol
container. If it is fragmented, we end up having a very wrong frame
tree.
Differential Revision: https://phabricator.services.mozilla.com/D49210
--HG--
extra : moz-landing-system : lando
Currently when checking if a window supports protected media it's up to the
caller interacting with a BrowserChild to check if a response is already
cached, to perform the check if needed, and to then set the cached response if a
call was made. This patch moves that logic internal to Browser child so that
callers need to only worry about interacting with a single function.
Differential Revision: https://phabricator.services.mozilla.com/D48585
--HG--
extra : moz-landing-system : lando
This test was originally written to test HTTPResponseProcessSelection before it
was hooked up into the process switch machinery. It hooks into some parts of the
process switch process which should probably be removed in the future (such as
overriding the child listener component registration), and is broken under
fission anyway.
Differential Revision: https://phabricator.services.mozilla.com/D47313
--HG--
extra : moz-landing-system : lando
We have the `LauncherRegistryInfo` class to check the launcher process was
launched successfully on Windows by comparing the timestamps in the registry
when each process was launched.
The problem was when the process is launched from an elevated process, we
relaunch a new launcher process via shell after we updated the launcher's
timestamp. As a result, `LauncherRegistryInfo` unexpectedly disabled the
launcher process even though there was nothing wrong.
A proposed fix is to introduce delay-write to the `LauncherRegistryInfo`. With
this, `LauncherRegistryInfo::Check` modifies only the image timestamp. To update
the launcher/browser timestamps, we need to call `LauncherRegistryInfo::Commit`.
When we ask shell to relaunch a new process, we hold back commit, delegating it
to the new process.
There is another consideration needed. If something fails during `LauncherMain`,
we call `DisableDueToFailure()` to disable the launcher until the image timestamp
is changed. In such a case, we should not change the stored timestamps even
though commit is attempted. The problem is we use a different instance to call
`DisableDueToFailure()` in `HandleLauncherError`. To deal with this design,
`LauncherRegistryInfo` has a static boolean to indicate disablement happens or not.
Differential Revision: https://phabricator.services.mozilla.com/D44928
--HG--
extra : moz-landing-system : lando
From https://drafts.csswg.org/css-overflow/#overflow-propagation:
> UAs must apply the overflow-* values set on the root element to the viewport.
> However, when the root element is an [HTML] html element (including XML syntax
> for HTML) whose overflow value is visible (in both axes), and that element has
> a body element as a child, user agents must instead apply the overflow-*
> values of the first such child element to the viewport. The element from which
> the value is propagated must then have a used overflow value of visible.
This was out of sync with Document::IsScrollingElement, which implements the
right thing.
Differential Revision: https://phabricator.services.mozilla.com/D49196
--HG--
extra : moz-landing-system : lando
Automatic update from web-platform-tests
Add webkitgtk_minibrowser runs to taskcluster daily. (#19466)
This is testing with the stable channel for now,
beta or nightly channels may be integrated later.
It uses a different docker image on taskcluster that
is currently configured with the last stable version
of WebKitGTK with experimental features enabled.
When the test start in taskcluster the browser will be installed
from the required channel.
Enable at run-time on webkitgtk_minibrowser some
features that are disabled by default.
Ensure also that the required --host=127.0.0.1
argument when running in docker is automatically
passed to the webdriver by the wpt runner.
--
wpt-commits: 9f0aff8885b01a38dcce738c02c58bd66300a25d
wpt-pr: 19466
Automatic update from web-platform-tests
[Contacts] Update implementation to match spec changes.
- Expose the `address` property and place it behind a flag.
- Add & implement the getProperties method.
Change-Id: If9bbebde6b8d076fd48b0b8a3584181e40adc1d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835621
Reviewed-by: Stephen White <senorblanco@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702810}
--
wpt-commits: a18270ee5ec0f752d7116ce14204bff3e6b7ec17
wpt-pr: 19469
Automatic update from web-platform-tests
[css-masking] Parse mask shorthand (#19346)
Test parsing of the components of the 'mask' shorthand.
https://www.w3.org/TR/css-masking-1/#the-mask
Firefox rejects "none margin-box", otherwise tests pass in Firefox.
--
wpt-commits: 04c6f30bcca263bb2e86e94125f2aaa36e5b2e7b
wpt-pr: 19346
Automatic update from web-platform-tests
Service worker: Add self.serviceWorker to ServiceWorkerGlobalScope
- In the previous code, the expiration time was set to null
so that remaining_timeout() was negative during initial script
evaluation so that calling self.serviceWorker.postMessage() would fail.
This CL sets max_request_expiration_time properly
in ServiceWorkerVersion::StartWorkerInternal().
- Add and fix unittests about expiration time.
- Fix the expected.txt properly.
- In spec, service worker's initial state should be parsed.
https://w3c.github.io/ServiceWorker/#service-worker-concept
Link to the Chrome Platform Status: https://chromestatus.com/feature/6678900060979200
Bug: 977496
Change-Id: I4f8368e165fb84304b49519ed43d7b21d5ec756d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819091
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Yuta Kasai <yutakasai@google.com>
Cr-Commit-Position: refs/heads/master@{#702788}
--
wpt-commits: 8561e5223c46c4a47f1fef1fe0b2b18ea7341d19
wpt-pr: 19246
Automatic update from web-platform-tests
Service Worker: Fetch event added asynchronously doesn't throw.
Based on the spec (https://github.com/whatwg/dom/pull/653),
addEventListener after the first evaluation of the Service
worker script should not throw.
Change-Id: I46af276a67e021cf277a98195bf5c04583ad0b0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838376
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Daniel Soromou <fosoromo@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#702753}
--
wpt-commits: 42efecfdb246ea0f22b5a82f5c13659894de3d72
wpt-pr: 19496
Automatic update from web-platform-tests
Convert VRService client to use BrowserInterfaceBroker
This change converts VRService mojom interface client in blink
to use BrowserInterfaceBroker, and converts VRService{Ptr, Request}
in chrome, content and blink to the new Mojo type.
Bug: 936482, 955171, 978694
Change-Id: Ib2d982ea3402c570c825e2b55d7aec2c77b2d8c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828717
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702732}
--
wpt-commits: c5b16519bfdc8e9c849a30f93bd26ab0dc05a2b2
wpt-pr: 19363
Automatic update from web-platform-tests
[LayoutNG] Fix bidi reordering of lines with empty inline boxes
This patch fixes bidi reordering sometimes confused by empty
inline boxes.
These items do not have resolved bidi levels. Before this
patch, |NGInlineLayoutAlgorithm| reordered ignoring such
items. This patch changes it to assign bidi levels to such
items by copying from adjacent items and let reordering to
handle them.
Bug: 1010662, 1010641, 998872
Change-Id: I5d074143970b83b64bddbb83cd03b17551e3f521
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837435
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Auto-Submit: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702526}
--
wpt-commits: 7cbaaf651d784a5c90fde0ff0b1aa6c029c5f2f3
wpt-pr: 19491
Automatic update from web-platform-tests
[LayoutNG] Fix clusterfuzz crash
Using empty Optional<MinMax> to indicate that MinMax value
should not matter caused trouble with ng_length_utils
ResolveInlineLengthInternal, when max-width was fit-content.
Use MinMax(0, LayoutUnitMax) to indicate intrinsic size does
not matter instead. It accomplishes the same goal, computed
size does not get clamped by intrinsic.
I've also tested running it with width:max-content out of
fear that we might end up with too wide OOF, but that did
not happen.
Bug: 1010798
Change-Id: Ife11b3d9637be91cc0648b7f8485af51f07108bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837118
Commit-Queue: Aleks Totic <atotic@chromium.org>
Auto-Submit: Aleks Totic <atotic@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702525}
--
wpt-commits: baf914481d76b25d7d054a23564d5b5418dd9f8b
wpt-pr: 19487
Automatic update from web-platform-tests
[LayoutNG] Clear layout results when the layout wasn't successful.
Today we can end up in a state where the layout result cache for a
LayoutBox contains a fragment tree which doesn't match the layout tree
state.
This occurs when we "abort" layout, i.e.
1) during the first pass children are positioned at a particular offset
2) a parent aborts layout due to resolving a BFC offset
3) the parent hits the layout result cache which has children at a
different offset
Bug: 1003558
Change-Id: Iabc5dfefd74c517222ec435cea376ad000a0372f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821674
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702507}
--
wpt-commits: eac401e3df87f17e49b38ec2f935fd1177139e23
wpt-pr: 19257
