Commit Graph

914646 Commits

Author SHA1 Message Date
David Grogan
fbea0c2413 Bug 1893347 [wpt PR 45896] - [css-flex] Include gaps in intrinsic sizes for column-wrap flexboxes, a=testonly
Automatic update from web-platform-tests
[css-flex] Include gaps in intrinsic sizes for column-wrap flexboxes

The intrinsic sizing code borrows PlaceFlexItems from Layout, but
PlaceFlexItems doesn't handle gaps, AlignFlexLines does. We don't want
to bring all of AlignFlexLines into intrinsic sizing, so just add gaps
manually.

Fixed: 335328452
Change-Id: Ic97b04ab22766a894299a3b74d0feea3734041fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486047
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292562}

--

wpt-commits: 08418af6de2abeebc92b68bb423997ed3ba81029
wpt-pr: 45896
2024-04-30 08:00:47 +00:00
Philip Jägenstedt
862ea21530 Bug 1893391 [wpt PR 45904] - Map constructed stylesheet tests to web-features, a=testonly
Automatic update from web-platform-tests
Map constructed stylesheet tests to web-features (#45904)

--

wpt-commits: c6bff7eac002f08561f96e191272d85e0733c4f6
wpt-pr: 45904
2024-04-30 08:00:46 +00:00
Francois Pierre Doray
2b21218950 Bug 1893513 [wpt PR 45914] - Revert "Reland "LoAF: Use document character position for inline scripts"", a=testonly
Automatic update from web-platform-tests
Revert "Reland "LoAF: Use document character position for inline scripts""

This reverts commit 277fb55a65900d9934b870d0a8d6d3f0938d2314.

Reason for revert: https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20MSAN/26595/overview

Original change's description:
> Reland "LoAF: Use document character position for inline scripts"
>
> This is a reland of commit af30ee5c327deebfdcfa8830e3ebcb501f9afdf1
>
> Reinforced some of the tests to fight the flakiness that caused the
> revert.
>
> Original change's description:
> > LoAF: Use document character position for inline scripts
> >
> > This applies to classic/module script blocks and event content
> > attributes.
> >
> > Bug: 328209286
> > Change-Id: Id11e0a9324c529925b11b950d73ed4491410f96d
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5425010
> > Reviewed-by: Michal Mocny <mmocny@chromium.org>
> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> > Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1291353}
>
> Bug: 328209286
> Change-Id: I322605134e2f91bba555aeb242d322cd2b15033b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5488076
> Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1292360}

Bug: 328209286
Change-Id: Id7440326d6bb300207cae63ba23d767f94713249
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490144
Owners-Override: Francois Pierre Doray <fdoray@chromium.org>
Auto-Submit: Francois Pierre Doray <fdoray@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Francois Pierre Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292539}

--

wpt-commits: c6e53bbafe6dc825c56cd07c2112263c5eea55c7
wpt-pr: 45914
2024-04-30 08:00:45 +00:00
Philip Jägenstedt
c1a46392b0 Bug 1893283 [wpt PR 45887] - Move a prefers-color-scheme test to css/mediaqueries/, a=testonly
Automatic update from web-platform-tests
Move a prefers-color-scheme test to css/mediaqueries/ (#45887)

* Move a prefers-color-scheme test to css/mediaqueries/

Use the prefers-color-scheme.svg already in the target directory, and
adapt the test to use the blue/purple colors from that.

* Update prefers-color-scheme-svg-as-image-ref.html
--

wpt-commits: 4f1737843b28b72a0004133e6991a9741bca9b69
wpt-pr: 45887
2024-04-30 08:00:44 +00:00
Henri Sivonen
2655180348 Bug 1882209 - Update encoding_rs to 0.8.34 to deal with rustc changes. r=glandium,supply-chain-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D207167
2024-04-30 07:29:44 +00:00
Mike Hommey
2e05ea66d4 Bug 1890935 - Bump the minimum version of Rust to 1.76. r=firefox-build-system-reviewers,sergesanspaille
Differential Revision: https://phabricator.services.mozilla.com/D207239
2024-04-30 07:29:43 +00:00
acseh
1218263560 Backed out changeset b2046b45aca1 (bug 1890838) for causing lint failures on nav_graph.xml CLOSED TREE 2024-04-30 10:35:07 +03:00
Jon Coppeard
584084b993 Bug 1892912 - Part 4: Extend weak map checks to cover all maps, not just ObjectWeakMap r=sfink
Differential Revision: https://phabricator.services.mozilla.com/D208873
2024-04-30 07:22:25 +00:00
Jon Coppeard
79f45fb9e8 Bug 1892912 - Part 3: Check GC things in system maps have the expected zone r=sfink
Getting this wrong could result pointers to moved GC things not being updated.

Differential Revision: https://phabricator.services.mozilla.com/D208872
2024-04-30 07:22:24 +00:00
Christian Holler
6968e11edb Bug 1894001 - Unify the REPRL support in JS engine for fuzzilli. r=truber
Differential Revision: https://phabricator.services.mozilla.com/D208896
2024-04-30 07:17:17 +00:00
Julien Cristau
1c57b1d218 Bug 1894145 - update msix publisher attributes to match new signing certificate. r=jlorenzo
Differential Revision: https://phabricator.services.mozilla.com/D208972
2024-04-30 07:01:45 +00:00
Mozilla Releng Treescript
2380c2f283 no bug - Bumping Firefox l10n changesets r=release a=l10n-bump DONTBUILD CLOSED TREE
cs -> 0f54b18e68b87bfc82652eb1ccd0fd6dd869f0a6
dsb -> 4f4c2b7d40647f5232114078146655bcfed5a201
es-AR -> 42228ca4434593daaf0c00730bdb49fc82380082
he -> c53cea027f8f98f9b672232d2bb3a129fc8669f7
skr -> de9c5041480fc4047b081f81430660c0d652659d
tr -> 0fdf65ba2e86b801d6a86a3832262015ed702a8a
uk -> 3bffd797bd50fe93379491bb63708a23153a0de6
2024-04-30 07:02:59 +00:00
Tamas Szentpeteri
55101bfe72 Backed out changeset c18051672452 (bug 1887649) for causing dt failures in browser_dbg-breakpoints-cond-ui-state.js. CLOSED TREE 2024-04-30 09:43:05 +03:00
iorgamgabriel
b9a3133cea Bug 1890838 - Global Settings Entry Point For Translation Global Settings r=android-reviewers,ohall
Differential Revision: https://phabricator.services.mozilla.com/D208154
2024-04-30 06:22:25 +00:00
Mike Hommey
255d84b782 Bug 1893781 - Update wasi-libc build-time check for latest LLVM trunk. r=firefox-build-system-reviewers,sergesanspaille
Submitted upstream at https://github.com/WebAssembly/wasi-libc/pull/492.

Differential Revision: https://phabricator.services.mozilla.com/D208940
2024-04-30 05:58:40 +00:00
Hubert Boma Manilla
79732e5913 Bug 1887649 - [devtools] Show the conditional/log breakpoint panel in codemirror 6 r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D205578
2024-04-30 05:57:42 +00:00
Nicolas Chevobbe
88d0c95b7f Bug 1892901 - [devtools] Remove performEOFFixup preserveBackslash parameter. r=devtools-reviewers,bomsy.
The parameter was always passed with true,
except in a unit test.

Differential Revision: https://phabricator.services.mozilla.com/D208320
2024-04-30 05:12:54 +00:00
Nicolas Chevobbe
ea2c75dcbb Bug 1892897 - [devtools] Re-enable camelcase eslint rule in devtools/shared/css/lexer.js. r=devtools-reviewers,bomsy.
Depends on D208318

Differential Revision: https://phabricator.services.mozilla.com/D208319
2024-04-30 05:12:54 +00:00
Boris Chiou
03ef57b490 Bug 1834876 - Part 5: Enable the preference of @starting-style on Nightly. r=webidl,layout-reviewers,saschanaz,emilio
The basic functionality of @starting-style is ready, so it's fine to
enable it on Nightly for experiments.

Differential Revision: https://phabricator.services.mozilla.com/D208573
2024-04-30 05:06:55 +00:00
Boris Chiou
ca4cb0656a Bug 1834876 - Part 4: Fix the case when changing the display from none. r=layout-reviewers,firefox-style-system-reviewers,emilio
Add one extra branch if we have before-change style but its display
is none, and the new style is not display:none. Also, we add an extra
subtest if we use the container query to change the display property.

Differential Revision: https://phabricator.services.mozilla.com/D208572
2024-04-30 05:06:54 +00:00
Boris Chiou
8772ca331e Bug 1834876 - Part 3: Use starting style for CSS Transitions. r=layout-reviewers,firefox-style-system-reviewers,emilio
Now we use the starting style if we have, to replace the before-change
style. This includes a minor refactoring of the handling of transitions
because it becomes a little bit complicated.

Differential Revision: https://phabricator.services.mozilla.com/D208571
2024-04-30 05:06:54 +00:00
Boris Chiou
d975b03929 Bug 1834876 - Part 2: Resolve starting style if we don't have before-change style. r=layout-reviewers,firefox-style-system-reviewers,emilio
Per spec, we define starting style for an element as the after-change style
with @starting-style rules applied in addition.

If an element does not have a before-change style for a given style change
event, the starting style is used instead of the before-change style to
compare with the after-change style to start transitions.

The basic idea in this patch is:
1. We add a flag to indicate if this element may have starting style. We
   set this flag during its full matching, and store this flag in the
   element data.
2. So during process animations, we check this flag, if this element may
   have starting style and specifies transitions, we resolve the
   starting style. Use it as the before-change style.

The implmentation in process_animations() and tests are in the following
patches.

Differential Revision: https://phabricator.services.mozilla.com/D208570
2024-04-30 05:06:53 +00:00
Boris Chiou
4c920b2d33 Bug 1834876 - Part 1: Add a flag in Rule if it is inside @starting-style. r=layout-reviewers,firefox-style-system-reviewers,emilio
The rules inside @starting-style doesn't apply to primary style, and
they are used only for CSS transitions (when computing starting style).

So adding a flag to make us easier to filter them out.

Differential Revision: https://phabricator.services.mozilla.com/D208569
2024-04-30 05:06:53 +00:00
dylan
b41bb321fe Bug 1891610 - added zstd support to devtools. r=jesup,bomsy,necko-reviewers,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D207490
2024-04-30 04:50:01 +00:00
mike a.
a6e0c6ac68 Bug 1879380 - Add nav buttons to toolbar in horizontal and tablet modes r=android-reviewers,zmckenney
Differential Revision: https://phabricator.services.mozilla.com/D207116
2024-04-30 03:49:03 +00:00
Ashley Hale
fd063f4485 Bug 1892653 - Fix repeating oklch gradients r=gfx-reviewers,lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D208960
2024-04-30 03:40:52 +00:00
longsonr
13bb51755d Bug 1892748 Part 2 - Reject cookies that end in a terminator character. r=dveditz,cookie-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D208156
2024-04-30 00:47:11 +00:00
longsonr
ec673d3054 Bug 1892748 Part 1 - Reject control characters in cookie attributes. r=dveditz,cookie-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D208155
2024-04-30 00:47:11 +00:00
Tooru Fujisawa
00aa7c9a70 Bug 1862273 - Part 3: Add testcases. r=jandem
Differential Revision: https://phabricator.services.mozilla.com/D208558
2024-04-30 00:42:12 +00:00
Tooru Fujisawa
b98e2b7f93 Bug 1862273 - Part 2: Support not-equal case in JSOp::TypeofEq. r=jandem
Differential Revision: https://phabricator.services.mozilla.com/D208557
2024-04-30 00:42:11 +00:00
Tooru Fujisawa
eb55be554d Bug 1862273 - Part 1: Add JSOp::TypeofEq for typeof val == "type". r=jandem
Differential Revision: https://phabricator.services.mozilla.com/D207364
2024-04-30 00:42:10 +00:00
Nathan LaPre
9d751c3283 Bug 1878356: Remove nbsp trimming from acc names, r=Jamie
This revision reverts the changes that trimmed non-breaking spaces from the
start and end of accessible names. The web platform group has decided that
those tests weren't valid as-is; the correct behavior is not to trim those
characters. This revision also removes expected-fail designations from
affected tests.

Differential Revision: https://phabricator.services.mozilla.com/D208687
2024-04-30 00:35:45 +00:00
Mozilla Releng Treescript
d9830b1739 no bug - Import translations from android-l10n r=release a=l10n CLOSED TREE 2024-04-30 00:17:39 +00:00
Arturo Mejia
e1eb3ce73c Bug 1892302 - Report when permissions for a web extension have changed r=willdurand,android-reviewers,geckoview-reviewers,zmckenney
Differential Revision: https://phabricator.services.mozilla.com/D207930
2024-04-30 00:02:26 +00:00
Iain Ireland
b1e099b138 Bug 1891662: Clear existing baseline script in UndoRecompileBaselineScriptsForDebugMode r=jandem
One alternative approach would be to use AutoEnterOOMUnsafeRegion and crash if we OOM while recompiling an on-stack baseline script. I'm tempted, but this patch is simple enough that we can let this code live for now.

Differential Revision: https://phabricator.services.mozilla.com/D208559
2024-04-29 19:49:41 +00:00
Glenn Watson
7a0189e02b Bug 1893088 - Split coord space mapping for stacking context coord / external scroll offsets r=gfx-reviewers,nical
During display list and scene building, there are two coordinate
remapping steps that occur:

1) From stacking context coords -> reference frame relative coords
2) From pre-scrolled coords -> removed external scrolling offsets

These were previously handled in one place, however we want to
split these up so that we can apply snapping _after_ step 1 but
prior to step 2. This will allow us to have fractional external
scroll offsets that don't affect snapping. These will be snapped
later on during frame build after applying any (possibly fractional
APZ scroll offsets). This is a cheap operation during frame building
as we only need to snap and modify the transform matrices, not
individual primitives.

This patch should have no functional changes, it's prep work for
the changes referenced above. It does move all of step 1 to be
done during DL building in the content process, and all of step
2 to be done during scene building in the GPU process. In future,
if/when we resolve the issues we have with reliance on cross-iframe
knowledge for fractional snapping, we can move step 2 (including
snapping) in to the content process as well.

Further, as part of the DL bypass work, we will need to remap coord
spaces during DL building in a differeny way, which this simplifies.

Differential Revision: https://phabricator.services.mozilla.com/D208427
2024-04-29 23:49:00 +00:00
Hiroyuki Ikezoe
afcf0864e2 Bug 1890064 - Revert 3ac45af6ece7 landed in bug 1875274. r=emilio
The original code is necessary to make content documents in the parent process
on Android.

On Android each tab has an nsWindow instance regardless whether the top level
content document gets loaded in the parent process or in a content process, it's
a 1:1 relationship. Thus using the nearest widget of the root frame to obtain an
nsIWidget would be fine, it would be an nsWindow instance if the document is in
the parrent process, it would be an PuppetWidget instance if the document is in
a content process.

Differential Revision: https://phabricator.services.mozilla.com/D207670
2024-04-29 23:43:20 +00:00
Hiroyuki Ikezoe
2e56ca91bc Bug 1890064 - Ignore documents which has been removed from the doc shell in ZoomConstraintsClient::RefreshZoomConstraints. r=emilio
It can avoid mixed-up nsBaseWidget::UpdateZoomConstraints calls for two initial
about:blank documents in the parent process.

Differential Revision: https://phabricator.services.mozilla.com/D207669
2024-04-29 23:43:20 +00:00
Botond Ballo
5a4c48e46e Bug 1893742 - Disable helper_doubletap_zoom_textarea.html on Mac. r=hiro
Differential Revision: https://phabricator.services.mozilla.com/D208803
2024-04-29 23:23:56 +00:00
Geoff Brown
4e48c49248 Bug 1892038 - Add missing marionette manifest path r=webdriver-reviewers,jdescottes,robwu
Differential Revision: https://phabricator.services.mozilla.com/D208409
2024-04-29 23:04:48 +00:00
Cristian Tuns
abd6340e5e Backed out changeset e706163e41b4 (bug 1878158) for causing spidermonekey bustages in PortableBaselineInterpret.cpp CLOSED TREE 2024-04-29 19:00:53 -04:00
Doug Thayer
7f806f3c49 Bug 1878158 - Allow cached getters in megamorphic GetProp/Elem r=iain
This patch is doing roughly three things:
- Adds a boolean field through the IR pipeline representing whether we want to
  allow getters or not. This will allow us to do a VM call and all that jazz
  within the op in order to actually call the getter
- Updates existing megamorphic handling to write information to the megamorphic
  cache indicating that the property is a getter. Existing megamorphic handlers
  will treat this as a cache miss and fail / bail
- Allows the tolerant VM calls to look up the cached getter in the megamorphic
  cache and call it without having to do the full expensive property lookup

Differential Revision: https://phabricator.services.mozilla.com/D206148
2024-04-29 21:58:29 +00:00
Cristian Tuns
2950c716a6 Backed out 3 changesets (bug 1862273) for causing spidermonkeys bustages in PortableBaselineInterpret.cpp CLOSED TREE
Backed out changeset 2f9259bc56ba (bug 1862273)
Backed out changeset 1da36a021156 (bug 1862273)
Backed out changeset 8e93e3353435 (bug 1862273)
2024-04-29 18:36:04 -04:00
Cristian Tuns
6df844c611 Backed out changeset e9cdeeb2f957 (bug 1891662) for causing bc failures in browser_errorpage.js 2024-04-29 18:34:01 -04:00
Tooru Fujisawa
7c49eed5fd Bug 1862273 - Part 3: Add testcases. r=jandem
Differential Revision: https://phabricator.services.mozilla.com/D208558
2024-04-29 21:45:50 +00:00
Tooru Fujisawa
9ada87e6dd Bug 1862273 - Part 2: Support not-equal case in JSOp::TypeofEq. r=jandem
Differential Revision: https://phabricator.services.mozilla.com/D208557
2024-04-29 21:45:50 +00:00
Tooru Fujisawa
c69cbb4603 Bug 1862273 - Part 1: Add JSOp::TypeofEq for typeof val == "type". r=jandem
Differential Revision: https://phabricator.services.mozilla.com/D207364
2024-04-29 21:45:49 +00:00
Emilio Cobos Álvarez
9acc400778 Bug 1892676 - Improve interaction of css zoom and non-absolute CSS units. r=dholbert
The values that we take from our parent should be zoomed in. Similarly,
root values should also be zoomed in by the effective zoom (for that, we
unzoom root values to zoom-independent pixels when storing them on the
device).

Container-relative units probably need more care / thought, because they
are in the layout (so zoom-independent) coordinate space already, since
they come from frames. Bug 1894104 is filed for this.

Differential Revision: https://phabricator.services.mozilla.com/D208599
2024-04-29 21:33:16 +00:00
longsonr
ad795c1057 Bug 1893731 - invalidate rendering observers when SVG geometry styles change r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D208832
2024-04-29 21:06:01 +00:00
Rob Lemley
c225e82f43 Bug 1885361 - Update remove_optimization_on_central to account for skip-unless-mozlint. r=marco,taskgraph-reviewers,ahal
The skip-unless-mozlint optimization strategy replaces the use of 'when: files-changed'
with the mozlint config files.
Since the job config is different, also need to remove 'optimization' for code-review
flagged jobs on mozilla-central.

Differential Revision: https://phabricator.services.mozilla.com/D208636
2024-04-29 20:59:47 +00:00