Commit Graph

767302 Commits

Author SHA1 Message Date
Jon Bauman
fc5f21743a Bug 1696045 - Add AVIF telemetry for unimplemented features and performance. r=aosmond
Differential Revision: https://phabricator.services.mozilla.com/D123378
2021-08-24 17:20:02 +00:00
Ting-Yu Lin
4613910b3e Bug 1726620 Part 2 - Add structs representing strong-type app units coordinates. r=botond
The motivation of introducing the structs is to use 64-bit integer
arithmetic to prevent 32-bit integer overflow. One application is to fix
the integer overflow when resolving flex item's main size in Bug 1469649.

The structs can be a start point to add more useful methods to explore
saturation arithmetic.

Differential Revision: https://phabricator.services.mozilla.com/D123266
2021-08-24 17:19:21 +00:00
Ting-Yu Lin
8035e9dde5 Bug 1726620 Part 1 - Generalize IntCoordTyped template to take a parameter as the underlying type. r=botond
This shouldn't change the behavior, but it allows us to define 64-bit
`IntCoordTyped` in Part 2.

Differential Revision: https://phabricator.services.mozilla.com/D123265
2021-08-24 17:19:21 +00:00
Sandor Molnar
d6e6c4a9a2 Bug 1633189 - disable toolkit/components/extensions/test/mochitest/test_ext_webrequest_basic.html for frequent linux-asan-opt failures. r=intermittent-reviewers,jmaher,robwu DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D123339
2021-08-24 17:04:26 +00:00
Gijs Kruitbosch
c56ae6e965 Bug 1723742 - make privacy pref pane highlights more high-contrast friendly, r=morgan,preferences-reviewers,desktop-theme-reviewers,dao,jaws
Differential Revision: https://phabricator.services.mozilla.com/D123161
2021-08-24 16:29:27 +00:00
Paul Zuehlcke
8fbed29742 Bug 1727316 - ClearDataService tests to ensure that we do not fallback to clearAll for non user requests. r=johannh,tgiles
Differential Revision: https://phabricator.services.mozilla.com/D122882
2021-08-24 16:18:23 +00:00
Paul Zuehlcke
c58de4bf8d Bug 1727316 - Avoid over-clearing data in ClearDataService if we do not have user input. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D122881
2021-08-24 16:18:23 +00:00
Jeff Muizelaar
ebfed4b7a4 Bug 1727351 - Remove mVsyncEnabledLock. r=aosmond
Just make mVsyncEnabled an Atomic<bool>

Differential Revision: https://phabricator.services.mozilla.com/D123488
2021-08-24 16:02:46 +00:00
Alexandru Michis
c8ea016b87 Backed out 13 changesets (bug 1724031) for causing dt failures in js/src/gc/Cell.h
CLOSED TREE

Backed out changeset 3a79fb5a7a07 (bug 1724031)
Backed out changeset 7991bfb259ae (bug 1724031)
Backed out changeset 5673e5c4f996 (bug 1724031)
Backed out changeset 75f1f67429e1 (bug 1724031)
Backed out changeset 3327c1d290b7 (bug 1724031)
Backed out changeset ae06621c5728 (bug 1724031)
Backed out changeset bb4c2384f676 (bug 1724031)
Backed out changeset 1a4a5c11b9f1 (bug 1724031)
Backed out changeset 58dd7d7a733e (bug 1724031)
Backed out changeset e4d4251e86a3 (bug 1724031)
Backed out changeset a7f3f8eb7ac0 (bug 1724031)
Backed out changeset d0fe0b0b2b84 (bug 1724031)
Backed out changeset 0cca6901539d (bug 1724031)
2021-08-24 19:28:49 +03:00
Molly Howell
31b4b6a762 Bug 1705684 - Correct download details panel spacing. r=desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D123401
2021-08-24 15:58:06 +00:00
Tom Ritter
5c6d7aa348 Bug 1726587: Fix ./mach doc r=mhentges
For whatever reason, ./mach doc is sourcing rewrite_mozbuild.py
causing the ast.get_source_segment function to get redefined.

(We do this redefinition because it is very easy to accidently
use get_source_segment in this code and forget it doesn't
work on Taskcluster.)

So add an exemption for sphinx to pass through to the original
function, but also fix an inifnite loop where we weren't calling
the original function.

Differential Revision: https://phabricator.services.mozilla.com/D123487
2021-08-24 15:31:11 +00:00
Paul Adenot
a7b4d10bbb Bug 1724994 - Promote GraphRunner to higher priority on Android. r=agi,pehrsons
Differential Revision: https://phabricator.services.mozilla.com/D123346
2021-08-24 15:13:31 +00:00
Jeff Muizelaar
4e0c60c99c Bug 1727324 - Remove WindowRenderer::AsClientLayerManager. r=aosmond
A step down the path of removing ClientLayerManager.

Differential Revision: https://phabricator.services.mozilla.com/D123451
2021-08-24 15:07:56 +00:00
Tom Ritter
6e574cca38 Bug 1724220: Crash in fuzzing builds when we hit an unexpected potential hardening bypass r=decoder,freddyb
Differential Revision: https://phabricator.services.mozilla.com/D121875
2021-08-24 14:57:45 +00:00
Tom Ritter
f492e82a10 Bug 1723204: Update tests to prevent crashes r=ckerschb,jdescottes,robwu
This is most commonly as a result of CU.evalInSandbox which
allows an arbitrary filename but when omitted will default
to the filename of the test, which is a filesystem path
and thus is disallowed.

Differential Revision: https://phabricator.services.mozilla.com/D122246
2021-08-24 14:57:44 +00:00
Tom Ritter
cb641423fa Bug 1723204: Wire up a crash for Javascript Load Telemetry r=ckerschb,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D121417
2021-08-24 14:57:44 +00:00
Tom Ritter
15cda29aa2 WIP: Bug 1723204: Infrastructure for causing a crash at most N times r=KrisWright,ckerschb,freddyb
Differential Revision: https://phabricator.services.mozilla.com/D121416
2021-08-24 14:57:43 +00:00
stransky
2312e1ba72 Bug 1727285 [Linux/X11] Provide more logging to Clipboard/X11 code, r=jhorak
Differential Revision: https://phabricator.services.mozilla.com/D123436
2021-08-24 14:52:58 +00:00
Belén Albeza
2e76ecbce9 Bug 1706633 - [devtools] Re-enable fission local-storage test r=jdescottes
This should have been fixed by 1706679

Differential Revision: https://phabricator.services.mozilla.com/D123437
2021-08-24 14:24:25 +00:00
Paul Adenot
3f7ea18b28 Bug 1727311 - Fix four clang-tidy warnings in GraphRunner.cpp. r=pehrsons
Differential Revision: https://phabricator.services.mozilla.com/D123443
2021-08-24 14:07:17 +00:00
Nazım Can Altınova
1b232babba Bug 1727039 - Add two marker schema structs for Java markers to make them visible in the timeline r=gerald
Differential Revision: https://phabricator.services.mozilla.com/D123435
2021-08-24 13:24:06 +00:00
Benjamin Beurdouche
9bdc7ccc5d Bug 1724869 - land NSS fe82761e35aa UPGRADE_NSS_RELEASE, r=djackson
```
2021-08-17  Robert Relyea  <rrelyea@redhat.com>

	* lib/softoken/lowpbe.c:
	Bug 1726022 Cache additional PBE entries

	Firefox password manager is slow to load (22s for 361 passwords on
	an i7), using 100% CPU and causing laptop fans to spin up

	Possible solution based on increasing the number of cache entries
	used by the PKCS5v2 values as the current code thrashes the cache as
	we use 2 pbe's per read operation.

	This patch is tested for correctness, but not fixing the issue. New
	test cases are needed.

	[fe82761e35aa] [tip]
```

Differential Revision: https://phabricator.services.mozilla.com/D123442
2021-08-24 13:19:13 +00:00
Jon Coppeard
a5ed17689f Bug 1724031 - Part 11: Fix GDB scripts to work with new function layout r=jandem
Differential Revision: https://phabricator.services.mozilla.com/D123097
2021-08-24 13:01:57 +00:00
Jon Coppeard
7d7d8c23d8 Bug 1724031 - Part 10: Use fixed slots to store function data r=jandem
Move class fields to fixed slots. I was originally going to remove the function
alloc kinds but they are used to iterate all functions for relazification.

Another complication is that the JIT assumes that the prototype property for
function constructors is always stored in the first dynamic slot, which
requires extended functions have a special size class with six fixed slots.

Differential Revision: https://phabricator.services.mozilla.com/D123094
2021-08-24 13:01:57 +00:00
Jon Coppeard
b806063841 Bug 1724031 - Part 9.5: Move JSFunction::class_ to avoid confusion r=jandem
Functions can now have one of two classes so it's best if JSFunction::class_
doesn't exist or people may use that without thinking.

Differential Revision: https://phabricator.services.mozilla.com/D123232
2021-08-24 13:01:56 +00:00
Jon Coppeard
7983b2c1a9 Bug 1724031 - Part 9: Add a separate JSClass for extended functions r=jandem
Differential Revision: https://phabricator.services.mozilla.com/D123089
2021-08-24 13:01:56 +00:00
Jon Coppeard
f2b87c19e3 Bug 1724031 - Part 8: Remove some unused JSFunction methods r=jandem
GetClonedSelfHostedFunctionNameOffMainThread doesn't seem to be used any more,
so the JSFunction methods it used can go too.

Differential Revision: https://phabricator.services.mozilla.com/D123088
2021-08-24 13:01:56 +00:00
Jon Coppeard
dc8f91f26d Bug 1724031 - Part 7: Factor out JIT test for whether an object is a function r=jandem
We will need to change this later as extended functions will have a different
class, so factor out the check.

Differential Revision: https://phabricator.services.mozilla.com/D123087
2021-08-24 13:01:55 +00:00
Jon Coppeard
b0a103eaf2 Bug 1724031 - Part 6: Store JSFunction's atom field as a JS::Value r=jandem
Differential Revision: https://phabricator.services.mozilla.com/D123086
2021-08-24 13:01:55 +00:00
Jon Coppeard
098362c5fc Bug 1724031 - Part 5: Store JSFunction's JIT data / script field as a JS::Value r=jandem
In preparation for storing this in a slot, store it as a JS::Value.

All values including JSScript pointers are stored as private values becuase the
JIT assumes it can access SelfHostedLazyScript pointers and JSScript pointers
in the same way. This means we will still need a trace hook when we store this
data in slots.

Differential Revision: https://phabricator.services.mozilla.com/D123085
2021-08-24 13:01:54 +00:00
Jon Coppeard
c8cd542c0f Bug 1724031 - Part 4: Store JSFunction's native function / environment object field as a JS::Value r=jandem
In preparation for storing this in a slot, store it as a Value.

The native function is stored as a private value. This requires casting it to
void* which AFAIU only conditionally supported in the C++ spec but in practice
supported everwhere. We used to do this in other places, although we have
removed them now.

Differential Revision: https://phabricator.services.mozilla.com/D123084
2021-08-24 13:01:54 +00:00
Jon Coppeard
9fca780648 Bug 1724031 - Part 3: Store JSFunction flags and arg count as a JS::Value r=jandem
In preparation for storing them in a slot, store them in a Value. The value is
encoded as a private uint32 value.

Differential Revision: https://phabricator.services.mozilla.com/D123083
2021-08-24 13:01:53 +00:00
Jon Coppeard
98f8f1c73d Bug 1724031 - Part 2: Store a functions flags and argument count in a single 32-bit field r=jandem
In preparation for storing this in a slot, this stores the two values together
in the same field.

Differential Revision: https://phabricator.services.mozilla.com/D123082
2021-08-24 13:01:53 +00:00
Jon Coppeard
c67b317ffa Bug 1724031 - Part 1: Make FunctionFlags setters return *this r=jandem
This is useful later on so we can update a function's flags with a single
expression rather than reading, updating and setting the flags separately.

Differential Revision: https://phabricator.services.mozilla.com/D123081
2021-08-24 13:01:53 +00:00
Jon Coppeard
1834d1cbbe Bug 1724031 - Part 0: Make set() method public on GC pointer wrappers r=jandem
There's no reason for these to be private when they all have operator=
implemented in terms of set() anyway.

Differential Revision: https://phabricator.services.mozilla.com/D123080
2021-08-24 13:01:52 +00:00
Michelle Goossens
87b5ec03df Bug 1727168 - Disable test for high frequency intermittent after migration r=intermittent-reviewers,bhearsum
Differential Revision: https://phabricator.services.mozilla.com/D123430
2021-08-24 13:01:49 +00:00
Brindusan Cristian
dfcfe1d342 Backed out 4 changesets (bug 1724220, bug 1723204) for causing cpp non-unified bustages in TestSmartCrashTrimmer.cpp.
CLOSED TREE

Backed out changeset 0dab9553a2a8 (bug 1724220)
Backed out changeset df236c937895 (bug 1723204)
Backed out changeset 4a20d1832cf4 (bug 1723204)
Backed out changeset d7e4042af76c (bug 1723204)
2021-08-24 15:33:32 +03:00
Julian Descottes
52e4ab408b Bug 1683611 - [devtools] Wait for inspector reloaded event in browser_inspector_remove-iframe-during-load.js r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D123325
2021-08-24 12:22:57 +00:00
stransky
ec9d5c0d9a Bug 1727285 [Wayland] Don't crash when gtk_clipboard_request_text() callback returns null text string, r=jhorak
Differential Revision: https://phabricator.services.mozilla.com/D123434
2021-08-24 11:51:48 +00:00
Julian Seward
bc42a55bde Bug 1725638. r=lth.
Differential Revision: https://phabricator.services.mozilla.com/D123101
2021-08-24 11:51:45 +00:00
Jan de Mooij
d5b123cf3d Bug 1726533 part 8 - Add ObjLiteralKind and use it instead of the Array / Singleton flags. r=arai
Differential Revision: https://phabricator.services.mozilla.com/D123292
2021-08-24 11:48:26 +00:00
Jan de Mooij
8bf9a98ce7 Bug 1726533 part 7 - Fix some comments. r=arai
Differential Revision: https://phabricator.services.mozilla.com/D123104
2021-08-24 11:48:26 +00:00
Jan de Mooij
7741567794 Bug 1726533 part 6 - Optimize PlainObject shape allocation for Stencil instantiation. r=arai
We now no longer allocate the object. We also don't allocate intermediate shapes for
each property because we first fill the map and then allocate the final shape.

Differential Revision: https://phabricator.services.mozilla.com/D123096
2021-08-24 11:48:25 +00:00
Jan de Mooij
8363b1f0ea Bug 1726533 part 5 - Don't store indexed properties for non-singleton object literals. r=arai
If these properties will be dense elements, there's no reason to define them on the
template object (or template shape with later patches).

If they're sparse elements, we now don't include them in the object's shape, but
it should be okay to rely on InitElem ops to define them later on.

Differential Revision: https://phabricator.services.mozilla.com/D123095
2021-08-24 11:48:25 +00:00
Jan de Mooij
06c2dce074 Bug 1726533 part 4 - Store the shape instead of object for NewObject ops. r=arai
We still allocate the object in the Stencil instantiation code, and then only
use its shape. This will be fixed in a later patch to allocate only the shape.

Differential Revision: https://phabricator.services.mozilla.com/D123093
2021-08-24 11:48:25 +00:00
Jan de Mooij
9604c0d434 Bug 1726533 part 3 - Add support for storing PlainObject shapes in PrivateScriptData. r=arai
The XDR and cloning code is the most complicated part unfortunately. This is based on
what we do for plain objects. Hopefully this can all be removed at some point.

Differential Revision: https://phabricator.services.mozilla.com/D123092
2021-08-24 11:48:24 +00:00
Jan de Mooij
16a7e6855d Bug 1726533 part 2 - Remove NewObjectOperationWithTemplate. r=arai
MNewObject never has a template object if `mode == ObjectLiteral`. This lets us
remove some code.

Differential Revision: https://phabricator.services.mozilla.com/D123091
2021-08-24 11:48:24 +00:00
Jan de Mooij
dae8d56ae1 Bug 1726533 part 1 - Remove NewObjectKind argument from NewObjectOperation. r=arai
Every caller passes GenericObject.

Differential Revision: https://phabricator.services.mozilla.com/D123090
2021-08-24 11:48:23 +00:00
Olli Pettay
50a110f8af Bug 1726364 - Scroll events stop working after synchronous XHR request while scrolling an iframe, r=edgar
I tried to keep the changes minimal in this case.
We may need some more changes to Document::UnsuppressEventHandlingAndFireEvents to make it work
well with Fission (but that Fission work is totally unrelated to this fix).

Differential Revision: https://phabricator.services.mozilla.com/D123389
2021-08-24 11:43:06 +00:00
Tom Ritter
d5cefe3b4a Bug 1724220: Crash in fuzzing builds when we hit an unexpected potential hardening bypass r=decoder,freddyb
Differential Revision: https://phabricator.services.mozilla.com/D121875
2021-08-24 11:20:45 +00:00