Commit Graph

264 Commits

Author SHA1 Message Date
justdave%bugzilla.org
c76cd588ce Bug 254498: Check for comment required for time validation was too late.
Patch by Tiago R. Mello <tiago@async.com.br>
r=kiko, a=justdave
2004-10-25 04:49:32 +00:00
bugreport%peshkin.net
4d03d01641 Bug 186093: Move CanSeeBug to User.pm and make User.pm usable by templates
r=kiko
a=justdave
2004-08-04 16:17:10 +00:00
jocuri%softhome.net
661915c1e3 Patch for bug 253604: When commit a bug, validate timetracking before user match; patch by Tiago R. Mello <tiago@async.com.br>; r=kiko, a=justdave. 2004-08-03 06:23:25 +00:00
jocuri%softhome.net
5af84e034b Patch for bug 253360: replace IF() with CASE WHEN for database compatibility; patch by Tomas Kopal <Tomas.Kopal@altap.cz>; r=vladd, a=justdave. 2004-07-31 09:36:18 +00:00
kiko%async.com.br
de220d98d1 Fix for bug 216008: Time Tracking: default values cause change bug
errors. Check if the time values haven't actually changed by using                     integer comparison (instead of string comparison). r=jouni, a=justdave.
2004-07-29 03:09:10 +00:00
kiko%async.com.br
74c54e3a8e Fix for bug 252789: Empty timetrackinggroup causes error "hours worked
needs to be positive" when changing bug. Sanitizing the AddComment bits
in process_bug.cgi to only touch work_time if user is in
timetrackinggroup. Fixes regression introduced in bug 252159.
r=jouni,joel; a=justdave.
2004-07-29 02:59:11 +00:00
kiko%async.com.br
0e83d69da2 Fix for bug 252159: centralize time validation. Adds a ValidateTime
function to Bugzilla::Bug and uses it in relevant callsites. Patch by
Alexandre Michetti Manduca <michetti@grad.icmc.usp.br>. r=kiko, a=justdave.
2004-07-22 17:48:37 +00:00
kiko%async.com.br
cd3bebfa78 Fix for bug 251935: Remove $COOKIE from process_bug.cgi. r=joel, a=myk. 2004-07-20 21:25:33 +00:00
gerv%gerv.net
aef47d46b4 Bug 240093 - get canconfirm working again. Patch by gerv; r=joel, a=justdave. 2004-07-17 16:09:28 +00:00
jocuri%softhome.net
f39fb919af Patch for bug 242161: make process_bug.cgi contain patchviewer ("diff") link like show_bug.cgi; patch by GavinS <bugzilla@chimpychompy.org>; r=vladd; a=justdave. 2004-06-01 12:53:27 +00:00
gerv%gerv.net
3810195167 Bug 237838 - make sure CheckCanChangeField() always gets correct resolution. Patch by gerv and Tom Karzes; r, a=justdave. 2004-04-27 22:28:06 +00:00
timeless%mozdev.org
b6daea0980 Bug 192571 Empty default owner (assignee or QA) causes "Reassign bug to owner and QA contact of selected component to NOOP
r=justdave a=justdave
2004-04-22 14:42:14 +00:00
kiko%async.com.br
6f3fb84923 Fix for bug 234175: Remove deprecated ConnectToDatabase() and
quietly_check_login()/confirm_login() calls.  Cleans up callsites
(consisting of most of our CGIs), swapping (where appropriate) for calls
to Bugzilla->login. Patch by Teemu Mannermaa <wicked@etlicon.fi>.
r=bbaetz, kiko. a=justdave.
2004-03-27 03:51:44 +00:00
justdave%syndicomm.com
0e962f6de6 Bug 24496: Adds a parameter "noresolveonopenblockers" which when enabled, prevents bugs from being closed if there are any bugs blocking it which are still open.
Patch by Andreas H��fler <andreas.hoefler@bearingpoint.com>
r= justdave, a= myk
2004-03-18 05:55:41 +00:00
justdave%syndicomm.com
48a6a62693 Bug 192516: Moving the loose .pm files into the Bugzilla directory, where they belong. These files pre-date the Bugzilla directory, and would have gone there had it existed at the time. The four files in question were copied on the CVS server to preserve CVS history in the files. This checkin deletes them from the old location and modifies everything else to know where they are now.
r= myk, gerv
a= justdave
2004-03-18 03:57:05 +00:00
gerv%gerv.net
79a5ebfb26 Bug 233645 - fix a number of 'undef' warnings which were killing performance for multiple bug change. Patch by gerv; r,a=justdave. 2004-02-13 20:24:51 +00:00
jocuri%softhome.net
fda2842064 Bug 219475: The check for null db entries in process_bug.cgi is wrong; patch by Chuck Duvall <caduvall@glue.umd.edu>; r=bbaetz; a=justdave. 2003-11-07 08:05:01 +00:00
jocuri%softhome.net
1d5d7e5307 Bug 223854: masscc on change several bugs doesn't honor usermatchmode; patch by Jon <kniht@us.ibm.com>; r=myk; a=myk. 2003-10-28 06:37:40 +00:00
jocuri%softhome.net
0e841123f6 Bug 218977: "Table 'namedqueries' was not locked with LOCK TABLES" on ThrowUserError('product_edit_denied'); r=bbaetz; a=justdave. 2003-10-19 08:46:39 +00:00
justdave%syndicomm.com
9d508ecdf1 Correcting the previous backout attempt, apparrently typoed a version number last time 2003-10-17 02:07:55 +00:00
justdave%syndicomm.com
f8d1d9c37d Backing out patch from bug 108528 - failed to take i10n concerns into account 2003-10-16 18:26:09 +00:00
timeless%mozdev.org
19efc5771e Bug 108528 - knob is not defined doesn't explain to 2001110503 users what to do
patch by caduvall@glue.umd.edu r=timeless a=justdave
2003-10-15 22:48:12 +00:00
jocuri%softhome.net
098a01af5b Bug 220034: empty form after changing bug details; patch by wicked@etlicon.fi (Teemu Mannermaa); r=kiko, a=justdave. 2003-10-13 21:38:13 +00:00
timeless%mozdev.org
4808783215 Bug 221264 Making no changes shouldn't affect Last modified
r=joel a=justdave
2003-10-07 05:59:30 +00:00
bbaetz%acm.org
bb7609223e Bug 208699 - Move Throw{Code,Template}Error into Error.pm
r,a=justdave
2003-09-14 06:05:23 +00:00
justdave%syndicomm.com
c17507209d Bug 215962: Missing {} around implied hash reference in params to ThrowUserError
patch by Eric Selberg <erik@selberg.com>
r= justdave a= justdave
2003-08-12 18:54:16 +00:00
preed%sigkill.com
2cb5490663 Bug 211435 - Fix "Table 'namedqueries' was not locked with LOCK TABLES" error; Patch by jocuri@softhome.net (Vlad Dascalu), r=bbaetz, a=justdave 2003-07-24 01:00:20 +00:00
preed%sigkill.com
c53cbbda66 Fixes singed tinderbox trees; vladd: NO TABS in patches, please. Spaces only. 2003-07-17 23:31:44 +00:00
preed%sigkill.com
7b0978e96e Bug 82172 - Don't allow empty bug summaries. Patch by jocuri@softhome.net (Vlad Dascalu), r=kiko, a=justdave 2003-07-17 22:54:25 +00:00
bbaetz%acm.org
c1e4afb682 Bug 180635 - Enhance Bugzilla::User to store additional information
r=myk,jake
2003-06-03 09:48:15 +00:00
bbaetz%acm.org
325350ad59 Bug 201816 - use CGI.pm for header output
r=joel, a=justdave
2003-05-05 01:15:38 +00:00
myk%mozilla.org
ce35b9bcd9 Fix for bug 179510: takes group restrictions into account when sending request notifications
r=bbaetz,jpreed
a=justdave
2003-04-25 05:41:29 +00:00
justdave%syndicomm.com
29f1575ab1 Bug 193965: On product change, user can accidentally opt-out of required group restriction
Patch by Joel Peshkin <bugreport@peshkin.net>
r= bbaetz, justdave
a= justdave
2003-04-24 21:50:33 +00:00
bbaetz%acm.org
709c9b24de Bug 199813 - Make all users of ThrowUserError pass $vars in explicitly.
r=gerv
a=justdave
2003-04-02 12:35:07 +00:00
jake%bugzilla.org
3c915014e3 Bug 196433 - Bugzilla now uses /usr/bin/perl as the shebang line
r=justdave
a=justdave
2003-03-27 00:07:02 +00:00
bbaetz%acm.org
d6885b62ab Bug 194394 - Internal error after turning useqacontact off
r,a=justdave
2003-02-23 07:31:09 +00:00
gerv%gerv.net
306d660cbd Bug 186994 - Unable to accept a new bug that has been assigned. Patch by gerv; r=bbaetz, a=justdave. 2003-02-16 11:59:44 +00:00
justdave%syndicomm.com
bb26a7057a Bug 193286: Field validation errors had the wrong page title
r= gerv, a= justdave
2003-02-15 08:03:51 +00:00
justdave%syndicomm.com
fe2f0fd7a4 Bug 192513: importxml.pl and move.pl now use the new mail routines introduced in bug 124174 (they got broken when processmail was removed). Also fixes several comments referring to processmail (which no longer exists) in other files, and removes references to processmail from the .htaccess files and the executable file list in checksetup.pl.
r= jaypee, a= justdave
2003-02-10 06:26:39 +00:00
preed%sigkill.com
dc8fce75f5 Bug 124174 - make processmail a package (Bugzilla::BugMail), r=gerv, r=jth, a=justdave 2003-02-09 22:04:25 +00:00
bbaetz%acm.org
9e45c085d5 Bug 192340 - 'unknown_keyword' error doesn't mention keyword
r=myk, a=justdave
2003-02-08 01:38:51 +00:00
burnus%gmx.de
4c1f2b41b9 bug 191087 - process_bug.cgi: "Mid-air collision!" title when not allowed to change a field
r=gerv, a=justdave
2003-02-05 08:50:03 +00:00
bbaetz%student.usyd.edu.au
f6351f6643 Bug 171493 - make show_bug use Bug.pm and remove bug_form.pl
r=justdave, joel
a=justdave
2002-11-28 10:49:58 +00:00
bugreport%peshkin.net
13e1ecfa4d Bug 147275 Rearchitect product groups
Patch by joel
r=bbaetz,justdave
a=justdave
2002-11-24 19:56:34 +00:00
bbaetz%student.usyd.edu.au
94fa0a68b3 Bug 180966 - warnings in webserver error log (take 2)
r=joel, a=justdave
2002-11-22 01:47:38 +00:00
justdave%syndicomm.com
30e6e7552e Backing out the checkin for bug 180966 (fix warnings in web server error log). This checkin caused commenting on bugs to fail
if timetracking is not enabled.
2002-11-21 18:46:21 +00:00
bbaetz%student.usyd.edu.au
c79e9457e0 Bug 180966 - fix misc warnings
r,a=myk
2002-11-20 00:53:14 +00:00
jake%bugzilla.org
d28961e68b Bug 180545 - It was possible to change the product/component of a bug without having the editbugs permission.
r=bbaetz
a=justdave
2002-11-18 04:27:34 +00:00
myk%mozilla.org
8f7f3eaa34 Fix for bug 179334: updates the setter consistently. also fixes numerous other bugs in the RT code.
r=bbaetz
a=myk
2002-11-11 12:36:27 +00:00
bbaetz%student.usyd.edu.au
ebafa2c013 Bug 179321 - cannot clear status whiteboard entirely
r=joel x2
a=justdave
2002-11-10 08:33:45 +00:00
gerv%gerv.net
e44ba20590 Bug 71794 - processmail shouldn't bother checking dependencies unless state changes. Patch by gerv; r=myk. 2002-11-08 08:04:58 +00:00
myk%mozilla.org
e762ceb1ba Fix for bug 172518: makes the request tracker use the generic user matching code
r=not_erik,joel
a=justdave
2002-11-08 01:35:46 +00:00
bugreport%peshkin.net
c2d00ecd2a Bug 95430 Reopening en masse fails.
Patch by jeff.hedlund
r=justdave, joel
2002-10-31 14:45:19 +00:00
bugreport%peshkin.net
33a982d398 Bug 175838 Reopening a bug does not clear resolution, nor does selecting 'clear resolution'
patch by jeff.hedlund@matrixsi.com
2xr=gerv
2002-10-31 02:44:05 +00:00
bbaetz%student.usyd.edu.au
dd3d83d08e Bug 147833 - start using CGI.pm
r=gerv, justdave
2002-10-26 01:57:09 +00:00
bugreport%peshkin.net
3f85278116 Bug 162990 Shorthand/wildcard entry for login names in assign, cc, qa, fields
patch by not_erik@dasbistro.com
r=joel, myk
2002-10-25 03:59:35 +00:00
bugreport%peshkin.net
e9b9a129a7 Bug 112373 you should be able to enter bug dependencies/blockers when you enter a bug.
patch by jhedlund
r,2xr=joel
2002-10-17 04:31:56 +00:00
gerv%gerv.net
bbb2237692 Bug 174221 - field names should be l10n in user-errors.html.tmpl. Patch by jeff.hedlund@matrixsi.com; r=burnus, gerv. 2002-10-16 23:15:48 +00:00
bugreport%peshkin.net
dd8abb1dbb Bug 24789 [E|A|R] Add Estimated, Actual, Remaining Time Fields
patch by jeff.hedlund@matrixsi.com
2xr=joel,justdave
2002-10-13 04:26:24 +00:00
bugreport%peshkin.net
8e99828e58 Bug 174112 Edit multiple bugs broken
r=burnus
2002-10-12 17:00:33 +00:00
gerv%gerv.net
160210ab39 Bug 170903 - Remove hard-coded titles and things. Patch B. Patch by gerv; r=bbaetz. 2002-10-10 19:02:36 +00:00
preed%sigkill.com
2ca51a9031 Fixes Gerv's tree bustage from the checkin for bug 163114; 2xr=#mozwebtools 2002-10-02 00:03:53 +00:00
gerv%gerv.net
05b79b02c3 Bug 163114 - Templatise all calls to DisplayError. Patch C. Patch by gerv; r=burnus. 2002-10-01 22:41:09 +00:00
bugreport%peshkin.net
323bb65a7e Bug 171639 dupes not marked in original bug
2xr=bbaetz
2002-10-01 00:13:58 +00:00
bugreport%peshkin.net
d87d54ddbc Bug 171322 process_bug.cgi makes reference to non-existant product variable
2xr=bbaetz
2002-09-29 04:01:54 +00:00
myk%mozilla.org
f8e4483e93 Fix for bug 98801: Implementation of the request tracker, a set of enhancements to attachment statuses.
r=gerv,bbaetz
2002-09-28 18:42:54 +00:00
gerv%gerv.net
152ef72c3d Bug 170064 - Change error API again to allow vars to be passed in the call. Patch by gerv; r=bbaetz. 2002-09-23 07:12:12 +00:00
gerv%gerv.net
e931ee5476 Bug 170075 - Mid-air collision pages should be titled as such. Patch by gerv; r=bbaetz. 2002-09-22 20:28:25 +00:00
bugreport%peshkin.net
1c0ddbd1ae bug 157756 - Groups_20020716_Branch Tracking : > 55 groups now supported
r=bbaetz, gerv
2002-09-22 17:15:13 +00:00
gerv%gerv.net
c6aa8133ac Bug 108987 - Linkify script to use quoteUrls on texts provided by user. Patch by gerv; r=kiko. 2002-09-21 15:17:09 +00:00
gerv%gerv.net
668cdbed8b Bug 168804 - Document CheckCanChangeField so sites can modify it for local needs. Patch by gerv; r=bbaetz, joel. 2002-09-18 23:23:55 +00:00
gerv%gerv.net
bda11cb1c6 Bug 167978 - Fix Throw*Error l10n regressions and add a test to catch more. Patch by gerv; r=bbaetz. 2002-09-12 22:51:50 +00:00
matty%chariot.net.au
f11ecf8841 Spelling fixes. 2002-09-06 03:59:06 +00:00
bbaetz%student.usyd.edu.au
debef61f9d Bug 161203 - Bug changes with intermediate pages munges fields with
multiple values (e.g., CC)
patch by "Randall M! Gee", r=bbaetz, myk
2002-08-27 09:35:22 +00:00
bbaetz%student.usyd.edu.au
2b781fd427 Bug 76923 - Don't |use diagnostics| (its really expensive at startup time)
r=joel x2
2002-08-26 06:17:26 +00:00
bbaetz%student.usyd.edu.au
4c3a5a0d9a Bug 164470 - mass reassign changes UNCONFIRMED->NEW
r=joel x2
2002-08-26 05:51:00 +00:00
gerv%gerv.net
48d6ce2ad3 Bug 143286 - Add support for Insiders, Private comments, Private Attachments. Patch by bugreport@peshkin.net; r=gerv. 2002-08-19 21:17:28 +00:00
gerv%gerv.net
4c214d26bb Bug 162068 - Fix callers of ThrowUserError to use messages.html.tmpl. Patch by gerv; r=bbaetz. 2002-08-15 22:57:21 +00:00
gerv%gerv.net
2e88df3e51 Bug 162066 - Fix callers of ThrowCodeError to use messages in code-error.html.tmpl. Patch by gerv; r=bbaetz. 2002-08-15 06:43:47 +00:00
bbaetz%student.usyd.edu.au
52987f01cc Bug 162642 - Cannot accept bugs if requiremilestone is on; regression from
bug 43600
r=preed x2
2002-08-14 11:55:24 +00:00
bbaetz%student.usyd.edu.au
80f3e185c0 Bug 43600 - Convert products/components to use ids instead of names.
Initial attempt by jake@bugzilla.org, updated by me
r=joel, preed
2002-08-12 05:43:05 +00:00
bbaetz%student.usyd.edu.au
190a892f2b Bug 118442 - Bugzilla fails to notice if nothing has changed when editing
multiple bugs if no keywords have been defined
patch by jake@bugzilla.org, r=bbaetz
2002-08-01 11:05:12 +00:00
bbaetz%student.usyd.edu.au
120976a543 Bug 157074 - verify-new-product doubles comment linefeeds on Win32
r=myk, jouni
2002-07-19 14:03:58 +00:00
bbaetz%student.usyd.edu.au
ae3aebbdc0 Bug 156844 - 'use of uninitialized value in string eq' warning
r=jouni x2
2002-07-11 11:46:08 +00:00
myk%mozilla.org
07ba2589b3 Fix for bug 99203: Implements bug aliases feature.
r=bbaetz,jouni
2002-07-03 23:07:14 +00:00
bbaetz%student.usyd.edu.au
4b3fa0a5f9 Bug 157085 - verify-new-product doesn't set defaults
r=jouni, gerv
2002-06-25 10:07:59 +00:00
bbaetz%student.usyd.edu.au
693d63dda2 Bug 151053, ConnectToDatabase/quietly_check_login sometimes not called
early enough
r=mattyt, jouni
2002-06-17 09:39:00 +00:00
bbaetz%student.usyd.edu.au
dd519e4374 Bug 151369 - need to trim the entered assignee's email address
r=mattyt x2
2002-06-16 05:26:50 +00:00
gerv%gerv.net
c4d9231226 Bug 144728 - Midair collision doubles line feeds. Patch by jouni@heikniemi.net; 2xr=justdave. 2002-05-29 07:21:44 +00:00
gerv%gerv.net
db55935a5f Bug 125066 - remove the need to set a milestone on accept for products with just one milestone. Patch by zeroj; r=justdave, gerv. 2002-04-24 20:07:57 +00:00
gerv%gerv.net
3bc9d4ca2b Bug 138588 - change to use new template structure. Patch by gerv, r=myk, afranke. 2002-04-24 07:24:50 +00:00
gerv%gerv.net
5820179602 Bug 137954 - Empty "move-button-text" field blocks changing bugs. Patch by gerv, 2xr=justdave. 2002-04-17 22:59:07 +00:00
bbaetz%student.usyd.edu.au
b8049151a5 bug 117718 - Mass Change removes a bugs groupset if the bug was in the
wrong product group
r=justdave x2
2002-04-16 08:29:01 +00:00
myk%mozilla.org
a26bc29e52 Fix for bug 125660: Templatizes process_bug.cgi.
Patch by Myk Melez <myk@mozilla.org>
r=gerv,bbaetz
2002-04-12 21:02:00 +00:00
gerv%gerv.net
20b99d16c6 Bug 124937 - templatise show_activity.cgi. Patch by me, r=myk, bbaetz. 2002-04-03 18:54:18 +00:00
justdave%syndicomm.com
a2f9effc6e Fix for bug 82143 and bug 95594: Attempting to reverse dependencies falsely reported a circular dependency loop, and setting
both the blocks and depends at the same time allowed a real dependency loop to be created.
Patch by Stephen Lee <slee@wilcoxassoc.com>
r= myk, justdave
2002-04-03 00:55:56 +00:00
gerv%gerv.net
d391f38ecb Bug 110012 - show_bug templatisation. r=bbaetz, afranke. 2002-03-23 17:58:41 +00:00
myk%mozilla.org
7395f6773d Fix for bug 72184: prevents users from entering too-large comments/descriptions that get rejected by MySQL's MAX_PACKET_SIZE restrictions.
Patch by Myk Melez <myk@mozilla.org>.
r=bbaetz,gerv
2002-03-11 07:33:03 +00:00
bbaetz%student.usyd.edu.au
fdfcfb96fd Bug 97471 - The assignee and qa contact should always be able to see their
bugs
r=justdave, afranke
2002-02-13 03:05:15 +00:00
bbaetz%student.usyd.edu.au
0c682418d4 Bug 119715 - strictvaluechecks should always be enabled
r=justdave, gerv
2002-02-05 00:20:09 +00:00